Commit Graph

182 Commits

Author SHA1 Message Date
BJ Weschke
ff9fce4bb8 Look ma! No more deadlocks! <sic>
As posted from #7458 and others similar to it in Mantis:
 p->app_lock was a mutex really designed for use with agents not in callback mode. That being the case, I've tried to code it so that when callback mode is used, the app_lock mutex will not be locked/unlocked at all. Please let me know how you make out - and if you continue to deadlock now, please reproduce the deadlock logging information and post to Mantis. 



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42133 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-06 18:16:41 +00:00
BJ Weschke
b617860594 Don't do wierd things on a callback agent that has attempted logoff while still on the phone.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@37212 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-06 20:38:45 +00:00
Russell Bryant
99b3637d6a use ast_set_callerid to be more consistent and to make sure that the
"callerid" option in the conf files is always handled the same way and sets ANI
(issue #7285, gkloepfer)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@36725 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-03 04:19:09 +00:00
BJ Weschke
6af35712ef Don't show agents as available when they are in wrap-up time. #6726 (ZX81)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@25563 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-08 14:12:20 +00:00
Kevin P. Fleming
f522e07cbd ensure that agents logged in via the manager interface are stored in the persistence database (related to issue #6301)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@10137 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-02-15 01:21:33 +00:00
Russell Bryant
e22510658b fix spelling errors (issue #6227)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@8047 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-13 06:07:39 +00:00
Russell Bryant
dee03d2b80 move variable to correct scope (issue #6197)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@7986 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-11 19:08:53 +00:00
Kevin P. Fleming
2fd6520a7e update agent persistence when an agent gets logged off by autologoff
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@7829 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-06 00:21:00 +00:00
Kevin P. Fleming
224c6e3f7c send device state updates for auto-logoff of agents as well
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@7809 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-05 00:58:29 +00:00
Russell Bryant
a434f8877a cast time_t to an int in printf/scanf (issue #5635)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@7634 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-12-26 18:19:12 +00:00
BJ Weschke
2783801610 Bug #6040 - Documentation correction
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@7580 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-12-21 19:53:49 +00:00
Kevin P. Fleming
f9bc6f8afc only report AGENT_IDLE for callback mode agents when they are actually idle (issue #5902)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@7449 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-12-13 04:43:38 +00:00
Kevin P. Fleming
41023ecb9c protect agent_bridgedchannel() from segfaulting when there is no bridged channel (issue #5879)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@7271 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-12-02 00:28:48 +00:00
Kevin P. Fleming
a563eab49a remove extraneous svn:executable properties
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@7221 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-29 18:24:39 +00:00
Kevin P. Fleming
ebf04fc570 more header include simplification
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7023 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-08 04:02:35 +00:00
Russell Bryant
bb3e125ed4 don't loop forever on an invalid options string (issue #5629)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6989 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-06 22:17:47 +00:00
Russell Bryant
31a804b97c issue #5605
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6979 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-06 15:09:47 +00:00
Kevin P. Fleming
426360e389 major update to arg/option parsing APIs and documentation
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6953 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-03 21:19:11 +00:00
Kevin P. Fleming
c24ba6ac5e fix remaining breakage from yesterday's changes
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6881 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-28 17:22:34 +00:00
Kevin P. Fleming
fff6a2c159 use new app-argument macros, and try to fix yesterday's breakage
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6880 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-28 17:11:20 +00:00
Russell Bryant
9ddf0e4dce Remove unnecessary checks before calls to ast_strlen_zero. Also, change
some places where strlen is used instead of ast_strlen_zero


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6866 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-27 02:19:37 +00:00
Russell Bryant
052db5af42 fix up arguments to AgentCallbackLogin so that the options string and the
specified extension do not conflict.  This also makes the application not
assume that the extension is numeric.  While we're at it, include some code
cleanup - strcpy to ast_copy_string, and cleanups to LOCAL_USER handling.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6856 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-26 16:16:05 +00:00
Russell Bryant
3453e3efa5 Doxygen documentation update from oej (issue #5505)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6847 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-24 20:12:06 +00:00
Kevin P. Fleming
2fe49e7a5f support sending text through agent channels (issue #5295)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6787 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-14 00:46:13 +00:00
Kevin P. Fleming
7734cca1c2 properly display connected channel name in 'agents' manager action for non-callback agents (issue #5235)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6766 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-13 21:59:25 +00:00
Mark Spencer
bb49ec837f Fix seg in chan_agent (bug #5402)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6757 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-13 16:29:49 +00:00
Kevin P. Fleming
2aa0434048 don't check 'acknowledged' for setting lastdisc, since it's guaranteed to be zero at this point (issue #5254)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6736 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-05 21:27:38 +00:00
Mark Spencer
ea215f5b7d Remove possibility of manager deadlocks from manager actions
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6687 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-28 23:10:14 +00:00
Kevin P. Fleming
f0b4072039 fix some buglets in 'agents' Manager action (issue #5235)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6657 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-26 02:04:07 +00:00
Kevin P. Fleming
5da915dcfd update MANY more files with proper copyright/license info (thanks Ian!)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6596 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-14 20:46:50 +00:00
Kevin P. Fleming
811ec06cfd more documentation (issue #5174)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6583 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-14 02:12:37 +00:00
Kevin P. Fleming
67584e21c8 ensure that agent channels don't get seized during login (issue #5020)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6577 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-14 00:59:51 +00:00
Kevin P. Fleming
f16f81db05 ensure that the AGENTBYCALLERID_* variable is cleared when an agent logs in to a different device (issue #5213)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6575 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-14 00:39:05 +00:00
Kevin P. Fleming
6f49ab2dfa partial formatting cleanup
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6574 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-14 00:28:06 +00:00
Kevin P. Fleming
836916dab4 add doxygen documentation (issue #5133)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6536 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-07 20:44:57 +00:00
Kevin P. Fleming
ffe23eb007 add AgentCallbackLogin and AgentLogoff manager actions (issue #4766)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6427 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-08-26 20:24:16 +00:00
Russell Bryant
cd17218e59 add line break after show agents output (bug #4768)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6186 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-07-25 16:53:28 +00:00
Kevin P. Fleming
22b0f5d306 add a library of timeval manipulation functions, and change a large number of usses to use the new functions (bug #4504)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6146 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-07-15 23:00:47 +00:00
Kevin P. Fleming
38598f57b4 make 'Agents' manager action conform to protocol (bug #4723)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6141 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-07-15 16:21:41 +00:00
Kevin P. Fleming
c13d601fb4 queue device state changes and handle them serially in a background thread
optimize device state related functions
add ast_get_channel_by_name_prefix to allow searching for matching channels in O(1) operation


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6062 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-07-08 21:14:34 +00:00
Kevin P. Fleming
6b72557890 ensure that AGENTBYCALLERID is set for agents being reloaded from persistent storage
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6039 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-07-06 14:47:25 +00:00
Kevin P. Fleming
9403a6e027 remember CallerID in AgentCallbackLogin, so it can be used at logoff time
use stored CallerID when auto-logoff occurs to clear AGENTBYCALLERID variable (bug #4616)
persist stored CallerID into/out of astdb


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6036 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-07-06 01:29:15 +00:00
Kevin P. Fleming
4803ab0bb2 don't use locks when reading usecounts (reading only, not writing)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5994 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-06-24 02:15:04 +00:00
Mark Spencer
e74c288783 Fix agent recording issue (bug #4551)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5933 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-06-18 16:38:48 +00:00
Kevin P. Fleming
e5e64bfd41 header ordering fixes for FreeBSD (pending a global merge into asterisk.h) (bug #4484)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5876 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-06-07 17:06:33 +00:00
Kevin P. Fleming
2b8338cb52 more file version tags
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5866 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-06-06 22:12:19 +00:00
Kevin P. Fleming
005e436b57 another round of version tag updates, along with 'show version files' pattern filtering
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5865 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-06-06 21:09:59 +00:00
Mark Spencer
2f1e6379b3 Fix agent deadlock and remove braindead tags dependency
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5777 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-05-26 20:24:56 +00:00
Kevin P. Fleming
c382394360 add counters to 'show agents' CLI command (bug #4232)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5660 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-05-15 02:48:16 +00:00
Kevin P. Fleming
1f9ab2380a use double-quotes instead of angle-brackets for non-system include files (bug #4058)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@5490 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-04-21 06:02:45 +00:00