Commit Graph

1069 Commits

Author SHA1 Message Date
Russell Bryant
cbfeb816e1 Move the check for a failure of ast_channel_alloc() to before locking the
pvt structure again.  Otherwise, on a failure, this will cause a deadlock.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@51197 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-17 21:17:21 +00:00
Olle Johansson
2e738d5a7c Issue #8793 bad response for Unsupported Extension (different fix).
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@50517 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-11 18:11:09 +00:00
Kevin P. Fleming
2194a0b079 ensure that threads which are supposed to be detached (because we aren't going to wait on them) are created properly
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@49635 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-05 16:56:40 +00:00
Olle Johansson
59ae6dac08 Issue 8596: Set CAN_BYE flag for 100 trying too
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@48974 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-27 15:43:52 +00:00
Russell Bryant
798116918e Remove a couple of misplaced dots in log messages. This was reported by
Andrea Spadaccini on the asterisk-dev mailing list.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@48939 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-24 06:47:29 +00:00
Olle Johansson
c3b8d9f510 Issue #8592 - handle 504 as 503 - congestion
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@48484 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-15 10:51:53 +00:00
Olle Johansson
d37fee2b0f Issue #8528 - make sure we don't delete the dialog too quickly after receiving
a 487. Move 487 handling into handle_response_invite where it really
belongs and don't add an ALREADYGONE flag to the dialog.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@48320 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-06 15:42:41 +00:00
Olle Johansson
8eb9c059e5 Don't add Contact header on BYE, CANCEL, MESSAGE requests
(Bye, Cancel backported from 1.4, MESSAGE bug reported to me by Gunnar at Omnitor)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@48315 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-06 12:14:40 +00:00
Olle Johansson
c70018c590 Only set the ALREADYGONE flag once in handle_response()
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@48272 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-05 17:59:15 +00:00
Olle Johansson
e76ee063e6 Issue 8319 - noriyuki - nonce-count updated *after* use
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@48165 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-30 20:47:53 +00:00
Olle Johansson
faee7ae5f1 Do proper test and don't leave dialogs hanging...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@48127 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-30 09:05:07 +00:00
Olle Johansson
96a36252b6 Change some logging levels. Not having hints is not an ERROR, but still should be reported.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47987 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-24 14:33:27 +00:00
Olle Johansson
279ebd00c5 Remove unused variable (rizzo)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47958 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-23 10:54:40 +00:00
Joshua Colp
fea6c62d61 Free history items at the end of use of the temporary SIP pvt structure. (issue #8383 reported by benh)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47855 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-20 16:16:22 +00:00
Olle Johansson
0b9a8ee148 Just to be safe, disable all the scheduled items after deleting a scheduler entry (rizzo)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47842 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-20 10:17:36 +00:00
Olle Johansson
08570a5080 Don't fixup if we haven't got PVT. Suggestion from Martin Vit on -dev mailing list inspired
by file's commit to chan_local.

"This shouldn't happen" ;-)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47743 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-16 16:44:56 +00:00
Olle Johansson
f41333b1c4 CANCEL requests are never authenticated (according to RFC 3261)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47705 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-15 21:18:47 +00:00
Olle Johansson
618dd887f1 Send error message if we fail to allocate sip socket, possibly caused by too few
file handles (wasn't possible before, but with the new way of sending temp messages, it is).

Found this bug under heavy load testing with SIPP.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47655 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-15 15:17:10 +00:00
Olle Johansson
e49736b059 Sending 200 OK and not getting ACK is considered critical for the call.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47648 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-15 13:08:34 +00:00
Olle Johansson
62cb689e89 Avoid collissions between the peerpoke system and the retransmits. Issue #8272.
In some cases, changed timers caused the retransmit system to destroy the dialog before peerpoke_expire
got a chance.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47596 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-14 11:06:31 +00:00
Tilghman Lesher
442781850b Having more than 255 old messages caused corruption in the new/old count
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47580 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 20:18:30 +00:00
Olle Johansson
ff0ce011a0 Don't send 487 if we've already sent 200 OK on invite at time of receiving a BYE in the same transaction.
(SIPP testing)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47571 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 19:04:39 +00:00
Olle Johansson
474abf4656 Clear dialog on loop (backport from 1.4 by mistake)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47470 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-10 20:46:25 +00:00
Olle Johansson
55867f295a - Don't check for ignore in blocks that isn't reached if ignore is on...
- return properly after sending reply in handle_request_invite


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47458 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-10 19:37:41 +00:00
Olle Johansson
a7e9e0893b Fix multipart/mixed SDP support (issue 8010, alphaque)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47452 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-10 18:50:08 +00:00
Olle Johansson
e37d7b6682 Destroy the proper dialog...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47308 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-08 07:40:38 +00:00
Olle Johansson
735b4cf688 Remove dialog properly at unload of module (rizzo)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47307 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-08 07:31:34 +00:00
Olle Johansson
b4392d33ed Don't ever reply to an ACK. (Issue 8265)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47248 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-07 13:02:30 +00:00
Joshua Colp
1961bac13d Repeat after me oej: I will at least make sure my code compiles before I commit it.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@46920 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-02 16:02:27 +00:00
Olle Johansson
7908be0c2f Don't overwrite flags in the packet
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@46899 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-02 15:15:06 +00:00
Olle Johansson
6a662fe33e Another try to fix ;rport NAT traversal support (issue #7473)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@46610 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-31 09:49:46 +00:00
Olle Johansson
e807fbcec5 If peer fails ACL check, fail the REGISTER attempt
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@46604 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-31 09:13:34 +00:00
Olle Johansson
2405e775b1 On the other hand, we already copy the NAT flags... Reverting.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@46598 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-31 09:03:37 +00:00
Olle Johansson
093d6d9554 Issue 7473 - support ;rport on REGISTER requests too.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@46585 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-31 08:52:35 +00:00
Olle Johansson
154c4e9504 Issue #7869 - Stop sending 302 redirect when not getting an answer...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@46406 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-29 19:28:18 +00:00
Olle Johansson
2bec3b7627 issue #7608: Notifications with wrong content-type. Reported by jsiddall.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@46402 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-29 19:00:27 +00:00
Olle Johansson
7a5dd9d78b Issue #7240, by mistake only committed to trunk (now 1.4), reported by
edgreenberg in Issue #7966. Thanks Ed!


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@46344 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-26 20:06:55 +00:00
Olle Johansson
67f0e37177 Working to resolve #7608 - adding debug output
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@46258 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-25 19:28:48 +00:00
Olle Johansson
4dc847a0f4 Fix the attack shield for 1.2 too. REFER and NOTIFY can create dialogs
in the world of Asterisk.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@46213 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-25 15:49:29 +00:00
Joshua Colp
e0cbd7f2d9 Don't create a "real" pvt structure for requests that shouldn't be able to create one. Instead use a temporary pvt and fill it with enough information so we can send a reply.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@45380 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-17 20:37:17 +00:00
Olle Johansson
2b0634ab95 After some research, we realized that the default behaviour since a long
time was doing the right thing, even though the change optimized a bit
and removed a lot of potential risks. 

Conclusion: No need for a configuration option at all.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@45306 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-17 15:50:32 +00:00
Joshua Colp
01a7955445 Use responses rather then replies even though they mean the same thing.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@45265 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-16 19:59:54 +00:00
Joshua Colp
e64fa8614d Add 'ignoreoodreplies' option which will not create a pvt structure on a SIP response but instead basically drop it.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@45260 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-16 19:28:18 +00:00
Kevin P. Fleming
ffb75188e1 ensure that IAX2 and SIP sockets allow UDP fragmentation when running on Linux (thanks to Brian Candler on the asterisk-dev list for the tip)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@44955 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-12 18:31:26 +00:00
Olle Johansson
cd79e99638 Issue #8101 - wrong parameter for screening in remote-party-id
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@44757 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-09 14:36:24 +00:00
Kevin P. Fleming
a8c86fb9b2 fix Polycom presence notification again
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@44432 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-05 01:27:57 +00:00
Kevin P. Fleming
87706f538e remove workaround for old Polycom firmware SUBSCRIBE requests
add workaround for new Polycom firmware SUBSCRIBE requests (bug is known to exist in 2.0.1 firmware)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@44392 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-04 21:15:29 +00:00
Joshua Colp
e0408416d3 Change the fd on the I/O context in case it changed during the reload, which is indeed possible. (issue #7943 reported by eclubb)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@44213 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-02 20:07:59 +00:00
Joshua Colp
87803a8ac6 Put in missing \ns on the end of ast_logs (issue #7936 reported by wojtekka)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43924 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 18:00:30 +00:00
Joshua Colp
12afd66083 Use proper type to represent the group variable (issue #8025 reported by makoto)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43705 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-26 20:38:06 +00:00