Commit Graph

3219 Commits

Author SHA1 Message Date
Eliel C. Sardanons
9167a2b5e1 Add XML documentation for:
- WaitForSilence()
   - WaitForNoise()
   - WaitForRing()
   - IVRDemo()
   - DBDel()
   - DBDeltree()

 (issue #13699)
 Reported by: snuffy
 Patches: 
       bug13699_20081016.diff uploaded by snuffy (license 35)
        (With minor changes)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153747 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-03 01:01:25 +00:00
Kevin P. Fleming
a67790c6f5 instead of trying to forcibly load res_agi when app_stack is loaded (even if the administrator didn't want it loaded), use GCC weak symbols to determine whether it was loaded already or not; if it was loaded, then use it.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153709 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-02 23:34:39 +00:00
Kevin P. Fleming
bd4eb070f3 bring over all the fixes for the warnings found by gcc 4.3.x from the 1.4 branch, and add the ones needed for all the new code here too
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153616 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-02 18:52:13 +00:00
Eliel C. Sardanons
ee6a480a6c Add Flash() application XML documentation.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153543 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-02 05:10:22 +00:00
Eliel C. Sardanons
cdc31b1e5b Fix a typo in the name of the application.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153541 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-02 04:57:02 +00:00
Sean Bright
39cbb89947 Another little one.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153472 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-02 02:57:27 +00:00
Russell Bryant
2baafa6156 fix a typo (thanks sean)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153470 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-02 02:55:25 +00:00
Russell Bryant
6f314f4d42 Fix various spelling and grammatical issues in documentation
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153468 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-02 02:50:33 +00:00
Russell Bryant
d7742120e9 - Use a for loop instead of a while loop
- Get rid of an unnecessary variable


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153437 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-02 02:20:10 +00:00
Russell Bryant
ad533bc62b Instead of doing a couple of strlen() calls each iteration of the loop, only do it once
at the beginning of the function


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153435 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-02 02:14:19 +00:00
Russell Bryant
5b168ee34b Merge changes from team/group/appdocsxml
This commit introduces the first phase of an effort to manage documentation of the
interfaces in Asterisk in an XML format.  Currently, a new format is available for
applications and dialplan functions.  A good number of conversions to the new format
are also included.

For more information, see the following message to asterisk-dev:

http://lists.digium.com/pipermail/asterisk-dev/2008-October/034968.html


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153365 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-11-01 21:10:07 +00:00
Mark Michelson
d521ad9696 * Fixed timeout logic in the dialing API as setting timeouts
had no effect
* Updated dialing API documentation to indicate that timeouts
  are specified in milliseconds
* Added a new timeout argument to the Page application. If time
  expires, any endpoints which have not answered will be hung up.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153223 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-31 20:05:46 +00:00
Terry Wilson
5fe37e47c6 Recent CDR fixes moved execution of the 'h' exten into the bridging code, so variables that were set after ast_bridge_call was called would not show up in the 'h' exten. Added a callback function to handle setting variables, etc. from w/in the bridging code. Calls back into a nested function within the function calling ast_bridge_call
(closes issue #13793)
Reported by: greenfieldtech


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153181 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-31 18:55:33 +00:00
Kevin P. Fleming
10d36d9f34 fix a few small things found by using sparse
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152809 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-30 16:49:02 +00:00
Tilghman Lesher
77060afdac Pay attention to the searchcontexts entry in voicemail.conf (related to AST-125)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152727 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-30 02:08:02 +00:00
Mark Michelson
5652a7b81e If there was no named defined in a voicemail.conf mailbox
entry, then app_directory would crash when attempting to
read that entry from the file. We now check for the NULL
or empty string properly so that there will be no crash.

(closes issue #13804)
Reported by: bluecrow76



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152646 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-29 20:53:53 +00:00
Steve Murphy
d736ac2b19 Merged revisions 152538 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r152538 | murf | 2008-10-28 23:19:04 -0600 (Tue, 28 Oct 2008) | 14 lines

A little documentation cross-ref between features and
dial and queue... I wasted some time (stupidly) trying
to get the one-touch parking stuff working, because it
didn't occur to me that I had to also have the corresponding
options in the dial command! Duh! (In all this time, I never
set this up before!)
So, to keep some poor fool from suffering the same fate,
I made the features.conf.sample file mention the corresponding
opts in dial/queue; and the docs for dial/app specifically
mention the corresponding decls in the feature.conf file.

I hope this doesn't spoil some vast, eternal plan...


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152605 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-29 05:47:13 +00:00
Steve Murphy
6fad66dfb3 Merged revisions 152535 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r152535 | murf | 2008-10-28 22:36:32 -0600 (Tue, 28 Oct 2008) | 46 lines

The magic trick to avoid this crash is not to
try to find the channel by name in the list,
which is slow and resource consuming, but rather
to pay attention to the result codes from the
ast_bridge_call, to which I added the 
AST_PBX_NO_HANGUP_PEER_PARKED value, which
now are returned when a channel is parked.
Why? because CDR's aren't generated via parking,
so nothing is needed, but if a transfer occurred,
there are critical things I need.

If you get AST_PBX_KEEPALIVE,
then don't touch the channel pointer.

If you get AST_PBX_NO_HANGUP_PEER, or
AST_PBX_NO_HANGUP_PEER_PARKED, then don't
touch the peer pointer.

Updated the several places where the results
from a bridge were not being properly obeyed,
and fixed some code I had introduced so that
the results of the bridge were not overridden 
(in trunk).

All the places that previously tested for 
AST_PBX_NO_HANGUP_PEER now have to check for
both AST_PBX_NO_HANGUP_PEER and AST_PBX_NO_HANGUP_PEER_PARKED.

I tested this against the 4 common parking
scenarios:


1. A calls B; B answers; A parks B; B hangs up while A is getting the parking
slot announcement, immediately after being put on hold.

2. A calls B; B answers; A parks B; B hangs up after A has been hung up, but
before the park times out.

3. A calls B; B answers; B parks A; A hangs up while B is getting the parking slot announcement, immediately after being put on hold.

4. A calls B; B answers; B parks A; A hangs up after B has been hung up, but before the park times out.


No crash.

I also ran the scenarios above against valgrind, and accesses looked good.



........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152536 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-29 05:01:00 +00:00
Tilghman Lesher
c7367e26be Merged revisions 152463 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r152463 | tilghman | 2008-10-28 17:32:34 -0500 (Tue, 28 Oct 2008) | 3 lines
  
  Quoting in the wrong direction
  (Fixes AST-107)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152467 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-28 22:33:40 +00:00
Tilghman Lesher
dd049d429d Merged revisions 152368 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r152368 | tilghman | 2008-10-28 12:04:56 -0500 (Tue, 28 Oct 2008) | 8 lines
  
  Reset all DIAL variables back to blank, in case Dial is called multiple times
  per call (which could otherwise lead to inconsistent status reports).
  (closes issue #13216)
   Reported by: ruddy
   Patches: 
         20081014__bug13216.diff.txt uploaded by Corydon76 (license 14)
   Tested by: ruddy
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152369 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-28 17:07:39 +00:00
Tilghman Lesher
45b7b39c22 Set ARGC in subroutines with the number of arguments passed.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152174 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-27 16:44:55 +00:00
Tilghman Lesher
4ee45f5309 Oops, only delete the ARG variables once upon release. The following section
would have removed them again (removing variables from 2 stack frames, instead
of just one).


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152134 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-27 16:24:11 +00:00
Jason Parker
b40220784f Remove options argument parsing/syntax (it isn't used any longer)
(closes issue #13789)
Reported by: IgorG
Patches:
      app_transfer.c.diff uploaded by IgorG (license 20)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152132 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-27 16:03:12 +00:00
Tilghman Lesher
855492c60c Default file modes should always be full read and write, to allow the system
administrator to make the decision of what permissions will actually be given,
through the use of the process umask.
(Closes issue# 13751)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151371 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-21 15:20:50 +00:00
Kevin P. Fleming
1ddc834b39 cleaup of the TCP/TLS socket API:
1) rename 'struct server_args' to 'struct ast_tcptls_session_args', to follow coding guidelines

2) make ast_make_file_from_fd() static and rename it to something that indicates what it really is for (again coding guidelines)

3) rename address variables inside 'struct ast_tcptls_session_args' to be more descriptive (dare i say it... coding guidelines)

4) change ast_tcptls_client_start() to use the new 'remote_address' field of the session args for the destination of the connection, and use the 'local_address' field to bind() the socket to the proper source address, if one is supplied

5) in chan_sip, ensure that we pass in the PP address we are bound to when creating outbound (client) connections, so that our connections will appear from the correct address



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151101 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-19 19:11:28 +00:00
BJ Weschke
31d28c2518 Give app_authenticate the ability to select a prompt other than the default.
(closes issue #13734)
 reported and patched by: jvandal



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150887 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-18 03:35:24 +00:00
BJ Weschke
7a8344bac6 The QueueEntry event now has the uniqueid of the channel included.
(closes issue #13731)
 reported and patched by: caio1982



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150773 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-18 00:25:18 +00:00
Tilghman Lesher
95ea0a5a70 Fix option handling code.
(closes issue #11040)
 Reported by: DEA
 Patches: 
       rt-meetme-flag-fixes-v2.txt uploaded by DEA (license 3)
       with additional fixes by me


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150384 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-17 04:28:13 +00:00
Jeff Peeler
4afb2649b9 Initialize character arrays as they are not guaranteed to be set.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150309 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-17 00:14:19 +00:00
Mark Michelson
270a2b6a61 Answer the channel prior to checking for the 'a'
option in app_sms.

(closes issue #13675)
Reported by: alecdavis
Patches:
      app_sms.bug13675.148985.diff.txt uploaded by alecdavis (license 585)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150257 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-16 22:44:05 +00:00
Mark Michelson
890a3c2a9b Updating app_skel.c to follow coding guidelines
with regards to braces used on if statements.

(closes issue #13696)
Reported by: alecdavis
Patches:
      app_skel.bug13696B.115850.diff.txt uploaded by alecdavis (license 585)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@150255 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-16 22:36:08 +00:00
Tilghman Lesher
1c5e6fc18b Minor spacing change
(closes issue #13697)
 Reported by: alecdavis
 Patches: 
       app_echo.bug13697.103249.diff.txt uploaded by alecdavis (license 585)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149588 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-15 15:30:21 +00:00
Kevin P. Fleming
8e33548633 building this module depends on res_agi being built as well
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149384 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-15 08:55:47 +00:00
Mark Michelson
dc36a357d2 When specifying an invalid timeout to Dial, take it
to mean that no timeout is desired.

(closes issue #13625)
Reported by: atis



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149279 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 23:57:46 +00:00
Mark Michelson
184fe6f87b Merged revisions 149200 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r149200 | mmichelson | 2008-10-14 17:40:42 -0500 (Tue, 14 Oct 2008) | 12 lines

Update the queue with the correct number of calls and
whether the call was completed within the service level
when a transfer takes place. This way, we do not "break"
the leastrecent and fewestcalls strategies by not logging
a call until after the transferred call has ended.

(closes issue #13395)
Reported by: Marquis
Patches:
      app_queue.c.transfer.patch uploaded by Marquis (license 32)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149201 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 22:41:13 +00:00
Tilghman Lesher
f7a5a731bd Merged revisions 149061 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r149061 | tilghman | 2008-10-14 15:09:06 -0500 (Tue, 14 Oct 2008) | 6 lines
  
  Check correct values in the return of ast_waitfor(); also, get rid of a
  possible memory leak.
  (closes issue #13658)
   Reported by: explidous
   Patch by: me
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@149062 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 20:16:48 +00:00
Tilghman Lesher
e818109d73 Merged revisions 148987 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r148987 | tilghman | 2008-10-14 14:03:08 -0500 (Tue, 14 Oct 2008) | 2 lines
  
  Some compilers warn, some don't.  Fixing.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148988 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 19:03:44 +00:00
Tilghman Lesher
5bf164e901 App is ignoring 'p' parameter -- initial pause.
(closes issue #13617)
 Reported by: alecdavis
 Patches: 
       app_sms.13oct.diff.txt uploaded by alecdavis (license 585)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148985 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 18:58:19 +00:00
Tilghman Lesher
7bdb6c3ea5 Merged revisions 148916 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r148916 | tilghman | 2008-10-14 12:41:08 -0500 (Tue, 14 Oct 2008) | 4 lines
  
  Ensure that mail headers are 7-bit clean, even when UTF-8 characters are used
  in headers like 'Subject' and 'To'.
  Closes AST-107.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148917 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 17:46:48 +00:00
Tilghman Lesher
6d5409e23d API differences in spandsp 0.0.6pre1 and higher
(closes issue #13688)
 Reported by: irroot
 Patches: 
       app_fax-span6.patch uploaded by irroot (license 52) with minor modifications by me


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148868 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 15:15:45 +00:00
Tilghman Lesher
c1351ad237 Merge realtime_update2 branch, which adds a new realtime API call named
'update2', which permits updates which match across multiple columns, instead
of requiring all tables to have a single unique identifier.  All of the other
API calls with the exception of 'update' already had the ability to match on
multiple fields, so it was a missing and very desireable feature that an API
call implementing an update should have this, too.

This does not change any outward performance of Asterisk, but it should make
life easier for application developers who use the RealTime framework.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148570 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-14 00:08:52 +00:00
Tilghman Lesher
926e3ad13d Merged revisions 148257 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r148257 | tilghman | 2008-10-10 11:25:31 -0500 (Fri, 10 Oct 2008) | 7 lines
  
  User not notified of temporary greeting, if ODBC storage is in use.
  (closes issue #13659)
   Reported by: moliveras
   Patches: 
         20081009__bug13659.diff.txt uploaded by Corydon76 (license 14)
   Tested by: moliveras
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148268 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-10 16:31:31 +00:00
Sean Bright
1dedb785ab Don't include logger.h in asterisk.h by default as it is causing problems building
app_voicemail.  Instead, include it where it is needed.  This turned out to be a
relatively minor issue because other headers include logger.h as well.

Need to test -addons before merging this back to 1.6.0.

(closes issue #13605)
Reported by: tomo1657
Patches: 
      13605_seanbright.diff uploaded by seanbright (license 71)
Tested by: mmichelson


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148200 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-10 00:42:13 +00:00
Mark Michelson
806f3581d9 Read the callerid in the correct order and make sure to
read the Urgent flag value from the IMAP headers.

(closes issue #13652)
Reported by: jaroth
Patches:
      imapheaders.patch uploaded by jaroth (license 50)




git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148144 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-09 23:30:47 +00:00
Tilghman Lesher
8b14e5f493 Reverting format addition for now
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148071 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-09 21:47:02 +00:00
Tilghman Lesher
f5d5eb5e19 Fudges for wav16, just like wav49
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148070 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-09 21:37:23 +00:00
Tilghman Lesher
e4de40eabc Merged revisions 147997 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r147997 | tilghman | 2008-10-09 14:38:33 -0500 (Thu, 09 Oct 2008) | 4 lines
  
  When blank, callerid name and number should display "unknown caller" in voicemail
  emails.
  (Closes issue #13643)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@148000 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-09 19:39:34 +00:00
Mark Michelson
b79629d182 Some small tweaks regarding realtime conference announcements.
(closes issue #13522)
Reported by: DEA
Patches:
      meetme-rt-fixes.txt uploaded by DEA (license 3)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@147714 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-08 22:32:37 +00:00
Tilghman Lesher
5f88f1738d Correct a typo in the help; also, ensure that the date and time are correctly
set, if not specified in the message.
(Closes issue #13594, closes issue #13595)
Reported by: alecdavis
 Patches: 
       20081001__bug13595.diff.txt uploaded by Corydon76 (license 14)
 Tested by: alecdavis


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@147592 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-08 19:08:32 +00:00
Joshua Colp
fddf5f914a Merged revisions 147517 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r147517 | file | 2008-10-08 11:51:42 -0300 (Wed, 08 Oct 2008) | 2 lines
  
  If we receive DTMF make sure that the state of the speech structure goes back to being not ready. (issue #LUMENVOX-8)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@147518 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-10-08 14:53:51 +00:00