Joshua Colp
2395b1a6f5
Due to recent changes tag will no longer be NULL if not present so we have to use ast_strlen_zero to see if it's actually blank.
...
(closes issue #12061 )
Reported by: flefoll
Patches:
chan_sip.c.br14.patch_pedantic_no_totag uploaded by flefoll (license 244)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@104082 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-25 15:17:18 +00:00
Tilghman Lesher
638ca62698
Backwards debug message.
...
(closes issue #12052 )
Reported by: flefoll
Patches:
chan_sip.c.br14.patch_found-notfound uploaded by flefoll (license 244)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@104037 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-22 22:45:14 +00:00
Mark Michelson
2d8f502132
And as a followup to revision 104026, completely remove event-related
...
calls from a section of code where we know there was no event to handle or get.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@104027 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-21 21:05:42 +00:00
Mark Michelson
b3dd064bcb
Remove an incorrect debug message. It reported that it had received a specific event and tried to report
...
which event was received. What actually was happening was that it was reporting the number of bytes returned
from a call to read().
Thanks to Jared Smith for bringing the issue up on IRC
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@104026 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-21 20:12:38 +00:00
Joshua Colp
11edc2ab8d
Don't wait for additional digits when overlap dialing is enabled if the setup message contains the sending_complete information element.
...
(closes issue #11785 )
Reported by: klaus3000
Patches:
sending_complete_overlap_asterisk-1.4.17.patch.txt uploaded by klaus3000 (license 65)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@103953 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-20 22:06:59 +00:00
Mark Michelson
6835ca7d03
Fix a crash if the channel becomes NULL while attempting to lock it.
...
(closes issue #12039 )
Reported by: danpwi
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@103904 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-20 21:40:08 +00:00
Joshua Colp
749f1e1963
Send CallerID Name in setup message.
...
(closes issue #11241 )
Reported by: tusar
Patches:
h323id_as_callerid_name.patch uploaded by tusar (license 344)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@103823 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-19 20:28:08 +00:00
Russell Bryant
8c9a6024d9
Account for the fact that the "other" channel can disappear while the local pvt
...
is not locked.
(fixes a problem introduced in rev 100581)
(closes issue #12012 )
Reported by: stevedavies
Patch by me
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@103821 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-19 20:02:49 +00:00
Joshua Colp
7b6d391b76
Fix building of chan_sip.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@103807 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-19 15:01:42 +00:00
Olle Johansson
7b72c89fb9
Make sure we send error replies correctly by checking the via header.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@103806 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-19 10:27:15 +00:00
Jason Parker
add30e2666
Fix previous commit so that we actually disable echocanbridged if echocancel is off.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@103795 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-18 22:28:56 +00:00
Jason Parker
4ce44f1c28
Correct a message when echocancelwhenbridged is on, but echocancel is not.
...
Issue #12019
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@103790 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-18 21:23:32 +00:00
Tilghman Lesher
4306df31b1
When a SIP channel is being auto-destroyed, it's possible for it to still be
...
in bridge code. When that happens, we crash. Delay the RTP destruction until
the bridge is ended.
(closes issue #11960 )
Reported by: norman
Patches:
20080215__bug11960__2.diff.txt uploaded by Corydon76 (license 14)
Tested by: norman
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@103780 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-18 17:31:52 +00:00
Mark Michelson
a300034b08
Fix a linked list corruption that under the right circumstances
...
could lead to a looped list, meaning it will traverse forever.
(closes issue #11818 )
Reported by: michael-fig
Patches:
11818.patch uploaded by putnopvut (license 60)
Tested by: michael-fig
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@103770 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-18 16:37:31 +00:00
Joshua Colp
c8d5a65d35
Don't care if the extension given doesn't exist for subscription based MWI.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@103763 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-18 15:33:14 +00:00
Russell Bryant
6bf909cd2e
Fix a crash in chan_iax2 due to a race condition
...
(closes issue #11780 )
Reported by: guillecabeza
Patches:
bug_iax2_jb_1.4.patch uploaded by guillecabeza (license 380)
bug_iax2_jb_trunk.patch uploaded by guillecabeza (license 380)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@103741 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-15 23:31:39 +00:00
Tilghman Lesher
e049bdfcfa
We aren't talking to ourselves; we're talking to someone else.
...
(closes issue #11771 )
Reported by: msetim
Patches:
ami_agent_talkingto-1.4.diff uploaded by caio1982 (license 22)
Tested by: caio1982, msetim
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@103607 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-13 06:25:03 +00:00
Joshua Colp
f3f663d6fd
Even if no CallerID name or number has been provided by the remote party still use the configured sip.conf ones.
...
(closes issue #11977 )
Reported by: pj
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@103385 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-12 15:09:24 +00:00
Mark Michelson
19f5074cd8
Yield the thread and return -1 if the ioctl fails for Zaptel timing device.
...
(closes issue #11891 )
Reported by: tzafrir
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@103070 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-08 18:00:38 +00:00
Joshua Colp
5e3cbd6f92
Make sure the presence of dbsecret is factored into user scoring.
...
(closes issue #11952 )
Reported by: bbhoss
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@102968 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-08 15:08:20 +00:00
Joshua Colp
f26bac62e6
Only consider a T.38-only INVITE compatible if we have both a joint capability between us and them and if they provided T.38.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@102725 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-06 17:59:23 +00:00
Mark Michelson
748609f25e
Clear the DTMF buffer on hangup.
...
(closes issue #11919 )
Reported by: eferro
Patches:
mgcp_dtmfclean_on_hangup.diff uploaded by eferro (license 337)
Tested by: eferro
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@102453 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-05 20:02:44 +00:00
Joshua Colp
e9c59d95eb
If a REGISTER attempt comes in that is a retransmission of a previous REGISTER do not create a new nonce value.
...
(issue #BE-381)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@102450 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-05 19:52:30 +00:00
Kevin P. Fleming
8a2fd8fdbd
ensure that components of chan_misdn.so are built using any special build options that the configure script generated (reported by Philipp Kempgen on asterisk-dev)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@102425 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-05 17:15:36 +00:00
Olle Johansson
649a083adb
Use the same CSEQ on CANCEL as on INVITE (according to RFC 3261)
...
(closes issue #9492 )
Reported by: kryptolus
Patches:
bug9492.txt uploaded by oej (license 306)
Tested by: oej
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@102142 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-03 16:38:12 +00:00
Olle Johansson
9a5d78c2c7
Handle ACK and CANCEL in an invite transaction - even if we get INFO transactions during the actual call setup.
...
(closes issue #10567 )
Reported by: jacksch
Tested by: oej
Patch by: oej inspired by suggestions from neutrino88 in the bug tracker
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@102090 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-03 10:37:32 +00:00
Russell Bryant
26365fdeca
Change the SDP_SAMPLE_RATE macro. It turns out that even though G.722 is 16 kHz,
...
it is supposed to specified as 8 kHz in the RTP, and RTP timestamps are supposed
to be calculated based on 8 kHz. (Apparently this is due to a bug in a spec, but
people follow it anyway, because it's the spec ...)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101989 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-01 23:06:32 +00:00
Russell Bryant
fe59cfa7aa
Add some more sanity checking on IAX2 dial strings for the case that no peer
...
or hostname was provided, which is the one part of the dial string that is
absolutely required. If it's not there, bail out.
(closes issue #11897 )
Reported by sokhapkin
Patch by me
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101693 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-02-01 00:32:49 +00:00
Jason Parker
9742fb53fe
Solaris compat fixes for struct in_addr funkiness.
...
Issue #11885 , patch by snuffy.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101482 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-31 19:52:49 +00:00
Russell Bryant
0343bf8348
Add more missing locking of the agents list ...
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101433 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-31 19:17:05 +00:00
Russell Bryant
70200cec77
Move the locking from find_agent() into the agent dialplan function handler to
...
ensure that the agent doesn't disappear while we're looking at it.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101414 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-31 19:07:46 +00:00
Russell Bryant
c6c7c3bf58
Add missing locking to the find_agent() function.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101413 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-31 19:04:52 +00:00
Olle Johansson
5e02b0d76e
Stop musiconhold on attended transfer.
...
(closes issue #11872 )
Reported by: gareth
Patches:
svn-101018.patch uploaded by gareth (license 208)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101152 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-30 11:20:31 +00:00
Jason Parker
f60be6bdb8
Initialize an array to 0s if config option not specified.
...
(closes issue #11860 )
Patches:
misdn_get_config.v1.diff uploaded by IgorG (license 20)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100930 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-29 17:41:43 +00:00
Jason Parker
75007e2ab5
Allow zap groups above 30 to work properly.
...
(closes issue #11590 )
Reported by: tbsky
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100835 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-29 16:10:00 +00:00
Christian Richter
31c5fc22a5
fixed potential segfault in misdn show channels CLI command
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100793 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-29 10:36:19 +00:00
Olle Johansson
52cfa83d42
(closes issue #11736 )
...
Reported by: MVF
Patches:
bug11736-2.diff uploaded by oej (license 306)
Tested by: oej, MVF, revolution
(russellb: This was the showstopper for the release.)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100740 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-29 08:26:48 +00:00
Mark Michelson
d53c693509
Undoing the deprecation of chan_vpb. It is alive and well.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100673 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-28 20:55:56 +00:00
Russell Bryant
fe50ae6de5
For some reason, the use of this strdupa() is leading to memory corruption on
...
freebsd sparc64. This trivial workaround fixes it.
(closes issue #10300 , closes issue #11857 , reported by mattias04 and Home-of-the-Brave)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100629 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-28 18:34:20 +00:00
Jason Parker
58a4fa50ce
Correct a comment which made little/no sense.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100624 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-28 18:23:09 +00:00
Russell Bryant
ef78f25e8a
Make some deadlock related fixes. These bugs were discovered and reported
...
internally at Digium by Steve Pitts.
- Fix up chan_local to ensure that the channel lock is held before the local
pvt lock.
- Don't hold the channel lock when executing the timing function, as it can
cause a deadlock when using chan_local. This actually changes the code back
to be how it was before the change for issue #10765 . But, I added some other
locking that I think will prevent the problem reported there, as well.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100581 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-28 17:15:41 +00:00
Tilghman Lesher
7060a6888d
When deleting a task from the scheduler, ignoring the return value could
...
possibly cause memory to be accessed after it is freed, which causes all
sorts of random memory corruption. Instead, if a deletion fails, wait a
bit and try again (noting that another thread could change our taskid
value).
(closes issue #11386 )
Reported by: flujan
Patches:
20080124__bug11386.diff.txt uploaded by Corydon76 (license 14)
Tested by: Corydon76, flujan, stuarth`
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100465 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-27 21:59:53 +00:00
Mark Michelson
53859e0bfc
Deprecating chan_vpb. It is now preferred that users of Voicetronix products
...
use chan_zap in combination with their zaptel drivers.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100418 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-25 22:32:41 +00:00
Jason Parker
a70508ed3d
This would have never been true, since we're passing (sizeof(req.data) - 1) as the len to recvfrom().
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100378 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-25 21:24:49 +00:00
Olle Johansson
107c1c37b4
Second attempt. Don't change invitestate when receiving 18x messages in CANCEL state.
...
(issue #11736 )
Reported by: MVF
Patch by oej.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@99978 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-23 21:07:16 +00:00
Olle Johansson
d95d9d7132
Make sure we don't cancel destruction on calls in CANCEL state, even if we
...
get 183 while waiting for answer on our CANCEL.
(issue #11736 )
Reported by: MVF
Patches:
bug11736.txt uploaded by oej (license 306)
Tested by: MVF
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@99977 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-23 20:58:20 +00:00
Mark Michelson
3e54e684b2
These flag tests were illogical. They were testing sip_peer flags on a sip_pvt.
...
Thanks to Russell for helping to get this odd problem figured out.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@99878 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-23 16:18:04 +00:00
Olle Johansson
f9cf98d4bf
Thanks to Russell's education I realize that BUFSIZ has changed since I learned the C language
...
over 20 years ago... Resetting chan_sip to the size of BUFSIZ that I expected in my old
head to avoid to heavy memory allocations on some systems.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@99652 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-22 20:56:09 +00:00
Olle Johansson
48066f4cfd
Add more dependencies on chan_local and add a note to the description of chan_local
...
so that people don't disable it in menuselect just to clean up.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@99594 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-22 17:41:57 +00:00
Olle Johansson
33b77709a7
Cleaning up some documentation that led to confusion in a bug report
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@99501 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-22 15:08:14 +00:00