kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-10-31 02:37:10 +00:00
Code Issues Packages Projects Releases Wiki Activity
12,126 Commits 151 Branches 1,609 Tags
48066f4cfddbe304d143aae24f5d7d5087344dc8
Commit Graph

12126 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Russell Bryant
7cd8afd1ea Some locking errors exposed the fact that the lock debugging code itself was 
not thread safe.  How ironic!  Anyway, these changes ensure that the code that
is accessing the lock debugging data is thread-safe.  

Many thanks to Ivan for finding and fixing the core issue here, and also 
thanks to those that tested the patch and provided test results.

(closes issue #10571)
(closes issue #10886)
(closes issue #10875)
(might close some others, as well ...)

Patches: (from issue #10571)
      ivan_ast_1_4_12_rel_patch_lock.h.diff uploaded by Ivan (license 229)
       - a few small changes by me


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85994 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-16 22:14:36 +00:00
Mark Michelson
eb154e963c Trying to remove a non-dynamic queue member via dynamic means can lead to some 
interesting (read nasty) situations. This patch clears up the issue by making
only dynamic queue members removable via dynamic methods.



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85958 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-16 21:14:34 +00:00
Tilghman Lesher
17ee21bf18 Also set up gmtoff (this is used in the %z gnu extension to strftime) 
Reported and fixed by jcmoore
Closes issue #11002


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85921 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-16 19:41:40 +00:00
Russell Bryant
f192689840 Remove a pointless lock. 
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85896 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-16 19:10:01 +00:00
Mark Michelson
661aa4ba35 Fixing a double free which happens in the statechange thread. 
(closes issue #10987, reported by andrew)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85852 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-16 15:21:58 +00:00
Joshua Colp
ed25613860 Check to make sure a value has been given to the VMCOUNT dialplan function. 
(closes issue #10996)
Reported by: marsosa


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85850 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-16 14:52:22 +00:00
Joshua Colp
3a935a35a0 Fix memory allocation issue in threadstorage. 
(closes issue #10995)
Reported by: snuffy
Patches:
      new-patch.diff uploaded by snuffy (license 35)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85818 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-16 14:19:39 +00:00
Philippe Sultan
ab36dd5843 Fix the output for this channel help CLI command 
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85800 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-16 10:46:13 +00:00
Russell Bryant
d63883be92 Ensure that no pending state changes are leaked when the device state change 
thread gets stopped on module unload.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85720 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-15 21:10:02 +00:00
Russell Bryant
87dc20fc03 Previously, app_queue created a thread to handle every single device state 
change.  I changed this a while ago in trunk for performance reasons.  However,
bug 8407 points out that it is actually a race condition, causing device state
changes to get processed in random order.  So, I backported my changes from
trunk to 1.4.
(closes issue #8407, patch provided by tim_ringenbach, committed patch by me)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85717 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-15 20:59:27 +00:00
Tilghman Lesher
47b21bae6e Don't execute a gosub if the arguments is zero-len (not just NULL) 
Reported by davevg
Fixed by me
Closes issue #10985


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85687 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-15 20:29:35 +00:00
Russell Bryant
d47ebb492f Add a small fix for the tw version of saying dates. 
(closes issue #7827)
Reported by: sharkey
Patches: 
      say.nits.patch uploaded by sharkey (license 172)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85686 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-15 20:21:27 +00:00
Jason Parker
eb9c632b90 Properly use DESTDIR in 'config' target. 
Do not try to run chkconfig or similar if using DESTDIR.

Issue 10938, patch by cabal95.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85684 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-15 20:15:51 +00:00
Russell Bryant
02bb2bcbaa Be pedantic about handling memory allocation failure. 
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85649 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-15 19:22:45 +00:00
Russell Bryant
9c47228dff The loop in the handler for the "core show locks" could potentially block for 
some amount of time.  Be a little bit more careful and prepare all of the
output in an intermediary buffer while holding a global resource.  Then, after
releasing it, send the output to ast_cli().


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85647 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-15 19:11:38 +00:00
Russell Bryant
3ba62c30b9 Make the default for the srvlookup option to be yes. It doesn't really make 
sense for it to default to off.  The default configuration file has it on, and
proper RFC behavior, as indicated by a comment in the code, is for it to be on.
So, let's have it on by default to make lives easier.
(closes issue #10954, suggested by jtodd)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85604 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-15 16:54:57 +00:00
Joshua Colp
0912ca3c07 Document that DTMF based features only work when two channels are bridged together. 
(closes issue #10773)
Reported by: pbayley


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85571 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-15 16:39:59 +00:00
Russell Bryant
6b9addb181 Make a few changes so that characters in the upper half of the ISO-8859-1 
character set don't get stripped when reading configuration.
(closes issue #10982, dandre)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85561 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-15 16:34:13 +00:00
Joshua Colp
0f3e461074 Bring both DTMF begin and end frames up through to the core for DTMF feature handling. 
(closes issue #10826)
Reported by: dimas


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85559 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-15 16:22:02 +00:00
Russell Bryant
ca69081253 Ensure the buffer passed to ast_canmatch_extension() is properly initialized so 
that it is null terminated.

(issue #10977)
Reported by: dimas
Patches: 
      pbxdundi.patch uploaded by dimas (license 88)
	    - small mods by me


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85556 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-15 15:40:45 +00:00
Joshua Colp
3cc997694d If Monitor or a spy was added to a P2P or native bridged channel bring the channel back to the generic bridging core so the monitor or spy operations work. 
(closes issue #10943)
Reported by: julianjm


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85552 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-15 14:55:04 +00:00
Russell Bryant
b5addcd9a5 Suppress a LOG_DEBUG message if debug is not enabled. 
(closes issue #10980)
Reported by: casper
Patches: 
      db.c.84633.diff uploaded by casper (license 55)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85548 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-15 13:16:23 +00:00
Russell Bryant
39f5611898 Make sure remote consoles unmute themselves again after reconnecting. 
(closes issue #10847)
Reported by: atis
Patches: 
      console_unmute_on_reconnect.patch uploaded by atis (license 242)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85545 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-15 13:05:45 +00:00
Russell Bryant
9b382ca76f Make sure that the base64 decoder returns a terminated string. 
(closes issue #10979)
Reported by: ys
Patches: 
      util.c.diff uploaded by ys (license 281)
	    - small mods by me


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85543 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-15 12:48:10 +00:00
Russell Bryant
91bfacc3ed Don't create the context for users in users.conf until we know at least one user exists. 
(closes issue #10971)
Reported by: dimas
Patches: 
      pbxconfig.patch uploaded by dimas (license 88)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85540 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-14 15:24:52 +00:00
Tilghman Lesher
81a5da0ada Remove deprecated syntax from sample ael file 
Reported and patched by: dimas
Closes issue #10967


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85536 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-13 15:26:01 +00:00
Russell Bryant
bad30446a6 Fix an issue with console verbosity when running asterisk -rx to execute a command 
and retrieve its output.  The issue was that there was no way for the main Asterisk
process to know that the remote console was connecting in the -rx mode.  The way that
James has fixed this is to have all remote consoles muted by default.  Then, regular
remote consoles automatically execute a CLI command to unmute themselves when they
first start up.

(closes issue #10847)
Reported by: atis
Patches: 
      asterisk-consolemute.diff.txt uploaded by jamesgolovich (license 176)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85533 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-13 05:48:10 +00:00
Russell Bryant
6c18b111b9 Properly handle the case where read() may return the text for more than one 
CLI command at once for a remote console.

(closes issue #10888)
Reported by: jamesgolovich
Patches: 
      asterisk-climultiple.diff.txt uploaded by jamesgolovich (license 176)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85532 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-13 05:24:33 +00:00
Tilghman Lesher
1e95206c51 Change Digium address 
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85523 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-12 18:30:55 +00:00
Russell Bryant
9723b7d878 Fix a spelling error in a log message. SMDI, not SDMI. 
(closes issue #10959)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85517 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-12 15:45:09 +00:00
Russell Bryant
c27db984f9 Fix the potential use of an uninitialized buffer in a log message. 
(closes issue #10958)
Reported by: dimas
Patches: 
      realtime.patch uploaded by dimas (license 88)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85515 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-12 15:40:35 +00:00
Joshua Colp
437a6ffcd3 When creating a new packet don't try to stop retransmission of it. It was just allocated/created so it's impossible for it to have already been scheduled. 
(closes issue #10945)
Reported by: flefoll
Patches:
      chan_sip.c.br14.85280.xmit_reliable-patch uploaded by flefoll (license 244)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85397 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-11 15:26:20 +00:00
Tilghman Lesher
18fa561af4 A dollar sign by itself, not indicating a start of a variable or expression prematurely ends substitution (closes issue #10939) 
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85356 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-11 04:35:33 +00:00
Russell Bryant
863ae211da I introduced a new member to the ast_filestream struct in 1.4.12, but put it 
in the middle of the struct, instead of at the end.  One of the Debian folks,
paravoid, pointed out that this breaks binary compatability with modules
compiled against older headers.  So, I'm moving the new member to the end
of the struct to resolve the situation.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85316 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-10 15:56:23 +00:00
Mark Michelson
30b6db4bcf The thread ID should be unsigned. 
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85315 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-10 15:51:56 +00:00
Joshua Colp
3b9fafc1e0 If devicestate is passed a port number strip it out. 
(closes issue #10930)
Reported by: ibc


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85280 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-10 14:42:00 +00:00
Joshua Colp
e568fc66d9 Add support for handling a 182 Queued response. 
(closes issue #10924)
Reported by: ramonpeek
Patches:
      queued-182.diff uploaded by ramonpeek (license 266)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85277 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-10 14:28:18 +00:00
Mark Michelson
deb480f124 A bunch of changes from sprintf to snprintf. 
See security advisory AST-2002-022



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85276 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-10 14:26:31 +00:00
Joshua Colp
3151af0015 Close voicemail message description file if duration did not meet the minimum, or else we will eventually run out of file descriptors. 
(closes issue #10918)
Reported by: brak2718
Patches:
      vm1.4.12.1.patch uploaded by brak2718 (license 279)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85242 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-10 14:14:56 +00:00
Kevin P. Fleming
9cdda4fc78 use a macro instead of an inline function, so that backtraces will report the caller of ast_frame_free() properly 
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85195 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-10 06:24:41 +00:00
Tilghman Lesher
96d11d3e02 This commit fixes the following issues: 
- Deadlock in ast_write (issue #10406)
- Deadlock in ast_read (issue #10406)
- Possible mutex initialization error in lock.h (issue #10571)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85158 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-09 21:55:06 +00:00
Joshua Colp
474e0e8d12 Don't perform a reinvite if a transfer is in progress. 
(issue #10915)
Reported by: ramonpeek


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85093 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-09 14:30:16 +00:00
Joshua Colp
ba0bb743e6 Only update codec information if the channel has a technology private structure. 
(issue #10915)
Reported by: ramonpeek


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85057 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-08 20:06:33 +00:00
Joshua Colp
3dcf938f73 Update codec information as well as address when doing hold reinvites. 
(issue #10868)
Reported by: mavince


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@85023 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-08 15:37:46 +00:00
Joshua Colp
2baeb29ae4 Don't keep trying to native bridge if either of the channels are involved in a masquerade operation to be done. 
(closes issue #10696)
Reported by: tbelder


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84990 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-08 15:03:07 +00:00
Russell Bryant
a914cb6654 Enable file dependency tracking for _all_ builds, and not just for builds with 
dev-mode enabled.  I have seen enough problems caused by this that I don't think
it's worth keeping.  I want to continue to encourage anybody that is interested
to continue to run Asterisk from svn.  Furthermore, I do not want their systems
to break when we change a structure definition in a header file.  :)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84957 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-08 03:28:34 +00:00
Philippe Sultan
95e24c44c1 Presence packets from a client who's connected with our Jabber ID are 
valid, therefore, those clients must be considered as buddies. The resource
string helps us make the distinction between clients.

Closes issue #10707, reported by yusufmotiwala.

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84902 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-07 16:15:39 +00:00
Philippe Sultan
c7e7a27bac Prevent Asterisk from crashing when receiving a presence packet 
without resource from a buddy that is known to have a resource list.

Revert a change I previously made, where Asterisk could point to a
freed memory location.

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84890 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-07 15:52:44 +00:00
Tilghman Lesher
9ae23cba31 Log exactly why we can't open the database, if we fail (closes issue #10887) 
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84851 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-05 19:42:21 +00:00
Joshua Colp
35ed1f7148 Update the remembered RTP peer information when putting an endpoint on hold or taking it off hold so that the RTP stack does not initiate a needless reinvite. 
(closes issue #10868)
Reported by: mavince


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84818 65c4cc65-6c06-0410-ace0-fbb531ad65f3
 2007-10-05 18:55:36 +00:00