Commit Graph

5861 Commits

Author SHA1 Message Date
Russell Bryant
68307855f9 Merged revisions 216368 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
  r216368 | russell | 2009-09-04 08:14:25 -0500 (Fri, 04 Sep 2009) | 12 lines
  
  Do not treat every SIP peer as if they were configured with insecure=port.
  
  There was a problem in the function responsible for doing peer matching by
  IP address and port number such that during the second pass for checking for
  a peer configured with insecure=port, it would end up treating every peer as
  if it had been configured that way.  These changes fix the logic in the peer
  IP and port comparison callback to handle insecure=port checking properly.
  
  This problem was introduced when SIP peers were converted to astobj2.  Many
  thanks to dvossel for noticing this while working on another peer matching
  issue.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@216434 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-04 13:56:09 +00:00
David Vossel
38bbe9653f Merged revisions 215955 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
  r215955 | dvossel | 2009-09-03 11:31:54 -0500 (Thu, 03 Sep 2009) | 6 lines
  
  Merge code associated with AST-2009-006
  
  (closes issue #12912)
  Reported by: rathaus
  Tested by: tilghman, russell, dvossel, dbrooks
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@216004 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-03 18:41:27 +00:00
Olle Johansson
8e59bc4a84 Merged revisions 215891 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
r215891 | oej | 2009-09-03 15:02:41 +0200 (Tor, 03 Sep 2009) | 10 lines

Add known internal IP address when autodomain=yes

(closes issue #14573)
Reported by: pj
Patches: 
      sip-internip-autodomain1.diff uploaded by mnicholson (license 96)
	modified by oej
Tested by: pj


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@215932 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-03 14:48:51 +00:00
Terry Wilson
debc2a0078 Merged revisions 215758 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
  r215758 | twilson | 2009-09-02 18:31:04 -0500 (Wed, 02 Sep 2009) | 25 lines
  
  Merged revisions 215682 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r215682 | twilson | 2009-09-02 16:41:22 -0500 (Wed, 02 Sep 2009) | 18 lines
    
    Re-send non-100 provisional responses to prevent cancellation
    
    From section 13.3.1.1 of RFC 3261:
    
       If the UAS desires an extended period of time to answer the INVITE,
       it will need to ask for an "extension" in order to prevent proxies
       from canceling the transaction. A proxy has the option of canceling
       a transaction when there is a gap of 3 minutes between responses in a
       transaction. To prevent cancellation, the UAS MUST send a non-100
       provisional response at every minute, to handle the possibility of
       lost provisional responses.
    
    (closes issue #11157)
    Reported by: rjain
    Tested by: twilson
    
    Review: https://reviewboard.asterisk.org/r/315/
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@215774 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-03 00:23:13 +00:00
David Vossel
58618f5e95 Merged revisions 215681 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
  r215681 | dvossel | 2009-09-02 16:39:31 -0500 (Wed, 02 Sep 2009) | 10 lines
  
  port string to int conversion using sscanf
  
  There are several instances where a port is parsed
  from a uri or some other source and converted to
  an int value using atoi(), if for some reason the
  port string is empty, then a standard port is used.
  This logic is used over and over, so I created a function
  to handle it in a safer way using sscanf().
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@215684 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-02 21:52:16 +00:00
Michiel van Baak
a5df0a703e Merged revisions 215665 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
  r215665 | mvanbaak | 2009-09-02 23:23:17 +0200 (Wed, 02 Sep 2009) | 5 lines
  
  add Parkinglot info to sip show peer <foo> and skinny show line <foo>
  
  If we had this from the start, debugging the 'parking not using configured parkinglot'
  bug would have been easier.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@215679 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-02 21:30:37 +00:00
David Vossel
fc10fe712b Merged revisions 215522 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
  r215522 | dvossel | 2009-09-02 12:26:40 -0500 (Wed, 02 Sep 2009) | 11 lines
  
  SIP uri parsing cleanup
  
  Now, the scheme passed to parse_uri can either be a
  single scheme, or a list of schemes ',' delimited.
  This gets rid of the whole problem of having to create
  two buffers and calling parse_uri twice to check for
  separate schemes.
  
  Review: https://reviewboard.asterisk.org/r/343/
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@215524 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-02 17:57:34 +00:00
Michiel van Baak
9cf5780234 Merged revisions 215479 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
  r215479 | mvanbaak | 2009-09-02 18:20:23 +0200 (Wed, 02 Sep 2009) | 3 lines
  
  like in chan_sip's sip_new skinny should copy the configured parkinglot from a line to the newly created channel.
  This makes callparking honor the configured parkinglot for skinny lines as well.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@215511 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-02 16:33:54 +00:00
Michiel van Baak
7286161ca0 Merged revisions 215462 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
  r215462 | mvanbaak | 2009-09-02 17:56:46 +0200 (Wed, 02 Sep 2009) | 12 lines
  
  Honor configured parkinglot when parking and retrieving parked calls
  
  Thank oej for pointing out the fact that sip_new did not copy parkinglot from the peer
  into the newly created channel.
  
  (closes issue #15538)
  Reported by: gracedman
  Patches:
        2009090100_sipnewparkinglot-161.diff.txt uploaded by mvanbaak (license 7)
  	  With mod by me to also fix callparking as well (this uploaded patch only fixed retrieving a parked call)
  Tested by: gracedman, mvanbaak
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@215464 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-09-02 16:01:20 +00:00
Tilghman Lesher
5b9cc171ab Merged revisions 214945 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
  r214945 | tilghman | 2009-08-31 11:18:33 -0500 (Mon, 31 Aug 2009) | 14 lines
  
  Merged revisions 214940 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r214940 | tilghman | 2009-08-31 11:16:52 -0500 (Mon, 31 Aug 2009) | 7 lines
    
    Also unlock the "other" channel, when returning, due to glare.
    (closes issue #15787)
     Reported by: tim_ringenbach
     Patches: 
           chan_local.diff uploaded by tim ringenbach (license 540)
     Tested by: tim_ringenbach
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@214958 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-08-31 16:22:02 +00:00
Tilghman Lesher
4b93cae37f Merged revisions 214199 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
  r214199 | tilghman | 2009-08-26 11:53:03 -0500 (Wed, 26 Aug 2009) | 6 lines
  
  Typo fix ("SIP/2.0 XXX" is 11 chars, not 10)
  (closes issue #15362)
   Reported by: klaus3000
   Patches: 
         chan_sip.c_logmessagefix_patch.txt uploaded by klaus3000 (license 65)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@214201 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-08-26 16:55:09 +00:00
David Vossel
8e4798e146 Merged revisions 213716 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
  r213716 | dvossel | 2009-08-21 17:22:11 -0500 (Fri, 21 Aug 2009) | 10 lines
  
  Register request line contains wrong address when user domain and register host differ
  
  (closes issue #15539)
  Reported by: Nick_Lewis
  Patches:
        chan_sip.c-registraraddr.patch uploaded by Nick (license 657)
        register_domain_fix_1.6.2 uploaded by dvossel (license 671)
  Tested by: Nick_Lewis, dvossel
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@213724 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-08-21 22:24:48 +00:00
Tilghman Lesher
8be21262e9 Merged revisions 213093 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
  r213093 | tilghman | 2009-08-19 15:29:41 -0500 (Wed, 19 Aug 2009) | 7 lines
  
  If we have realtime caching enabled, 'sip reload' must purge users/peers, even if the config files haven't changed.
  (closes issue #12869)
   Reported by: bcnit
   Patches: 
         20090819__issue12869__2.diff.txt uploaded by tilghman (license 14)
   Tested by: lasko
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@213096 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-08-19 20:34:38 +00:00
Richard Mudgett
6999ab3338 Merged revisions 212758 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
  r212758 | rmudgett | 2009-08-18 11:29:47 -0500 (Tue, 18 Aug 2009) | 9 lines
  
  Merged revisions 212727 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r212727 | rmudgett | 2009-08-18 11:00:56 -0500 (Tue, 18 Aug 2009) | 1 line
    
    Removed some deadwood and added some doxygen comments.
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@212768 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-08-18 16:48:01 +00:00
Sean Bright
f13ed5160c Merged revisions 212581 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
  r212581 | seanbright | 2009-08-17 14:50:24 -0400 (Mon, 17 Aug 2009) | 5 lines
  
  Correct spelling of AGENTACCEPTDTMF in chan_agent.
  
  (closes issue #15668)
  Reported by: davidw
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@212583 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-08-17 18:55:32 +00:00
Jeff Peeler
f395f03ef6 Merged revisions 212506 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
  r212506 | jpeeler | 2009-08-17 11:50:45 -0500 (Mon, 17 Aug 2009) | 19 lines
  
  Merged revisions 212498 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r212498 | jpeeler | 2009-08-17 11:34:56 -0500 (Mon, 17 Aug 2009) | 12 lines
    
    Fix segfault when reloading chan_misdn.
    
    If more ports were specified than configured in misdn.conf a reload would crash
    asterisk. The problem was the unconfigured port was using data from the
    previously configured port. When the data for an unconfigured port was freed a
    crash would result from the double free.
    
    (closes issue #12113)
    Reported by: agupta
    Patches:
          bug12113.patch uploaded by jpeeler (license 325)
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@212508 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-08-17 16:52:12 +00:00
Richard Mudgett
cfd8debc3f Merged revisions 212431 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
  r212431 | rmudgett | 2009-08-17 10:42:51 -0500 (Mon, 17 Aug 2009) | 16 lines
  
  Merged revisions 212430 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  Fix uninitialized variable causing random MWI indications.
  
  (closes issue #15727)
  Reported by: doda
  Patches:
        dahdi_changes.patch uploaded by doda (license 853)
  
  ........
    r212430 | rmudgett | 2009-08-17 10:36:28 -0500 (Mon, 17 Aug 2009) | 1 line
    
    Fix uninitialized variable.
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@212433 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-08-17 15:50:31 +00:00
Kevin P. Fleming
b6370b2383 Merged revisions 212113 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
  r212113 | kpfleming | 2009-08-13 10:46:25 -0500 (Thu, 13 Aug 2009) | 3 lines
  
  Ensure that T38FaxVersion is put into outgoing SDP in the proper case.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@212115 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-08-13 15:47:26 +00:00
Joshua Colp
bedce86b42 Merged revisions 212067 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
  r212067 | file | 2009-08-13 10:51:04 -0300 (Thu, 13 Aug 2009) | 2 lines
  
  Check an actual populated variable when seeing if we need to do video or not.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@212069 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-08-13 13:54:42 +00:00
Matthew Nicholson
a26a8a80bd Merged revisions 211876 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
  r211876 | mnicholson | 2009-08-12 14:53:14 -0500 (Wed, 12 Aug 2009) | 11 lines
  
  Make asterisk handle 423 Interval Too Short messages better.
  
  This change uses separate values for the acceptable minimum expiry provided by the 423 error and the expiry value stored in the configuration file.  Previously, the value pulled from the configuration file would be overwritten.
  
  (closes issue #14366)
  Reported by: Nick_Lewis
  Patches:
        sip-expiry-fix1.diff uploaded by mnicholson (license 96)
        chan_sip.c-reqexpiry.patch uploaded by Nick (license 657)
  Tested by: mnicholson
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@211950 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-08-12 22:38:30 +00:00
Tilghman Lesher
07e59f290c AST-2009-005
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@211569 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-08-10 19:30:55 +00:00
Joshua Colp
cba1b6e411 Merged revisions 211347 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
  r211347 | file | 2009-08-10 11:07:44 -0300 (Mon, 10 Aug 2009) | 5 lines
  
  Fix retrieval of the port used for the video stream when adding SDP to a SIP message.
  
  (closes issue #15121)
  Reported by: jsmith
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@211349 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-08-10 14:12:18 +00:00
Joshua Colp
41af598912 Merged revisions 210817 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
  r210817 | file | 2009-08-06 14:47:04 -0300 (Thu, 06 Aug 2009) | 11 lines
  
  Accept additional T.38 reinvites after an initial one has been handled.
  
  Discussion of this subject has yielded that it is not actually acceptable to change
  T.38 parameters after the initial reinvite but declining is harsh and can cause the
  fax to fail when it may be possible to allow it to continue. This patch changes things
  so that additional T.38 reinvites are accepted but parameter changes ignored. This gives
  the fax a fighting chance.
  
  (closes issue #15610)
  Reported by: huangtx2009
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@210819 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-08-06 17:48:57 +00:00
Richard Mudgett
8794156fd3 Merged revisions 210640 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
  r210640 | rmudgett | 2009-08-05 14:40:03 -0500 (Wed, 05 Aug 2009) | 21 lines
  
  Merged revisions 210575 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r210575 | rmudgett | 2009-08-05 14:18:56 -0500 (Wed, 05 Aug 2009) | 14 lines
    
    Dialplan starts execution before the channel setup is complete.
    
    *  Issue 15655: For the case where dialing is complete for an incoming
    call, dahdi_new() was asked to start the PBX and then the code set more
    channel variables.  If the dialplan hungup before these channel variables
    got set, asterisk would likely crash.
    *  Fixed potential for overlap incoming call to erroneously set channel
    variables as global dialplan variables if the ast_channel structure failed
    to get allocated.
    *  Added missing set of CALLINGSUBADDR in the dialing is complete case.
    
    (closes issue #15655)
    Reported by: alecdavis
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@210681 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-08-05 20:28:07 +00:00
Kevin P. Fleming
13b95231de Merged revisions 209760-209761 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
  r209760 | kpfleming | 2009-07-31 20:03:07 -0500 (Fri, 31 Jul 2009) | 13 lines
  
  Merged revisions 209759 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r209759 | kpfleming | 2009-07-31 19:52:00 -0500 (Fri, 31 Jul 2009) | 7 lines
    
    Minor changes inspired by testing with latest GCC.
    
    The latest GCC (what will become 4.5.x) has a few new warnings, that in these
    cases found some either downright buggy code, or at least seriously poorly
    designed code that could be improved.
  ........
................
  r209761 | kpfleming | 2009-07-31 20:04:06 -0500 (Fri, 31 Jul 2009) | 1 line
  
  Revert accidental Makefile change.
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@209781 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-08-01 01:25:04 +00:00
David Brooks
058028d79b Merged revisions 209554 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
  r209554 | dbrooks | 2009-07-30 11:07:05 -0500 (Thu, 30 Jul 2009) | 6 lines
  
  Fixes numerous spelling errors. Patch submitted by alecdavis.
  
  (closes issue #15595)
  Reported by: alecdavis
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@209593 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-30 18:46:07 +00:00
Mark Michelson
2eea5e2553 Merged revisions 209516 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
  r209516 | mmichelson | 2009-07-30 09:38:21 -0500 (Thu, 30 Jul 2009) | 8 lines
  
  Fix a crash that can result if text codecs are allowed but textsupport is disabled.
  
  (closes issue #15596)
  Reported by: fabled
  Patches:
        sip-red.patch uploaded by fabled (license 448)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@209517 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-30 14:40:15 +00:00
David Brooks
029963b5c5 Merged revisions 209098 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
  r209098 | dbrooks | 2009-07-27 11:33:50 -0500 (Mon, 27 Jul 2009) | 6 lines
  
  Fixing typos. Replaces "recieved" with "received" and "initilize" with "initialize"
  
  (closes issue #15571)
  Reported by: alecdavis
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@209233 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-27 20:28:28 +00:00
Jeff Peeler
be1c607f5a Merged revisions 208924 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
  r208924 | jpeeler | 2009-07-26 20:20:37 -0500 (Sun, 26 Jul 2009) | 9 lines
  
  Merged revisions 208923 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r208923 | jpeeler | 2009-07-26 20:18:31 -0500 (Sun, 26 Jul 2009) | 2 lines
    
    Fix logic errors from 208746
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@208926 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-27 01:22:31 +00:00
Jeff Peeler
4a8ebd3dcb Merged revisions 208749 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
  r208749 | jpeeler | 2009-07-25 01:23:18 -0500 (Sat, 25 Jul 2009) | 13 lines
  
  Merged revisions 208746 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r208746 | jpeeler | 2009-07-25 01:19:50 -0500 (Sat, 25 Jul 2009) | 7 lines
    
    Fix compiling under dev-mode with gcc 4.4.0.
    
    Mostly trivial changes, but I did not know of any other way to fix the
    "dereferencing type-punned pointer will break strict-aliasing rules" error
    without creating a tmp variable in chan_skinny.
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@208754 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-25 06:25:30 +00:00
Mark Michelson
623e055a28 Merged revisions 208588 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
  r208588 | mmichelson | 2009-07-24 13:31:04 -0500 (Fri, 24 Jul 2009) | 16 lines
  
  Merged revisions 208587 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r208587 | mmichelson | 2009-07-24 13:26:50 -0500 (Fri, 24 Jul 2009) | 10 lines
    
    Only send a BYE when hanging up a channel that is up.
    
    For cases where Asterisk sends an INVITE and receives a non 2XX final
    response, Asterisk would follow the INVITE transaction by immediately
    sending a BYE, which was unnecessary.
    
    (closes issue #14575)
    Reported by: chris-mac
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@208590 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-24 18:32:25 +00:00
Kevin P. Fleming
72c88bd434 Merged revisions 208548 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
  r208548 | kpfleming | 2009-07-24 10:02:53 -0500 (Fri, 24 Jul 2009) | 8 lines
  
  Resolve a T.38 negotiation issue left over from the udptl-updates merge.
  
  The udptl-updates branch that was merged yesterday failed to properly send back
  T.38 SDP responses with the correct error correction mode, if the incoming SDP
  from the other end caused us to change error correction modes. This patch
  corrects that situation.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@208550 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-24 15:05:40 +00:00
Kevin P. Fleming
f4d55039dc Merged revisions 208464 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
  r208464 | kpfleming | 2009-07-23 16:57:24 -0500 (Thu, 23 Jul 2009) | 46 lines
  
  Rework of T.38 negotiation and UDPTL API to address interoperability problems
  
  Over the past couple of months, a number of issues with Asterisk
  negotiating (and successfully completing) T.38 sessions with various
  endpoints have been found. This patch attempts to address many of
  them, primarily focused around ensuring that the endpoints'
  MaxDatagram size is honored, and in addition by ensuring that T.38
  session parameter negotiation is performed correctly according to the
  ITU T.38 Recommendation.
  
  The major changes here are:
  
  1) T.38 applications in Asterisk (app_fax) only generate/receive IFP
  packets, they do not ever work with UDPTL packets. As a result of
  this, they cannot be allowed to generate packets that would overflow
  the other endpoints' MaxDatagram size after the UDPTL stack adds any
  error correction information. With this patch, the application is told
  the maximum *IFP* size it can generate, based on a calculation using
  the far end MaxDatagram size and the active error correction mode on
  the T.38 session. The same is true for sending *our* MaxDatagram size
  to the remote endpoint; it is computed from the value that the
  application says it can accept (for a single IFP packet) combined with
  the active error correction mode.
  
  2) All treatment of T.38 session parameters as 'capabilities' in
  chan_sip has been removed; these parameters are not at all like
  audio/video stream capabilities. There are strict rules to follow for
  computing an answer to a T.38 offer, and chan_sip now follows those
  rules, using the desired parameters from the application (or channel)
  that wants to accept the T.38 negotiation.
  
  3) chan_sip now stores and forwards ast_control_t38_parameters
  structures for tracking 'our' and 'their' T.38 session parameters;
  this greatly simplifies negotiation, especially for pass-through
  calls.
  
  4) Since T.38 negotiation without specifying parameters or receiving
  the final negotiated parameters is not very worthwhile, the
  AST_CONTROL_T38 control frame has been removed. A note has been added
  to UPGRADE.txt about this removal, since any out-of-tree applications
  that use it will no longer function properly until they are upgraded
  to use AST_CONTROL_T38_PARAMETERS.
  
  Review: https://reviewboard.asterisk.org/r/310/
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@208484 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-23 22:21:57 +00:00
Mark Michelson
4642b45802 Merged revisions 208388 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
  r208388 | mmichelson | 2009-07-23 14:34:49 -0500 (Thu, 23 Jul 2009) | 24 lines
  
  Merged revisions 208386 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r208386 | mmichelson | 2009-07-23 14:24:21 -0500 (Thu, 23 Jul 2009) | 17 lines
    
    Fix a problem where a 491 response could be sent out of dialog.
    
    This generalizes the fix for issue 13849. The initial fix corrected the
    problem that Asterisk would reply with a 491 if a reinvite were received
    from an endpoint and we had not yet received an ACK from that endpoint
    for the initial INVITE it had sent us. This expansion also allows Asterisk
    to appropriately handle an INVITE with authorization credentials if Asterisk
    had not received an ACK from the previous transaction in which Asterisk had
    responded to an unauthorized INVITE with a 407.
    
    (closes issue #14239)
    Reported by: klaus3000
    Patches:
          14239.patch uploaded by mmichelson (license 60)
    Tested by: klaus3000
    	  
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@208390 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-23 19:35:57 +00:00
Jeff Peeler
d49abf44d6 Merged revisions 208383 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
  r208383 | jpeeler | 2009-07-23 14:21:50 -0500 (Thu, 23 Jul 2009) | 12 lines
  
  Merged revisions 208380 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r208380 | jpeeler | 2009-07-23 14:19:53 -0500 (Thu, 23 Jul 2009) | 6 lines
    
    Only set the priindication setting when not performing a reload
    
    (closes issue #14696)
    Reported by: fdecher
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@208385 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-23 19:24:06 +00:00
Mark Michelson
c8982d075e Merged revisions 208314 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
  r208314 | mmichelson | 2009-07-23 11:29:37 -0500 (Thu, 23 Jul 2009) | 9 lines
  
  Merged revisions 208312 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r208312 | mmichelson | 2009-07-23 11:29:18 -0500 (Thu, 23 Jul 2009) | 3 lines
    
    Remove inaccurate XXX comment.
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@208318 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-23 16:30:20 +00:00
Mark Michelson
b2cd6bc4f3 Merged revisions 208263 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
  r208263 | mmichelson | 2009-07-23 10:46:34 -0500 (Thu, 23 Jul 2009) | 15 lines
  
  Merged revisions 208262 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r208262 | mmichelson | 2009-07-23 10:43:07 -0500 (Thu, 23 Jul 2009) | 8 lines
    
    Properly handle 183 responses which do not contain an SDP.
    
    (closes issue #15442)
    Reported by: ffloimair
    Patches:
          15442.patch uploaded by mmichelson (license 60)
    Tested by: tkarl, ffloimair
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@208265 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-23 15:48:10 +00:00
Jeff Peeler
d494d95490 Merged revisions 207854 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
  r207854 | jpeeler | 2009-07-21 15:26:02 -0500 (Tue, 21 Jul 2009) | 16 lines
  
  Merged revisions 207827 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r207827 | jpeeler | 2009-07-21 15:16:55 -0500 (Tue, 21 Jul 2009) | 9 lines
    
    Wait for wink before dialing when using E&M wink signaling
    
    There was already code for other signaling types in dahdi_handle_event to
    handle dialing if a dial operation dial string was present. Simply add
    SIG_EMWINK to the list.
    
    (closes issue #14434)
    Reported by: araasch
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@207861 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-21 20:29:08 +00:00
Jeff Peeler
1d09cbe4bd Revert r207637, this approach could potentially block for an unacceptable
amount of time.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@207784 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-21 17:12:45 +00:00
Kevin P. Fleming
cffe0f2476 Merged revisions 207680 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
  r207680 | kpfleming | 2009-07-21 08:28:04 -0500 (Tue, 21 Jul 2009) | 18 lines
  
  Merged revisions 207647 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r207647 | kpfleming | 2009-07-21 08:04:44 -0500 (Tue, 21 Jul 2009) | 12 lines
    
    Ensure that user-provided CFLAGS and LDFLAGS are honored.
    
    This commit changes the build system so that user-provided flags (in ASTCFLAGS
    and ASTLDFLAGS) are supplied to the compiler/linker *after* all flags provided
    by the build system itself, so that the user can effectively override the
    build system's flags if desired. In addition, ASTCFLAGS and ASTLDFLAGS can now
    be provided *either* in the environment before running 'make', or as variable
    assignments on the 'make' command line. As a result, the use of COPTS and LDOPTS
    is no longer necessary, so they are no longer documented, but are still supported
    so as not to break existing build systems that supply them when building Asterisk.
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@207684 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-21 13:48:38 +00:00
Jeff Peeler
cebf0a71d8 Wait for wink before dialing when using E&M wink signaling
This patch adds a new dahdi_wait function to specifically wait for the wink
event. If the wink is not eventually received the channel is hung up. 

(closes issue #14434)
Reported by: araasch
Patches:
      emwinkmod uploaded by araasch (license 693)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@207637 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-21 04:45:19 +00:00
Mark Michelson
52bfea4da6 Merged revisions 207424 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
  r207424 | mmichelson | 2009-07-20 14:48:12 -0500 (Mon, 20 Jul 2009) | 39 lines
  
  Merged revisions 207423 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r207423 | mmichelson | 2009-07-20 14:39:59 -0500 (Mon, 20 Jul 2009) | 33 lines
    
    Answer video SDP offers properly when videosupport is not enabled.
    
    Copied from Review board:
    
    In issue 12434, the reporter describes a situation in which audio and video 
    is offered on the call, but because videosupport is disabled in sip.conf, 
    Asterisk gives no response at all to the video offer. According to RFC 3264, 
    all media offers should have a corresponding answer. For offers we do not 
    intend to actually reply to with meaningful values, we should still reply 
    with the port for the media stream set to 0.
    
    In this patch, we take note of what types of media have been offered and 
    save the information on the sip_pvt. The SDP in the response will take into 
    account whether media was offered. If we are not otherwise going to answer 
    a media offer, we will insert an appropriate m= line with the port set to 0.
    
    It is important to note that this patch is pretty much a bandage being 
    applied to a broken bone. The patch *only* helps for situations where video 
    is offered but videosupport is disabled and when udptl_pt is disabled but 
    T.38 is offered. Asterisk is not guaranteed to respond to every media offer. 
    Notable cases are when multiple streams of the same type are offered. 
    The 2 media stream limit is still present with this patch, too.
    
    In trunk and the 1.6.X branches, things will be a bit different since Asterisk 
    also supports text in SDPs as well.
    
    (closes issue #12434)
    Reported by: mnnojd
    
    Review: https://reviewboard.asterisk.org/r/311
    Review: https://reviewboard.asterisk.org/r/313
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@207426 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-20 20:02:03 +00:00
Richard Mudgett
6063455e79 Merged revisions 145293,158010 from
https://origsvn.digium.com/svn/asterisk/branches/1.4
to make merging easier.  These changes are already on trunk.

................
  r145293 | rmudgett | 2008-09-30 18:55:24 -0500 (Tue, 30 Sep 2008) | 54 lines

  channels/chan_misdn.c
  channels/misdn/isdn_lib.c
  *  Miscellaneous other fixes from trunk to make merging easier later.

  ........
  r145200 | rmudgett | 2008-09-30 16:00:54 -0500 (Tue, 30 Sep 2008) | 7 lines

  *  Miscellaneous formatting changes to make v1.4 and trunk
  more merge compatible in the mISDN area.

  channels/chan_misdn.c
  *  Eliminated redundant code in cb_events() EVENT_SETUP

  ........
  r144257 | crichter | 2008-09-24 03:42:55 -0500 (Wed, 24 Sep 2008) | 9 lines

  improved helptext of misdn_set_opt.
  ........
  r142181 | rmudgett | 2008-09-09 12:30:52 -0500 (Tue, 09 Sep 2008) | 1 line

  Cleaned up comment

  ........
  r138738 | rmudgett | 2008-08-18 16:07:28 -0500 (Mon, 18 Aug 2008) | 30 lines

  channels/chan_misdn.c
  *  Made bearer2str() use allowed_bearers_array[]
  *  Made use the causes.h defines instead of hardcoded numbers.
  *  Made use Asterisk presentation indicator values if either of the
  mISDN presentation or screen options are negative.
  *  Updated the misdn_set_opt application option descriptions.
  *  Renamed the awkward Caller ID presentation misdn_set_opt
  application option value not_screened to restricted.
  Deprecated the not_screened option value.

  channels/misdn/isdn_lib.c
  *  Made use the causes.h defines instead of hardcoded numbers.
  *  Fixed some spelling errors and typos.
  *  Added all defined facility code strings to fac2str().

  channels/misdn/isdn_lib.h
  *  Added doxygen comments to struct misdn_bchannel.

  channels/misdn/isdn_lib_intern.h
  *  Added doxygen comments to struct misdn_stack.

  channels/misdn_config.c
  configs/misdn.conf.sample
  *  Updated the mISDN presentation and screen parameter descriptions.

  doc/misdn.txt (doc/tex/misdn.tex)
  *  Updated the misdn_set_opt application option descriptions.
  *  Fixed some spelling errors and typos.
................
  r158010 | rmudgett | 2008-11-19 19:46:09 -0600 (Wed, 19 Nov 2008) | 9 lines

  Merged revision 157977 from
  https://origsvn.digium.com/svn/asterisk/team/group/issue8824

  ........
  Fixes JIRA ABE-1726

  The dial extension could be empty if you are using MISDN_KEYPAD
  to control ISDN provider features.
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@207287 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-18 02:09:13 +00:00
Jeff Peeler
933fb5bc3f Merged revisions 207156 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
  r207156 | jpeeler | 2009-07-17 14:37:38 -0500 (Fri, 17 Jul 2009) | 14 lines
  
  Merged revisions 207155 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r207155 | jpeeler | 2009-07-17 14:36:19 -0500 (Fri, 17 Jul 2009) | 7 lines
    
    Fix format specifier to print out an unsigned long long.
    
    Yep, it's even ifdefed out code. But it made it to the RR list...
    
    (closes issue #14726)
    Reported by: lmadsen
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@207158 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-17 19:39:24 +00:00
David Vossel
f1fdcb317f Merged revisions 207029 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
  r207029 | dvossel | 2009-07-17 12:51:44 -0500 (Fri, 17 Jul 2009) | 6 lines
  
  sip option flags handled incorrectly
  
  (closes issue #15376)
  Reported by: Takehiko Ooshima
  Tested by: dvossel, Takehiko_Ooshima
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@207031 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-17 17:53:03 +00:00
David Vossel
88dc0e47d7 Merged revisions 206939 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
  r206939 | dvossel | 2009-07-17 11:13:22 -0500 (Fri, 17 Jul 2009) | 20 lines
  
  Merged revisions 206938 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r206938 | dvossel | 2009-07-17 11:05:06 -0500 (Fri, 17 Jul 2009) | 14 lines
    
    SIP incorrect From: header information when callpres is prohib
    
    Some ITSP make use of the "Anonymous" display name to detect a
    requirement to withhold caller id across the PSTN. This does
    not work if the display name is "Unknown".
    
    (closes issue #14465)
    Reported by: Nick_Lewis
    Patches:
          chan_sip.c-callerpres.patch uploaded by Nick (license 657)
          chan_sip.c-callerpres_trunk.patch uploaded by dvossel (license 671)
    Tested by: Nick_Lewis, dvossel
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@206941 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-17 16:16:35 +00:00
David Vossel
19b741deb0 Merged revisions 206768 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
  r206768 | dvossel | 2009-07-15 17:04:13 -0500 (Wed, 15 Jul 2009) | 8 lines
  
  Session timer were not activated if Supported header field in INVITE had both "timer" and other options.
  
  (closes issue #15403)
  Reported by: makoto
  Patches:
        sip-session-timer.patch uploaded by makoto (license
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@206774 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-15 22:06:07 +00:00
Richard Mudgett
f8e567cb65 Merged revisions 206707 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
  r206707 | rmudgett | 2009-07-15 16:14:41 -0500 (Wed, 15 Jul 2009) | 33 lines
  
  Merged revisions 206706 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ................
    r206706 | rmudgett | 2009-07-15 15:44:55 -0500 (Wed, 15 Jul 2009) | 26 lines
    
    Merged revision 206700 from
    https://origsvn.digium.com/svn/asterisk/be/branches/C.2-...
    
    ..........
      Fixed chan_misdn crash because mISDNuser library is not thread safe.
    
      With Asterisk the mISDNuser library is driven by two threads concurrently:
      1. channels/misdn/isdn_lib.c::manager_event_handler()
      2. channels/misdn/isdn_lib.c::misdn_lib_isdn_event_catcher()
    
      Calls into the library are done concurrently and recursively from
      isdn_lib.c.
    
      Both threads can fiddle with the master/child layer3_proc_t lists.  One
      thread may traverse the list when the other interrupts it and then removes
      the list element which the first thread was currently handling.  This is
      exactly what caused the crash.  About 60 calls were needed to a Gigaset
      CX475 before it occurred once.
    
      This patch adds locking when calling into the mISDNuser library.
      This also fixes some cb_log calls with wrong port parameter.
    
      JIRA ABE-1913
          Patches: misdn-locking.patch (Modified with mostly cosmetic changes)
    ..........
  ................
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@206764 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-15 21:40:29 +00:00
David Vossel
44fa844576 Merged revisions 206702 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
  r206702 | dvossel | 2009-07-15 15:20:01 -0500 (Wed, 15 Jul 2009) | 10 lines
  
  callerid(num) is wrong when username is missing 
  
  A domain only sip uri <sip:123.123.123.123> would return
  123.123.123.123 as callid num.  Now, if the username is
  missing from a uri, the callerid num field is left empty.
  
  (closes issue #15476)
  Reported by: viraptor
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@206704 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-15 20:21:05 +00:00
Richard Mudgett
d4f6b326fa Merged revisions 206489 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
  r206489 | rmudgett | 2009-07-14 12:01:48 -0500 (Tue, 14 Jul 2009) | 35 lines
  
  Merged revisions 206487 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r206487 | rmudgett | 2009-07-14 11:44:47 -0500 (Tue, 14 Jul 2009) | 28 lines
    
    Fixes several call transfer issues with chan_misdn.
    
    *  issue #14355 - Crash if attempt to transfer a call to an application.
    Masquerade the other pair of the four asterisk channels involved in the
    two calls.  The held call already must be a bridged call (not an
    applicaton) or it would have been rejected.
    
    *  issue #14692 - Held calls are not automatically cleared after transfer.
    Allow the core to initate disconnect of held calls to the ISDN port.  This
    also fixes a similar case where the party on hold hangs up before being
    transferred or taken off hold.
    
    *  JIRA ABE-1903 - Orphaned held calls left in music-on-hold.
    Do not simply block passing the hangup event on held calls to asterisk
    core.
    
    *  Fixed to allow held calls to be transferred to ringing calls.
    Previously, held calls could only be transferred to connected calls.
    *  Eliminated unused call states to simplify hangup code.
    *  Eliminated most uses of "holded" because it is not a word.
    
    (closes issue #14355)
    (closes issue #14692)
    Reported by: sodom
    Patches:
          misdn_xfer_v14_r205839.patch uploaded by rmudgett (license 664)
    Tested by: rmudgett
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@206558 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-07-14 18:32:20 +00:00