Commit Graph

66 Commits

Author SHA1 Message Date
Steve Murphy
164d8a5e61 In response to 10578, I just ran 1.4 thru valgrind; some of the config leakage I've already fixed, but it doesn't hurt to double check. I found and fixed leaks in res_jabber, cdr_tds, pbx_ael. Nothing major, tho.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89088 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-07 21:40:28 +00:00
Jason Parker
f43de2908a Make sure we free some allocated memory before returning.
Issue 11131, patch by eliel.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@87908 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-31 21:23:11 +00:00
Philippe Sultan
95e24c44c1 Presence packets from a client who's connected with our Jabber ID are
valid, therefore, those clients must be considered as buddies. The resource
string helps us make the distinction between clients.

Closes issue #10707, reported by yusufmotiwala.

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84902 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-07 16:15:39 +00:00
Philippe Sultan
c7e7a27bac Prevent Asterisk from crashing when receiving a presence packet
without resource from a buddy that is known to have a resource list.

Revert a change I previously made, where Asterisk could point to a
freed memory location.

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@84890 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-07 15:52:44 +00:00
Philippe Sultan
022b5c1696 According to both RFC 3920 - section 9.1.2 - and Google's XMPP server
complaint, if set, the 'from' attribute must be set to the user's full
JID.

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81650 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-06 14:20:54 +00:00
Philippe Sultan
c6365f5138 A fix for two critical problems detected while working with Daniel
McKeehan in issue #10184. 

Upon priority change, the resource list is not NULL terminated when
moving an item to the end of the list. This makes Asterisk endlessy
loop whenever it needs to read the list. Jids with different resource and
priority values, like in Gmail's and GoogleTalk's jabber clients put
that problem in evidence.

Upon reception of a 'from' attribute with an empty resource string,
Asterisk crashes when trying to access the found->cap pointer if the
resource list for the given buddy is not empty. This situation is
perfectly valid and must be handled. The Gizmoproject's jabber client
put that problem in evidence.

Also added a few comments in the code as well as a handle for the
capabilities from Gmail's jabber client, which are stored in a caps:c tag
rather than the usual c tag.

Closes issue #10184.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79665 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-08-16 09:37:10 +00:00
Tilghman Lesher
34ee6b0df8 Fix 1.4 breakage
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@72554 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-29 04:43:15 +00:00
Olle Johansson
64b3683dbe Adding a few Todo's to res_jabber so we don't forget.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68030 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 10:00:17 +00:00
Olle Johansson
b857aed39e Ok, we found out that this is not about if you have any *active* clients using TLS, but
if you have initialized TLS at all during the lifetime of the module. So if you reload
to disable TLS, it won't help.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68028 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 09:55:13 +00:00
Olle Johansson
dd7f6f8e21 If you have a jabber client that uses TLS, refuse unload. Bad fix, but will prevent
crashes while we are trying to find a workaround.

Iksemel development seems to have stalled and we might have to stop using the 
TCP/TLS connections in that library and use our own, which would scale better
from a poll/select perspective I guess. It would also make it easier to migrate
to OpenSSL and stop Asterisk from depending on both OpenSSL and GnuTLS.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68027 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 09:42:26 +00:00
Olle Johansson
ff2943dd59 Issue #9738 - Make sure we can unload res_jabber. Patch by phsultan - thanks!
Due to a bug in the iksemel library, this will not work if you are using GTLS
in the connection. That's being investigated. If you figure out a way to handle
that without us having to patch iksemel, let us know in the bug report. Thanks.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67993 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 09:00:44 +00:00
Tilghman Lesher
c314f35ac2 Issue 9739 - Malformed jid causes a crash
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67021 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 15:50:16 +00:00
Kevin P. Fleming
5f9897ba56 handle the GNUTLS library properly in the configure script and build system
don't build in OSP support unless we have found and are allowed to use SSL support


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@66157 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-25 14:28:46 +00:00
Olle Johansson
6cfe6a550e Issue 8409 - phsultan - Fix "login" as component to jabber server.
...and, by accident, fix a bug in chan_sip for stopping a loop on retransmits
   of BYE requests.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@65836 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-24 14:38:30 +00:00
Jason Parker
9ad1e5d09c Fix a crash when checking version attribute in an incoming XML caps element.
Issue 9667, patch by phsultan.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@63099 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-04 20:03:49 +00:00
Olle Johansson
a1bdbc0289 Add final new line after JabberEvent
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@60984 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-09 18:02:17 +00:00
Russell Bryant
0cb0e410ba When building a response to a subscription, the "from" must be the full Jabber
ID.  This fixes some problems where jabber users are not able to add their
Asterisk account to their user list, since they are unable to get Asterisk
to approve their subscription.  (issue #8210, reported by caspy, and verified
by bradtem)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@59363 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-29 17:43:52 +00:00
Joshua Colp
a00f75604b Don't reference a potentially NULL pointer. (issue #9199 reported by klolik)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@57770 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-05 03:35:03 +00:00
Jason Parker
e0b88aba12 No need to cast nor free with strdupa (thanks file)
55555!


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@55555 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-20 16:53:45 +00:00
Olle Johansson
920f332399 - Not sending arguments to an application is not "out of memory"
- Making error messages a bit more clear


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@55483 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-19 21:12:55 +00:00
Tilghman Lesher
27475a306d Text fix for jabber reload command (reported by bkruse via IRC)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53294 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-07 05:24:31 +00:00
Kevin P. Fleming
444adcb477 reduce stack consumption for AMI and AMI/HTTP requests by nearly 20K in most cases
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49676 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-05 22:16:33 +00:00
Tilghman Lesher
56a1e60c54 More changes making the CLI more consistent with "category verb arguments" (continuation of issue 8236)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47053 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-02 23:49:13 +00:00
Russell Bryant
edb73def8e don't crash when an incoming message has no "from" (issue #8205, jmls)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@45999 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-23 17:07:45 +00:00
Joshua Colp
9ab793dcf8 Let's remember to unregister JabberStatus too (issue #8184 reported by jmls)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@45694 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-19 17:24:40 +00:00
Russell Bryant
fecc14cd0f change some debug output to use LOG_DEBUG instead of verbose output
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@44911 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-12 10:24:36 +00:00
Kevin P. Fleming
ff05bf15c8 update thread creation code a bit
reduce standard thread stack size slightly to allow the pthreads library to allocate the stack+data and not overflow a power-of-2 allocation in the kernel and waste memory/address space
add a new stack size for 'background' threads (those that don't handle PBX calls) when LOW_MEMORY is defined


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@44378 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-04 19:47:22 +00:00
Matt O'Gorman
592cbc0452 fix issue with dialing client without resource.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@44312 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-03 22:35:43 +00:00
Matt O'Gorman
5058b9e13f updated res_jabber for even better component support, soon will be jep-0100 compliant.
also removed chan_jingle and infromed info from jingle.txt, chan_gtalk still works and should be used in this version.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@44240 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-03 00:01:34 +00:00
Matt O'Gorman
ff11e64e67 updates for better compontent support
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@43466 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-21 23:50:56 +00:00
Matt O'Gorman
02868b1723 thats odd, but just in case it happens again i want to see it.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43305 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-20 00:39:44 +00:00
Matt O'Gorman
f6f7e134be fixed timeout issue as well as some other minor issues
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43303 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-19 23:57:04 +00:00
Kevin P. Fleming
fcb999c01c merge qwell's CLI verbification work
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@43212 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-18 19:54:18 +00:00
Russell Bryant
cf5a226c4b remove leading space in Packet manager event header
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41849 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 15:04:26 +00:00
Matt O'Gorman
05a695af72 everything that loads a config that needs a config file to run
now reports AST_MODULE_LOAD_DECLINE when loading if config file
is not there, also fixed an error in res_config_pgsql where it 
had a non static function when it should.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@41633 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-31 21:00:20 +00:00
Kevin P. Fleming
0a27d8bfe5 merge new_loader_completion branch, including (at least):
- restructured build tree and makefiles to eliminate recursion problems
  - support for embedded modules
  - support for static builds
  - simpler cross-compilation support
  - simpler module/loader interface (no exported symbols)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@40722 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-21 02:11:39 +00:00
Matt O'Gorman
1ef09ebfed some code clean up and catch for a act_hook being called
without a packet.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@39351 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-08 17:07:41 +00:00
Matt O'Gorman
33f0232f07 This patch allows for a user to send messages and
monitor a jabber connection over manager.
patches from 7673 and 7666 with minor changes.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@39248 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-07 22:03:50 +00:00
Matt O'Gorman
3f115f8c31 Many many code cleanup changes given to me by Oej
Thanks, sorry I didn't put this in forever ago.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@39229 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-07 21:15:28 +00:00
Russell Bryant
a0f151db99 eliminate a pointer signedness warning
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37289 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-07 07:00:28 +00:00
Matt O'Gorman
5c30f76ba3 solves issue with bug 7468. but with a patch that works
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@37087 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-05 20:28:54 +00:00
Tilghman Lesher
b43f5638ef Missing parenthesis
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36176 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-27 15:53:27 +00:00
Matt O'Gorman
ccc7f662d8 dont copy an id or a message if they dont exist.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@36175 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-27 14:07:24 +00:00
Russell Bryant
5288621ed4 handle ast_calloc failure and tweak some formatting to comply with coding
guidelines (issue #7341, casper)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@34667 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-18 21:45:48 +00:00
Matt O'Gorman
76fae31988 oops moved block without renaming a variable correctly.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33299 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-09 18:37:26 +00:00
Matt O'Gorman
124357f300 convert one of my linked lists to ast_linklist
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@33263 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-09 16:08:33 +00:00
Matt O'Gorman
1e530787f3 solves some bugs with memory allocation, and adds
a message stack.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32918 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-07 22:43:20 +00:00
Kevin P. Fleming
472c1ca282 simplify autoconfig include mechanism (make tholo happy he can use lint again :-)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32846 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-07 18:54:56 +00:00
Matt O'Gorman
6c0155e6cb fixes some issues with description loggin on presence
as well as some typos.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32675 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-06 19:51:26 +00:00
Matt O'Gorman
835c77ccfa fix a potential segfault
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@32674 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-06 19:18:44 +00:00