Commit Graph

30860 Commits

Author SHA1 Message Date
Alexander Traud
971378bbdb install_prereq: Update Debian/Ubuntu libraries.
ASTERISK-27555

Change-Id: Idc36e91db30c0163c560d04c5a82bca5d6ce92a8
2018-02-10 12:39:45 +01:00
Richard Mudgett
b2fcb30d38 cdr.c: Fix runtime leak of CDR records.
Need to remove all CDR's listed by a CDR object from the active_cdrs_all
container including the root/master record.

ASTERISK-27656

Change-Id: I48b4970663fea98baa262593d2204ef304aaf80e
2018-02-09 14:26:46 -06:00
Jenkins2
e132f22a2e Merge "chan_console: don't read and write at the same time" 2018-02-09 09:31:16 -06:00
Jenkins2
7484ed25ff Merge "app_confbridge: ConfbridgeList event has standard channel shapshot headers." 2018-02-07 06:42:20 -06:00
Jenkins2
7394556b46 Merge "app_confbridge: Add the Muted header to ConfbridgeJoin AMI event." 2018-02-07 06:04:05 -06:00
Jenkins2
2de2a1001a Merge "endpoint identifiers: Some code cleanup." 2018-02-06 05:40:14 -06:00
Jenkins2
9255048d9e Merge "res_pjsip/config_domain_aliases.c: Add check for missing domain." 2018-02-05 16:11:20 -06:00
Richard Mudgett
67cd90f10d app_confbridge: ConfbridgeList event has standard channel shapshot headers.
* Made the AMI ConfbridgeList action's ConfbridgeList events output all
the standard channel snapshot headers instead of a few hand-coded channel
snapshot headers.  The benefit is that the CallerIDName gets disruptive
characters like CR, LF, Tab, and a few others escaped.  However, an empty
CallerIDName is now output as "<unknown>" instead of "<no name>".

ASTERISK-27651

Change-Id: Iaf7d54a9d40194c2db060bc9b4979fab6720d977
2018-02-05 13:47:30 -06:00
Richard Mudgett
f4b161440b app_confbridge: Add the Muted header to ConfbridgeJoin AMI event.
ASTERISK-27651

Change-Id: Idef2ca54d242d1b894efd3fc7b360bc6fd5bdc34
2018-02-05 13:47:30 -06:00
Jenkins2
0a784a91a3 Merge "res_sorcery_realtime.c: Fix ref leak if object failed to apply." 2018-02-05 13:05:40 -06:00
Jenkins2
2d90b1efd9 Merge "manager.c: Fixed "(null):" header in AMI AsyncAGIEnd event" 2018-02-05 12:23:19 -06:00
Jenkins2
b392c1013f Merge "res_pjsip.c: Fix documentation typos." 2018-02-03 10:52:58 -06:00
Jenkins2
5c524e3287 Merge "manager_channels.c: Reordered ast_manager_build_channel_state_string_prefix()" 2018-02-03 10:26:55 -06:00
Jenkins2
43add42567 Merge "res_pjsip_mwi.c: Fix null pointer crash" 2018-02-03 10:06:32 -06:00
Jenkins2
df948d1a09 Merge "manager.c: Fix potential memory leak and corruption." 2018-02-03 09:41:42 -06:00
Oron Peled
5b8fea93d1 chan_console: don't read and write at the same time
It seems that the ALSA backend of PortAudio doesn't know how to both
read and write at the same time by adding a per-device mutex.

FIXME: currently only a draft version. Need to either auto-detect
we work with the ALSA backend or add an extra configuration option
to use this mutex.

ASTERISK-27426 #close

Change-Id: I635eacee45f5413faa18f5a3b606af03b926dacb
2018-02-03 09:41:07 -05:00
Richard Mudgett
1017db107c endpoint identifiers: Some code cleanup.
res_pjsip_endpoint_identifier_user.c:
* Fix copy/paste error in find_endpoint().  We were using a constant
"anonymous" string instead of the passed in endpoint_name when checking
the transport domain for an endpoint match.
* Eliminate RAII_VAR in find_endpoint().
* Remove always true check in find_transport_state_in_use().
* Remove useless CMD_STOP in find_transport_state_in_use().

res_pjsip_endpoint_identifier_anonymous.c:
* Eliminate RAII_VAR in anonymous_identify().
* Remove always true check in find_transport_state_in_use().
* Remove useless CMD_STOP in find_transport_state_in_use().

Change-Id: I86924c31db5bd225ca0c1219c761b668c6f91189
2018-02-02 18:03:06 -06:00
Richard Mudgett
b71e469d68 res_pjsip/config_domain_aliases.c: Add check for missing domain.
What is the point of defining an alias and not saying what is being
aliased?

Change-Id: I98a892016ed61dcf5efeb6619fd748925103f0be
2018-02-02 17:55:14 -06:00
Richard Mudgett
0960de71ae res_pjsip.c: Fix documentation typos.
Change-Id: I82ae0b92bfa2ece84a5c684efd9eefdc83ebd068
2018-02-02 17:48:28 -06:00
Richard Mudgett
bef49d90c1 res_sorcery_realtime.c: Fix ref leak if object failed to apply.
Change-Id: I3c7106ff77009754725cee790eadf5da44154ab6
2018-02-02 17:46:39 -06:00
Richard Mudgett
4142eacfef Merge "appdocsxml.xslt: Add Language to channel snapshot transformation" 2018-02-02 10:26:15 -06:00
Joshua Colp
dd459da428 Merge "bridge_softmix.c: Report not talking immediately when muted." 2018-02-02 06:22:59 -06:00
Sungtae Kim
7e32adf044 manager.c: Fixed "(null):" header in AMI AsyncAGIEnd event
* Changed to create ami_event string only when the given blob is not
json_null().
* Fixed bad expression.

ASTERISK-27621

Change-Id: Ice58c16361f9d9e8648261c9ed5d6c8245fb0d8f
2018-02-01 17:24:14 -06:00
Joshua Elson
73f92c2c52 res_pjsip_mwi.c: Fix null pointer crash
ASTERISK-27652 #close

Change-Id: I78a0d38bfd8d0d82830f3d53da04872d6b67284d
2018-02-01 15:33:23 -06:00
Sean Bright
fc98843d4b appdocsxml.xslt: Add Language to channel snapshot transformation
Change-Id: I8f494b0c895a69b8bc94656d0c6ceebecb0394d8
2018-02-01 15:03:03 -06:00
Richard Mudgett
3419a048b9 manager.c: Fix potential memory leak and corruption.
ast_str_append_event_header() could potentially leak and corrupt memory if
the ast_str needed to expand to add the AMI event header.

* Fixed to return error if the ast_str_append() failed.

Change-Id: I92f36b855540743b208d76e274152ee2d758176d
2018-02-01 13:51:27 -06:00
Richard Mudgett
bcfe172f8d manager_channels.c: Reordered ast_manager_build_channel_state_string_prefix()
* Made not allocate memory if the channel snapshot is an internal channel.

* Free memory earlier when no longer needed.

Change-Id: Ia06e0c065f1bd095781aa3f4a626d58fa4d28b38
2018-02-01 12:28:32 -06:00
Jenkins2
f041bc7863 Merge "app_confbridge: Update dsp_silence_threshold and dsp_talking_threshold docs." 2018-02-01 11:36:00 -06:00
George Joseph
b148453708 Merge "res_pjsip_pubsub: Prune subs with reliable transports at startup" 2018-02-01 11:26:49 -06:00
Jenkins2
b9efe5adf0 Merge "res_pjsip_registrar_expire: Delete empty module." 2018-02-01 10:41:20 -06:00
Jenkins2
d592adf623 Merge "BuildSystem: Raise autoconf version requirement to 2.60a." 2018-02-01 10:30:21 -06:00
Jenkins2
a3e72c308b Merge "res_pjsip_session: Prevent crash during shutdown." 2018-01-31 17:11:57 -06:00
Jenkins2
7a6db221ab Merge "core: Create ast_atomic macro's." 2018-01-31 17:06:56 -06:00
Jenkins2
9083901068 Merge "app_voicemail: Avoid always true when using pointer address." 2018-01-31 15:43:03 -06:00
Corey Farrell
4e4428ef3c res_pjsip_registrar_expire: Delete empty module.
Verified nothing in the testsuite lists this module as a dependency.

Change-Id: I90c7d52c7e15e85fde3389d5eaccb05b97848813
2018-01-31 15:10:35 -06:00
Richard Mudgett
1ccac0be0e bridge_softmix.c: Report not talking immediately when muted.
Currently in app_confbridge if someone mutes a channel while that channel
is talking, the talk detection code is suspended while the channel is
muted.  As far an an external observer is concerned, the muted channel's
talk status is still "talking" even though the channel is not contributing
audio to the conference bridge.  When the channel is later unmuted, it
takes the usual 'dsp_silence_threshold' option time to clear the talking
status even though the channel may have stopped talking while the channel
was muted.

* In bridge_softmix.c, clear the talking status and report talking stopped
if the channel was talking when the channel is muted.  When the channel is
unmuted and the channel is still talking then report the channel as
talking since it is contributing audio to the bridge again.

ASTERISK-27647

Change-Id: Ie4fdbc05a0bc7343c2972bab012e2567917b3d4e
2018-01-31 13:14:40 -06:00
Richard Mudgett
b9024197ab app_confbridge: Update dsp_silence_threshold and dsp_talking_threshold docs.
The dsp_talking_threshold does not represent time in milliseconds.  It
represents the average magnitude per sample in the audio packets.  This is
what the DSP uses to determine if a packet is silence or talking/noise.

Change-Id: If6f939c100eb92a5ac6c21236559018eeaf58443
2018-01-31 13:13:27 -06:00
Richard Mudgett
6c5e3226ec res_pjsip_registrar.c: Fix compiler error.
Need to include signal.h to define pthread_kill() and SIGURG.

Change-Id: I10ae3aa4bf8e7386ac29ade78c0f2caed8e674fa
2018-01-31 11:02:47 -06:00
Jenkins2
093484d137 Merge "loader: Use ast_cli_completion_add for 'module load' completion." 2018-01-31 07:48:21 -06:00
Jenkins2
eb9440edf7 Merge "res_pjsip_registrar_expire: Refactor into res_pjsip_register" 2018-01-31 07:28:24 -06:00
Jenkins2
8f6978d7b8 Merge "pbx_variables.c: Misc fixes in variable substitution." 2018-01-31 06:52:24 -06:00
Jenkins2
15d9fee96d Merge "install_prereq: Update RHEL/CentOS/Fedora libraries." 2018-01-31 06:42:59 -06:00
Corey Farrell
60701b3252 res_pjsip_session: Prevent crash during shutdown.
pjproject does not have a function to reverse pjsip_inv_usage_init.
This means we need to ignore any calls to the functions once shutdown is
final.

ASTERISK-27571 #close

Change-Id: Ia550fcba563e2328f03162d79fb185f16b7c9b9d
2018-01-30 23:19:22 -06:00
Corey Farrell
720dbb5745 core: Create ast_atomic macro's.
Create ast_atomic macro's to provide a consistent interface to the
common functionality of __atomic and __sync built-in functions.

ASTERISK-27619

Change-Id: Ieba3f81832a0e25c5725ea067e5d6f742d33eb5b
2018-01-30 12:50:38 -05:00
George Joseph
2b9aa6b5bb res_pjsip_pubsub: Prune subs with reliable transports at startup
In an earlier release, inbound registrations on a reliable transport
were pruned on Asterisk restart since the TCP connection would have
been torn down and become unusable when Asterisk stopped.  This same
process is now also applied to inbound subscriptions.

Also fixed issues in res_pjsip_registrar where it wasn't handling the
monitoring correctly when multiple registrations came in over the same
transport.

To accomplish this, the pjsip_transport_event feature needed to
be refactored to allow multiple monitors (multiple subcriptions or
registrations from the same endpoint) to exist on the same transport.
Since this changed the API, any external modules that may have used the
transport monitor feature (highly unlikey) will need to be changed.

ASTERISK-27612
Reported by: Ross Beer

Change-Id: Iee87cf4eb9b7b2b93d5739a72af52d6ca8fbbe36
2018-01-30 09:29:51 -06:00
Jenkins2
da4ddb1faa Merge "Build System: Require __sync or __atomic functions." 2018-01-30 06:56:08 -06:00
Jenkins2
0886e75991 Merge "Sample modules.conf: comment out example load statement." 2018-01-30 06:54:32 -06:00
Jenkins2
652dc0d38c Merge "Build System: Add support for __atomic built-in operators." 2018-01-30 06:54:00 -06:00
George Joseph
81db0aca0f res_pjsip_registrar_expire: Refactor into res_pjsip_register
res_pjsip_registrar_expire remains as an empty module for now.

Change-Id: Ib93698938bae548d2199cb542f3692d1a171239f
2018-01-29 12:49:53 -07:00
Corey Farrell
cf21e9fc97 Sample modules.conf: comment out example load statement.
The sample modules.conf explicitly loaded res_musiconhold.so.  This is
redundent as autoload=yes is already set.  It causes warnings if
res_musiconhold.so was not installed and results in an unexpected load
if the admin disables autoload without remembering to remove the
res_musiconhold load statement.

Also remove reference to unknown module pbx_gtkconsole.

Change-Id: Ib01888994d9f1364b14d3c9fb6ff96774a6e580a
2018-01-29 13:40:11 -05:00