Commit Graph

31985 Commits

Author SHA1 Message Date
Kevin Harwell
07c23cea37 Merge "res_pjsip_endpoint_identifier_ip.c: Added regex support to match_header" into 16 2018-08-03 13:26:19 -05:00
Alexander Traud
e9d41572b3 pjproject_bundled: Find shared libraries in root --with-ssl=PATH.
The script configure from Teluu expects shared libraries (.so) in a subfolder
called 'lib', when --with-xyz=PATH is specified. However for OpenSSL, the
default location is the root of the source folder = PATH. Furthermore, Asterisk
supports both, 'lib' and root. For consistency and because Asterisk is using
(only) OpenSSL in PJProject, it is enhanced to support both locations, just
like Asterisk.

ASTERISK-27995

Change-Id: I8eb916a88b6b8c22e29bb40bee8faaca6c73406f
2018-08-03 09:19:35 -05:00
Joshua Colp
1e837e13f5 res_pjsip_registrar: Improve performance on inbound handling.
This change removes a sorcery lookup for retrieving all
contacts at the end of the registration process by keeping
track of the contacts that are added/updated/deleted.

This ensures at the end of the process the container of
contacts we have is the current state.

Pool usage has also been reduced by allocating one for
usage throughout the handling of a REGISTER and resetting
it to a clean state. This ensures that in most cases
we allocate once and just reuse it.

ASTERISK-28001

Change-Id: I1a78b2d46f9a2045dbbff1a3fd6dba84b612b3cb
2018-08-03 04:09:08 -05:00
Joshua Colp
19494d9481 Merge "thirdparty/pjproject: fix deadlock in response retransmissions" into 16 2018-08-02 07:13:48 -05:00
Joshua Colp
4462990ce7 Merge "BuildSystem: Enable Jansson in Solaris 11." into 16 2018-08-02 06:16:32 -05:00
Torrey Searle
e818925a58 thirdparty/pjproject: fix deadlock in response retransmissions
The tdata containing the response can be shared by both the dialog
object and the tsx object.  In order to prevent the race condition
between the tsx retransmission and the dialog sending a response,
clone the tdata before modifying it for the dialog send response.

ASTERISK-27966 #close

Change-Id: Ic381004a3a212fe1d8eca0e707fe09dba4a6ab4e
2018-08-01 11:12:09 -05:00
Joshua Colp
927f68bb9d Merge "res_rtp_asterisk: In Developer Mode, do not require OpenSSL." into 16 2018-08-01 04:23:15 -05:00
Joshua Colp
8a8569cb81 Merge "res_pjsip_pubsub: Use ast_true for "prune_on_boot"." into 16 2018-07-31 16:11:16 -05:00
Richard Mudgett
20b53b5cee pjsip_wizard.conf.sample: Update remote_hosts description.
Remove the note that SRV records are not supported as that is no longer
true.

ASTERISK-27993

Change-Id: Id0dd6ef40e52702be9727a2b6122216cb00bb4ca
2018-07-31 11:29:15 -05:00
George Joseph
914b9e1934 CI: Add optional uninstall step before installing asterisk
Change-Id: I7dedf1e925eafc3a0adf01dd9dfbe44eb642aab7
2018-07-30 08:44:25 -05:00
Alexander Traud
93d1c34efe BuildSystem: Enable ncurses for menuselect in Solaris 11.
The check for the library ncurses should use not use the header <curses.h> but
<ncurses.h>, because on some platforms <curses.h> is not a drop-in replacement
for <ncurses.h>: For example in Solaris, the symbol initscr is a typedef in
<curses.h> to a symbol which does not exist in the library ncurses (initscr32).
Simply use <ncurses.h> when you link to ncurses.

Furthermore in Solaris, the header <ncurses.h> is in a subdirectory
/usr/include/ncurses and not available via pkg-config.

ASTERISK-15331
ASTERISK-14935
ASTERISK-12382
ASTERISK-9107

Change-Id: Ife367776b0ccf17d3fefed868245376bfb93745d
2018-07-29 03:21:19 -05:00
Joshua Colp
ee9794d741 res_pjsip_pubsub: Use ast_true for "prune_on_boot".
Change-Id: Iedec4e7390b3e821987681da24d0298632b9873d
2018-07-28 08:01:10 -05:00
Alexander Traud
c10b3ccd5f BuildSystem: Enable Jansson in Solaris 11.
In Solaris, the header <jansson.h> is in /usr/include/jansson. To find
Jansson even in such a subdirectory, the tool pkg-config is queried via
AST_PKG_CONFIG_CHECK. For those platforms, which do not list Jansson via
pkg-config, the previous check remains and is executed thereafter.

Because the check for the NetBSD Editline library uses the tool pkg-config
the code of PKG_PROG_PKG_CONFIG must be used. Because that check happens
earlier than Jansson, it must be placed in front of that.

ASTERISK-27991

Change-Id: I69ea0f379f87a50049654b2487c76ee1c04fa53a
2018-07-28 07:48:16 -05:00
Richard Mudgett
32ce8e5cf3 res_pjsip_endpoint_identifier_ip.c: Added regex support to match_header
This patch adds regular expression support to make the identify section's
match_header option more useful when attempting to match complex headers
like the 'To' or 'From' headers.  The 'From' header has variable
components such as the tag parameter that you cannot predict.  To specify
a regular expression put slashes around the regular expression in place of
the header value.

[identify-alice]
type=identify
endpoint=alice
match_header=From: /<sip:alice@127\\.0\\.0\\.1>/

* Added regex support to match_header so you could match a 'To' header
among other complex headers.

Fixed reported crashes when trying to match special headers like 'Contact'.
The identify section's match_header method used code that assumed you were
matching a generic header.  Any other type of header could cause a crash
if the header structure variant did not match the generic header enough.

* Made use code that will work for any header type instead of code
specific to generic headers.

Other fixes while in the area:

* Made check all headers of the requested name.
* Added some more sanity checks to the configured identify matching
options when applying the configuration.

ASTERISK-27548

Change-Id: I27dfd4ff5e2259b906640e3c330681b76b4ed1f1
2018-07-27 10:58:30 -05:00
Joshua Colp
59f53514ce res_pjsip_pubsub: Treat "prune_on_boot" as a yes / no.
The alembic for the PJSIP subscription persistence table has the
"prune_on_boot" field as a boolean. While in Asterisk we are
tolerant of many different definitions of true and false in the
database we only accept "yes" and "no". This change makes the
field treated as a yes/no instead of an integer, thus storing
"yes" and "no" instead of "1" and "0".

Change-Id: Ic8b9211b36babefe78f70def6828a135a6ae7ab6
2018-07-27 10:47:17 -05:00
Alexander Traud
8da81a208f res_rtp_asterisk: In Developer Mode, do not require OpenSSL.
OpenSSL is an optional external library and should stay optional even when
Developer Mode is configured.

ASTERISK-27990

Change-Id: Ia68a4cd5474b26d45e0f43b04032ad598022853b
2018-07-27 08:49:28 -05:00
Joshua Colp
a31e877502 Merge "loader: Process dependencies for built-in modules." into 16 2018-07-27 06:04:34 -05:00
Joshua Colp
f5dbcf122f Merge "Build System: Create 'make install-configs' target." into 16 2018-07-27 05:51:36 -05:00
Joshua Colp
3ce7f3a441 Merge "devicestate: Don't create topic when change isn't cached." into 16 2018-07-27 05:37:35 -05:00
Joshua Colp
e449bc32de Merge "res_rtp_asterisk: Avoid merging command and regular T.140 text packets" into 16 2018-07-27 05:34:50 -05:00
George Joseph
e097dca4d7 CI: Fix placement of job summary statments
Change-Id: Iace19e718f4e8fb48eb7dc9f98af53b115cc45f3
2018-07-26 17:56:41 -06:00
Corey Farrell
e5de8a70f8 loader: Process dependencies for built-in modules.
With the new module loader it was missed that built-in modules never
parsed dependencies from mod->info into vectors of mod.  This caused
manager to be initialized before acl (named_acl).  If manager.conf
used any named ACL's they would not be found and result in no ACL being
applied to the AMI user.

In addition to the manager ACL fix this adds "extconfig" to all builtin
modules which support realtime configuration.  This only matters if one
of the builtin modules is configured with 'preload', depending on
"extconfig" will cause config.c to automatically be initialize during
the preload stage.

Change-Id: I482ed6bca6c1064b05bb538d7861cd7a4f02d9fc
2018-07-26 15:29:39 -04:00
neutrino88
d3809d61cb res_rtp_asterisk: Avoid merging command and regular T.140 text packets
When realtime text packets are to be sent, the text is accumulated in a
buffer and sent regularly by a timer.  It can happen that commands such as
a backspace, CR, or LF get merged with regular text.  This breaks some
UAs.

The proposed change:
* We test if the current packet contains a command.  If so we send the
buffer immediately.
* We test if the buffer contained a command.  If so we send the buffer
immediately.
* We accumulate the text (or the command) in the buffer.

ASTERISK-27970

Change-Id: Ifbe993311410fa855cb8aa4a12084db75f413462
2018-07-26 13:58:11 -05:00
George Joseph
798f049e82 CI: Add docker info to job summary
Change-Id: I45d52005a9b692ad303c11792f226ace1e449901
2018-07-26 10:35:41 -06:00
Corey Farrell
7578881b3d Build System: Create 'make install-configs' target.
This target requires specifying CONFIG_SRC=path_to_configs.  This can be
used to install custom configs for the Asterisk build while still
performing directory replacements on asterisk.conf.

Modify internal INSTALL_CONFIGS so first argument requires full path to
the config sources relative to Asterisk source root.

Change-Id: Idcd841df3c8d5bfe23d566bb9e2e448e9df4f8ab
2018-07-26 10:19:25 -05:00
Kevin Harwell
8ea13d62cd json.c: improve ast_json_to_ast_variables performance
When converting from a json object to an ast variables list the conversion
algorithm was doing a complete traversal of the entire variables list for
every item appended from the json structure.

This patch makes it so the list is no longer traversed for each new ast
variable being appended.

Change-Id: I8bf496a1fc449485150d6db36bfc0354934a3977
2018-07-25 15:37:08 -05:00
Joshua Colp
e5c0ac6a64 devicestate: Don't create topic when change isn't cached.
When publishing a device state the change can be marked as being
cachable or not. If it is not cached the change is just published
to all interested and not stored away for later query. This was not
fully taken into account when publishing in stasis. The act of
publishing would create a topic for the device even if it may be
ephemeral.

This change makes it so messages which are not cached won't create
a topic for the device. If a topic does already exist it will be
published to but otherwise the change will only be published to
the device state all topic.

ASTERISK-27591

Change-Id: I18da0e8cbb18e79602e731020c46ba4101e59f0a
2018-07-25 14:20:57 -05:00
George Joseph
4a51f2792e Merge "Build System: Silence build of bundled jansson." into 16 2018-07-25 13:59:43 -05:00
Joshua Colp
84b5245476 Merge "res_pjsip: Change log message from error to warning for valid use cases" into 16 2018-07-25 13:59:13 -05:00
Jenkins2
166aa49664 Merge "CI: Explicitly pass BRANCH_NAME to buildAsterisk and installAsterisk" into 16 2018-07-25 12:48:53 -05:00
Jenkins2
6e2ce299c3 Merge "CI: Add options to initialize and cleanup database to runTestsuite.sh" into 16 2018-07-25 12:48:19 -05:00
George Joseph
93997f9698 CI: Explicitly pass BRANCH_NAME to buildAsterisk and installAsterisk
Change-Id: I652f4a0ea5107c778e27a78bccb67b18b0c4e087
2018-07-25 09:21:19 -06:00
George Joseph
0baf660bde CI: Add options to initialize and cleanup database to runTestsuite.sh
Change-Id: I352333233bab5377723bf37d490ba84fc55bc853
2018-07-25 09:12:59 -06:00
Corey Farrell
74cbeabb97 CI: Do not mkdir 2.
Change-Id: Ib7377d26a6c98b38bad463f47c84f1875ac84eb7
2018-07-25 10:07:51 -04:00
Corey Farrell
adf3c569a2 Build System: Silence build of bundled jansson.
Change-Id: I7392c79c0173057f5378010bf1fe65e300e8fc56
2018-07-25 08:34:54 -04:00
George Joseph
e4b0f09bcc CI: RefDebug: Fix reference to testsuite URL
Change-Id: I0ee41d95a87f0d97b01f2757012b846bcfe6443d
2018-07-25 06:14:35 -06:00
Corey Farrell
5537048d60 Build System: Fix bundled jansson install.
Update the bundled jansson Makefile to do nothing during Asterisk
install, use a target that is not phony to initiate the jansson make and
install.

Change-Id: I7643cc3d39af9feba8fc0da676b646efc5f8b3bb
2018-07-24 15:28:04 -04:00
Jenkins2
18a074e540 Merge "CI: Use bundled jansson if needed." into 16 2018-07-24 10:51:24 -05:00
George Joseph
cecff1f7ab Merge "Enable bundling of jansson, require 2.11." into 16 2018-07-24 10:50:41 -05:00
Corey Farrell
9f3620a578 CI: Use bundled jansson if needed.
Use pkg-config to determine if jansson is at least 2.11, enabled bundled
version otherwise.

Change-Id: Ib555a8b72ff6f6925f9280ef035caa0b91ca4bd2
2018-07-24 10:47:43 -05:00
George Joseph
835489f76d Merge "res_pjsip: Update default keepalive interval to 90 seconds." into 16 2018-07-24 08:30:34 -05:00
Florian Floimair
1f46e2e91c res_pjsip: Change log message from error to warning for valid use cases
If a SIP MESSAGE is triggered for an endpoint that is currently not registered
- and therefore has no valid contact associated - an error message was logged.
Since this is a valid request in a valid use cases this is now changed to a
warning, as discussed with Matt Fredrickson on the asterisk-dev mailing list.

Change-Id: I55eb62d2712818a58c7532119dec288bd98cf0c0
2018-07-24 07:20:06 -05:00
Jenkins2
b9630a9591 Merge "CI: Add --privileged flag to docker options" into 16 2018-07-24 06:03:02 -05:00
Jenkins2
9913a4fcca Merge "CI: Set correct user:group when publishing docs" into 16 2018-07-24 06:02:59 -05:00
George Joseph
393428be7b Merge "build_tools/make_version: Get MAINLINE_BRANCH from .gitreview." into 16 2018-07-24 05:40:41 -05:00
George Joseph
8550fad21a CI: Add --privileged flag to docker options
Change-Id: If92d55f15306e55dd7091ac3c47b13ebbbb03488
2018-07-24 04:40:31 -06:00
George Joseph
f2580d037f CI: Set correct user:group when publishing docs
Change-Id: Ibabeb9ac730d9755cf54318d0da74771c939b86b
2018-07-24 04:32:03 -06:00
Richard Mudgett
35d06e46ae core: AST_DEVMODE no longer affects ABI.
Remove AST_DEVMODE from the AST_BUILDOPTS list and the AST_BUILDOPTS_SUM
calculation as it no longer affects API/ABI compatibility.

Change-Id: Id5bd6dfade173a53b3a49f715586b86e3fb24acb
2018-07-23 13:48:18 -05:00
Jenkins2
fb6af6dbd2 Merge "CI: Split --test-command argument." into 16 2018-07-23 13:45:21 -05:00
George Joseph
03b1078117 Merge "sched: Make ABI compatible between dev mode and non-dev mode." into 16 2018-07-23 13:32:24 -05:00