Commit Graph

6942 Commits

Author SHA1 Message Date
Russell Bryant
7c01bf15df Don't set the full command string until after verifying that there is not
another CLI command with the same command text registered.  This prevents
a crash if someone accidentally calls ast_cli_register()  on the same CLI
command data twice.  This also fixes a small bug where the helpers list
would get unlocked without being locked if building the full command failed.
(closes issue #10858, reported by jamesgolovich, patched by me)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@84169 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-01 14:55:10 +00:00
Joshua Colp
8de5a4857e Don't register the dnsmgr refresh CLI command twice.
(closes issue #10856)
Reported by: jamesgolovich
Patches:
      asterisk-dnsmgrclireg.diff.txt uploaded by jamesgolovich (license 176)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@84162 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-01 14:02:26 +00:00
Matthew Fredrickson
32c5558676 Let's use process time instead of wall clock time for show translation
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@84115 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-29 00:19:15 +00:00
Tilghman Lesher
8b2b13a750 Merged revisions 84078 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r84078 | tilghman | 2007-09-28 09:13:47 -0500 (Fri, 28 Sep 2007) | 2 lines

Correct pronunciations of numbers for .nl (Closes issue #10837)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@84079 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-28 14:22:58 +00:00
Tilghman Lesher
d3904a21c4 Merged revisions 84049 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r84049 | tilghman | 2007-09-28 00:30:22 -0500 (Fri, 28 Sep 2007) | 3 lines

Avoid a deadlock with ALL of the locks in the masquerade function, not just the
pairs of channels.  (Closes issue #10406)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@84050 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-28 05:37:16 +00:00
Dwayne M. Hubbard
bd5b6cea68 Merged revisions 84018 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r84018 | dhubbard | 2007-09-27 18:12:25 -0500 (Thu, 27 Sep 2007) | 1 line

if an Agent is redirected, the base channel should actually be redirected.  This was causing multiple issues, especially issue 7706 and BE-160
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@84019 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-27 23:18:09 +00:00
Tilghman Lesher
0efe82bf9e Merged revisions 83773 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r83773 | tilghman | 2007-09-25 09:13:25 -0500 (Tue, 25 Sep 2007) | 2 lines

jmls pointed out that unsetting the group and setting the group to the blank string aren't quite the same.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@83774 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-25 14:18:09 +00:00
Tilghman Lesher
ddc6f8100e Permit custom locations for astdb and the keys directory (though default to the current locations) (Closes issue #10267)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@83726 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-24 22:06:19 +00:00
Tilghman Lesher
7abaa82162 Merged revisions 83637 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r83637 | tilghman | 2007-09-24 10:17:06 -0500 (Mon, 24 Sep 2007) | 3 lines

Making change to group splitting, as discussed on the -dev list.  The main
effect of this will be to permit Set(GROUP([cat])=), i.e. unsetting a group.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@83654 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-24 16:40:12 +00:00
Tilghman Lesher
02c997c64c Add the MeetmeList and Reload manager commands, which supplement the need to have Command privilege. (closes issue #10736)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@83532 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-22 14:03:48 +00:00
Tilghman Lesher
48f56ba8b4 Fixes for FreeBSD... testing for every conceivable math function now
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@83517 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-22 02:07:53 +00:00
Russell Bryant
9f64905d4e Merged revisions 83432 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r83432 | russell | 2007-09-21 09:37:20 -0500 (Fri, 21 Sep 2007) | 4 lines

gcc 4.2 has a new set of warnings dealing with cosnt pointers.  This set of
changes gets all of Asterisk (minus chan_alsa for now) to compile with gcc 4.2.
(closes issue #10774, patch from qwell)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@83433 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-21 14:40:10 +00:00
Tilghman Lesher
78a94595f6 Check for the presence of trunc and round, and make the ISOC99 detection a little more sane (closes issue #10776)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@83431 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-21 14:25:51 +00:00
Jason Parker
857f785a40 More NEW_CLI conversions.
(issue #10724)
Patches:
      app_playback.c.patch uploaded by moy (license 222)
      app_minivm.c.patch uploaded by eliel (license 64)
      astmm.c.patch uploaded by eliel (license 64)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@83381 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-20 23:14:30 +00:00
Russell Bryant
5cbdfc9925 Merged revisions 83348 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r83348 | russell | 2007-09-20 16:16:48 -0500 (Thu, 20 Sep 2007) | 4 lines

When daemonizing, don't change working directory to "/".  It makes it not be
able to do a core dump when not running as uid=root.
(closes issue #10766, xrg)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@83349 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-20 21:17:39 +00:00
Russell Bryant
86e254caba trivial formatting change
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@83298 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-20 19:45:00 +00:00
Russell Bryant
06fd2e1a05 trivial formatting change
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@83297 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-20 19:42:33 +00:00
Russell Bryant
2d7b84b2cf minor spelling fixes in a comment
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@83296 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-20 19:32:18 +00:00
Russell Bryant
f8911d2bbc minor grammar fix
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@83295 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-20 19:22:10 +00:00
Russell Bryant
2fde4885db trivial formatting change
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@83293 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-20 19:11:31 +00:00
Russell Bryant
6aa1638d8a Don't start the event processing thread until after forking.
(reported by Simon on the -dev list, thanks!)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@83233 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-20 16:27:07 +00:00
Joshua Colp
6489076887 Fix memory leaks in pbx_dundi, cdr_pgsql, and the configuration file parser.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@83229 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-20 16:10:57 +00:00
Russell Bryant
fc1fdac8f2 Merged revisions 83121 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r83121 | russell | 2007-09-19 10:10:14 -0500 (Wed, 19 Sep 2007) | 4 lines

Fix up another potential race condition.  Do the loop decrementing use count
on events with the eventq protected from being changed.
(reported on IRC by Ivan)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@83126 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-19 15:11:12 +00:00
Joshua Colp
25597993d7 Extend manager show connected with additional information.
(closes issue #10757)
Reported by: outtolunc
Patches:
      manager.c.sessionstart.diff uploaded by outtolunc (license 237)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@83073 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-19 13:30:01 +00:00
Jason Parker
c7a9ec1691 (issue #10724)
Reported by: eliel
Patches:
      res_features.c.patch uploaded by eliel (license 64)
      res_agi.c.patch uploaded by seanbright (license 71)
      res_musiconhold.c.patch uploaded by seanbright (license 71)
      pbx.c.patch uploaded by moy (license 222)
      logger.c.patch uploaded by moy (license 222)
      frame.c.patch uploaded by moy (license 222)
      manager.c.patch uploaded by moy (license 222)
      http.c.patch uploaded by moy (license 222)
      dnsmgr.c.patch uploaded by moy (license 222)
      res_realtime.c.patch uploaded by eliel (license 64)
      res_odbc.c.patch uploaded by seanbright (license 71)
      res_jabber.c.patch uploaded by eliel (license 64)
      chan_local.c.patch uploaded by eliel (license 64)
      chan_agent.c.patch uploaded by eliel (license 64)
      chan_alsa.c.patch uploaded by eliel (license 64)
      chan_features.c.patch uploaded by eliel (license 64)
      chan_sip.c.patch uploaded by eliel (license 64)
      RollUp.1.patch (includes all of the above patches) uploaded by seanbright (license 71)

Convert many CLI commands to the NEW_CLI format.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@82930 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-18 22:43:45 +00:00
Russell Bryant
c3b4322469 Merged revisions 82867 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r82867 | russell | 2007-09-18 15:56:43 -0500 (Tue, 18 Sep 2007) | 10 lines

Fix a memory leak that can occur on systems under higher load.  The issue is
that when events are appended to the master event queue, they use the number
of active sessions as a use count so it will know when all active sessions
at the time the event happened have consumed it.  However, the handling of
the number of sessions was not properly synchronized, so the use count was
not always correct, causing an event to disappear early, or get stuck in
the event queue for forever.

(closes issue #9238, reported by bweschke, patch from Ivan, modified by me)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@82868 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-18 20:59:21 +00:00
Russell Bryant
96d9f820e9 Merged revisions 82676 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r82676 | russell | 2007-09-17 15:16:25 -0500 (Mon, 17 Sep 2007) | 4 lines

Put a memset in ast_localtime() instead of a couple places in app_voicemail
to prevent the problem everywhere instead of just a couple of places.
(related to issue #10746)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@82678 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-17 20:19:58 +00:00
Doug Bailey
410bdaf535 Fix memory leak introduced when POST support was added.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@82568 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-17 14:58:19 +00:00
Joshua Colp
abe84c029f Merged revisions 82514 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r82514 | file | 2007-09-16 23:00:59 -0300 (Sun, 16 Sep 2007) | 4 lines

(closes issue #10734)
Reported by: asgaroth
Instead of passing a NULL pointer into snprintf pass "". It makes Solaris much happier.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@82516 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-17 02:02:09 +00:00
Steve Murphy
6a98adc357 Merged revisions 82444 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r82444 | murf | 2007-09-14 15:19:27 -0600 (Fri, 14 Sep 2007) | 1 line

closes issue #10668; thanks to arkadia for his patch; had to leave out the bit about ending the previous cdr in the fork; it would destroy current implementations.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@82457 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-14 21:30:44 +00:00
Russell Bryant
37dbcf6422 Merged revisions 82339 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r82339 | russell | 2007-09-13 13:57:08 -0500 (Thu, 13 Sep 2007) | 1 line

resolve a warning when not building under dev mode
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@82341 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-13 19:16:24 +00:00
Russell Bryant
79d79ac840 Merged revisions 82337 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r82337 | russell | 2007-09-13 13:45:59 -0500 (Thu, 13 Sep 2007) | 4 lines

Only compile in tracking astobj2 statistics if dev-mode is enabled.  Also, when
dev mode is enabled, register the CLI command that can be used to run the astobj2
test and print out statistics.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@82338 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-13 18:52:35 +00:00
Tilghman Lesher
22436131f7 Merged revisions 82291 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r82291 | tilghman | 2007-09-12 16:28:33 -0500 (Wed, 12 Sep 2007) | 2 lines

Oops, wrong location for FreeBSD zone files

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@82292 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-12 21:32:24 +00:00
Tilghman Lesher
82cf384e03 Merged revisions 82285 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r82285 | tilghman | 2007-09-12 15:12:06 -0500 (Wed, 12 Sep 2007) | 4 lines

Working on issue #10531 exposed a rather nasty 64-bit issue on ast_mktime, so we
updated the localtime.c file from source.  Next we'll have to write ast_strptime
to match.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@82290 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-12 21:25:57 +00:00
Steve Murphy
95ee34a654 This fix closes issue #10642 -- it's not perfect, but should retain most blank lines in config files, via read/write cycles.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@82288 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-12 20:50:40 +00:00
Mark Michelson
3a6e79ad80 Fixes Solaris build warnings
(closes issue #10698, reported and patched by snuffy)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@82283 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-12 16:24:45 +00:00
Russell Bryant
7e19df05b9 Merged revisions 82280 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r82280 | russell | 2007-09-12 10:16:49 -0500 (Wed, 12 Sep 2007) | 4 lines

Clean up the output of "asterisk -h".  This tweaks the wording and wraps lines
at 80 characters.
(closes issue #10699, seanbright)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@82281 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-12 15:19:11 +00:00
Russell Bryant
2a3ed7b879 remove unused functions that made this file not build under dev mode
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@82270 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-11 22:38:53 +00:00
Steve Murphy
c88e216a14 This solves an unreported solaris compile problem (missing -lnsl -lsocket).
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@82268 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-11 22:37:20 +00:00
Steve Murphy
c6b6a67364 Merged revisions 82261 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r82261 | murf | 2007-09-11 14:36:15 -0600 (Tue, 11 Sep 2007) | 1 line

this change should fix issue # 10659 -- what I worry about is how many other bug reports it may generate. Hopefully, we can please the/a majority. Hopefully. We shall see. Calls not marked ANSWERED and with only one channel name will not be posted. This should eliminate the double CDR's.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@82262 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-11 20:49:21 +00:00
Joshua Colp
0dc7b3e8f8 (closes issue #10666)
Reported by: arkadia
Patches:
      cdr_lockorder.patch uploaded by arkadia (license 233)
Optimize CDR stuff a bit.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@82248 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-11 15:34:40 +00:00
Joshua Colp
e4c8ac7abd (closes issue #10695)
Reported by: junky
Patches:
      count_showconn.diff uploaded by junky (license 177)
Provide a count of connected users to manager.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@82232 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-11 13:15:37 +00:00
Joshua Colp
a7d3a24fa5 (closes issue #10692)
Reported by: snuffy
Patches:
      minivm.diff uploaded by snuffy (license 35)
Instead of using err (which is not available under Solaris) use fdprintf with stderr.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@82231 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-11 13:10:04 +00:00
Jason Parker
10f28b2d79 Add a counter to the 'database deltree' CLI command.
Note: this is slightly different than the initial patch, because I felt
 that using res <= 0 would be a change in behavior.

Closes issue #10687, patch by junky


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@82154 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-10 17:39:08 +00:00
Jason Parker
ccb6b0065d Add counter to 'database show' CLI command.
(also a minor whitespace change that I found along the way)

Closes issue #10683, patch by junky


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@82125 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-10 16:24:29 +00:00
Steve Murphy
6cc72a0e0d Changes applied from marta's team/marta/astobj2 branch to solve a race condition
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@82124 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-10 16:19:45 +00:00
Russell Bryant
9dba50322d Merged revisions 81997 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r81997 | russell | 2007-09-08 13:41:32 -0500 (Sat, 08 Sep 2007) | 2 lines

Fix a small memory leak.  ast_unregister_atexit() did not free the entry it removed.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81998 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-08 18:45:51 +00:00
Joshua Colp
a565584d05 Fix memory issue that crept up with Russell's testing. It is *not* proper to free the frame we get in ast_write.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81858 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-06 22:34:44 +00:00
Luigi Rizzo
8e62c6c4d0 various changes to the documentation, and redefinition of
ao2_hash_fn and ao2_callback_fn typedefs, in preparation
to more cleanup of the _search_flags

Please do not merge this change to 1.4 yet - there are no
functional changes anyways.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81712 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-06 15:43:49 +00:00
Russell Bryant
8bcfddc8ec Merged revisions 81599 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r81599 | russell | 2007-09-05 15:53:41 -0500 (Wed, 05 Sep 2007) | 11 lines

Fix an issue that can occur when you do an attended transfer to parking.  If
you complete the transfer before the announcement of the parking spot finishes,
then the channel being parked will hear the remainder of the announcement.
These changes make it so that will not happen anymore.

Basically, res_features sets a flag on the channel is playing the announcement
to so that the file streaming core knows that it needs to watch out for a
channel masquerade, and if it occurs, to abort the announcement.

(closes BE-182)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@81600 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-09-05 20:58:19 +00:00