Commit Graph

27524 Commits

Author SHA1 Message Date
George Joseph
dd5c063934 res_pjproject: Add module providing pjproject logging and utils
res_pjsip_log_forwarder has been renamed to res_pjproject
and enhanced as follows:

As a follow-on to the recent 'Add CLI "pjsip show buildopts"' patch,
a new ast_pjproject_get_buildopt function has been added.  It
allows the caller to get the value of one of the buildopts.

The initial use case is retrieving the runtime value of
PJ_MAX_HOSTNAME to insure we don't send a hostname greater
than pjproject can handle.  Since it can differ between
the version of pjproject that Asterisk was compiled against
and the version of pjproject that Asterisk is running against,
we can't use the PJ_MAX_HOSTNAME macro directly in Asterisk
source code.

Change-Id: Iab6e82fec3d7cf00c1cf6185c42be3e7569dee1e
2016-01-20 09:56:13 -07:00
Joshua Colp
1232dcbce0 Merge "funcs/func_cdr: Correctly report high precision values for duration and billsec" 2016-01-20 10:33:27 -06:00
Joshua Colp
367f2e73e3 Merge "pjsip_loging_refactor: Rename res_pjsip_log_forwarder to res_pjproject" 2016-01-20 10:32:48 -06:00
Matt Jordan
3b9cba4294 funcs/func_cdr: Correctly report high precision values for duration and billsec
When CDRs were refactored, func_cdr's ability to report high precision values
for duration and billsec (the 'f' option) was broken. This was due to func_cdr
incorrectly interpreting the duration/billsec values provided by the CDR engine
in milliseconds, as opposed to seconds. Since the CDR engine only provides
duration and billsec in seconds, and does not expose either attribute with
sufficient precision to merely pass back the underlying value, this patch fixes
the bug by re-calculating duration and billsec with microsecond precision based
on the start/answer/end times on the CDR.

ASTERISK-25179 #close

Change-Id: I8bc63822b496537a5bf80baf6102c06206bee841
2016-01-20 08:11:44 -06:00
Rodrigo Ramírez Norambuena
479cc99acd README: Update year in copyright
Change-Id: I56240f537fb3205672cdb2a74f0591ae7bb73dbc
2016-01-20 10:52:45 -03:00
Joshua Colp
9fa76ba215 test_threadpool: Wait for each task to complete and fix memory leak.
This change makes the thread_timeout_thrash unit test wait for
each task to complete. This fixes the problem where the test would
prematurely end when all threads were gone and a new one had to be
started to handle the last task. It also increases the thrasing as
it is now more likely for each task to encounter the above scenario.

This also fixes a memory leak where the data for each task was not
being freed.

ASTERISK-25611 #close

Change-Id: I5017d621a4dc911f509074c16229b86bff2fb3c6
2016-01-19 17:21:35 -06:00
Mark Michelson
ecfc3ed157 Merge "Refactor init_logger_chain locking." 2016-01-19 17:07:28 -06:00
Richard Mudgett
c9f7269b2e taskprocessor.c: Increase CLI "core ping taskprocessor" timeout.
Change-Id: I4892d6acbb580d6c207d006341eaf5e0f8f2a029
2016-01-19 16:48:59 -06:00
Richard Mudgett
6e2a867716 taskprocessor.c: Fix some taskprocessor unrefs.
You have to call ast_taskprocessor_unref() outside of the taskprocessor
implementation code.  Taskprocessor use since v12 has become more
transient than just the singleton uses in earlier versions.

Change-Id: If7675299924c0cc65f2a43a85254e6f06f2d61bb
2016-01-19 16:48:14 -06:00
Richard Mudgett
a4dcbdf50f Fix alembic branches on master.
Change-Id: I64ed21fec50eb833641ca49d92184f6aaabd86e8
2016-01-19 14:16:17 -06:00
Corey Farrell
35a3e8cc7f Refactor init_logger_chain locking.
This removes logchannels locking from init_logger_chain, puts the
responsibility on the caller.  Adds locking around the one call that was
missing it.

ASTERISK-24833

Change-Id: I6cc42117338bf9575650a67bcb78ab1a33d7bad8
2016-01-19 14:21:25 -05:00
Rodrigo Ramírez Norambuena
378fed4900 app_queue: Fix preserved reason of pause when Asterisk is restared
When the Asterisk is restared is not preseved reason paused of members.
This patch fixed this cases, retain data on astdb and set when Asterisk
is started.

ASTERISK-25732 #close

Report by: Rodrigo Ramírez Norambuena

Change-Id: Id3fb744c579e006d27cda4a02334ac0e4bed9eb5
2016-01-19 10:14:17 -03:00
Joshua Colp
690ab5fba7 Merge "Remove *.gcna / *.gcno files from added module sources." 2016-01-18 19:24:28 -06:00
George Joseph
130aa1427e pjsip_loging_refactor: Rename res_pjsip_log_forwarder to res_pjproject
Change-Id: I5387821f29e5caa0cba0b7d62b0fc0d341e7e20b
2016-01-18 18:01:36 -07:00
Mark Michelson
48257ad36f Merge "Update version number in features.conf.sample" 2016-01-18 17:31:40 -06:00
Joshua Colp
2cdbd4d711 Merge "pjsip/alembic: Fix qualify_timeout column definition" 2016-01-18 05:49:45 -06:00
Joshua Colp
96763f48cf Merge "func_channel: Add help text for undocumented CHANNEL function arguments" 2016-01-17 13:48:32 -06:00
Joshua Colp
82938d0507 Merge "main/config: Clean config maps on shutdown." 2016-01-17 11:44:38 -06:00
Daniel Journo
eaf2b5052e Update version number in features.conf.sample
Update the version number in the comments from Asterisk 12 to Asterisk 12+

Change-Id: Ie692ac8cda3c993c3bf10f27f51a1cca3317ec7b
2016-01-16 20:02:43 +00:00
Daniel Journo
c60d6c0162 pjsip/alembic: Fix qualify_timeout column definition
Corrects the qualify_timeout column type from Integer to Decimal

ASTERISK-25686 #close
Reported-by: Marcelo Terres

Change-Id: I757d0e3c011ee9be6cd5abd48bc92441a405d3c8
2016-01-16 19:58:17 +00:00
Joshua Colp
34dbed9619 Merge "bridge_basic: don't play an attended transfer fail sound after target hangs up" 2016-01-16 08:29:58 -06:00
Joshua Colp
a19a513714 Merge "bridge_basic: don't cache xferfailsound during an attended transfer" 2016-01-16 08:29:17 -06:00
Joshua Colp
644a9d0e99 Merge "taskprocessor.c: Simplify ast_taskprocessor_get() return code." 2016-01-16 08:28:17 -06:00
Corey Farrell
480ccfcc97 main/config: Clean config maps on shutdown.
ASTERISK-25700 #close

Change-Id: I096da84f9c62c6095f68bcf98eac4b7c7868e808
2016-01-15 20:00:08 -06:00
Kevin Harwell
a5b38b604c bridge_basic: don't cache xferfailsound during an attended transfer
The xferfailsound was read from the channel at the beginning of the transfer,
and that value is "cached" for the duration of the transfer. Therefore, changing
the xferfailsound on the channel using the FEATURE() dialplan function does
nothing once the transfer is under way.

This makes it so the transfer code instead gets the xferfailsound configuration
options from the channel when it is actually going to be used.

This patch also fixes a potential memory leak of the props object as well as
making sure the condition variable gets initialized before being destroyed.

ASTERISK-25696 #close

Change-Id: Ic726b0f54ef588bd9c9c67f4b0e4d787934f85e4
2016-01-15 17:51:18 -06:00
Richard Mudgett
d36c4d0b01 taskprocessor.c: Simplify ast_taskprocessor_get() return code.
Change-Id: Id5bd18ef1f60ef8be453e677e98478298358a9d1
2016-01-15 12:44:33 -06:00
Richard Mudgett
0a878020dc astmm.c: Add more stats to CLI "memory show" commands.
* Add freed regions totals to allocations and summary.

* Add totals for all allocations and not just the selected allocations.

Change-Id: I61d5a5112617b0733097f2545a3006a344b4032a
2016-01-14 19:57:29 -06:00
Kevin Harwell
84b30c5e18 bridge_basic: don't play an attended transfer fail sound after target hangs up
If the attended transfer destination answers (picks call up or goes to
voicemail) and then hangs up on the transferer then transferer hears the
fail sound.

This patch makes it so the fail sound is not played when the transfer
destination/target hangs up after answering.

ASTERISK-25697 #close

Change-Id: I97f142fe4fc2805d1a24b7c16143069dc03d9ded
2016-01-14 16:06:03 -06:00
Corey Farrell
c7caee6c4b Remove *.gcna / *.gcno files from added module sources.
Asterisk uses a Makefile macro to associate additional sources with a
module.  This macro is responsible for creating clean targets but
previously left behind *.gcna and *.gcno files.

ASTERISK-25683 #close
Reported by yaron nahum

Change-Id: Idc0823fe80a25c42cefae901fde875e9fc38d8ea
2016-01-14 15:38:51 -05:00
Rusty Newton
68cad96ffd func_channel: Add help text for undocumented CHANNEL function arguments
Adding help text documentation for:
* hangupsource
* appname
* appdata
* exten
* context
* channame
* uniqueid
* linkedid

ASTERISK-24097 #close
Reported by: Steven T. Wheeler
Tested by: Rusty Newton

Change-Id: Ib94b00568b0433987df87d5b67ea529b5905754d
2016-01-14 09:26:15 -06:00
Joshua Colp
c3d458d226 Merge "pjsip: Add option global/regcontext" 2016-01-14 06:32:12 -06:00
Daniel Journo
8182146e85 pjsip: Add option global/regcontext
Added new global option (regcontext) to pjsip. When set, Asterisk will
dynamically create and destroy a NoOp priority 1 extension
for a given endpoint who registers or unregisters with us.

ASTERISK-25670 #close
Reported-by: Daniel Journo

Change-Id: Ib1530c5b45340625805c057f8ff1fb240a43ea62
2016-01-13 11:42:20 -06:00
Joshua Colp
022423b98b app: Queue hangup if channel is hung up during sub or macro execution.
This issue was exposed when executing a connected line subroutine.
When connected or redirected subroutines or macros are executed it is
expected that the underlying applications and logic invoked are fast
and do not consume frames. In practice this constraint is not enforced
and if not adhered to will cause channels to continue when they shouldn't.
This is because each caller of the connected or redirected logic does not
check whether the channel has been hung up on return. As a result the
the hung up channel continues.

This change makes it so when the API to execute a subroutine or
macro is invoked the channel is checked to determine if it has hung up.
If it has then a hangup is queued again so the caller will see it
and stop.

ASTERISK-25690 #close

Change-Id: I1f9a8ceb1487df0389f0d346ce0f6dcbcaf476ea
2016-01-13 11:01:18 -06:00
Mark Michelson
ef57080b27 Merge "res_pjsip_log_forwarder.c: Add CLI "pjsip show buildopts"." 2016-01-13 09:48:58 -06:00
Sean Bright
79a7321a47 res_musiconhold: Prevent multiple simultaneous reloads.
There are two ways in which the reload() function in res_musiconhold can be
called from the CLI:

  * module reload res_musiconhold.so
  * moh reload

In the former case, the module loader holds a lock that prevents multiple
concurrent calls, but in the latter there is no such protection.

This patch changes the 'moh reload' CLI command to invoke the module loader
directly, rather than call reload() explicitly.

ASTERISK-25687 #close

Change-Id: I408968b4c8932864411b7f9ad88cfdc7b9ba711c
2016-01-13 07:50:29 -06:00
Richard Mudgett
1fffe71f77 res_pjsip_log_forwarder.c: Add CLI "pjsip show buildopts".
PJPROJECT has a function available to dump the compile time
options used when building the library.

* Add CLI "pjsip show buildopts" command.

* Update contrib/scripts/autosupport to get pjproject information.

Change-Id: Id93a6a916d765b2a2e5a1aeb54caaf83206be748
2016-01-12 20:27:47 -06:00
Joshua Colp
9a13df1b3c Merge "pjsip_sdp_rtp: Add option endpoint/bind_rtp_to_media_address" 2016-01-12 19:45:28 -06:00
Joshua Colp
d8f8cf5462 Merge "res_pjsip: Create human friendly serializer names." 2016-01-12 13:59:49 -06:00
Joshua Colp
d9840023ce Merge "res_sorcery_realtime: Remove leading ^ requirement." 2016-01-12 13:59:27 -06:00
Joshua Colp
9e6ea2ba72 Merge topic 'update_taskprocessor_commands'
* changes:
  Sorcery: Create human friendly serializer names.
  Stasis: Create human friendly taskprocessor/serializer names.
  taskprocessor.c: New API for human friendly taskprocessor names.
  taskprocessor.c: Sort CLI "core show taskprocessors" output.
2016-01-12 13:25:49 -06:00
Joshua Colp
7e418b1ab5 Merge "taskprocessor.c: Fix CLI "core show taskprocessors" output format." 2016-01-12 13:18:58 -06:00
Joshua Colp
e89d2691e9 Merge topic 'update_taskprocessor_commands'
* changes:
  taskprocessor.c: Fix CLI "core show taskprocessors" unref.
  taskprocessor.c: Add CLI "core ping taskprocessor" missing unlock.
2016-01-12 13:18:35 -06:00
Joshua Colp
e57defa8dd Merge "ccss.c: Replace space in taskprocessor name." 2016-01-12 13:17:54 -06:00
Mark Michelson
01c5e2a07e res_sorcery_realtime: Remove leading ^ requirement.
res_sorcery_realtime's search-by-regex callback performed a check to
ensure that the passed-in regex began with a caret (^). If it did not,
then no results would be returned.

This callback only started to become used when "like" support was added
to PJSIP CLI commands. The CLI command for listing objects would pass an
empty regex ("") to the sorcery backend if no "like" statement was
present. For most sorcery backends, this resulted in returning all
objects. However, for realtime, this resulted in returning no objects.

This commit seeks to fix the regression by removing the requirement from
res_sorcery_realtime for the passed-in-regex to begin with a caret.

ASTERISK-25689 #close
Reported by Marcelo Terres

Change-Id: I22b4dc5d7f3f11bb29ac2e42ef94682e9bab3b20
2016-01-12 13:07:17 -06:00
Joshua Colp
1d5651bcea Merge "app_queue: Add member flag "in_call" to prevent reading wrong lastcall time" 2016-01-12 06:05:30 -06:00
George Joseph
a41aab477a pjsip_sdp_rtp: Add option endpoint/bind_rtp_to_media_address
On a system with multiple ip addresses in the same subnet, if a
transport is bound to a specific ip address and endpoint/media_address
 is set, the SIP/SDP will have the correct address in all fields but
the rtp stream MAY still originate from one of the other ip addresses,
most probably the "primary" ip address.  This happens because
 res_pjsip_sdp_rtp/create_rtp always calls ast_instance_new with
the "all" ip address (0.0.0.0 or ::).

The new option causes res_pjsip_sdp_rtp/create_rtp to call
ast_rtp_instance_new with the endpoint's media_address (if specified)
instead of the "all" address.  This causes the packets to originate from
the specified address.

ASTERISK-25632
ASTERISK-25637
Reported-by: Olivier Krief
Reported-by: Dan Journo

Change-Id: I3dfaa079e54ba7fb7c4fd1f5f7bd9509bbf8bd88
2016-01-11 18:41:31 -06:00
Mark Michelson
188438c53f Merge "Revert "pjsip_location: Delete contact_status object when contact is deleted"" 2016-01-11 17:43:39 -06:00
Joshua Colp
fb8bdcce01 Merge "pbx: Deadlock between contexts container and context_merge locks" 2016-01-11 17:37:19 -06:00
Joshua Colp
e106292a92 Merge "Alembic: Increase column size of PJSIP AOR "contact"." 2016-01-11 16:59:11 -06:00
Joshua Colp
8bd9e2dcc0 Merge "Alembic: Add PJSIP global keep_alive_interval." 2016-01-11 16:59:05 -06:00