Commit Graph

1624 Commits

Author SHA1 Message Date
Joshua Colp
c17a4c7f53 Make create_dirpath use our standard for return values. -1 is failure, 0 is success. (issue #9205 reported by ballares)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@57869 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-05 17:49:18 +00:00
Tilghman Lesher
12a38f8e56 Memory leak of a list, if call recording was abandoned
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@57648 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-03 06:36:55 +00:00
Joshua Colp
aa54a5f91b Change naughty warning message to provide useful information. If a write now fails on a channel in meetme it will tell you the channel name instead of spitting out the wrong error message.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@55956 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-21 20:32:16 +00:00
Russell Bryant
602c5bb8c3 Fix random crashes when using the MeetMe application. This patch converts list
handling to use the linked list macros and most importantly, implements
reference counting on the ast_conference objects.  The reference counting was
first backported from 1.4.  However, that code has some problems that caused
the reference count to never hit zero.  Those problems are fixed in this patch
and will be resolved in 1.4 and trunk next, with a different patch.

(issues #7647, #9073, #9106, BE-115). 


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@55750 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-21 00:19:14 +00:00
Russell Bryant
82bc576ea4 Convert a tab to spaces so that the documentation is printed out properly
aligned.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@55588 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-20 19:49:50 +00:00
Tilghman Lesher
fababa3b74 forcename and forcegreetings options should check to see if the recording already exists
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@55434 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-19 18:09:09 +00:00
Olle Johansson
179c829291 Documentation update (#9053, jsmith)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@55277 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-18 12:32:13 +00:00
Joshua Colp
975f117300 Answer the channel before recording privacy information. (issue #8926 reported by lmamane)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@55153 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-17 03:53:45 +00:00
Russell Bryant
c9c943e8e2 Revert the change I did in revisions 54955, 54969, and 54970, in 1.2, 1.4,
and trunk.  I decided that once a conference is created from meetme.conf,
it is acceptable behavior that the pin can not be changed until the
conference goes away.  I also added a note in meetme.conf to describe this
behavior.

We still have another issue in 1.4 and trunk where some conferences with no
users don't go away.  That is the real bug that needs to be addressed here.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@55005 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-16 22:48:22 +00:00
Russell Bryant
2802ea3eeb For conferences that are configured in meetme.conf, check the configuration
file every time someone joins the conference instead of only when the
conference is first created.  This is to ensure that changes to the pin
numbers in the config file are always honored.  (issue #9073)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@54955 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-16 20:56:58 +00:00
Joshua Colp
041061ca36 Use a separate variable to indicate execution should continue instead of the return value. (issue #8842 reported by pluto70)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@54622 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-15 16:14:40 +00:00
Tilghman Lesher
f49ce518ba Issue 9003 - If fullname is empty, quote() passes back "\""
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@53529 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-08 13:36:10 +00:00
Tilghman Lesher
7d1af2b829 Issue 7440 - Macro called from Macro from the h extension exits prematurely
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@53354 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-07 15:30:02 +00:00
Russell Bryant
fed5b6a9b4 Revert some changes that accidentally got committed as a part of another fix.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@53134 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-03 20:39:45 +00:00
Russell Bryant
8c161f55e4 set the DIALSTATUS variable to contain "INVALIDARGS" when the dial application
exits early because of invalid arguments instead of just leaving it empty.
(issue #8975)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@53133 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-03 20:38:13 +00:00
Jason Parker
8ab0b28aba Fix a small typo. Synopsis lines shouldn't have a newline
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@53107 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-01 23:14:09 +00:00
Russell Bryant
f9db7779f0 Fix a bunch of places where pthread_attr_init() was called, but
pthread_attr_destroy() was not.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@53045 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-31 21:25:11 +00:00
Joshua Colp
8ba938b508 Now that filename is part of the structure and since it comes before postprocess... we have to add it to our postprocess line. (reported on asterisk-dev by Boris Bakchiev)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@52716 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-29 23:39:39 +00:00
Joshua Colp
e06d0f644b Make COMPLETECALLER and COMPLETEAGENT output to queue_log follow documentation. (issue #7677 reported by amilcar)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@52415 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-27 02:09:10 +00:00
Joshua Colp
245cdf50ba Add another note about audio files being played back to each bridged party. (issue #8718 reported by ppyy)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@52162 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-25 01:48:52 +00:00
Russell Bryant
5823b29f58 Fix a seg fault when running this application with no arguments from AGI.
(issue #8905, junky)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@52137 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-25 00:39:50 +00:00
Russell Bryant
bd06c9494b Don't set a new value for the END_ variable on the channel before using the
old value.  If you do, it will lead to accessing a memory address that has
been free()'d.  (issue #8895, arkadia)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@51828 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-24 00:17:50 +00:00
Joshua Colp
edca3010a4 Move filestream creation to Mixmonitor loop. This will prevent a blank file from being created if no frames ever pass through to be recorded. (issue #7589 reported by steve_mcneil)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@51406 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-22 19:08:52 +00:00
Tilghman Lesher
c69d99c830 Postgres driver doesn't like a NULL pointer when retrieving the length (Bug 8513)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@51158 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-16 21:26:06 +00:00
Tilghman Lesher
e9b6a2c807 Check return value before dereferencing (Bug 8822)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@50987 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-15 23:09:02 +00:00
Matt O'Gorman
741131aaa2 Solves issue with forwarding voicemails from folders other than inbox.
patch by anthonyl.



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@50946 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-15 20:44:53 +00:00
Joshua Colp
ef53c893c3 Add another return value to dial_exec_full that indicates execution is going to continuing at a new extension/context/priority and to just let it slide. (issue #8598 reported by jon)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@50295 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-10 04:51:06 +00:00
Tilghman Lesher
a0afc6c927 The advent of realtime has enabled people to use commas in the fullname field.
This could cause an issue with sending voicemails, when the field is unquoted.
(Issue 8595)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@50150 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-09 13:30:04 +00:00
Tilghman Lesher
be0be1b4f1 If openstream fails, then we crash (Issue 8564)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@49833 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-07 21:43:10 +00:00
Matt O'Gorman
99815228f2 converted a lot of 256 to PATH_MAX and some white space fixes.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@49447 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-04 17:45:16 +00:00
Matt O'Gorman
82016c83d2 good catch russell sorry i missed that.
fix magic number with proper sizeof


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@49412 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-04 16:48:43 +00:00
Matt O'Gorman
58f6fb69fb When using ODBC_STORAGE VoicemailMain doesn't create the
subdirectories for a mailbox such as the INBOX directory.

this patch solves that problem, was written by anthony
be-125


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@49354 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-03 23:22:47 +00:00
Joshua Colp
f28947f7ef Free localuser structure when we fail to dial (issue #8612 reported by rizzo)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@48584 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-19 21:10:26 +00:00
Matt O'Gorman
2cbdcb35b1 app_externalivr needs a real silence file, and additional
changes to add silence files into core instead of extra
patch provided by bug 8177 with minor additions.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@48394 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-11 21:55:43 +00:00
Tilghman Lesher
983d09bc21 When doing a fork() and exec(), two problems existed (Issue 8086):
1) Ignored signals stayed ignored after the exec().
2) Signals could possibly fire between the fork() and exec(), causing Asterisk
signal handlers within the child to execute, which caused nasty race conditions.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@48374 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-11 00:33:59 +00:00
Tilghman Lesher
31759faca8 If the recording in the database is too large, it will fail to retrieve with
an mmap error.  Not too sure why this doesn't happen when we put it in the
database, also, but since that doesn't seem to be broken, I'm not going to fix
it (at least until someone reports it).  Solution is to ask for the file in
smaller chunks.  (Bug 8385)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@48251 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-05 01:26:08 +00:00
Jason Parker
9ce01ec196 Revert change from 8016 - this breaks other stuff... Needs further review.
Tip: When you've reported a bug about something and somebody has put up a
patch for it..  It's not a good idea to open a completely new bug and say that
something is broken because of the patch in the other bug - PLEASE mention
something in the bug where the patch was actually created.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@48246 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-04 21:20:34 +00:00
Jason Parker
8c413a42eb Fix an issue where a message isn't saved correctly when using ODBC storage and reviewing a message.
Issue 8016 - patch by sokhapkin.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@48236 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-04 19:06:26 +00:00
Kevin P. Fleming
37d6a18db1 if Dial() is going to send music-on-hold to the calling party, it has to send PROGRESS first to ensure that the reverse audio path has been setup first (BE-106)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@48192 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-01 23:30:59 +00:00
Joshua Colp
0c18e0a5e1 Use the proper function to get the new message count instead of always using the filesystem. (issue #8421 reported by slimey)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@48053 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-27 18:03:57 +00:00
Tilghman Lesher
0e783db690 Failing to trap -1 error from mmap causes segfault (Issue 8385)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47862 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-20 19:59:07 +00:00
Jason Parker
b5d03cfa96 Fix a couple of typos in applications.. Initially spotted by mrobinson.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47780 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-16 23:16:35 +00:00
Kevin P. Fleming
c446ef9782 correct argument name typo that caused global variable to be used instead of the one for the specified voicemail user
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47696 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-15 20:30:29 +00:00
Kevin P. Fleming
bedd43d2f9 ensure that message duration is included in email notifications for forwarded messages (BE-96, fix by me after corydon used his clue-bat on me)
ensure that duration in the message metadata is updated if prepending is done during forwarding (related to BE-96)
remove prototype for API call that does not exist


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47677 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-15 17:56:42 +00:00
Joshua Colp
5cea7867b3 Update copyright information in the ADSI logo blob.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47631 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-14 22:15:10 +00:00
Joshua Colp
0d9602565f When sending an SMS with a user data header properly set the UDH flag in the first byte. (issue #8347 reported by hoffmeis)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47549 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 17:05:32 +00:00
Tilghman Lesher
38ba4c204e Move thread-unsafe initializer to the module loading code; add the
corresponding function to the module unload to fix a memory leak.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@46662 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-31 15:46:04 +00:00
Russell Bryant
bf20deeba1 We should always be using _exit() after a fork() or vfork() instead of exit().
This is because exit() does some extra cleanup which in some implementations
of vfork(), for example, can actually modify the state of the parent process,
causing very weird bugs or crashes.  (issue #7971, Nick Gavrikov)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@46361 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-27 17:36:07 +00:00
Joshua Colp
0d26753de2 Respect language selection when seeing if the file exists (issue #8178 reported by mnicholson)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@45691 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-19 17:16:37 +00:00
Joshua Colp
d0649af76d Turn on volume adjustment if it needs to be on (issue #8136 reported by mnicholson)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@45060 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-13 17:01:22 +00:00