Commit Graph

7970 Commits

Author SHA1 Message Date
Luigi Rizzo
0dbf814a79 - use symbolic constants and macros to play with the debug flag
on the frame counters. Document it in the header file.
- provide a single exit point for a function;
- mark XXX some unclear parts of the code.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21933 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-21 14:49:21 +00:00
Luigi Rizzo
e61e34e8a1 simplify pbx_builtin_execiftime
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21906 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-21 13:44:15 +00:00
Luigi Rizzo
a702e1f001 simplify a function
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21879 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-21 12:58:39 +00:00
Luigi Rizzo
97d1c9a3c6 minor cleanup
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21878 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-21 12:12:42 +00:00
Luigi Rizzo
eb6dca850d one more client for find_context_locked()
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21851 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-21 11:30:02 +00:00
Luigi Rizzo
73c8b06dcc localize a variable, and make a minor code rearrangement.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21850 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-21 11:19:48 +00:00
Luigi Rizzo
b5e6162359 more NULL "" equivalence in cid fields.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21849 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-21 11:05:54 +00:00
Luigi Rizzo
7ecc442d77 more NULL "" equivalence in cid fields.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21835 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-21 11:02:28 +00:00
Luigi Rizzo
1a6572c4e6 more NULL "" equivalence,
mark a couple of inconsistencies (missing CallerIDnum,
"unknown" instead of "<unknown>") - there are more of the same.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21821 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-21 10:57:03 +00:00
Luigi Rizzo
652ccf5037 more NULL "" equivalence in CLI fields.
Mark a place where we don't clear a buffer while we probably should.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21820 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-21 10:51:31 +00:00
Luigi Rizzo
4cef4ef720 more NULL / "" equivalence for CID fields.
Mark an inconsistency in empty string handling.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21819 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-21 10:47:07 +00:00
Luigi Rizzo
965ff42bed more NULL "" equivalence in CID fields.
Mark a potentially missing item in managerevent



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21818 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-21 10:41:13 +00:00
Luigi Rizzo
ef619f6dd8 ast_strdup can handle NULL args well, so use it.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21817 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-21 10:37:59 +00:00
Luigi Rizzo
7d9c26dfea more NULL and "" equivalence in cid fields
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21816 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-21 10:31:23 +00:00
Luigi Rizzo
309f16bd07 make NULL and "" equivalent in cid fields, mark some missing NULL checks.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21814 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-21 10:05:45 +00:00
Luigi Rizzo
91df5c2e62 make NULL and "" equivalent for some cid fields.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21792 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-21 10:00:58 +00:00
Luigi Rizzo
2d0ff2cf1a Replace three replicas of the same code with a function.
Consider NULL and "" as equivalent in cid strings.

On passing, also remove an extra data copy.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21786 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-21 09:54:23 +00:00
Luigi Rizzo
08220b9073 comment that for callerid field, NULL and "" should be considered
equivalent (the reason is, when passing these strings through a
statically allocated buffer, we have no way to tell between NULL and ""
so we would be unable to preserve the difference, if any).

No code changes yet.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21743 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-20 17:39:44 +00:00
Olle Johansson
6149e82b6c Clarify result of sipsock_read
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21707 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-19 23:49:36 +00:00
Russell Bryant
d722e66e07 add the malloc attribute to the memory allocation wrappers
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21681 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-19 22:32:07 +00:00
Kevin P. Fleming
2af019970f Merged revisions 21638 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r21638 | kpfleming | 2006-04-19 16:10:41 -0500 (Wed, 19 Apr 2006) | 2 lines

support system-specific scripts in safe_asterisk, before starting Asterisk proper

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21639 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-19 21:11:31 +00:00
Tilghman Lesher
efc4a4708c Merged revisions 21597 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r21597 | tilghman | 2006-04-19 13:43:17 -0500 (Wed, 19 Apr 2006) | 2 lines

Bug 6553 - plug memory leaks when ODBC connection is down

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21600 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-19 18:56:38 +00:00
Tilghman Lesher
493c71f3f7 Oops, wasn't revised the way I thought it was
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21599 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-19 18:50:51 +00:00
Tilghman Lesher
1522635e0e Blocked revisions 21597 via svnmerge
........
r21597 | tilghman | 2006-04-19 13:43:17 -0500 (Wed, 19 Apr 2006) | 2 lines

Bug 6553 - plug memory leaks when ODBC connection is down

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21598 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-19 18:44:58 +00:00
Luigi Rizzo
b9f3e4e0f3 move a replicated block of code in the one place where it belongs.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21596 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-19 18:15:20 +00:00
Luigi Rizzo
bd01d66909 merge two nested 'if' which are really a single block.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21595 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-19 18:07:19 +00:00
Luigi Rizzo
9476cb356e fix indentation of a large block
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21572 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-19 18:00:32 +00:00
Luigi Rizzo
501c9e181c start sorting out the duplicated code in the privacy handler
for future removal



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21568 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-19 17:58:07 +00:00
Luigi Rizzo
b3343aecdf merge two nested 'if' which are really a single block.
(indentation still to be fixed)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21566 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-19 17:29:15 +00:00
Luigi Rizzo
73f2d344fb more localization and variable removal
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21538 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-19 16:54:04 +00:00
Luigi Rizzo
c9f669e56d more localization of variables
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21537 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-19 16:36:15 +00:00
Luigi Rizzo
c6a8784e95 localize one more variable;
use ast_strdup as it can handle the NULL argument well.
mark a dubious piece of code with XXX



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21536 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-19 16:19:52 +00:00
Luigi Rizzo
0f4a1bc9ac localize some variables
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21535 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-19 16:10:11 +00:00
Luigi Rizzo
2bdcaa4849 extract a common condition.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21508 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-19 15:15:03 +00:00
Luigi Rizzo
25eb0525d9 fix indentation of some large blocks after previous changes
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21481 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-19 14:53:18 +00:00
Luigi Rizzo
25c6ab22f9 more simplifications - use a local variable c instead of o->chan,
use S_OR as appropriate.

Still need to fix the indentation of some blocks.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21480 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-19 14:50:17 +00:00
Luigi Rizzo
acf0f038dc more simplifications
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21479 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-19 14:14:40 +00:00
Luigi Rizzo
3aaaa41609 start cleaning up this code so we can split the 900 lines function
into manageable chunks.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21468 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-19 14:02:49 +00:00
Luigi Rizzo
2745be5b26 support 'languageprefix' in asterisk.conf to modify the algorithm
to build pathnames for language-specific files (see file.c for
a description)

Default, of course, to the standard behaviour.

We don't have an asterisk.conf.sample to put an example of use!



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21451 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-19 13:59:34 +00:00
Luigi Rizzo
d93234c25b add experimental code for new-style "say" application.
The rules for spelling out numbers and dates are in the config
file "say.conf", which can be edited to implement national
or even local language rules.

The new code can be enabled through the cli command
'say load new'
while the old code can be restored with
'say load old'

Eventually, this code should go to a better place,
but for the time being we keep here as it provides
very similar functions.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21421 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-19 10:27:31 +00:00
Luigi Rizzo
64fbe4cbc5 add example syntax for new-style number and date spelling
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21420 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-19 10:21:58 +00:00
Luigi Rizzo
da7721169d one more client for find_context_locked(),
plus a few minor fixes.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21393 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-19 09:31:41 +00:00
Luigi Rizzo
065367db37 use a function, set_ext_pri(), to assign extension and priority.
On passing, fix a bug in __ast_pbx_run() where the wrong priority
was used in a call to ast_exists_extension() (see comment in the code).



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21392 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-19 09:18:30 +00:00
Luigi Rizzo
91b441abdf replace repeated code to walk contexts with a function,
find_context_locked()



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21365 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-19 08:52:15 +00:00
Luigi Rizzo
585e50fb38 move to a different file (channel.c for the time being) the
wrappers around the basic 'say' functions, and redeclare these
wrappers as ordinary functions rather than function pointers.

This way, alternative implementations of the 'say' functions
will only have to implement the basic functions and not the
wrappers.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21338 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-19 07:23:22 +00:00
Luigi Rizzo
52430bda0d - use ast_calloc instead of ast_malloc
- use ast_channel_lock/unlock in a few places
- comment some dubious pieces of code
- use memset to zero a buffer



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21311 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-19 06:58:20 +00:00
Olle Johansson
4403905c2d Add reference to RFC for mailbox notification
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21277 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-19 00:45:37 +00:00
Olle Johansson
d0f254ef61 Cosmetic fixes to code...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21262 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-19 00:04:03 +00:00
Kevin P. Fleming
cc2fb34bb3 fix obvious breakage
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21239 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-18 23:50:59 +00:00
Kevin P. Fleming
bcecc3d863 doh! don't double-increment the bracket count for embedded references
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21236 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-18 23:25:22 +00:00