Commit Graph

7408 Commits

Author SHA1 Message Date
Kevin P. Fleming
02ae73bd6a proper fix for ast_group_t change
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43977 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-29 13:44:12 +00:00
Joshua Colp
87803a8ac6 Put in missing \ns on the end of ast_logs (issue #7936 reported by wojtekka)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43924 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 18:00:30 +00:00
Kevin P. Fleming
7620e04612 fix buggy (and overly complex) loop used during reload of app_queue for static member list updating
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43916 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 17:31:57 +00:00
BJ Weschke
fb599cc53e app_queue is comparing the device names incorrectly while checking their statuses. It's internal list of interfaces includes the dial string, while the argument passed to this function does not have the dial string (/n for a local channel). This causes it to ignore the device state changes because it thinks it belongs to none of its members. (#8040 reported and patch by tim_ringenbach)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43897 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 16:37:15 +00:00
Kevin P. Fleming
dc268f1e6e eliminate compiler warning introduced by recent changes
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43895 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 16:32:44 +00:00
Joshua Colp
34adb7efe6 Stop the stream after waitstream returns so that our formats get restored. (issue #7370 reported by kryptolus)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43891 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 16:13:55 +00:00
BJ Weschke
f6ddf4e7d4 Fix race condion crash with get_member_status (#7864 - tim_ringenbach reported and patched)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43871 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 15:18:05 +00:00
Tilghman Lesher
a2d98d6c7c Avoid inability to lock directory log message by creating the directory ahead of time. (Issue 7631)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43815 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-27 20:20:35 +00:00
Jason Parker
e247b8ab33 Playback() wasn't setting PLAYBACKSTATUS under several circumstances.
Playback() returns -1 on missing args - so should Background()


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43800 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-27 19:35:09 +00:00
Russell Bryant
0d9ea31f3a Fix a problem that occurred if a user entered a digit that matched a bridge
feature that was configured using multiple digits, and the digit that was
pressed timed out in the feature digit timeout period.  For example, if blind
transfer is configured as '##', and a user presses just '#'.  In this situation,
the call would lock up and no longer pass any frames.
(issue #7977 reported by festr, and issue #7982 reported by michaels and
 valuable input provided by mneuhauser and kuj.  Fixed by me, with testing help
 and peer review from Joshua Colp).

There are a couple of issues involved in this fix:

1) When ast_generic_bridge determines that there has been a timeout, it returned
   AST_BRIDGE_RETRY.  Then, when ast_channel_bridge gets this result, it calls
   ast_generic_bridge over again with the same timestamp for the next event.
   This results in an endless loop of nothing until the call is terminated.
   This is resolved by simply changing ast_generic_bridge to return 
   AST_BRIDGE_COMPLETE when it sees a timeout.

2) I also changed ast_channel_bridge such that if in the process of calculating
   the time until the next event, it knows a timeout has already occured, to
   immediately return AST_BRIDGE_COMPLETE instead of attempting to bridge the
   channels anyway.

3) In the process of testing the previous two changes, I ran into a problem in
   res_features where ast_channel_bridge would return because it determined
   that there was a timeout.  However, ast_bridge_call in res_features would
   then determine by its own calculation that there was still 1 ms before the
   timeout really occurs.  It would then proceed, and since the bridge broke
   out and did *not* return a frame, it interpreted this as the call was over
   and hung up the channels.

   The reason for this was because ast_bridge_call in res_features and
   ast_channel_bridge in channel.c were using different times for their
   calculations.  channel.c uses the start_time on the bridge config, which
   is the time that the feature digit was recieved.  However, res_features
   had another time, 'start', which was set right before calling 
   ast_channel_bridge.  'start' will always be slightly after start_time in the
   bridge config, and sometimes enough to round up to one ms.

   This is fixed by making ast_bridge_call use the same time as 
   ast_channel_bridge for the timeout calculation.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43778 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-27 16:54:30 +00:00
Christian Richter
630930dd7f fixed a bug which led to chan_list zombies, when the call could not be properly established in misdn_call. also removed the ACK_HDLC stuff which is not really needed.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43764 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-27 12:51:03 +00:00
Russell Bryant
8c2fee974a Back in revision 4798, this message was changed from using ast_cli() to directly
calling write().  During this change, checking if this was a remote console was
removed.  This caused this message about using "exit" or "quit" to exit an
Asterisk console to come up in times where it did not make sense.  This change
restores the check to see if this is a remote console before printing the
message.  (fixes BE-4)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43708 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-26 20:49:21 +00:00
Joshua Colp
ff41b0ae36 I changed the channel structure... let's be sure this gets updated!
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43706 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-26 20:38:42 +00:00
Joshua Colp
12afd66083 Use proper type to represent the group variable (issue #8025 reported by makoto)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43705 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-26 20:38:06 +00:00
Russell Bryant
a0da756f2a When parsing the sections of voicemail.conf that contain mailbox definitions,
don't introduce a length limit on the definition by using a 256 byte temporary
storage buffer.  Instead, make the temporary buffer just as big as it needs
to be to hold the entire mailbox definition.
(fixes BE-68)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43699 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-26 20:23:15 +00:00
Tilghman Lesher
83b377451c Two bugs when forwarding voicemail (Issue 7824):
1) delete=yes was ignored
2) maxmessages was ignored


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43634 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-25 21:14:41 +00:00
Russell Bryant
00ca92aeee Check to see if the channel that is activating the IAXPEER function is actually
an IAX2 channel before proceeding to process it to avoid crashing.
(issue #8017, reported by admott, fixed by myself)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43552 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-24 13:50:30 +00:00
Joshua Colp
c6e25717b4 Yay another 'round of spy fixes! This fixes a small logic flaw with the cleanup function and a memory allocation issue. (issue #7960 reported by jojo & issue #7999 reported by aster1) Special thanks to csum77 for letting me into a box where this issue was happening.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43509 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-22 21:53:51 +00:00
Tilghman Lesher
e095711654 Whitespace change... really just an excuse to test repotools
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43420 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-21 17:01:48 +00:00
Tilghman Lesher
a6751ecf3a TDS 0.64 updates
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43409 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-21 16:18:19 +00:00
Kevin P. Fleming
377dac8495 make some more functions static
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43314 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-20 05:08:05 +00:00
Matt O'Gorman
942768c022 fixes some verbose vs debug issues. patch from bug 2617
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43269 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-19 16:21:08 +00:00
Tilghman Lesher
6728ebb72c cid is passed to a destructive function; thus a copy is needed (issue 7961)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43248 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-19 12:28:55 +00:00
Olle Johansson
eb4bd38c92 Issue #7682 - don't add contacts to 4xx responses.
(Ugly fix, not proud at all)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43220 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-18 20:08:22 +00:00
Joshua Colp
b1708137da Add deprecation notice about app_math (issue #7957 reported by k-egg)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43163 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-18 15:30:26 +00:00
Steve Murphy
c8821eb38a Clarified what "callwaiting" does in zapata.conf.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43160 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-18 15:05:56 +00:00
Joshua Colp
e42bf94e06 Add number unobtainable tone for New Zealand (issue #7969 reported by nic_bellamy)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43159 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-18 15:05:39 +00:00
Tilghman Lesher
88ccb83574 Directory used the wrong context for delivery of 0- and *- keypresses
(according to Directory's own documentation) - Issue 7965


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43072 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-17 13:54:34 +00:00
Tilghman Lesher
a729fb97e4 When a realtime peer expires, reset the ipaddress in the realtime database back to 0 (Issue 6656)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43019 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-16 07:57:04 +00:00
Tilghman Lesher
b2122691de When the marked user enters the conference, we should no longer timeout
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43003 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-16 04:44:02 +00:00
Tilghman Lesher
1df9da9fef Error message references wrong argument (Issue 7951)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42946 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-14 22:16:31 +00:00
Tilghman Lesher
ca79503d56 Backport bugfix patch from 7918 to 1.2 - msg_cfg destroyed before used
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42892 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-13 19:51:24 +00:00
Tilghman Lesher
9c8d9ce377 When paging, only wait 5 seconds for the marked user to enter the conference.
After that, assume the paging already completed by the time the channel entered
the conference and drop back out.  (Issue 7275)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42783 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-11 21:47:23 +00:00
Tilghman Lesher
438f99e100 Spelling/grammar fixes (Issue 7929)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42716 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-11 16:39:06 +00:00
Tilghman Lesher
fd0496f3f6 Two grammar issues (bug 7927)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42697 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-11 14:40:13 +00:00
Joshua Colp
cc0f191aab Only truly consider the channel in the same format if the format matches the raw format OR if a translation path already exists to translate between them. (issue #7887 reported by softins & issue #7803 reported by alvaro_palma_aste). Thanks goes to stubert for giving me access to a box and showing me a scenario where this occured.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42600 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-09 20:24:19 +00:00
Olle Johansson
ed09034360 - Reset proper flag
- Don't delete SIP dialog prematurely
Strangely enough imported from svn trunk... It's confusing here in Greenland.

(Committing from 36.000 feet above Greenland, on the way to asterisk@von
http://www.pulver.com/asterisk )


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42535 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-09 12:14:03 +00:00
Joshua Colp
25c493ffdc Swap spies during masquerading
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42452 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-08 18:50:43 +00:00
Tilghman Lesher
ec7535bba2 Jump logic was backwards: goto returns 0 if it succeeds, and we should jump if authentication fails. (Bug #7907)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42421 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-08 16:06:17 +00:00
Joshua Colp
a4e28347fe Use ast_best_codec to set the read/write format
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42402 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-08 04:37:07 +00:00
Tilghman Lesher
0cfb462845 Format vulnerability fix - allowing the user to specify a format is not a good idea (Bug 7811)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42355 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-07 23:12:29 +00:00
Joshua Colp
0367363edb Let's use the same thing we use in other places to calculate our time for ast_cond_timedwait (issue #7697 reported by bn999)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42260 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-07 16:30:44 +00:00
Steve Murphy
d3d62f3678 This should fix the problem reported in 7564: logger config file errors getting lost because logging isn't configured yet. The problem was that the code that exists to handle this case was not getting reached, because other tests were causing an early return from ast_log().
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42200 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-07 02:14:14 +00:00
Steve Murphy
283039a071 added hours,minutes,seconds .gsm files to the install portion of the makefile, as per bug 7545
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42150 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-06 20:09:10 +00:00
Joshua Colp
754cb0114f Don't close the second file descriptor if it's the same as the first one, as it will have already been closed elsewhere and could cause massive panic. (issue #7699 reported by bn999)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42148 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-06 20:02:59 +00:00
BJ Weschke
ff9fce4bb8 Look ma! No more deadlocks! <sic>
As posted from #7458 and others similar to it in Mantis:
 p->app_lock was a mutex really designed for use with agents not in callback mode. That being the case, I've tried to code it so that when callback mode is used, the app_lock mutex will not be locked/unlocked at all. Please let me know how you make out - and if you continue to deadlock now, please reproduce the deadlock logging information and post to Mantis. 



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42133 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-06 18:16:41 +00:00
Christian Richter
8be5b66038 fixed pipe consuming bug when using chanIsAvail (#7878), also moved a debug log to the very begining of misdn_hangup.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42110 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-06 17:10:41 +00:00
Joshua Colp
e627ecb8a7 Make realtime regseconds work as people expected (0 on registration expiration or release, and actual on normal state) (issue #7684 reported by kshumard)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42086 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-06 15:55:20 +00:00
Joshua Colp
68de3c0b29 Merge in last round of spy fixes. This should hopefully eliminate all the issues people have been seeing by distinctly separating what each component (core/spy) is responsible for. Core is responsible for adding a spy to a channel, feeding frames to the spy, removing the spy from a channel, and telling the spy to stop. Spy is responsible for reading frames in, and cleaning up after itself.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42054 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-05 20:02:48 +00:00
Jason Parker
cc82df15ff Small typo in zapata.conf.sample
Reported by ppyy in 7881


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42014 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-05 16:27:46 +00:00