Commit Graph

30319 Commits

Author SHA1 Message Date
Joshua Colp
b5a186d723 Merge "bridge_channel.c: Fix Deadlock when using Local channels and fax gateway" into 13 2018-06-06 05:46:28 -05:00
George Joseph
8dbd3d2b05 Merge "tcptls: Allow OpenSSL configured with no-dh." into 13 2018-06-05 14:22:35 -05:00
George Joseph
a938f49bc5 Merge "tcptls.h: Repair ./configure --with-ssl=PATH." into 13 2018-06-05 14:20:38 -05:00
George Joseph
93a85150e1 Merge "tcptls: Allow OpenSSL 1.1.x configured with enable-ssl3-method no-deprecated." into 13 2018-06-05 13:01:08 -05:00
Joshua Colp
f17d09ae63 Merge "app_meetme: Fix manager event documentation for several events." into 13 2018-06-05 06:53:33 -05:00
George Joseph
db2413b446 app_sendtext: Allow content types other than text/plain
There was no real reason to limit the conteny type to text/plain other
than that's what it was limited to before.  Now any text/* content
type will be allowed for channel drivers that don't support enhanced
messaging and any type will be allowed for channel drivers that do
support enhanced messaging.

Change-Id: I94a90cfee98b4bc8e22aa5c0b6afb7b862f979d9
2018-06-04 13:19:52 -06:00
Pirmin Walthert
8b67e2bd14 bridge_channel.c: Fix Deadlock when using Local channels and fax gateway
ast_indicate is invoked with the bridge locked. As ast_indicate locks the
other end of the bridge as well this can lead to a deadlock in some situations.
(Especially when a different thread does the same in the reverse order).
This patch calls ast_indicate after unlocking the bridge which fixes the
deadlock. Calling ast_indicate with these parameters without locking the
bridge should be safe as this is done at different places without a
bridge lock.

ASTERISK-27094 #close
Reported-by: David Brillert

Change-Id: I5f86c1e2ce75b9929a36ab589b18c450e62ea35f
2018-06-01 14:24:59 -06:00
William McCall
9ff4779f03 app_confbridge: Add talking indicator for ConfBridgeList AMI response
When an AMI client connects, it cannot determine if a user was talking
prior to a transition in the user speaking state (which would generate
a ConfbridgeTalking event). This patch causes app_confbridge to track the
talking state and make this state available via ConfBridgeList.

ASTERISK-27877 #close

Change-Id: I19b5284f34966c3fda94f5b99a7e40e6b89767c6
2018-06-01 05:34:06 +00:00
Joshua Colp
a385467a35 Merge "ast_coredumper: Fix output directory and variable precedence" into 13 2018-05-31 05:15:57 -05:00
Richard Mudgett
071232244a app_meetme: Fix manager event documentation for several events.
The MeetmeJoin, MeetmeLeave, MeetmeEnd, MeetmeMute, MeetmeTalking, and
MeetmeTalkRequest AMI events were documented with sending out a Usernum
header when the User header was actually output.

* Change the online documentation to match reality.

ASTERISK-27873
ASTERISK-25261

Change-Id: I437bc70618d07c183c9624b7069c2fcae7f17a39
2018-05-29 12:38:13 -05:00
Joshua Colp
369e611ac0 Merge "libasteriskssl: Allow OpenSSL 1.0.2 configured with no-deprecated." into 13 2018-05-29 12:07:39 -05:00
Alexander Traud
8c78337479 tcptls.h: Repair ./configure --with-ssl=PATH.
asterisk/tcptls.h was included (explicitly, implicitly, or transitively). Those
inclusions got replaced by forward declarations. As side effect, the inclusions
got completed.

ASTERISK-27878

Change-Id: I9d102728e30336d6522e5e4ae9e964013a0835f7
2018-05-28 17:32:15 +02:00
Alexei Gradinari
9ad3918acd pjsip_options: handle modification of qualify options in realtime
Currentrly pjsip_options code does not handle the situation when the
qualify options were changed in realtime database.
Only 'module reload res_pjsip' helps.

This patch add a check on contact add/update observers if the contact
qualify options are different than local aor qualify options.
If the qualify options were modified then synchronize
the pjsip_options AOR local state.

ASTERISK-27872

Change-Id: Id55210a18e62ed5d35a88e408d5fe84a3c513c62
2018-05-25 18:01:42 -04:00
Alexander Traud
6833c763c7 tcptls: Allow OpenSSL configured with no-dh.
Additionally, this change allows auto-negotiation of the elliptic curve/group
for servers, not only with OpenSSL 1.0.2 but also with OpenSSL 1.1.0 and newer.
This enables X25519 (since OpenSSL 1.1.0) and X448 (since OpenSSL 1.1.1) as a
side-effect.

ASTERISK-27876

Change-Id: I62c2aba4a630aefc231b71f646207e8c027d9497
2018-05-25 08:56:46 -06:00
Alexander Traud
204cc25a27 tcptls: Allow OpenSSL 1.1.x configured with enable-ssl3-method no-deprecated.
ASTERISK-27874

Change-Id: Ica65113511c7a1c13f7988e7d9e7d9e7f3f620dd
2018-05-25 14:24:51 +02:00
Joshua Colp
7f318c3ab5 Merge "res/res_rtp_asterisk: ensure marker bit is correctly set on ssrc change" into 13 2018-05-24 14:55:59 -05:00
George Joseph
acfdfcd19e ast_coredumper: Fix output directory and variable precedence
The OUTPUTDIR variable in ast_debug_tools.conf.sample is now set
to "/tmp" instead of "/some/directory".

Variables set on the command line or that are already in the
environment now take predecence over variables set in the config files.

ASTERISK-27846
Reported by: Ted G

Change-Id: Ie8baec52d531886bf5849ec1d59bb59dc87ad387
2018-05-24 13:00:06 -06:00
Joshua Colp
bb33dafa8f Merge "tcptls: Repair ./configure --with-ssl=PATH." into 13 2018-05-24 06:07:18 -05:00
Joshua Colp
27a8189b0c Merge "channel.c: Fix off nominal channel allocation failure path." into 13 2018-05-24 05:15:50 -05:00
Joshua Colp
751652ec59 Merge "config.c: Fix successful DELETE treated as failure" into 13 2018-05-24 05:10:07 -05:00
Torrey Searle
4b7fd478d5 res/res_rtp_asterisk: ensure marker bit is correctly set on ssrc change
Certain race conditions between changing bridge types and DTMF can
cause the current FLAG_NEED_MARKER_BIT to send the marker bit before
the actual first packet of native bridging.

This logic keeps track of the ssrc the bridge is currently sending
and will correctly ensure the marker bit is set if SSRC as changed
from the previous sent packet.

ASTERISK-27845

Change-Id: I01858bd0235f1e5e629e20de71b422b16f55759b
2018-05-23 20:13:57 -06:00
Alexei Gradinari
a576f50362 pjsip_options: show/reload AOR qualify options using CLI
Currentrly pjsip_options code does not handle the situation when the
AOR qualify options were changed.

Also there is no way to find out what qualify options are using.

This patch add CLI commands to show and synchronize Aor qualify options:
pjsip show qualify endpoint <id>
    Show the current qualify options for all Aors on the PJSIP endpoint.
pjsip show qualify aor <id>
    Show the PJSIP Aor current qualify options.
pjsip reload qualify endpoint <id>
    Synchronize the qualify options for all Aors on the PJSIP endpoint.
pjsip reload qualify aor <id>
    Synchronize the PJSIP Aor qualify options.

ASTERISK-27872

Change-Id: I1746d10ef2b7954f2293f2e606cdd7428068c38c
2018-05-23 17:33:01 -04:00
Richard Mudgett
90a075221b channel.c: Fix off nominal channel allocation failure path.
__ast_channel_alloc_ap() had a failure exit path that hadn't setup the fd
descriptors to -1 yet.  The destructor would then attempt to close these
fd's that had never been opened.

Change-Id: Icf21093f36c60781e8cf6ee9d586536302af33e3
2018-05-22 17:17:31 -05:00
Alexei Gradinari
d6145087cf config.c: Fix successful DELETE treated as failure
The config engine destroy_func callback function returns the number of
rows deleted or -1 on error.  But the function
ast_destroy_realtime_fields treated non-zero return values as error.

ASTERISK-27863

Change-Id: Ied02b38e8196cb03043e609a0679feebd288d17b
2018-05-21 16:23:56 -06:00
Joshua Colp
6dbecc2319 Merge "app_voicemail: Fix data-type mismatch between app_voicemail and database" into 13 2018-05-21 09:05:37 -05:00
Alexander Traud
ec40bd945c libasteriskssl: Allow OpenSSL 1.0.2 configured with no-deprecated.
Use CRYPTO_set_id_callback(.) only with OpenSSL 0.9.8 and older.

ASTERISK-27867

Change-Id: Iadd58d5bf6f538eb224203970a4e88e26f259655
2018-05-20 13:53:19 +02:00
Alexander Traud
b6234f9577 tcptls: Repair ./configure --with-ssl=PATH.
SSL_OP_NO_TLSv1_1 and SSL_OP_NO_TLSv1_2 got discovered without honoring a PATH.

ASTERISK-27865

Change-Id: I8cd358eed7411726d08fa7b01691bef122fbeb71
2018-05-19 07:26:03 -06:00
Kevin Harwell
835cbbe38c Merge "app_voicemail: Fix incorrect msg leaving/retrieving an ODBC voicemail" into 13 2018-05-18 16:43:06 -05:00
Jenkins2
aa37dad11a Merge "chan_mobile: support handling of caller-id names ("cnam")." into 13 2018-05-18 16:06:34 -05:00
Jenkins2
9564fc19f5 Merge "res_pjsip_endpoint_identifier_ip: Unregister the module for headers." into 13 2018-05-18 15:18:33 -05:00
Nic Colledge
436d17fa50 app_voicemail: Fix incorrect msg leaving/retrieving an ODBC voicemail
Correct the log warning message shown when ODBC voicemail
retrieve_file is called and there is a null value in the category
column.
A more meaningfull message is now written at debug level.

ASTERISK-27853

Change-Id: Ic36e97d5eb070a23a12ba45972f6b53e2182a3f4
2018-05-17 15:55:18 -06:00
Brian P. Martin
8c1202beb9 chan_mobile: support handling of caller-id names ("cnam").
Add support to handle caller-ID names ("cnam") in addition to caller-ID
numbers.  The prior code ignored the caller-ID name altogether, and
used the local name for the cell phone (e.g. "my-iphone") in its place.

Note: as of this writing, at least some Android phones don't pass cnam to
us. This can be seen by issuing "core set debug 2" in the CLI and watching
the "CLIP" record when a call comes in.  If cnam isn't in the CLIP record,
there's nothing we can do to provide one.  We'll provide a null cnam field,
so later Asterisk processes know to try other sources (e.g. cidname database,
OpenCNAM, etc.).

Reported by: Brian Martin
Tested by: Brian Martin
ASTERISK-27726

Change-Id: I89490d85fa406c36261879c50ae5e65595538ba5
2018-05-17 16:22:47 -05:00
Alexander Traud
b615df06d3 res_pjsip_endpoint_identifier_ip: Unregister the module for headers.
Asterisk uses Reference Counting to track whether a module can be unloaded.
Every consumer who requires a module, increases the reference count. When the
consumer goes, is unloaded itself, it has to decrease the reference count on
all its used/required modules. That way
 core stop gracefully
works on the command-line interface (CLI): One module after the other is
unloaded. A recent change broke this for the module res_pjsip.

ASTERISK-27861

Change-Id: I261abcb411d026bbb0691cc78f28300bfd3103a3
2018-05-17 01:02:38 -06:00
Alexander Traud
99b24dc63b res_pjsip: Register pjsip_transport_management not externally but internally.
The module (res_)pjsip_transport_management got moved into res_pjsip. It is no
longer an independent/external module with (un)load_module and therefore has to
register just internally with res_pjsip.

ASTERISK-27860

Change-Id: Icd0413be7d2e98b92f51e6d6c353f2570bb4be95
2018-05-16 23:35:32 -06:00
Jenkins2
0afe108dd6 Merge "cli: Display correct unit for HTTP timeout in "manager show settings"." into 13 2018-05-16 09:40:58 -05:00
Jenkins2
118eef8907 Merge "Fix GCC 8 build issues." into 13 2018-05-16 09:37:35 -05:00
Joshua Colp
23e58ec220 Merge "rtp_engine: Remove the double assigned RTP payload ID of H.263+." into 13 2018-05-15 04:13:41 -05:00
Joshua Colp
8926bc20fd Merge "rtp_engine: Avoid a typo error in Doxygen for ast_rtp_codecs_find_payload_code." into 13 2018-05-14 06:25:06 -05:00
Jenkins2
3e65d3bee9 Merge "git: Ignore *.orig." into 13 2018-05-14 06:24:10 -05:00
Joshua Colp
ac9d6b0523 Merge "pjsip: Rewrite OPTIONS support with new eyes." into 13 2018-05-14 04:06:20 -05:00
Nic Colledge
36f08075da app_voicemail: Fix data-type mismatch between app_voicemail and database
Fix data-type mismatch between app_voicemail and database columns
exposed by new version of MariaDB

ASTERISK-27760

Change-Id: I8543ad480a08c98be78bde1ee870e6e6c84b2c5b
2018-05-12 11:22:23 +01:00
Alexander Traud
308a967470 rtp_engine: Remove the double assigned RTP payload ID of H.263+.
Mantis-3709 (Commit 68ff3c3, Asterisk 1.2) added support for the video format
H.263+. For this, the RTP payload ID 103 got assigned statically. Commit f1aadc8
assigned another payload ID 98 for this format in Asterisk 1.6.

Change-Id: I90e35b158487f8f1f8187da6241b54cd3b74e667
2018-05-11 11:50:01 -06:00
Corey Farrell
67212eae87 cli: Display correct unit for HTTP timeout in "manager show settings".
HTTP timeout is in seconds, not minutes.

ASTERISK-27852 #close

Change-Id: Ie6640835cb07307555741f9b559c2eb876d9343e
2018-05-11 13:26:39 -04:00
Alexander Traud
9fe4f99cba rtp_engine: Avoid a typo error in Doxygen for ast_rtp_codecs_find_payload_code.
Change-Id: Ica089d4507a27ddfc4ce3a88d697ffbef378de48
2018-05-11 09:38:20 -06:00
Corey Farrell
d893e57c90 Fix GCC 8 build issues.
This fixes build warnings found by GCC 8.  In some cases format
truncation is intentional so the warning is just suppressed.

ASTERISK-27824 #close

Change-Id: I724f146cbddba8b86619d4c4a9931ee877995c84
2018-05-11 09:58:19 -04:00
Joshua Colp
a722e79434 Merge "makeopts.in: Remove unused/undefined AST_MARCH_NATIVE." into 13 2018-05-10 03:45:35 -05:00
Joshua Colp
eba5ead107 Merge "sip_to_pjsip: Enable python3 compatibility." into 13 2018-05-09 19:01:02 -05:00
Matthew Fredrickson
316efcddb9 res_hep: Adds hostname resolution support for capture_address
Previously, only an IP address would be accepted for the capture_address config
setting in hep.conf.  This change allows capture_address to be a resolvable
hostname or an IP address.

ASTERISK-27796 #close
Reported-By: Sebastian Gutierrez

Change-Id: I33e1a37a8b86e20505dadeda760b861a9ef51f6f
2018-05-09 14:14:08 -06:00
Jenkins2
6783eb8cca Merge "app_macro: Prevent infinite loop in find_matching_priority." into 13 2018-05-09 11:27:42 -05:00
Corey Farrell
19ebad0d30 git: Ignore *.orig.
This prevents accidental commit of files created by patch.

Change-Id: I68380db61f0f9d620046f719ccd978811d0e9964
2018-05-09 10:30:41 -04:00