Commit Graph

2884 Commits

Author SHA1 Message Date
Luigi Rizzo
87890e75ba constify get_header(), which let me find out and fix one bug (overwriting
a string in the buffer) and finding out another one (not fixed yet,
just marked XXX).



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18789 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-10 11:04:04 +00:00
Luigi Rizzo
47df1e2020 - describe how sip packets are stored internally;
- remove useless braces or local variables;
- simplify some code sequences;
- mark with XXX a possible locking issue.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18788 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-10 10:40:13 +00:00
Luigi Rizzo
20d1876617 struct sip_request cleanup:
- remove a debug field that was read but never set, so it was basically
  unused as well as the code testing it (also removed);

- make scalar fields contiguous so any array overflow will be
  less harmful;



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18787 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-10 10:30:38 +00:00
Luigi Rizzo
104c2b0a3a more cleanup: remove useless braces, replace "if" with "?",
localize a couple of variables, remove trailing whitespace.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18786 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-10 10:22:42 +00:00
Olle Johansson
9b4e335439 Re-instate removed comment
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18785 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-10 10:01:14 +00:00
Luigi Rizzo
e081b42cd6 another batch of minor code simplifications
(moving repeated expressions into a function, const on
some arguments)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18784 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-10 09:53:22 +00:00
Luigi Rizzo
e468d9011d a bunch of trivial code normalizations (removal of unnecessary
casts and parentheses, formatting fixes, pointing out replicated
code and so on). No functional changes.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18666 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-09 23:16:29 +00:00
Kevin P. Fleming
f10f427d49 since the module API is changing, it's a good time to const-ify the description() and key() return values
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18552 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-08 22:01:19 +00:00
Olle Johansson
8159124572 -Fixing some debugging messages in history and console
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18403 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-07 20:19:44 +00:00
Olle Johansson
aefba4ad7d Add history events for re-invites
(need to nail this issue...)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18373 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-07 19:46:50 +00:00
Olle Johansson
f235bbe5a5 make history easier to read
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18371 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-07 19:36:44 +00:00
Olle Johansson
8cd506cdfd Add some more information to SIP history
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18370 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-07 19:25:19 +00:00
Olle Johansson
7089dc1341 Issue #6899 - remove OSP support code from chan_sip.c and app_dial.c
- implement all functions through internal APIs in res_osp.c and app_osplookup.c
(homesick)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18369 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-07 19:11:22 +00:00
Olle Johansson
fd54f36509 Hmm. What is that keyword?? Let me see... Wait... Maybe... Ahh! OOPS!
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18342 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-07 18:52:23 +00:00
Russell Bryant
3808318cff change a couple uses of !strlen() to ast_strlen_zero(). Oddly enough, one of
these used to be this way and got changed ...


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18309 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-07 16:28:50 +00:00
Olle Johansson
839ebd8e03 - sip_alloc failures are also caused by too few available file descriptors, so we can not
open socket for RTP (audio/video/rtcp).
  Error message change to clarify.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18307 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-07 16:22:28 +00:00
Olle Johansson
b479a91e97 - Add cause code for format error
- Change to SWITCH_CONGESTION instead of CONGESTION
(imported from 1.2)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18262 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-07 14:42:25 +00:00
Olle Johansson
48ca2c82bf Import of revistion 18250 from 1.2
- Fix minor memory leak
- Add proper cause codes on memory allocation failures


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18261 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-07 14:30:14 +00:00
Christian Richter
ece21c3019 sorry litle mistake
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18221 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-07 12:03:51 +00:00
Christian Richter
47b8610f70 git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18192 65c4cc65-6c06-0410-ace0-fbb531ad65f3 2006-04-07 09:46:38 +00:00
Christian Richter
7788d5061c fixed a bridging-endless-loop also fixed the rdnis is not exported issue
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18190 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-07 09:31:27 +00:00
Olle Johansson
b7d32b9e0b Issue #6674: Set the URI correctly on BYEs when we have an incoming call
Reported by aubergine, fix by oej


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18161 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-07 08:19:52 +00:00
Olle Johansson
4ded41daa5 Cosmetic update for outbound REFERs
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18060 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-06 21:49:24 +00:00
Olle Johansson
965394e4c2 Add "NewChan" event to history to track the birth of a new ast_chan from a
SIP invite


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18059 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-06 21:33:39 +00:00
Olle Johansson
009e081199 Improved handling of 491 responses
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18058 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-06 21:29:54 +00:00
Olle Johansson
518c4b295d Small changes to parse_sip_options
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18057 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-06 21:18:12 +00:00
Olle Johansson
be4ac5e57a Small fixes to handle_request_invite
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18056 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-06 21:13:32 +00:00
Olle Johansson
62128ba7b7 - Don't change channel direction on re-invites
- Don't re-initialize initreq on re-invites


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18033 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-06 21:01:06 +00:00
Olle Johansson
5483288048 - Implement handle_request_notify to handle incoming NOTIFY requests
and respond properly to them.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18024 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-06 20:36:25 +00:00
Olle Johansson
9bd9bceef7 Implement a handle_response_refer function to take care of responses
to outbound REFERS. Not that common, but still needed.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18022 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-06 20:16:08 +00:00
Olle Johansson
1e8d1dda7d Change transmit_notify_sipfrag to handle other messages than 200 OK, needed for
SIPtransfer improvement


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17993 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-06 19:59:21 +00:00
Olle Johansson
ddcd16e519 - doxygen
- debug message control


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17991 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-06 19:39:27 +00:00
Luigi Rizzo
4408c0e6b5 structures can be copied with the '=' operators, no need to
use memcpy.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17988 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-06 19:31:59 +00:00
Luigi Rizzo
6f09a652dd normalize some for() loops.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17943 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-06 17:09:00 +00:00
North Antara
0a24923596 skinny debug/verbose cleanup.
Thanks casper!


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17903 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-06 16:50:33 +00:00
Tilghman Lesher
756c7cbb12 Bug 6873 - Finish moving from the non-threadsafe (and poor randomness) rand() to threadsafe ast_random()
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17627 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-05 17:44:44 +00:00
Christian Richter
7028946605 some final fixes for cpn
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17594 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-05 15:54:15 +00:00
Christian Richter
ce8fc47ffc * advanced the error Handling routine for wrong frames from mISDN
* added more code for connected party number handling
* fixed the portinfo program, it can now be used to test mISDN again



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17562 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-05 14:51:48 +00:00
Christian Richter
d7a839a299 fixed some essential segfaults happening under heavy load. Added a bit more error handling if we receive wrong data form mISDN (e.g. if we crashed before => handle_err() ). Added first steps to implement the parseing of the connected party number.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17404 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-04 19:09:26 +00:00
Olle Johansson
42fddfa075 Formatting cleanup
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17369 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-04 18:34:21 +00:00
Olle Johansson
0a1898d8d6 Issue #6878 - Manager event DNDstate hidden under verbose option (casper)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17366 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-04 18:26:24 +00:00
Olle Johansson
37ff50a890 - Don't return AST_DEVICE_UNKNOWN to devicestate engine, since this will
cause a channel walk...
- Doxygen fixed for devicestate.c


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17365 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-04 18:24:41 +00:00
Matthew Fredrickson
a868675e2f chan_iax2 cleanups and optimizations (#6858)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17329 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-04 17:05:01 +00:00
Matt O'Gorman
b9e7287ce6 adds manager event when an iax2 peer loses registration.
also some minor code clean up. patch from 6868 with minor
changes.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17311 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-04 16:15:40 +00:00
Olle Johansson
878c88f899 Add tag to NOTIFY headers (imported from 1.2)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17151 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-03 20:40:08 +00:00
Christian Richter
a096fbd87d * removed unneeded bc->state field
* added statefullness for bchannel activation/deactivation
* fixed a lot PCM bridging issues
* some debugging logs are now on a higher loglevel



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17128 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-03 19:17:59 +00:00
Matt O'Gorman
319945c922 bug updates chan_h323 to some api changes it
also allows for it to compile once more patch
taken from 6446 with minor mods, similar bugs 6521
and 6560


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17104 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-03 18:36:30 +00:00
Olle Johansson
5fbe9f80e8 Don't add hangup cause on non-final responses. (Imported from 1.2)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17075 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-03 17:52:11 +00:00
Olle Johansson
67b460d43c Issue #6848 - Accept MWI subscriptions with no Accept: header
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17050 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-03 10:50:56 +00:00
Olle Johansson
46a1b7c73b Don't add ast_extension_state on re-subscribes
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@16829 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-01 00:44:36 +00:00