Commit Graph

28456 Commits

Author SHA1 Message Date
Joshua Colp
251113408a Merge "manager: Add <see-also> tags to relate AoC events and actions" into 14 2016-08-16 05:34:19 -05:00
Joshua Colp
f21701b4a4 Merge "res_agi: Improve documentation" into 14 2016-08-16 05:34:00 -05:00
Joshua Colp
8de930b593 Merge "manager: Add <see-also> links between related events" into 14 2016-08-16 05:33:44 -05:00
Joshua Colp
5d32617a25 Merge "pbx.c: Additional fixes to ast_context_remove_extension_callerid2." into 14 2016-08-16 05:33:23 -05:00
zuul
01083e87e2 Merge "func_channel: Reorganize documentation" into 14 2016-08-16 01:21:15 -05:00
zuul
b8b9cee272 Merge "manager: Add <see-also> tags to relate UserEvent actions/apps/events" into 14 2016-08-15 23:04:33 -05:00
zuul
4b46e440df Merge "manager: Add <see-also> tags to relate Bridge related events,actions, and apps" into 14 2016-08-15 19:16:46 -05:00
zuul
cb6b69b53e Merge "manager: Add <see-also> tags to relate interrelated events/actions together" into 14 2016-08-15 18:48:53 -05:00
zuul
709f5f5bd4 Merge "app_dial: Improve documentation" into 14 2016-08-15 17:04:24 -05:00
cjack
19e323a6aa chan_sip: Fix lastrtprx always updated
Packets are read regulary, when there is no data in buffer fr->frametype
is AST_FRAME_NULL. There was no check of frametype and lastrtprx always 
updated and, therefore, rtptimeout did not work at all.

ASTERISK-25270 #close

Change-Id: If3b5ca0dbb822582a86eb7d01dcae4e83448c41d
2016-08-15 16:55:54 -05:00
Alexei Gradinari
811e7d7788 core: Entity ID is not set or invalid
The Exchanging Device and Mailbox States could not working
if the Entity ID (EID) is not set manually and can't be obtained
from ethernet interface.

This patch replaces debug message to warning
and addes missing description about option 'entityid' to
asterisk.conf.sample.

With this patch the asterisk also:
(1) decline loading the modules which won't work without EID:
    res_corosync and res_pjsip_publish_asterisk.
(2) warn if EID is empty on loading next modules:
    pbx_dundi, res_xmpp

Starting with v197 systemd/udev will automatically assign "predictable"
names for all local Ethernet interfaces.
This patch also addes some new ethernet prefixes "eno" and "ens".

ASTERISK-26164 #close

Change-Id: I72d712f1ad5b6f64571bb179c5cb12461e7c58c6
2016-08-15 13:35:39 -05:00
Richard Mudgett
840d274f4e res_sorcery_config.c: Cleanup ao2 container usage idioms.
Change-Id: Iad24b335fb121a2bc7f1d048ab7420569edcba5a
2016-08-15 13:14:21 -05:00
Richard Mudgett
2f8f063d0a sorcery.c: Minor optimizations.
* Remove some unused parameters from internal functions:
sorcery_wizard_create()
sorcery_wizard_update()
sorcery_wizard_delete()

* Created the struct sorcery_observer_invocation ao2 object without a lock
since it is not needed in sorcery_observer_invocation_alloc().

* Cleanup generic ao2 container sorcery object id hash, sort, and cmp
functions.

Change-Id: Iff71d75f52bc1b8cee955456838c149faaa4f92e
2016-08-15 13:14:21 -05:00
Richard Mudgett
aed60171f1 sorcery.c: Tweak some container declaration formatting.
* Tweak sorcery_object_type_alloc() formatting.
* Tweak ast_sorcery_init() formatting.

Change-Id: Ib02430023f15268cd7a2ea53f2c331213e4d3944
2016-08-15 13:14:21 -05:00
Corey Farrell
f7f9081f7a pbx.c: Additional fixes to ast_context_remove_extension_callerid2.
Do not check registrar of the first extension head.  We should only check
the registrar when we match the priority.

Additionally fix a couple calls to strcmp which used the input callerid
instead of the clean version ex.cidmatch.

ASTERISK-26233

Change-Id: I17ea6881a18f40840ae9c1f5394aab1fbb3769f1
2016-08-15 11:12:42 -05:00
Matt Jordan
7c46e3bfbb app_dial: Improve documentation
* Add some helpful <literal> and other embedded paragraph tags

* Document some of the lesser known channel variables set by Dial

* Add examples for some common Dial uses, along with some more
  challenging but useful options

Change-Id: Ib2fb9301e8e044d14fbb2815ec64161f19bbfbc1
2016-08-15 07:42:40 -05:00
Matt Jordan
2e77b973fb manager: Add <see-also> tags to relate interrelated events/actions together
Change-Id: Idbac539205aa732bf786c4f765577d8e9ff28ba4
2016-08-15 07:41:32 -05:00
Matt Jordan
18065140d5 manager: Add <see-also> tags to relate Bridge related events,actions, and apps
Change-Id: I67e6b79fa3102e494b5fe6cc7510472249080e85
2016-08-15 07:41:01 -05:00
Matt Jordan
f69ae95889 manager: Add <see-also> tags to relate AoC events and actions
Change-Id: Iea89a36222712148c1775c05ed0ad1049d67a70e
2016-08-15 07:40:46 -05:00
Matt Jordan
c5574667c7 manager: Add <see-also> tags to relate UserEvent actions/apps/events
Change-Id: I80f8a981f62f50e74609c69c49edcaca6c95efa4
2016-08-15 07:40:31 -05:00
Matt Jordan
1a44ebe8ec res_agi: Improve documentation
* Groups of AGI commands that have similar functionality now reference
  each other, and all reference the AGI application for ease of wiki
  reference.

* The documentation for the AGI application has been improved, in
  particular noting the various AGI types and how they are invoked.

* A warning message has been added to DeadAGI, noting that it is
  deprecated.

Change-Id: I479ccdee8a7393f01b18692c3d4ab7e6bdd1875d
2016-08-15 07:40:15 -05:00
Matt Jordan
3b3198333a manager: Add <see-also> links between related events
This patch adds some see-also references between related AMI events. It
focuses primarily on those events that are guaranteed to come in pairs,
such as DTMFBegin/DTMFEnd, as well as those that occur during the life
cycle of an Asterisk channel, such as Newchannel/Hangup.

Change-Id: Iaab600477052018d0f8c03d0c624c0856e9ff1f3
2016-08-15 07:39:51 -05:00
Matt Jordan
89dccb04bc func_channel: Reorganize documentation
* Following the example of the PJSIP channel driver, the channel
  technology specific documentation has been moved to the respective
  channel drivers that provide that functionality. This has the benefit
  of locating the documentation of items with those modules that provide
  it.

* Examples of using the CHANNEL function for both standard items as well
  as for PJSIP have been added.

* The 'max_forwards' standard item has been documented.

Change-Id: Ifaa79a232c8ac99cf8da6ef6cc7815d398b1b79b
2016-08-15 07:39:12 -05:00
Joshua Colp
2ce487585e manager: Clarify that dialplan manipulation actions are under system class.
ASTERISK-26246 #close

Change-Id: Id673b9786389f9d2a87f638ce1a25161f5f31657
2016-08-15 07:34:19 -05:00
zuul
0bb8366580 Merge "res_pjsip: Fail global load if debug or default_from_user are empty" into 14 2016-08-12 18:49:52 -05:00
zuul
f771e284eb Merge "res_pjsip_caller_id: Copy header name to short header name" into 14 2016-08-12 14:14:04 -05:00
zuul
906d0e72e1 Merge "Run mandatory cleanup when startup fails." into 14 2016-08-12 13:59:44 -05:00
zuul
488ea6b865 Merge "location.c: Misc fixes and cleanups." into 14 2016-08-12 12:06:13 -05:00
Joshua Colp
2153309241 Merge "app_queue: Prevent crash when a call is forwarded to an invalid location" into 14 2016-08-12 09:34:45 -05:00
Joshua Colp
7a6f943bf2 Merge "alembic: add auth_username to endpoint's identify_by enum" into 14 2016-08-12 04:47:07 -05:00
Joshua Colp
a4ba3d2b52 Merge "res_pjsip res_pjsip_mwi: Misc fixes and cleanups." into 14 2016-08-12 04:46:29 -05:00
zuul
15540119c0 Merge "pjsip_distributor.c: Add missing allocation failure check." into 14 2016-08-12 03:22:29 -05:00
zuul
d003057ff5 Merge "res_pjsip: Make aor named lock a mutex." into 14 2016-08-11 23:14:42 -05:00
Corey Farrell
03b80c5d27 Run mandatory cleanup when startup fails.
Errors during startup result in an exit.  These error branches should be
calling ast_run_atexit(0) to ensure mandatory cleanup is run.

ASTERISK-26267 #close

Change-Id: If226f2326ae2df7add20040696132214cf2bb680
2016-08-11 23:12:32 -04:00
zuul
6092514405 Merge "taskprocessor.c: Tweak high water checks." into 14 2016-08-11 21:17:56 -05:00
zuul
ef3973f57f Merge "res_odbc: Show only when there a fail attempt of connection in CLI" into 14 2016-08-11 21:17:54 -05:00
Joshua Colp
cf48c672af Merge "cdr_adaptive_odbc: Fix DNSs mixed config quote quoted_identifiers" into 14 2016-08-11 19:42:09 -05:00
Joshua Colp
968e78f9be Merge "autohints: Update CHANGES and extensions.conf.sample" into 14 2016-08-11 16:10:36 -05:00
George Joseph
33952469f2 res_pjsip_caller_id: Copy header name to short header name
When compact_headers was set, we were sending a zero-length header name
for PAI and RPID because we always forced the short header name length
to 0.  We did this because we cloned the header from "From" and wanted
to clear "f" from the sname.  By cloning however, we bypass pjproject's
automatic logic that sets sname to name if there's no compact form of
the header, which there isn't for PAI and RPID.  So now we force sname
to be the same as name right after we set name.

res_pjsip_diversion needed the same treatment for the Diversion header.

ASTERISK-26241 #close

Change-Id: I633ec139630cd83809aae00336cee4a10077e467
2016-08-11 14:17:36 -05:00
zuul
8071c3d04e Merge "Fixed compile flags for non-module libs" into 14 2016-08-11 14:08:52 -05:00
Matt Jordan
82529ae4e6 app_queue: Prevent crash when a call is forwarded to an invalid location
When a call forward attempt is made from a Queue member, the current
code will hang up the forwarding channel in an off-nominal condition
prior to raising the Stasis events informing the rest of Asterisk that
the call was forwarded. This will result in a slew of dreaded FRACKs,
most likely leading to a crash.

This patch modifies the code such that we don't hang up the forwarding
channel even in an off-nominal condition until we've safely raised the
Stasis messages.

ASTERISK-25797 #close

Change-Id: Ife5abed351691fd79105321636eaa8ea8dcdba38
2016-08-11 13:56:12 -05:00
George Joseph
2db2d9dbd3 res_pjsip: Fail global load if debug or default_from_user are empty
If debug was specified in the global configuration but left blank,
the logger would treat it as a wildcard and log all hosts.  If
default_from_user was empty, a crash would result.

The global apply handler now checks for empty strings.

ASTERISK-26239 #close
ASTERISK-26238 #close

Change-Id: Ie75727f5cd5808845d92cc81f5713842fb203336
2016-08-11 12:33:07 -05:00
zuul
ef7361659f Merge "res_resolver_unbound: Allow compilation with libunbound version < 1.5" into 14 2016-08-11 12:30:19 -05:00
Richard Mudgett
63863ed0f3 res_pjsip res_pjsip_mwi: Misc fixes and cleanups.
* Eliminated RAII_VAR() usage in
ast_sip_persistent_endpoint_update_state().

* Added a missing allocation failure check to
persistent_endpoint_find_or_create().

* Made persistent_endpoint_find_or_create() create the new object without
a lock as it isn't needed.

* Cleaned up some ao2 container allocation idioms.

* Reordered res_pjsip_mwi.c load_module() and unload_module()

Change-Id: If8ce88fbd82a0c72a37a2388f74f77237a6a36a8
2016-08-11 12:17:34 -05:00
Richard Mudgett
ab45dfaeb9 location.c: Misc fixes and cleanups.
* Eliminated most RAII_VAR() usage.

* Added several missing allocation failure checks.

* Made ast_sip_for_each_contact() allocate the wrapper ao2 object without
a lock as it is not needed.

Change-Id: Ie20913365156c95dd79e5d471cfd25e99ae880bc
2016-08-11 12:13:41 -05:00
George Joseph
96887cc110 autohints: Update CHANGES and extensions.conf.sample
Make it clear that we're talking about device state hints and add
an entry to the sample config.

Change-Id: Iaef58ffb960191a21b713e8e0b51ce1fcd47e433
2016-08-11 11:01:33 -06:00
Richard Mudgett
7f9789fc39 taskprocessor.c: Tweak high water checks.
* The high water check in ast_taskprocessor_alert_set_levels() would
trigger immediately if the new high water level is zero and the queue was
empty.

* The high water check in taskprocessor_push() was off by one.

Change-Id: I687729fb4efa6a0ba38ec9c1c133c4d407bc3d5d
2016-08-11 11:59:58 -05:00
Richard Mudgett
94ff684388 res_pjsip: Make aor named lock a mutex.
The named aor lock was always being locked for writes so a rwlock adds no
benefit and may be slower because rwlocks are biased toward read locking.

Change-Id: I8c5c2c780eb30ce5441832257beeb3506fd12b28
2016-08-11 11:58:25 -05:00
Richard Mudgett
31a1b066ee pjsip_distributor.c: Add missing allocation failure check.
Change-Id: I932ab2cea845e534d9ff318035b6de39972d3b28
2016-08-11 11:57:10 -05:00
zuul
b08497c048 Merge "channels/chan_pjsip: Add PJSIP_SEND_SESSION_REFRESH" into 14 2016-08-11 11:43:20 -05:00