Commit Graph

14045 Commits

Author SHA1 Message Date
Leif Madsen
a4db8a85e9 Update.version and ChangeLog
git-svn-id: https://origsvn.digium.com/svn/asterisk/tags/1.4.33@271294 65c4cc65-6c06-0410-ace0-fbb531ad65f3
1.4.33
2010-06-17 20:03:01 +00:00
Leif Madsen
42b299ffb2 Create 1.4.33 from 1.4.33-rc2
git-svn-id: https://origsvn.digium.com/svn/asterisk/tags/1.4.33@271264 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-17 19:17:23 +00:00
Leif Madsen
d4a7c0026c Merge 269635 and update ChangeLog.
git-svn-id: https://origsvn.digium.com/svn/asterisk/tags/1.4.33-rc2@269746 65c4cc65-6c06-0410-ace0-fbb531ad65f3
1.4.33-rc2
2010-06-10 14:23:35 +00:00
Leif Madsen
b2a5b74ebc Merge in revision 269335. Updated ChangeLog and .version files.
git-svn-id: https://origsvn.digium.com/svn/asterisk/tags/1.4.33-rc2@269350 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-09 17:55:11 +00:00
Leif Madsen
96f99f9732 Create 1.4.33-rc2 from 1.4.33-rc1.
Shoutouts to pabelanger and the Maniacal Maniac.

git-svn-id: https://origsvn.digium.com/svn/asterisk/tags/1.4.33-rc2@269348 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-09 17:48:42 +00:00
Leif Madsen
f544f3b196 Use autotagged externals
git-svn-id: https://origsvn.digium.com/svn/asterisk/tags/1.4.33-rc1@266648 65c4cc65-6c06-0410-ace0-fbb531ad65f3
1.4.33-rc1
2010-06-01 15:59:25 +00:00
Leif Madsen
92a6a01c9f Importing files for 1.4.33-rc1 release.
git-svn-id: https://origsvn.digium.com/svn/asterisk/tags/1.4.33-rc1@266647 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-01 15:59:14 +00:00
Leif Madsen
14a3f2861e Creating tag for the release of asterisk-1.4.33-rc1
git-svn-id: https://origsvn.digium.com/svn/asterisk/tags/1.4.33-rc1@266646 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-01 15:57:23 +00:00
Tilghman Lesher
f703a2d7fa Prevent CLI prompt from distorting output of lines shorter than the prompt.
Uses the VT100 method of clearing the line from the cursor position to the
end of the line:  Esc-0K

(closes issue #17160)
 Reported by: coolmig
 Patches: 
       20100531__issue17160.diff.txt uploaded by tilghman (license 14)
 Tested by: coolmig


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@266585 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-01 15:17:46 +00:00
Paul Belanger
b3076dd0f5 Fix formatting issue with previous patch.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@266580 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-01 14:57:49 +00:00
Paul Belanger
abc4bceec2 Missing fallback to audio fax feature when T.38 re-INVITE failed
When a T.38 re-INVITE failed with an 488 or 606 answer, we should
fallback to audio fax by send a re-re-INVITE without T.38. The
function is backported from 1.6 asterisk.

(closes issue #16795)
Reported by: vrban

(closes issue #16692)
Reported by: vrban
Patches:
      t38_fallback_to_audio_v3.patch uploaded by vrban (license 756)
Tested by: lmadsen, vrban, haggard

https://reviewboard.asterisk.org/r/514/



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@266579 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-06-01 14:54:05 +00:00
Tilghman Lesher
06914c13cf Reverting patch and reopening issue #16784, as patch breaks color display.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@266437 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-30 04:43:28 +00:00
Tilghman Lesher
a9b91b8435 Use sigaction for signals which should persist past the initial trigger, not signal.
If you call signal() in a Solaris signal handler, instead of just resetting
the signal handler, it causes the signal to refire, because the signal is not
marked as handled prior to the signal handler being called.  This effectively
causes Solaris to immediately exceed the threadstack in recursive signal
handlers and crash.

(closes issue #17000)
 Reported by: rmcgilvr
 Patches: 
       20100526__issue17000.diff.txt uploaded by tilghman (license 14)
 Tested by: rmcgilvr


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@266142 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-26 21:11:44 +00:00
David Vossel
9d466eed00 add dahdi_func_write to zap_tech structure
This was supposed to be committed with r263292, the back-port
of teh DAHDI buffer policy dial string option


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@266140 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-26 20:33:00 +00:00
Mark Michelson
a69a5d0772 Make AgentComplete message more consistent.
At times, the "Member" field was not specified during the event.
It's there now.

(closes issue #15638)
Reported by: elbriga
Patches:
      patchAppQueueAgentComplete.diff uploaded by elbriga (license 482)




git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@266004 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-26 18:21:10 +00:00
Tilghman Lesher
7f7ae0d3cf Not finding rows in the DB does not rise to the level of a warning.
(closes issue #17062)
 Reported by: drookie
 Patches: 
       20100525__issue17062.diff.txt uploaded by tilghman (license 14)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@265910 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-26 16:21:00 +00:00
David Vossel
ff8057a92a fixes build issue with zaptel
(closes issue #17394)
Reported by: aragon
Patches:
      half_buffer_fix.diff uploaded by dvossel (license 671)
Tested by: aragon


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@265613 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-25 17:11:40 +00:00
Matthew Nicholson
2fc3375a89 Don't mark the cdr records of unanswered queue calls with "NOANSWER". This restores the behavior prior to r258670.
(closes issue #17334)
Reported by: jvandal
Patches:
      queue-cdr-fixes1.diff uploaded by mnicholson (license 96)
Tested by: aragon, jvandal


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@265610 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-25 16:48:19 +00:00
Terry Wilson
7e9a71f5d8 Merged revisions 265320,265467 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
  r265320 | twilson | 2010-05-24 14:06:40 -0500 (Mon, 24 May 2010) | 14 lines
  
  Add the FullyBooted AMI event
  
  It is possible to connect to the manager interface before all Asterisk modules
  are loaded. To ensure that an application does not send AMI actions that might
  require a module that has not yet loaded, the application can listen for the
  FullyBooted manager event. It will be sent upon connection if all modules have
  been loaded, or as soon as loading is complete. The event:
  
     Event: FullyBooted
     Privilege: system,all
     Status: Fully Booted
  
  Review: https://reviewboard.asterisk.org/r/639/
........
  r265467 | twilson | 2010-05-24 17:21:58 -0500 (Mon, 24 May 2010) | 1 line
  
  Merge the rest of the FullyBooted patch
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@265570 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-25 13:33:21 +00:00
David Vossel
6105e07933 fixes segfault when using generic plc
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@265365 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-24 19:37:55 +00:00
Mark Michelson
ed585b5bb3 Don't hang up on a queue caller if the file we attempt to play does not exist.
This also fixes a documentation mistake in file.h that made my original attempt
to correct this problem not work correctly.

(closes issue #17061)
Reported by: RoadKill


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@265089 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-21 20:59:14 +00:00
Mark Michelson
94238573fa Fix grammatical error in comment.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@264999 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-21 16:53:53 +00:00
Mark Michelson
b91ff0498e Allow ast_safe_sleep to defer specific frames until after the sleep has concluded.
From reviewboard

Background:
A Digium customer discovered a somewhat odd bug. The setup is that parties A
and B are bridged, and party A places party B on hold. While party B is 
listening to hold music, he mashes a bunch of DTMF. Party A takes party
B off hold while this is happening, but party B continues to hear hold
music. I could reproduce this about 1 in 5 times.

The issue:
When DTMF features are enabled and a user presses keys, the channel that
the DTMF is streamed to is placed in an ast_safe_sleep for 100 ms, the
duration of the emulated tone. If an AST_CONTROL_UNHOLD frame is read
from the channel during the sleep, the frame is dropped. Thus the
unhold indication is never made to the channel that was originally placed
on hold.

The fix:
Originally, I discussed with Kevin possible ways of fixing the specific
problem reported. However, we determined that the same type of problem
could happen in other situations where ast_safe_sleep() is used. Using
autoservice as a model, I modified ast_safe_sleep_conditional() to
defer specific frame types so they can be re-queued once the sleep has
finished. I made a common function for determining if a frame should
be deferred so that there are not two identical switch blocks to
maintain.

Review: https://reviewboard.asterisk.org/r/674/



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@264996 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-21 16:28:34 +00:00
Richard Mudgett
20f140f1c7 ast_callerid_parse() had a path that left name uninitialized.
Several callers of ast_callerid_parse() do not initialize the name
parameter before calling thus there is the potential to use an
uninitialized pointer.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@264820 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-20 23:23:21 +00:00
Mark Michelson
610c1dc6bf 1.4 version of PLC fix.
Analogous to trunk revision 264452, but without the change
to chan_sip since it is not necessary in this branch.



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@264541 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-20 15:59:44 +00:00
Matthew Nicholson
f428d9bfdb Set quieted flag when receiving a dtmf tone during playback in speechbackground.
(closes issue #16966)
Reported by: asackheim


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@264334 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-19 20:01:38 +00:00
Tilghman Lesher
136073265c Internal timing is now on by default, if you're using DAHDI 2.3 or above.
The reason for ensuring DAHDI 2.3 or above is that this version ensures that
a timer is always available, whereas in previous versions, it was possible
for DAHDI to be loaded, but have no drivers to actually generate timing.  If
internal_timing was turned on in this circumstance, a complete lack of audio
would result.  This is the reason why internal_timing was not on by default.
However, now that DAHDI ensures the availability of a timer, there is no
reason for this setting to be off (and in fact, it solves a great many initial
user problems).

(closes issue #15932)
 Reported by: dimas
 Patches: 
       20100519__issue15932.diff.txt uploaded by tilghman (license 14)
 Tested by: tilghman


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@264248 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-19 17:41:29 +00:00
Alec L Davis
201fb5663a fix incorrectly typed indications for [nz] stutter and dialrecall
(closes issue #17359)
Reported by: alecdavis
Patches: 
      bug17359.diff.txt uploaded by alecdavis (license 585)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@264056 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-19 08:23:07 +00:00
Tilghman Lesher
e7ef5288c9 Because progress is called multiple times, across several frames, we must persist states when detecting multitone sequences.
(closes issue #16749)
 Reported by: dant
 Patches: 
       dsp.c-bug16749-1.patch uploaded by dant (license 670)
 Tested by: dant


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@263949 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-19 06:32:27 +00:00
Jeff Peeler
4a168f6578 Modify directory name reading to be interrupted with operator or pound escape.
In the case of accidentally entering the wrong first three letters for the
reading, users could be very frustrated if the name listing is very long. This
allows interrupting the reading by pressing 0 or #. 0 will attempt to execute
a configured operator (o) extension and # will exit and proceed in the
dialplan.

ABE-2200


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@263769 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-18 18:54:58 +00:00
Mark Michelson
760f0a8a8b Fix logic error when checking for a devstate provider.
When using strsep, if one of the list of specified separators is not found,
it is the first parameter to strsep which is now NULL, not the pointer returned
by strsep.

This issue isn't especially severe in that the worst it is likely to do is waste
some cycles when a device with no '/' and no ':' is passed to ast_device_state.



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@263639 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-17 22:00:28 +00:00
Mark Michelson
109a363733 Remove arbitrary size limitation for hints.
(closes issue #17257)
Reported by: tim_ringenbach
Patches:
      hints_crash_fix.diff uploaded by tim ringenbach (license 540)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@263637 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-17 21:48:46 +00:00
Leif Madsen
6b3e946479 Manager cookies are not compatible with RFC2109.
The Version field in the cookies we're setting contain quotes around the version
number which is not compatible with RFC2109 and breaks some implementations.

(closes issue #17231)
Reported by: ecarruda
Patches:
      manager_rfc2109-trunk-v1.patch uploaded by ecarruda (license 559)
      manager_rfc2109-1.6.2-v1.patch uploaded by ecarruda (license 559)
Tested by: ecarruda, russell

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@263456 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-17 14:35:18 +00:00
Leif Madsen
a6b675ba39 Update link to new version of core sounds.
The latest version of the core sounds files 1.4.19 now includes the missing
queue-minute sound file which is called by app_queue but which has been
missing.

(closes issue #17123)
Reported by: n8ideas

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@263374 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-17 14:04:57 +00:00
David Vossel
0e37a19b92 backport of DAHDI buffer policy dial string option
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@263292 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-17 13:01:39 +00:00
Jeff Peeler
93a73ba6a7 Fix internal timing not working with Zaptel
dahdi_compat.h was not being included in channel.c when used with 
Zaptel and wasn't in file.c at all.

(closes issue #15250)
Reported by: mneuhauser
Patches: 
      dahdi_compat.patch uploaded by mneuhauser (license 425)
Tested by: IgorG


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@263112 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-13 23:08:13 +00:00
David Vossel
dbcb9d1577 fixes app_meetme dsp error
We attempted to detect silence after translating a frame
from signed linear.  This caused a flooding of errors.  To
resolve this the code to detect silence was moved before the
translation.

(closes issue #17133)
Reported by: jsdyer



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@262662 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-12 17:00:04 +00:00
Jason Parker
1f91e893eb Use a less silly method for modifying a flex-generated file.
The sed syntax that was used wasn't actually valid, causing some versions to
choke.  This is the method that is used in 1.6.x+ for similar changes.

(closes issue #16696)
Reported by: bklang
Patches: 
      16696-sedfix.diff uploaded by qwell (license 4)
Tested by: qwell


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@262421 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-11 19:55:42 +00:00
Tilghman Lesher
98c114f991 Fix issue #17302 a slightly different way (mad props to Qwell)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@262321 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-11 17:22:07 +00:00
Tilghman Lesher
921f7c3ef8 Allow compilation on Mac OS X 10.4 (Tiger)
(closes issue #17297)
 Reported by: jcovert
 Patches: 
       20100506__issue17297.diff.txt uploaded by tilghman (license 14)

(closes issue #17302)
 Reported by: jcovert


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@262151 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-10 16:34:21 +00:00
Jeff Peeler
2edad509ce Only allow the operator key to be accepted after leaving a voicemail.
Or rather disallow the operator key from being accepted when not offered,
such as after finishing a recording from within the mailbox options menu.

ABE-2121
SWP-1267


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@261735 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-06 20:10:59 +00:00
Jeff Peeler
544c49c200 Revert 261698, code in trunk leads me to believe unadvertised options are supported.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@261699 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-06 18:47:28 +00:00
Jeff Peeler
7fd6beb054 Remove some hidden broken code in the voicemail mailbox options menu.
After finishing a recording from within the mailbox options menu, pressing 0
exhibited strange behavior with operator=yes turned on. Pressing 0 was not
even advertised as an option and the options from the vm-saveoper prompt:
"Press 1 to accept this recording. Otherwise, please continue to hold" did
not function correctly. While this of course could be fixed, it didn't really
seem to make sense even if it was working properly.

ABE-2121
SWP-1267


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@261698 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-06 18:39:06 +00:00
Jason Parker
ae6e5fa31d Use the versioned MOH tarballs, now that we have them.
This makes for more reproducibility.  Prompted by a discussion in #asterisk-dev


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@261608 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-06 16:56:02 +00:00
Paul Belanger
07dbb0f074 Registration fix for SIP realtime.
Make sure realtime fields are not empty.

(closes issue #17266)
Reported by: Nick_Lewis
Patches:
      chan_sip.c-realtime.patch uploaded by Nick Lewis (license 657)
Tested by: Nick_Lewis, sberney

Review: https://reviewboard.asterisk.org/r/643/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@261274 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-05 16:42:22 +00:00
Tilghman Lesher
c842507c3e Add a tiny corner case to the previous commit
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@261094 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-04 23:47:08 +00:00
Tilghman Lesher
6acbf688e6 Protect against overflow, when calculating how long to wait for a frame.
(closes issue #17128)
 Reported by: under
 Patches: 
       d.diff uploaded by under (license 914)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@261093 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-04 23:36:53 +00:00
Jeff Peeler
8e05e30a2d Voicemail transfer to operator should occur immediately, not after main menu.
There were two scenarios in the advanced options that while using the
operator=yes and review=yes options, the transfer occurred only after exiting
the main menu (after sending a reply or leaving a message for an extension).
Now after the audio is processed for the reply or message the transfer occurs
immediately as expected.

ABE-2107
ABE-2108



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@260923 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-04 18:46:46 +00:00
Tim Ringenbach
73c6d27e33 Fix FILTER() examples to work in 1.4
Review: https://reviewboard.asterisk.org/r/644/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@260887 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-04 17:40:59 +00:00
Jason Parker
b683fb2e4e Fix fallout from removing from configure script. Pointed out by philipp64 on #asterisk-dev
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@260801 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-05-04 15:49:27 +00:00