Commit Graph

33335 Commits

Author SHA1 Message Date
George Joseph
7159cd2ad3 .github: Fix recheck label typos 2023-07-07 13:31:53 -06:00
George Joseph
6c9c68cb86 .github: Fix recheck label manipulation 2023-07-07 13:31:53 -06:00
George Joseph
af2abdbae6 .github: Allow PR submit checks to be re-run by label 2023-07-07 13:31:53 -06:00
Ben Ford
aba7168abe res_pjsip_session: Added new function calls to avoid ABI issues.
Added two new functions (ast_sip_session_get_dialog and
ast_sip_session_get_pjsip_inv_state) that retrieve the dialog and the
pjsip_inv_state respectively from the pjsip_inv_session on the
ast_sip_session struct. This is due to pjproject adding a new field to
the pjsip_inv_session struct that caused crashes when trying to access
fields that were no longer where they were expected to be if a module
was compiled against a different version of pjproject.

Resolves: #145
2023-07-07 13:31:53 -06:00
George Joseph
818e53184c test_statis_endpoints: Fix channel_messages test again 2023-07-07 13:31:53 -06:00
George Joseph
53d3f8892d test_stasis_endpoints.c: Make channel_messages more stable
The channel_messages test was assuming that stasis would return
messages in a specific order.  This is an incorrect assumption as
message ordering was never guaranteed.  This was causing the test
to fail occasionally.  We now test all the messages for the
required message types instead of testing one by one.

Resolves: #158
2023-07-07 13:31:53 -06:00
George Joseph
86bad8f550 build: Fix a few gcc 13 issues
* gcc 13 is now catching when a function is declared as returning
  an enum but defined as returning an int or vice versa.  Fixed
  a few in app.h, loader.c, stasis_message.c.

* gcc 13 is also now (incorrectly) complaining of dangling pointers
  when assigning a pointer to a local char array to a char *. Had
  to change that to an ast_alloca.

Resolves: #155
2023-07-07 13:31:53 -06:00
George Joseph
aa87a29100 .github: Rework for merge approval 2023-07-07 13:31:53 -06:00
Ben Ford
0799c3d099 AMI: Add CoreShowChannelMap action.
Adds a new AMI action (CoreShowChannelMap) that takes in a channel name
and provides a list of all channels that are connected to that channel,
following local channel connections as well.

Resolves: #104

UserNote: New AMI action CoreShowChannelMap has been added.
2023-07-07 13:31:53 -06:00
George Joseph
c857cbc8f1 .github: Fix issues with cherry-pick-reminder 2023-07-07 13:31:53 -06:00
Mike Bradeen
79e4c7e370 indications: logging changes
Increase verbosity to indicate failure due to missing country
and to specify default on CLI dump

Resolves: #89
2023-07-07 13:31:53 -06:00
George Joseph
348228565d .github Ignore error when adding reviewrs to PR 2023-07-07 13:31:53 -06:00
George Joseph
6ba174263f .github: Update field descriptions for AsteriskReleaser 2023-07-07 13:31:53 -06:00
George Joseph
f26641b997 .github: Change title of AsteriskReleaser job 2023-07-07 13:31:53 -06:00
George Joseph
1971b06e04 .github: Don't add cherry-pick reminder if it's already present 2023-07-07 13:31:53 -06:00
George Joseph
8d59e19fce .github: Fix quoting in PROpenedOrUpdated 2023-07-07 13:31:53 -06:00
George Joseph
729542902d .github: Add cherry-pick reminder to new PRs 2023-07-07 13:31:53 -06:00
Sean Bright
a554cfe062 core: Cleanup gerrit and JIRA references. (#40) (#61)
* Remove .gitreview and switch to pulling the main asterisk branch
  version from configure.ac instead.

* Replace references to JIRA with GitHub.

* Other minor cleanup found along the way.

Resolves: #39
2023-07-07 13:31:53 -06:00
Joshua C. Colp
31eeb9d068 .github: Tweak improvement issue type language. 2023-07-07 13:31:53 -06:00
Gitea
08c709d7c5 .github: Tweak new feature language, and move feature requests elsewhere. 2023-07-07 13:31:53 -06:00
Joshua C. Colp
1908567695 .github: Fix staleness check to only run on certain labels. 2023-07-07 13:31:53 -06:00
George Joseph
5cca713eda .github: Add AsteriskReleaser 2023-07-07 13:31:53 -06:00
Mike Bradeen
5d225cfa1c cel: add local optimization begin event
The current AST_CEL_LOCAL_OPTIMIZE event is and has been
triggered on a local optimization end to serve as a flag
indicating the event occurred.  This change adds a second
AST_CEL_LOCAL_OPTIMIZE_BEGIN event for further detail.

Resolves: #52

UpgradeNote: The existing AST_CEL_LOCAL_OPTIMIZE can continue
to be used as-is and the AST_CEL_LOCAL_OPTIMIZE_BEGIN event
can be ignored if desired.

UserNote: The new AST_CEL_LOCAL_OPTIMIZE_BEGIN can be used
by itself or in conert with the existing
AST_CEL_LOCAL_OPTIMIZE to book-end local channel optimizaion.
2023-07-07 13:31:53 -06:00
George Joseph
1ab4a01397 .github: Fix CherryPickTest to only run when it should
Fixed CherryPickTest so it triggers only on the
"cherry-pick-test" label instead of all labels.
2023-07-07 13:31:53 -06:00
George Joseph
d34fb9d393 .github: Fix reference to CHERRY_PICK_TESTING_IN_PROGRESS 2023-07-07 13:31:53 -06:00
George Joseph
96b5db5d2c .github: Remove separate set labels step from new PR 2023-07-07 13:31:53 -06:00
George Joseph
2be80ff944 .github: Refactor CP progress and add new PR test progress 2023-07-07 13:31:53 -06:00
George Joseph
e3d18b6f45 .github: Add cherry-pick test progress labels 2023-07-07 13:31:52 -06:00
George Joseph
9875f3472e .github: Update issue templates 2023-07-07 13:31:52 -06:00
George Joseph
f0789ba2cb .github: Remove unnecessary parameter in CherryPickTest 2023-07-07 13:31:52 -06:00
George Joseph
21a2ee2a48 Initial GitHub PRs 2023-07-07 13:31:52 -06:00
George Joseph
8bcf6c298c Initial GitHub Issue Templates 2023-07-07 13:31:52 -06:00
George Joseph
730bf4a8b4 test.c: Fix counting of tests and add 2 new tests
The unit test XML output was counting all registered tests as "run"
even when only a subset were actually requested to be run and
the "failures" attribute was missing.

* The "tests" attribute of the "testsuite" element in the
  output XML now reflects only the tests actually requested
  to be executed instead of all the tests registered.

* The "failures" attribute was added to the "testsuite"
  element.

Also added 2 new unit tests that just pass and fail to be
used for CI testing.

Change-Id: Ia137814b5aeb0e1a44c75034bd3615c26021da69
2023-07-07 13:31:52 -06:00
Mike Bradeen
c8c528e9d3 res_mixmonitor: MixMonitorMute by MixMonitor ID
While it is possible to create multiple mixmonitor instances
on a channel, it was not previously possible to mute individual
instances.

This change includes the ability to specify the MixMonitorID
when calling the manager action: MixMonitorMute.  This will
allow an individual MixMonitor instance to be muted via id.
This id can be stored as a channel variable using the 'i'
MixMonitor option.

As part of this change, if no MixMonitorID is specified in
the manager action MixMonitorMute, Asterisk will set the mute
flag on all MixMonitor spy-type audiohooks on the channel.
This is done via the new audiohook function:
ast_audiohook_set_mute_all.

ASTERISK-30464

Change-Id: Ibba8c7e750577aa1595a24b23316ef445245be98
2023-07-07 13:31:52 -06:00
Mike Bradeen
266c79dbfc format_sln: add .slin as supported file extension
Adds '.slin' to existing supported file extensions:
.sln and .raw

ASTERISK-30465

Change-Id: Ice848addc03a64c8404b87cb5d3b13399c57e496
2023-07-07 13:31:52 -06:00
Mike Bradeen
d94555b4f4 bridge_builtin_features: add beep via touch variable
Add periodic beep option to one-touch recording by setting
the touch variable TOUCH_MONITOR_BEEP or
TOUCH_MIXMONITOR_BEEP to the desired interval in seconds.

If the interval is less than 5 seconds, a minimum of 5
seconds will be imposed.  If the interval is set to an
invalid value, it will default to 15 seconds.

A new test event PERIODIC_HOOK_ENABLED was added to the
func_periodic_hook hook_on function to indicate when
a hook is started.  This is so we can test that the touch
variable starts the hook as expected.

ASTERISK-30446

Change-Id: I800e494a789ba7a930bbdcd717e89d86040d6661
2023-07-07 13:31:52 -06:00
Mike Bradeen
ba51bb6089 cli: increase channel column width
For 'core show channels', the Channel name field is increased
to 64 characters and the Location name field is increased to
32 characters.

For 'core show channels verbose', the Channel name field is
increased to 80 characters, the Context is increased to 24
characters and the Extension is increased to 24 characters.

ASTERISK-30455

Change-Id: Ibec3742ce360ffc93bc56e9984c2a21dabc4d5e1
2023-07-07 13:31:52 -06:00
Mike Bradeen
5b76e3cdee app_senddtmf: Add option to answer target channel.
Adds a new option to SendDTMF() which will answer the specified
channel if it is not already up. If no channel is specified, the
current channel will be answered instead.

ASTERISK-30422

Change-Id: Iddcbd501fcdf9fef0f453b7a8115a90b11f1d085
(cherry picked from commit f015d3e0cc)
2023-07-07 13:31:52 -06:00
Mike Bradeen
59bcdad4d5 app_directory: Add a 'skip call' option.
Adds 's' option to skip calling the extension and instead set the
extension as DIRECTORY_EXTEN channel variable.

ASTERISK-30405

Change-Id: Ib9d9db1ba5b7524594c640461b4aa8f752db8299
2023-07-07 13:31:52 -06:00
Mike Bradeen
8e8a188a8c app_read: Add an option to return terminator on empty digits.
Adds 'e' option to allow Read() to return the terminator as the
dialed digits in the case where only the terminator is entered.

ie; if "#" is entered, return "#" if the 'e' option is set and ""
if it is not.

ASTERISK-30411

Change-Id: I49f3221824330a193a20c660f99da0f1fc2cbbc5
2023-07-07 13:31:52 -06:00
Mike Bradeen
64afaeb72a app_directory: add ability to specify configuration file
Adds option to app_directory to specify a filename from which to
read configuration instead of voicemail.conf ie;

same => n,Directory(,,c(directory.conf))

This configuration should contain a list of extensions using the
voicemail.conf format, ie;

2020=2020,Dog Dog,,,,attach=no|saycid=no|envelope=no|delete=no

ASTERISK-30404

Change-Id: Id58ccb1344ad1e563fa10db12f172fbd104a9d13
(cherry picked from commit ef6901e137)
2023-07-07 13:31:52 -06:00
Asterisk Development Team
8a6ee89571 Update for certified/18.9-cert4 certified-18.9-cert4 certified/18.9-cert4 2023-01-19 06:33:44 -05:00
George Joseph
dda609c9df res_pjsip_transport_websocket: Add remote port to transport
When Asterisk receives a new websocket conenction, it creates a new
pjsip transport for it and copies connection data into it.  The
transport manager then uses the remote IP address and port on the
transport to create a monitor for each connection.  However, the
remote port wasn't being copied, only the IP address which meant
that the transport manager was creating only 1 monitoring entry for
all websocket connections from the same IP address. Therefore, if
one of those connections failed, it deleted the transport taking
all the the connections from that same IP address with it.

* We now copy the remote port into the created transport and the
  transport manager behaves correctly.

ASTERISK-30369

Change-Id: Ib506d40897ea6286455ac0be4dfbb0ed43b727e1
2022-12-23 05:32:04 -07:00
Joshua C. Colp
c20750bbaf res_pjsip_transport_websocket: Also set the remote name.
As part of PJSIP 2.11 a behavior change was done to require
a matching remote hostname on an established transport for
secure transports. Since the Websocket transport is considered
a secure transport this caused the existing connection to not
be found and used.

We now set the remote hostname and the transport can be found.

ASTERISK-30065

Change-Id: Ia1cdef33e1411f927985b4b852c95e163c080e94
2022-12-23 05:31:55 -07:00
Alexandre Fournier
646a9a7ec6 res_geoloc: fix NULL pointer dereference bug
The `ast_geoloc_datastore_add_eprofile` function does not return 0 on
success, it returns the size of the underlying datastore. This means
that the datastore will be freed and its pointer set to NULL when no
error occured at all.

ASTERISK-30346

Change-Id: Iea9b209bd1244cc57b903b9496cb680c356e4bb9
2022-12-13 10:32:27 -05:00
Asterisk Development Team
1196d4b5d3 Update for certified/18.9-cert3 certified/18.9-cert3 2022-12-01 15:11:36 -05:00
Asterisk Development Team
4e9c0bc880 Update CHANGES and UPGRADE.txt for certified/18.9-cert3 2022-12-01 14:54:03 -05:00
Asterisk Development Team
28a23f6595 Update for certified/18.9-cert3 2022-12-01 13:52:55 -06:00
Mike Bradeen
de142180a3 ooh323c: not checking for IE minimum length
When decoding q.931 encoded calling/called number
now checking for length being less than minimum required.

ASTERISK-30103

Change-Id: I3dcfce0f35eca258dc450f87c92d4d7af402c2e7
2022-12-01 11:55:57 -06:00
Mike Bradeen
2285ffd5eb manager: prevent file access outside of config dir
Add live_dangerously flag to manager and use this flag to
determine if a configuation file outside of AST_CONFIG_DIR
should be read.

ASTERISK-30176

Change-Id: I46b26af4047433b49ae5c8a85cb8cda806a07404
2022-12-01 11:54:17 -06:00