Commit Graph

2335 Commits

Author SHA1 Message Date
Joshua Colp
8765a9d73a Merged revisions 92937 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r92937 | file | 2007-12-14 11:16:15 -0400 (Fri, 14 Dec 2007) | 4 lines

Up the length of the format on the SIP channel since it can now be rather long.
(closes issue #11552)
Reported by: francesco_r

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92938 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-14 15:18:10 +00:00
Jason Parker
a19a3f493c Remove remnants of a poorly merged commit. (92697)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92758 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-13 16:23:50 +00:00
Jason Parker
78465ad2a3 Merged revisions 92696 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

(closes issue #10690)
........
r92696 | qwell | 2007-12-12 18:11:09 -0600 (Wed, 12 Dec 2007) | 7 lines

If a typo is found in a config file, we previous continued on with what was already loaded.
We do not want to do this (see bug below for details).

This makes it so that if a [ is found without a ], the entire config will fail, and nothing in it will be loaded.

Issue 10690.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92697 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-13 00:18:04 +00:00
Jason Parker
b0968803b9 We need to set the address we want to match against before we actually do the match..
Closes issue #11518.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92421 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-11 21:58:26 +00:00
Olle Johansson
36270ad02b Removing some LOG_DEBUG items
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92160 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-10 14:18:21 +00:00
Olle Johansson
2e286ba797 Merged revisions 92158 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r92158 | oej | 2007-12-10 15:04:44 +0100 (MÃ¥n, 10 Dec 2007) | 16 lines

Avoid reinvite race situations with two Asterisks trying
to reinvite each other in 1.4 and trunk. 

This patch implements support for the 491 error code that
Asterisk 1.4 generates on situations where we get an 
incoming INVITE and already has one in progress.

Thanks to mavetju for reporting and to Raj Jain for an
excellent explanation of the problem.

Patch by myself. Tested with 8 Asterisk servers connected
to each other in a training network.

Closes issue #10481


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92159 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-10 14:10:24 +00:00
Jason Parker
a214f02b32 Fix a small typo in a comment.
Closes issue #11490


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@91782 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-07 16:37:36 +00:00
Joshua Colp
45dfc612de Merged revisions 91439 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r91439 | file | 2007-12-06 12:14:26 -0400 (Thu, 06 Dec 2007) | 4 lines

Add support for accepting and sending T.38 in the initial INVITE.
(closes issue #9402)
Reported by: thdei

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@91440 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-06 16:18:49 +00:00
Olle Johansson
0cc002a48a Rename "username" to "defaultuser" to match with "defaultip".
"Username" still works, but is deprecated.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@91152 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-05 13:09:47 +00:00
Olle Johansson
10d047737f Remove the cseqs from "sip show channel" and make more place for the call ID.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@91151 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-05 12:58:12 +00:00
Jason Parker
3f677a718a Add manager action 'sipshowregistry'.
Closes issue #11464, patch by eliel.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@90991 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-04 21:23:30 +00:00
Joshua Colp
4a5b8ad6b3 Merged revisions 90269 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r90269 | file | 2007-11-30 10:43:15 -0400 (Fri, 30 Nov 2007) | 6 lines

Fix locking issues under one legged replaces scenarios.
(closes issue #11420)
Reported by: irroot
Patches:
      chan_sip_oneleg.patch uploaded by irroot (license 52)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@90270 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-30 14:45:36 +00:00
Russell Bryant
062327c960 remove a duplicate manager event
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89710 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-27 20:17:36 +00:00
Olle Johansson
09e1c572d8 Starting to merge changes from the "moremanager" branch. Documentation will
follow.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89702 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-27 19:45:39 +00:00
Olle Johansson
df7ba90b20 The following patch with updates for trunk. Works much better in trunk.
Also by accident fixed a bad typo by a previous committer, which actually made video calls
not work fully...

Merged revisions 89630 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89630 | oej | 2007-11-27 16:23:17 +0100 (Tis, 27 Nov 2007) | 12 lines

If we get a codec offer using a well-known payload type, but using it for another
codec that we don't know, Asterisk did not remove that codec from the list.

With this patch, we remove the codec from audio and video rtp objects and
deny it ever existed. Thanks to lasse for testing.

(closes issue #11376)
Reported by: lasse
Patches: 
      bug11376.txt uploaded by oej (license 306)
Tested by: lasse

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89698 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-27 19:24:17 +00:00
Olle Johansson
11df6a9119 Rename "limitonpeer" to "counteronpeer" since the call-limit is deprecated.
Both still works in this version.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89613 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-26 21:23:48 +00:00
Olle Johansson
5070d10864 Formatting, doxygenification
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89611 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-26 21:12:50 +00:00
Olle Johansson
96ad455115 Formatting changes, cleaning up some code
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89609 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-26 20:55:09 +00:00
Olle Johansson
d4863bb0f0 Start using Doxygen groupings to group variables and defines.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89607 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-26 20:19:50 +00:00
Joshua Colp
71c602a2d1 Instead of printing out one codec in sip show channels print out all of the native ones (this is for video).
(closes issue #11366)
Reported by: ovi


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89573 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-26 14:50:51 +00:00
Tilghman Lesher
c8edf66bb4 Typo (someone needs to test compile before committing his changes)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89560 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-25 17:44:16 +00:00
Olle Johansson
debdfd958c More doxygen changes
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89557 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-25 12:18:35 +00:00
Olle Johansson
b380467388 Housekeeping
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89556 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-25 12:12:00 +00:00
Olle Johansson
a2c95022ac Formatting, doxygen updates
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89555 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-25 12:06:57 +00:00
Olle Johansson
07cb09ad86 - Deprecate "call-limit" in chan_sip. No other channel driver enforces call-limits
and we now have the groupcount system to implement call-limits in the dialplan. You
  can use the "setvar" option in realtime/sip.conf to set limits per device.

- Implement "callcounter" as a new option to enable the call counting we need to
  report device status to queue, manager and SIP subscriptions.

The call counter setting is now enabled in the code by setting the device call-limit
to 999. When we remove the call limit, we can simply enable this with a boolean
setting.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89554 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-25 11:46:17 +00:00
Olle Johansson
77e15c9b2f Housekeeping...
- Fix typo in chan_sip
- Remove changes to caller ID structure, moving it to branch (russellb)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89551 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-25 11:10:52 +00:00
Luigi Rizzo
87b633b71e set rtpmap video info according to what is read from SDP;
make the format explicit in a debug message;

print the audio instead of aggregated peer capability in a debugging msg.




git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89532 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-23 15:49:40 +00:00
Steve Murphy
86476c607f closes issue #11285, where an unload of a module that creates a dialplan context, causes a crash when you do a 'dialplan show' of that context. This is because the registrar string is defined in the module, and the stale pointer is traversed. The reporter offered a patch that would always strdup the registrar string, which is practical, but I preferred to destroy the created contexts in each module where one is created. That seemed more symmetric. There were only 6 place in asterisk where this is done: chan_sip, chan_iax2, chan_skinny, res_features, app_dial, and app_queue. The two apps destroyed the context, but left the contexts. All is fixed now and unloads should be dialplan friendly.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89513 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 23:54:12 +00:00
Luigi Rizzo
7e8835e0d7 remove another set of redundant #include "asterisk/options.h"
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89512 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 23:24:55 +00:00
Luigi Rizzo
a23c055c3d move asterisk/paths.h outside asterisk.h and into those files
who really need it.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89466 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-20 23:16:15 +00:00
Olle Johansson
28531cde08 Fix sip show history.
Closes issue #11312


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89446 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-20 14:44:26 +00:00
Olle Johansson
308646f8ef Change terminology a bit for CLI commands handling SIP channels/calls/dialogs/whatever.
Closes issue #11312


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89444 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-20 08:36:32 +00:00
Mark Michelson
fb3b4f4937 Changed the "busy-level" option in sip.conf to "busylevel" to be more parallel
with the SIPPEER() argument of the same name. The deprecation procedure is not
being used here since this is a trunk-only option.

(closes issue #11307, reported by pj, patched by me)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89441 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-19 23:24:35 +00:00
Tilghman Lesher
0aa40f1366 Change delimiter of SIPPEER to be comma (instead of pipe) and further deprecate the old ':' delimiter
Reported by: pj
Patch by: tilghman
Closes issue #11305


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89429 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-19 20:13:40 +00:00
Luigi Rizzo
0595b5e2aa include "logger.h" and errno.h from asterisk.h - usage shows that they
were included almost everywhere.
Remove some of the instances.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89424 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-19 18:52:04 +00:00
Olle Johansson
743d3774d7 Adding busy-level to the SIP_PEER() dialplan function.
With this, you can control the peer in the dialplan, so you avoid placing outbound
calls when the device has reached busy-level.
Reported by pj.

Closes bug #11180



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89406 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-19 09:12:27 +00:00
Olle Johansson
1dc6524449 Make some notes about a problem I found with the OPTIONs handler while working with
the bug tracker. Since we don't authenticate devices (peers/users) on OPTIONS we don't
have the proper context set for the user/peer. 

However, we might not want to process an authentication for every OPTIONS, so we could
have a config option for this, "optionsforceok" to always answer 200 OK on the request
and not check device or destination, nor add a SDP. If Asterisk sends the OPTIONs request,
it doesn't care about the reply. Some devices use OPTIONs to discover capabilities,
since we should answer like an INVITE from the device and we need to support that properly
too, which we don't today.

So much to do :-)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89404 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-19 08:34:26 +00:00
Luigi Rizzo
5663ff6518 fix breakage induced by previous mistake
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89382 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-17 14:45:46 +00:00
Luigi Rizzo
4afe3b5ba9 remove redundant #include "asterisk/compat.h",
but make sure that asterisk/compiler.h is included everywhere



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89336 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-16 21:08:28 +00:00
Luigi Rizzo
fdb7f7ba3d Start untangling header inclusion in a way that does not affect
build times - tested, there is no measureable difference before and
after this commit.

In this change:

use asterisk/compat.h to include a small set of system headers:
inttypes.h, unistd.h, stddef.h, stddint.h, sys/types.h, stdarg.h,
stdlib.h, alloca.h, stdio.h

Where available, the inclusion is conditional on HAVE_FOO_H as determined
by autoconf.

Normally, source files should not include any of the above system headers,
and instead use either "asterisk.h" or "asterisk/compat.h" which does it
better. 

For the time being I have left alone second-level directories
(main/db1-ast, etc.).



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89333 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-16 20:04:58 +00:00
Joshua Colp
e7e208009f And file said... let trunk build again! Accomplished by some more constification, and marking a function in chan_sip as purposely unused until it is fixed up.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89290 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-15 15:21:04 +00:00
Olle Johansson
8740176dc3 Always relying on the responses when crossing NAT's are not a good
solution, it breaks communication.
Rizzo - you need to implement a configuration option for this 
code. It's good, but maybe should be off by default.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89285 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-15 12:21:57 +00:00
Olle Johansson
a4ce44bda4 Merged revisions 89281 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89281 | oej | 2007-11-15 12:26:22 +0100 (Tor, 15 Nov 2007) | 6 lines

Don't send re-invites during pending INVITE transactions.

Patch by one47 - thanks!

Closes issue #9305

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89283 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-15 11:31:27 +00:00
Olle Johansson
c698e39245 Merged revisions 89280 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89280 | oej | 2007-11-15 12:15:09 +0100 (Tor, 15 Nov 2007) | 5 lines

Improve support for multipart messages. Code by gasparz, changes
by me (mostly formatting). Thanks, gasparz!

Closes issue #10947

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89282 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-15 11:27:19 +00:00
Olle Johansson
257b4fb41e Exit early instead of deciding to exit after processing the message.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89279 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-15 10:26:00 +00:00
Olle Johansson
eab6b00904 Add support for application/dtmf SIP INFO dtmf handling. Yep, another
way of handling DTMF in SIP. Totally undocumented, but implemented
in enough devices so we have to support it. 

Code by sergee, small changes by oej.

Closes issue #11049


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89278 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-15 10:21:41 +00:00
Luigi Rizzo
7f8ecd2cd3 make the 'name' and 'value' fields in ast_variable const char *
This prevents modifying the strings in the stored variables, 
and catched a few instances where this was actually done.

Given the differences between trunk and 1.4 (and the fact that this
is effectively an API change) it is better to fix 1.4 independently.
These are

chan_sip.c::sip_register()
chan_skinny.c:: near line 2847
config.c:: near line 1774
logger.c::make_components()
res_adsi.c:: near line 1049

I may have missed some instances for modules that do not build here.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89268 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-14 13:18:40 +00:00
Russell Bryant
50426062b7 - Convert initialization of a struct to C99 style instead of GNU style
- Fix a minor spelling error in a comment


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89251 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-13 20:53:49 +00:00
Tilghman Lesher
f821071748 Merged revisions 89246 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89246 | tilghman | 2007-11-13 11:34:11 -0600 (Tue, 13 Nov 2007) | 2 lines

If we set a value for qualify, we should actually pay attention to it, instead of overriding the value

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89247 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-13 17:41:02 +00:00
Tilghman Lesher
061e5a1674 Merged revisions 89184 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89184 | tilghman | 2007-11-12 11:29:17 -0600 (Mon, 12 Nov 2007) | 5 lines

Fix two cases of memory corruption caused by background threads.
Reported by: atis
Patch by: tilghman
Fixes issue #10923

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89185 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-12 17:44:04 +00:00