Commit Graph

1472 Commits

Author SHA1 Message Date
Olle Johansson
5b52f69201 When adding new functions, please add a forward declaration.
I *know* it is not required, but it makes navigation easier and will help
when splitting up this large source code file. 

Thank you!


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45209 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-16 13:20:21 +00:00
Olle Johansson
43505df9f4 Importing rev 45196 from 1.4 - don't kill dialog for a bad response
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45204 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-16 13:03:02 +00:00
Olle Johansson
09b8583937 A B2BUA should *not* issue proxy auth.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45194 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-16 12:28:18 +00:00
Joshua Colp
e1bb0dab37 Merged revisions 45040 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r45040 | file | 2006-10-13 12:01:17 -0400 (Fri, 13 Oct 2006) | 2 lines

Complete merging in RPID screen changes (issue #8101 reported by hristo, patch by oej in revision 44757)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45047 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-13 16:02:27 +00:00
Luigi Rizzo
e1378c470f Try to avoid the use of 'z' modifier in cases where it is not
necessary - rather, cast the argument to int.

In this case, the string is in a UDP packet and as such
limited to 64k so its length can be safely represented in an int
without truncation (besides, this is just a debugging message!)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45010 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-13 11:18:01 +00:00
Luigi Rizzo
1fe21371a3 arguments to auth_headers() needed to be swapped here.
To avoid the same mistake in the future (due to slightly
confusing variable names), add a comment.

On passing, remove a redundant initialization.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45009 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-13 11:11:19 +00:00
Kevin P. Fleming
49b0cc8c94 eliminate compiler warning
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44973 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-12 19:16:16 +00:00
Kevin P. Fleming
0ecfae3dbd Merged revisions 44971 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r44971 | kpfleming | 2006-10-12 14:14:24 -0500 (Thu, 12 Oct 2006) | 2 lines

we can only send one 'a=ptime' attribute per media session, not one for each format

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44972 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-12 19:15:25 +00:00
Kevin P. Fleming
035aeb82e4 Merged revisions 44956 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r44956 | kpfleming | 2006-10-12 13:38:51 -0500 (Thu, 12 Oct 2006) | 10 lines

Merged revisions 44955 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r44955 | kpfleming | 2006-10-12 13:31:26 -0500 (Thu, 12 Oct 2006) | 2 lines

ensure that IAX2 and SIP sockets allow UDP fragmentation when running on Linux (thanks to Brian Candler on the asterisk-dev list for the tip)

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44957 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-12 18:43:52 +00:00
Luigi Rizzo
97ac6793c7 + move [almost] all instances of WWW-Authenticate/Proxy-Authenticate
and friends in a function, auth_headers(), which is used to
  simplify the interface of do_{proxy|register}_auth().
 
+ use PROXY_AUTH = 407, WWW_AUTH = 401 as values for enum sip_auth_type;

No functional change, only code cleanup.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44933 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-12 15:12:54 +00:00
Luigi Rizzo
59e61ae4a0 reduce indentation of two large blocks
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44901 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-11 23:36:25 +00:00
Luigi Rizzo
6d6e60be79 operator != also works between booleans...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44900 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-11 23:26:44 +00:00
Russell Bryant
9e2abab8fa Revert Luigi's accidental commit of his local changes when debugging some SIP
authentication issues.  This was committed in revision 44844, where the commit
message was just "small formatting cleanup", so I am pretty sure he didn't mean
to commit this part.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44876 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-11 13:38:37 +00:00
Luigi Rizzo
328e1c9d1c remove duplicate prototypes. Have not checked if there are more.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44875 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-11 13:21:33 +00:00
Luigi Rizzo
ed683ccc2a simplify and comment handle_response_peerpoke()
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44874 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-11 13:12:31 +00:00
Luigi Rizzo
312fd57758 fix indentation of a function after previous commit
(whitespace-only change)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44865 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-11 12:24:57 +00:00
Luigi Rizzo
2eeaeaa7a7 handle_response_peerpoke() does not need to return anything.
(Reindentation in the next commit.)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44853 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-11 09:17:05 +00:00
Luigi Rizzo
510b9f04c0 small formatting cleanup
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44844 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-11 08:56:09 +00:00
Joshua Colp
832014a91b Merged revisions 44819 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r44819 | file | 2006-10-10 13:21:44 -0400 (Tue, 10 Oct 2006) | 2 lines

Move some stuff around so that a NOTIFY dialog won't hang around until the end of the world under certain circumstances

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44820 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-10 17:23:14 +00:00
Joshua Colp
1eedc8af43 Merged revisions 44806 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r44806 | file | 2006-10-10 12:30:00 -0400 (Tue, 10 Oct 2006) | 2 lines

Bail out if we have no refer structure and we get a refer response

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44807 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-10 16:31:05 +00:00
Joshua Colp
fadc6c4ed7 Merged revisions 44788 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r44788 | file | 2006-10-10 11:23:14 -0400 (Tue, 10 Oct 2006) | 2 lines

Only set DTMF information if an RTP structure exists

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44789 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-10 15:25:05 +00:00
Luigi Rizzo
06fab1382b clarify the use of the standard SIP port number, 5060,
and rename the old DEFAULT_SIP_PORT as STANDARD_SIP_PORT
to make it clear that this is not something we can change,
unlike other defaults.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44774 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-10 08:08:35 +00:00
Luigi Rizzo
15fcc45c4e improve formatting of SIP packets when dumped to the verbose
output stream, so it is easier to find them in the log.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44770 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-10 07:40:27 +00:00
Olle Johansson
d766095219 Being pedantic... "media" is easier to understand than "data" in the function name... :-)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44753 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-09 11:20:02 +00:00
Luigi Rizzo
853f7ed660 slightly restructure sipsock_read() removing a "goto"
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44752 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-09 09:04:30 +00:00
Luigi Rizzo
69af2cea2f use S_OR in one place
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44751 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-09 08:33:52 +00:00
Luigi Rizzo
ad63b4c7c1 update_call_counter(): indentation fixes and small simplifications
at the top of the function.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44750 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-08 23:26:10 +00:00
Luigi Rizzo
06ef2c1907 localize some variables and reduce nesting depth
(indentation will be fixed by a separate commit).



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44749 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-08 23:04:12 +00:00
Luigi Rizzo
dd2121b075 small simplification to initreqprep()
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44748 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-08 22:45:01 +00:00
Luigi Rizzo
36e4f62e7c Simplify function parse_request() using a single loop instead
of two very similar ones.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44747 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-08 22:20:35 +00:00
Luigi Rizzo
b90f91c3b4 do not dereference p if we know it is NULL.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44745 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-08 14:10:26 +00:00
Olle Johansson
1b64c41369 Fix some debug output for setsockopt for TOS
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44731 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-07 20:42:27 +00:00
Olle Johansson
259f0d76b6 - move definition of global_autoframing to the same place as other globals
- set initial value at load/reload
- Add questionmarks for someone to fill in for doxygen 


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44717 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-07 18:57:11 +00:00
Olle Johansson
12ef70f0c0 Add/change doxygen and comments
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44708 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-07 16:32:31 +00:00
Olle Johansson
9cc9c38250 Explain usage of DEFAULT_SIP_PORT
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44706 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-07 16:03:36 +00:00
Olle Johansson
64aae4a887 Do *NOT* use DEFAULT_SIP_PORT in these comparisions, since users may change
that, but the protocol clearly states that if we DO NOT mention a port it
is 5060. DEFAULT_SIP_PORT is whatever we default to listen to.

I believe it's the third time I revert a patch like this.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44697 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-07 15:38:18 +00:00
Luigi Rizzo
901a66c401 slightly restructure the code that computes the channel's name
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44675 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-07 12:50:42 +00:00
Luigi Rizzo
a1a5824869 put repeated code to set nat mode in a function.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44674 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-07 12:20:16 +00:00
Luigi Rizzo
bc1e5f77af put common code in a function to avoid repetitions.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44664 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-07 11:28:38 +00:00
Luigi Rizzo
b37dc86c74 remove hardwired usage of 5060, use DEFAULT_SIP_PORT instead
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44663 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-07 11:11:39 +00:00
Luigi Rizzo
e691246b6e improve and document function get_in_brackets(), introducing
a helper function find_closing_quote() of more general use.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44651 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-07 09:36:09 +00:00
Luigi Rizzo
6466c2ebf9 when possible, use ast_set2_flags instead of ast_set/ast_clr .
Also mark XXX some dubious places.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44641 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-07 08:56:59 +00:00
Luigi Rizzo
ccca5843fd Two things:
1. slightly rearrange/simplify the parsing of the argument in sip_register.
   This brings in a patch that has been in Mantis (5834)  for ages,
   and is the larger part of the commit;

2. implement the "contact" option for peers, similar to the one in users.conf:

   If you put a "contact" option with a non-empty argument (e.g. contact=123)
   in a peer section, asterisk will register with the provider as if you had a     

        register= username:secret@host/contact 

   line in the general section.

The latter is a very small is a new feature so i am not putting it
in the 1.4 branch, although the "contact" option in user.conf is
already in the 1.4 branch and so it wouldn't be too strange to
merge it.

Note that the implementation of "contact" is much simpler than
the one in 5834, and limited to a few lines in build_peer().



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44566 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-06 15:41:12 +00:00
Olle Johansson
cb127f4baa Remove deprecated "incominglimit" config option
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44545 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-06 09:01:09 +00:00
Joshua Colp
0b26b56316 Merged revisions 44486 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r44486 | file | 2006-10-05 14:01:51 -0400 (Thu, 05 Oct 2006) | 2 lines

One more T.38 fix! Don't leave a reinvite hanging by a thread if the other side is already setup with T.38

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44487 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-05 18:03:34 +00:00
Joshua Colp
9924c3e2e9 Merged revisions 44450 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r44450 | file | 2006-10-04 22:40:40 -0400 (Wed, 04 Oct 2006) | 2 lines

Don't totally bail out if T.38 was negotiated

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44451 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-05 02:43:07 +00:00
Kevin P. Fleming
975ef9de9d Merged revisions 44433 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r44433 | kpfleming | 2006-10-04 20:30:05 -0500 (Wed, 04 Oct 2006) | 10 lines

Merged revisions 44432 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r44432 | kpfleming | 2006-10-04 20:27:57 -0500 (Wed, 04 Oct 2006) | 2 lines

fix Polycom presence notification again

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44434 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-05 01:30:44 +00:00
Kevin P. Fleming
50bcacbdbd Merged revisions 44393 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r44393 | kpfleming | 2006-10-04 16:17:30 -0500 (Wed, 04 Oct 2006) | 11 lines

Merged revisions 44392 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r44392 | kpfleming | 2006-10-04 16:15:29 -0500 (Wed, 04 Oct 2006) | 3 lines

remove workaround for old Polycom firmware SUBSCRIBE requests
add workaround for new Polycom firmware SUBSCRIBE requests (bug is known to exist in 2.0.1 firmware)

........

................


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44394 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-04 21:20:55 +00:00
Kevin P. Fleming
3c876af5cf Merged revisions 44378 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r44378 | kpfleming | 2006-10-04 14:47:22 -0500 (Wed, 04 Oct 2006) | 4 lines

update thread creation code a bit
reduce standard thread stack size slightly to allow the pthreads library to allocate the stack+data and not overflow a power-of-2 allocation in the kernel and waste memory/address space
add a new stack size for 'background' threads (those that don't handle PBX calls) when LOW_MEMORY is defined

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44379 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-04 19:51:38 +00:00
Joshua Colp
6727e8f599 Merged revisions 44284 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r44284 | file | 2006-10-03 14:35:55 -0400 (Tue, 03 Oct 2006) | 2 lines

Use VideoSupport instead so it is considered a valid XML attribute name. (issue #8075 reported by renemendoza)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@44285 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-03 18:37:06 +00:00