Commit Graph

6835 Commits

Author SHA1 Message Date
Terry Wilson
cd3b672f45 Merged revisions 306973 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r306973 | twilson | 2011-02-08 12:14:09 -0800 (Tue, 08 Feb 2011) | 9 lines
  
  Merged revisions 306972 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r306972 | twilson | 2011-02-08 12:05:13 -0800 (Tue, 08 Feb 2011) | 2 lines
    
    Fix comparison for REFER Replaces tags with pedantic=yes
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@306979 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-02-08 20:18:08 +00:00
Terry Wilson
4b54ce5ce5 Merged revisions 306618 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r306618 | twilson | 2011-02-07 13:59:54 -0800 (Mon, 07 Feb 2011) | 17 lines
  
  Merged revisions 306617 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r306617 | twilson | 2011-02-07 13:51:43 -0800 (Mon, 07 Feb 2011) | 10 lines
    
    Don't allow a REFER w/replaces to replace its own dialog
    
    Asterisk currently accepts a REFER with a Refer-To with an embedded Replaces
    header that matches the dialog of the REFER. This would be a situation like A
    calls B, A calls C, A transfers B to A, which is just silly. This patch makes
    the transfer fail instead of making Asterisk freak out and forget to hang other
    channels up.
    
    Review: https://reviewboard.asterisk.org/r/1093/
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@306619 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-02-07 22:15:27 +00:00
Jeff Peeler
6bb8cc3a9b Fix SIP deadlock involving state changes.
Once again a call to pbx_builtin_getvar_helper (and pbx_builtin_setvar_helper)
has caused locking problems. Both of these functions lock the channel when
the channel argument is passed in!

In this case, the suspected problem (the backtrace makes it impossible to tell)
was the private being locked in sip_set_rtp_peer and then:
transmit_reinvite_with_sdp
 try_suggested_sip_codec
   pbx_builtin_getvar_helper
(Traced to verify that the fix was only required in 1.8 and later.)

(closes issue #18491)
Reported by: cmaj
Patches: 
      chan_sip_fix_deadlocks_bug_18491.txt uploaded by cmaj (license 830)
Tested by: cmaj



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@306215 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-02-03 23:49:28 +00:00
Terry Wilson
5eca7e5bd5 Merged revisions 306126 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r306126 | twilson | 2011-02-03 12:56:00 -0800 (Thu, 03 Feb 2011) | 16 lines
  
  Merged revisions 306119 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r306119 | twilson | 2011-02-03 12:36:34 -0800 (Thu, 03 Feb 2011) | 9 lines
    
    Set hangup cause in local_hangup
    
    When a call involves a local channel (like SIP -> Local -> SIP), the hangup
    cause was not being set. This resulted in SIP channels sometimes getting a
    503 error instead of a 486 when the far side sent a busy. In Asterisk 1.8+
    this also can cause issues with CCSS that involve a local channel. This patch
    sets the hangupcause for one side of the local channel to the other in
    local_hangup for outbound calls.
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@306127 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-02-03 21:03:26 +00:00
Richard Mudgett
a785544090 Merged revisions 305889 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r305889 | rmudgett | 2011-02-02 18:15:07 -0600 (Wed, 02 Feb 2011) | 17 lines
  
  Merged revisions 305888 via svnmerge from
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r305888 | rmudgett | 2011-02-02 18:02:43 -0600 (Wed, 02 Feb 2011) | 8 lines
  
    Minor AST_FRAME_TEXT related issues.
  
    * Include the null terminator in the buffer length.  When the frame is
    queued it is copied.  If the null terminator is not part of the frame
    buffer length, the receiver could see garbage appended onto it.
  
    * Add channel lock protection with ast_sendtext().
  
    * Fixed AMI SendText action ast_sendtext() return value check.
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@305923 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-02-03 00:24:40 +00:00
Andrew Latham
b7c58ed676 Replace link to old doc with new wiki page.
Link to https://wiki.asterisk.org/wiki/display/AST/SIP+Retransmissions



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@305753 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-02-02 15:08:33 +00:00
Jason Parker
974aa9e2ad Reverse sense of an error test when reading from astdb.
(closes issue #18545)
Reported by: jcovert
Patches: 
      chan_iax2.c.patch uploaded by jcovert (license 551)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@305692 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-02-01 22:48:16 +00:00
Richard Mudgett
39728fbe4d Merged revisions 305342 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r305342 | rmudgett | 2011-01-31 17:50:10 -0600 (Mon, 31 Jan 2011) | 14 lines
  
  Merged revisions 305341 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r305341 | rmudgett | 2011-01-31 17:45:58 -0600 (Mon, 31 Jan 2011) | 7 lines
    
    Obtain the pri lock for PRI queue counters.
    
    Need to obtain the pri lock when calling pri_dump_info_str() to avoid a
    reentrancy problem when calculating the Q.921 Q count statistic.
    
    JIRA AST-484
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@305343 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-02-01 00:01:09 +00:00
Jason Parker
1a5122534c Merged revisions 305253 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r305253 | qwell | 2011-01-31 16:59:34 -0600 (Mon, 31 Jan 2011) | 17 lines
  
  Merged revisions 305252 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r305252 | qwell | 2011-01-31 16:56:54 -0600 (Mon, 31 Jan 2011) | 10 lines
    
    Prevent a crash when dialing a technology with no destination (ex: Dial(SIP/))
    
    chan_iax2 and other channel drivers already had code to prevent this.  The
    attempt that app_dial was making to prevent it was not correct, so I fixed that.
    
    (closes issue #18371)
    Reported by: gbour
    Patches: 
          18371.patch uploaded by gbour (license 1162)
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@305254 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-01-31 23:07:00 +00:00
Matthew Nicholson
15b9d1ac10 Merged revisions 304244 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r304244 | mnicholson | 2011-01-26 14:42:16 -0600 (Wed, 26 Jan 2011) | 13 lines
  
  Merged revisions 304241 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r304241 | mnicholson | 2011-01-26 14:38:22 -0600 (Wed, 26 Jan 2011) | 6 lines
    
    This patch modifies chan_sip to route responses to the address the request came from.  It also modifies chan_sip to respect the maddr parameter in the Via header.
    
    ABE-2664
    
    Review: https://reviewboard.asterisk.org/r/1059/
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@304245 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-01-26 20:43:27 +00:00
Richard Mudgett
1cd13abaf5 Merged revisions 304149 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r304149 | rmudgett | 2011-01-26 13:38:38 -0600 (Wed, 26 Jan 2011) | 9 lines
  
  Merged revisions 304148 from
  https://origsvn.digium.com/svn/asterisk/be/branches/C.3-bier
  
  ..........
    r304148 | rmudgett | 2011-01-26 13:23:46 -0600 (Wed, 26 Jan 2011) | 2 lines
  
    Update documentation for DAHDISendCallreroutingFacility() application.
  ..........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@304150 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-01-26 19:39:35 +00:00
Terry Wilson
412ac4639d Merged revisions 303960 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r303960 | twilson | 2011-01-25 16:02:42 -0600 (Tue, 25 Jan 2011) | 23 lines
  
  Merged revisions 303906 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r303906 | twilson | 2011-01-25 14:50:59 -0600 (Tue, 25 Jan 2011) | 16 lines
    
    Guard against retransmitting BYEs indefinitely
    
    In the case of an attended transfer (A calls B, A atxfers to C) where
    A becomes unreachable before replying to Asterisk's BYE, Asterisk can
    sometimes retransmit the BYE indefinitely. This is because
    __sip_autodestruct tests p->refer && !ast_test_flag(&p->flags[0],
    SIP_ALREADYGONE and will then transmit a BYE. When this BYE times out,
    it will not ever be marked as ALREADYGONE, so when __sip_autodestruct
    is called again, we end up starting the cycle over.
    
    This patch adds a call to sip_alreadygone(pkt->owner) in retrans_pkt
    in the case of a BYE that has timed out. This should prevent Asterisk
    from trying to transmit new BYE messages in the future.
    
    Review: https://reviewboard.asterisk.org/r/1077/
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@303962 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-01-25 22:09:01 +00:00
Tilghman Lesher
ab1f22bb75 Merged revisions 303858 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

........
  r303858 | tilghman | 2011-01-25 12:41:26 -0600 (Tue, 25 Jan 2011) | 5 lines
  
  Fix "sip show user <tab>", so that it actually shows results, instead of just completing the last entry.
  
  (closes issue #16675)
  Reported by: pj
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@303860 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-01-25 18:55:27 +00:00
Richard Mudgett
8e51d30b67 Merged revisions 303769 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r303769 | rmudgett | 2011-01-25 11:42:42 -0600 (Tue, 25 Jan 2011) | 47 lines
  
  Merged revisions 303765 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r303765 | rmudgett | 2011-01-25 11:36:50 -0600 (Tue, 25 Jan 2011) | 40 lines
    
    Sending out unnecessary PROCEEDING messages breaks overlap dialing.
    
    Issue #16789 was a good idea.  Unfortunately, it breaks overlap dialing
    through Asterisk.  There is not enough information available at this point
    to know if dialing is complete.  The ast_exists_extension(),
    ast_matchmore_extension(), and ast_canmatch_extension() calls are not
    adequate to detect a dial through extension pattern of "_9!".
    
    Workaround is to use the dialplan Proceeding() application early in
    non-dial through extensions.
    
    * Effectively revert issue #16789.
    
    * Allow outgoing overlap dialing to hear dialtone and other early media.
    A PROGRESS "inband-information is now available" message is now sent after
    the SETUP_ACKNOWLEDGE message for non-digital calls.  An
    AST_CONTROL_PROGRESS is now generated for incoming SETUP_ACKNOWLEDGE
    messages for non-digital calls.
    
    * Handling of the AST_CONTROL_CONGESTION in chan_dahdi/sig_pri was
    inconsistent with the cause codes.
    
    * Added better protection from sending out of sequence messages by
    combining several flags into a single enum value representing call
    progress level.
    
    * Added diagnostic messages for deferred overlap digits handling corner
    cases.
    
    (closes issue #17085)
    Reported by: shawkris
    
    (closes issue #18509)
    Reported by: wimpy
    Patches:
          issue18509_early_media_v1.8_v3.patch uploaded by rmudgett (license 664)
          Expanded upon issue18509_early_media_v1.8_v3.patch to include analog
          and SS7 because of backporting requirements.
    Tested by: wimpy, rmudgett
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@303771 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-01-25 17:49:20 +00:00
Jason Parker
8bd0213ea3 Merged revisions 303285 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r303285 | qwell | 2011-01-21 15:48:09 -0600 (Fri, 21 Jan 2011) | 15 lines
  
  Merged revisions 303284 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r303284 | qwell | 2011-01-21 15:45:34 -0600 (Fri, 21 Jan 2011) | 8 lines
    
    Reset configuration before parsing users.conf.
    
    Some values configured in chan_dahdi.conf were able to leak in to users.conf
    configuration.  This was surprising users, and potentially setting non-sane
    "defaults".
    
    ASTNOW-125
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@303467 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-01-24 17:20:03 +00:00
Jason Parker
779b3494df Temporarily revert r303286
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@303375 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-01-21 23:11:02 +00:00
Jason Parker
c2aa3f8621 Merged revisions 303285 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r303285 | qwell | 2011-01-21 15:48:09 -0600 (Fri, 21 Jan 2011) | 15 lines
  
  Merged revisions 303284 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r303284 | qwell | 2011-01-21 15:45:34 -0600 (Fri, 21 Jan 2011) | 8 lines
    
    Reset configuration before parsing users.conf.
    
    Some values configured in chan_dahdi.conf were able to leak in to users.conf
    configuration.  This was surprising users, and potentially setting non-sane
    "defaults".
    
    ASTNOW-125
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@303286 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-01-21 21:50:11 +00:00
Sean Bright
4e770f12bf Initialize an uninitialized variable.
(closes issue #18640)
Reported by: jcovert
Patches:
      chan_sip.c.patch uploaded by jcovert (license 551)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@302414 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-01-19 15:45:17 +00:00
Sean Bright
5dbb8aa010 Use appropriate type for requested format in chan_local.
We were passing and storing the requested format as an int instead of format_t
resulting in truncation.

(closes issue #18238)
Reported by: whizemen
Patches:
      0018238_speex16.patch uploaded by whizemen (license 1143)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@302412 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-01-19 15:31:39 +00:00
Matthew Nicholson
34bda44174 Merged revisions 302313 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r302313 | mnicholson | 2011-01-18 15:40:03 -0600 (Tue, 18 Jan 2011) | 11 lines
  
  Merged revisions 302311 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r302311 | mnicholson | 2011-01-18 15:35:03 -0600 (Tue, 18 Jan 2011) | 4 lines
    
    URI encode the user part of the contact header.
    
    ABE-2705
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@302314 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-01-18 21:43:21 +00:00
Richard Mudgett
78e1319a13 Deadlock between dahdi_request() and pri_dchannel() processing an incomming call.
The sig_pri_new_ast_channel() is called with the channel private lock held
when pri_dchannel() calls it and no channel private lock held when
dahdi_request() calls it.  The use of pri_grab() in
sig_pri_new_ast_channel() could leave the channel private lock held when
it returns if the lock was not held before calling it.

Make sig_pri_new_ast_channel() just lock the PRI span lock instead of
using pri_grab().  It is safe to do this because dahdi_request() does not
have the channel private lock and the deadlock potential with the PRI span
lock is only between pri_dchannel() and other threads.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@301946 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-01-14 21:09:57 +00:00
Brett Bryant
a257d69f35 Changing previous revisions 301845/301847 to use ast_sockaddr_setnull() instead
of setting the field manually to avoid uninitialized data.

Review: https://reviewboard.asterisk.org/r/1076/



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@301851 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-01-14 20:11:55 +00:00
Brett Bryant
bc223456ff Fix for a consistent MulticastRTP channel driver crash due to use of unitilized
data.

(closes issue #18290)
(closes issue #18602)
Reported by: voipgate, wybecom

Review: https://reviewboard.asterisk.org/r/1076/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@301845 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-01-14 19:35:23 +00:00
Jeff Peeler
9190854417 Resolve deadlock involving REFER.
Two fixes:
1) One must always have the private unlocked before calling
pbx_builtin_setvar_helper to not invalidate locking order since it locks the
channel.
2) Unlock the channel before calling pbx_find_extension, which starts and stops
autoservice during the lookup. The problem scenario as illustrated by the
reporter:

Thread: do_monitor
-----------------------
handle_request_do
 handle_incoming
  handle_request_refer
   ast_parking_ext_valid
    pbx_find_extension
     ast_autoservice_stop
      while (chan_list_state == as_chan_list_state) { usleep(1000); }

Thread: autoservice_run
-----------------------
autoservice_run
 chan = ast_waitfor_n
  ast_waitfor_nandfds
   ast_waitfor_nandfds_classic / simple / complex (depending on your system)
    ast_channel_lock(c[x]);

handle_request_do and schedule_process_request_queue locks the owner
if it exists. The autoservice thread is waiting for the channel lock, which
wasn't ever released since the do_monitor thread was waiting for autoservice
operations to complete. Solved by unlocking the channel but keeping a reference
to guarantee safety.

(closes issue #18403)
Reported by: jthurman
Patches: 
      20110103-blind_deadlock.diff uploaded by jthurman (license 614)
      issue18403.patch uploaded by jpeeler (license 325)
Tested by: jthurman



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@301790 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-01-14 17:32:52 +00:00
Terry Wilson
08938fe910 Merged revisions 301682 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

........
  r301682 | twilson | 2011-01-12 15:05:02 -0600 (Wed, 12 Jan 2011) | 9 lines
  
  Don't reject all SUBSCRIBE auth requests
  
  When merging another SUBSCRIBE fix from 1.4, some braces were put in
  the wrong place. This patch fixes that.
  
  (closes issue #18597)
  Reported by: thsgmbh
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@301683 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-01-12 21:19:48 +00:00
Richard Mudgett
be4d5e4348 The DTMF attended transfer feature cannot callback a chan_dahdi BRI phone.
The DAHDI ISDN channel name is not dialable.

Make a channel name like DAHDI/i3/400-12 dialable when the sequence number
is stripped off of the name.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@301134 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-01-08 01:11:31 +00:00
Richard Mudgett
2baf7ac892 Merged revision 300711 from
https://origsvn.digium.com/svn/asterisk/be/branches/C.3-bier

..........
  r300711 | rmudgett | 2011-01-05 13:43:55 -0600 (Wed, 05 Jan 2011) | 14 lines

  A call retrieved from hold may wind up with no audio.

  If the retrieved call is natively bridged then the call may not have any
  audio path.  The following warning message is given:
  "Failed to add <dfd> to conference <chan>/<chan>: Invalid argument".

  * Open the media on a B channel when pri_fixup_principle() moves the call
  from a no_b_channel channel to a real channel.

  * Added lock protection while pri_fixup_principle() moves a call from one
  private structure to another.

  * Made some pri_fixup_principle() messages more meaningful.
..........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@300714 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-01-05 20:54:21 +00:00
Leif Madsen
d5036e449b Merged revisions 300520 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

........
  r300520 | lmadsen | 2011-01-04 15:52:41 -0600 (Tue, 04 Jan 2011) | 9 lines
  
  Fix backwards and broken XML documentation.
  
  (closes issue #18547)
  Reported by: jcovert
  Patches: 
        xmldoc.c.patch uploaded by jcovert (license 551)
        chan_iax2.c.doc.patch uploaded by jcovert (license 551)
        chan_sip.c.patch uploaded by jcovert (license 551)
        chan_agent.c.patch uploaded by jcovert (license 551)
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@300521 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-01-04 21:53:27 +00:00
Terry Wilson
be2b52c028 Merged revisions 300298 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r300298 | twilson | 2011-01-04 11:37:26 -0600 (Tue, 04 Jan 2011) | 22 lines
  
  Merged revisions 300216 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r300216 | twilson | 2011-01-04 11:11:48 -0600 (Tue, 04 Jan 2011) | 15 lines
    
    Don't authenticate SUBSCRIBE re-transmissions
    
    This only skips authentication on retransmissions that are already
    authenticated. A similar method is already used for INVITES. This
    is the kind of thing we end up having to do when we don't have a
    transaction layer...
    
    (closes issue #18075)
    Reported by: mdu113
    Patches: 
          diff.txt uploaded by twilson (license 396)
    Tested by: twilson, mdu113
    
    Review: https://reviewboard.asterisk.org/r/1005/
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@300301 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2011-01-04 17:54:41 +00:00
Tilghman Lesher
7268144da1 Merged revisions 299625 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r299625 | tilghman | 2010-12-25 04:05:00 -0600 (Sat, 25 Dec 2010) | 12 lines
  
  Merged revisions 299624 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r299624 | tilghman | 2010-12-25 04:04:06 -0600 (Sat, 25 Dec 2010) | 5 lines
    
    Move check for extension existence below variable inheritance, due to the possible use of an eswitch.
    
    (closes issue #16228)
     Reported by: jlaguilar
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@299626 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-12-25 10:07:15 +00:00
Moises Silva
4c54cac705 Merged revisions 299530 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

........
  r299530 | moy | 2010-12-22 21:28:37 -0500 (Wed, 22 Dec 2010) | 7 lines
  
  Enqueue AST_CONTROL_PROGRESS after AST_CONTROL_RINGING when MFC-R2 calls are accepted
  
  (closes issue #18438)
  Reported by: mariner7
  Tested by: moy
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@299531 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-12-23 02:53:02 +00:00
Richard Mudgett
30a74dd9fe Chan_dahdi sends an empty COLP on the bridged channel.
Chan_dahdi always inserts a connected party IE when you call from one
dahdi channel to another dahdi channel, even if no such information was
received on the 2nd channel.  This clears the display of many phones.

* Removed leftover artifact from before the valid flag was added.

* Updated all of the channel's caller id information with the new
connected line information instead of just the string parts.

(closes issue #18508)
Reported by: wimpy
Patches:
      issue18508_trunk.patch uploaded by rmudgett (license 664)
Tested by: wimpy, rmudgett


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@299405 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-12-22 02:10:39 +00:00
Matthew Nicholson
7358372d1a Merged revisions 299242 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r299242 | mnicholson | 2010-12-20 15:25:35 -0600 (Mon, 20 Dec 2010) | 23 lines
  
  Merged revisions 299194,299198,299220 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r299194 | mnicholson | 2010-12-20 14:45:38 -0600 (Mon, 20 Dec 2010) | 6 lines
    
    Respond as soon as possible with a 202 Accepted to refer requests.
    
    This change also plugs a few memory leaks that can occur when parking sip calls.
    
    ABE-2656
  ........
    r299198 | mnicholson | 2010-12-20 15:00:44 -0600 (Mon, 20 Dec 2010) | 2 lines
    
    Remove changes to via processing that were not supposed to go into the last commit.
  ........
    r299220 | mnicholson | 2010-12-20 15:21:39 -0600 (Mon, 20 Dec 2010) | 4 lines
    
    Use ast_free() instead of free()
    
    ABE-2656
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@299353 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-12-21 15:25:03 +00:00
Mark Michelson
bc5602a88f Fix a couple of CCSS issues.
* Make sure to allocate a cc_params structure
  when creating autopeers.

* Use sip_uri_cmp when retrieving SIP CC agents
  and monitors in case parameters appear in the
  URI.

(closes issue #18504)
Reported by: kkm

(closes issue #18338)
Reported by: GeorgeKonopacki
Patches: 
      18338.diff uploaded by mmichelson (license 60)
Tested by: GeorgeKonopacki




git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@299248 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-12-20 21:38:30 +00:00
Tzafrir Cohen
8a73e54701 Typos: recieved => received
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@299004 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-12-20 09:14:29 +00:00
Brad Watkins
1c1631cebf Fix parsing of mwi => lines in sip.conf
Reworking parsing of mwi => lines to resolve a segfault.  Also add a set of unit tests for the function that does the parsing.

(closes issue #18350)
Reported by: gbour
Tested by: Marquis, gbour

Review: https://reviewboard.asterisk.org/r/1053/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@298773 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-12-17 17:26:31 +00:00
Tilghman Lesher
5bc2e04ec0 Ensure the ipaddr field in realtime is large enough to handle IPv6 addresses.
(closes issue #18464)
 Reported by: IgorG
 Patches: 
       realtime_ipv6store.diff uploaded by IgorG (license 20)
       (plus a few additional lines by tilghman)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@298539 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-12-16 09:28:17 +00:00
Richard Mudgett
3ed89f0e89 Merged revisions 298194 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r298194 | rmudgett | 2010-12-13 11:04:41 -0600 (Mon, 13 Dec 2010) | 26 lines
  
  Merged revisions 298193 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r298193 | rmudgett | 2010-12-13 10:56:07 -0600 (Mon, 13 Dec 2010) | 19 lines
    
    Outgoing PRI/BRI calls cannot do DTMF triggered transfers.
    
    Outgoing PRI/BRI calls cannot do DTMF triggered transfers if a PROCEEDING
    message is not received.  The debug output shows that the DTMF begin event
    is seen, but the DTMF end event is missing.  When the DTMF begin happens,
    the call is muted so we now have one way audio (until a DTMF end event is
    somehow seen).
    
    * Made set the proceeding flag when the PRI_EVENT_ANSWER event is
    received.
    
    * Made absorb the DTMF begin and DTMF end events if we are overlap dialing
    and have not seen a PROCEEDING message.
    
    * Added a debug message when absorbing a DTMF event.
    
    JIRA SWP-2690
    JIRA ABE-2697
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@298195 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-12-13 17:11:43 +00:00
Terry Wilson
7310e07564 Merged revisions 297960 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r297960 | twilson | 2010-12-09 16:10:31 -0600 (Thu, 09 Dec 2010) | 21 lines
  
  Merged revisions 297959 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r297959 | twilson | 2010-12-09 16:00:30 -0600 (Thu, 09 Dec 2010) | 14 lines
    
    Ignore spurious REGISTER requests
    
    If a REGISTER request with a Call-ID matching an existing transaction is received
    it was possible that the REGISTER request would overwrite the initreq of the
    private structure. This info is used to generate messages for other responses in
    the transaction. This patch ignores REGISTER requests that match non-REGISTER
    transactions.
    
    (closes issue #18051)
    Reported by: eeman
    Tested by: twilson
    
    Review: https://reviewboard.asterisk.org/r/1050/
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@297965 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-12-09 22:18:19 +00:00
David Vossel
f32ff875d6 Fixes issue with outbound google voice calls not working.
Thanks to az1234 and nevermind_quack for their input in helping debug the issue.

(closes issue #18412)
Reported by: nevermind_quack
Patches:
      fix uploaded by dvossel (license 671)




git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@297957 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-12-09 21:32:20 +00:00
Jeff Peeler
00143b2778 Merged revisions 297605 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r297605 | jpeeler | 2010-12-06 16:03:04 -0600 (Mon, 06 Dec 2010) | 18 lines
  
  Merged revisions 297603 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r297603 | jpeeler | 2010-12-06 15:57:15 -0600 (Mon, 06 Dec 2010) | 12 lines
    
    Improve handling of REGISTER requests with multiple contact headers.
    
    The changes here attempt to more strictly follow RFC 3261 section 10.3.
    Basically the following will now cause a 400 Bad Response to be returned, if:
    - multiple Contact headers are present with one set to expire all bindings ("*")
    - wildcard parameter is specified for Contact without Expires header or Expires
      header is not set to zero.
    
    ABE-2442
    ABE-2443
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@297607 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-12-06 22:06:37 +00:00
Sean Bright
cc870a3b31 Merged revisions 297534 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

........
  r297534 | seanbright | 2010-12-03 12:40:52 -0500 (Fri, 03 Dec 2010) | 3 lines
  
  The CLI command should not contain <placeholder>s, these are for descriptions.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@297535 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-12-03 17:41:30 +00:00
Jeff Peeler
add7816848 Merged revisions 297073 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r297073 | jpeeler | 2010-12-01 11:52:46 -0600 (Wed, 01 Dec 2010) | 30 lines
  
  Merged revisions 297072 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r297072 | jpeeler | 2010-12-01 11:50:09 -0600 (Wed, 01 Dec 2010) | 23 lines
    
    Fix not stopping MOH when transfered local channel queue member is answered.
    
    The problem here is only present when local channels are used with the MOH
    passthru option as well as no optimization (/nm). I will describe the slightly
    bizarre scenario that was used to test, where phones B and C are queue members:
    
    Phone A dials into a queue with two members using local channels and the above
    options. Phone B answers. Phone A blind transfers phone B into the same queue.
    Phone A hangs up. Phone C answers, but phone B didn't stop playing MOH.
    
    In this scenario, the unhold frame that should have gotten to phone B never
    arrived due to the masquerade from the blind transfer. This is usually fine
    since app_queue manages the starting and stopping of MOH. However, with the
    passthrough option enabled when app_queue attempts to stop MOH it tries to do
    so on the local channel rather than the real channel. The easiest solution
    was to just make sure to send an unhold frame during the transfer since it
    wouldn't make sense to have MOH playing after a transfer anyway. This only
    modifies SIP transfers, but the other transfers did not seem to be a problem.
    If DTMF based transfers were a problem it might be okay to add ast_moh_stop
    to finishup, but I didn't want to have to add that unless required.
    
    ABE-2624
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@297075 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-12-01 17:53:13 +00:00
Tilghman Lesher
a41c5537d9 Merged revisions 296950 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

........
  r296950 | tilghman | 2010-11-30 19:38:19 -0600 (Tue, 30 Nov 2010) | 2 lines
  
  Missed initializations caused startup errors on Mac OS X (and possibly others, too).
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@296951 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-12-01 01:46:32 +00:00
Paul Belanger
9194596f7d Merged revisions 296671 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r296671 | pabelanger | 2010-11-29 17:54:14 -0500 (Mon, 29 Nov 2010) | 12 lines
  
  Merged revisions 296670 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r296670 | pabelanger | 2010-11-29 17:49:39 -0500 (Mon, 29 Nov 2010) | 5 lines
    
    Make sure nothing else is needed before destroying the scheduler.
    
    (closes issue #18398)
    Reported by: pabelanger
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@296673 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-11-29 23:05:45 +00:00
Russell Bryant
7017473c8c Complete some error handling in transmit_publish() in chan_sip.c.
This error handling block caught my eye.  It was missing a couple of things,
but it should be safe now.  Thanks to mmichelson for the quick peer review
on IRC.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@296628 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-11-29 21:26:44 +00:00
Richard Mudgett
b8249ee177 Merged revision 296575 from
https://origsvn.digium.com/svn/asterisk/be/branches/C.3-bier

..........
  r296575 | rmudgett | 2010-11-29 14:27:37 -0600 (Mon, 29 Nov 2010) | 13 lines

  Invalid mISDN PTMP redirecting signaling as TE towards NT.

  The mISDN PTMP redirection signaling (NOTIFY redirecting number and
  notification code, SETUP redirecting number) is also sent in PTMP/TE mode.
  It should only apply in PTMP/NT mode.  The call setup proceeds but the
  network (Deutsche Telekom) reacts with ugly ISDN STATUS messages.

  Also don't send the redirecting number ie when PTP is also sending the
  DivertingLegInformation2 facility.  The redirecting number ie is redundant
  and the network (Deutsche Telekom) complains about it.

  Patches:
        abe_2651_v4.patch uploaded by rmudgett (license 664)

  JIRA ABE-2651
  JIRA SWP-2537
..........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@296582 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-11-29 20:46:03 +00:00
Brad Watkins
ee5d9d0835 Fix reloading of peer when a user is requested.
Prevent peer reloading from causing multiple MWI subscriptions to be created when using realtime.  This had the effect of sending one NOTIFY for every time a sip peer made a call, in one case eventually overwhelming  the phone and causing it to reboot.

(closes issue #18342)
Reported by: nivek
Patches:
      issue0018342p1.patch uploaded by nivek (license 636)
Tested by: nivek

Review: https://reviewboard.asterisk.org/r/1029/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@296352 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-11-26 18:19:02 +00:00
Richard Mudgett
5634ae11d5 Merged revisions 296166 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
  r296166 | rmudgett | 2010-11-24 16:42:45 -0600 (Wed, 24 Nov 2010) | 50 lines
  
  Merged revisions 296165 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r296165 | rmudgett | 2010-11-24 16:41:07 -0600 (Wed, 24 Nov 2010) | 43 lines
    
    Oneway audio to SIP phone from FXS port after FXS port gets a CallWaiting pip.
    
    The FXS connected phone has to have CW/CID support to fail, as it will
    send back a DTMF 'A' or 'D' when it's ready to receive CallerID.  A normal
    phone with no CID never fails.  Also the SIP phone does not hear MOH when
    the CW call is answered.
    
    The DTMF end frame is suppressed when the phone acknowledges the CW signal
    for CID.  The problem is the DTMF begin frame needs to be suppressed as
    well.  The DTMF begin frame is causing SIP to start sending the DTMF RTP
    frames.  Since the DTMF end frame is suppressed, SIP will not stop sending
    those DTMF RTP packets.
    
    * Suppress the DTMF begin and end frames when the channel driver is
    looking for DTMF digits.
    
    * Fixed a couple issues caused by not cleaning up the CID spill if you
    answer the CW call while it is sending the CID spill.
    
    * Fixed not sending CW/CID spill to the phone when the call is natively
    bridged.  (Fixed by not using native bridge if CW/CID is possible.)
    
    * Suppress received audio when sending CW/CID spills.  The other parties
    involved do not need to hear the CW/CID spills and may be confused if the
    CW call is for them.
    
    (closes issue #18129)
    Reported by: alecdavis
    Patches:
          issue_18129_v1.8_v3.patch uploaded by rmudgett (license 664)
    Tested by: alecdavis, rmudgett
    
    
    NOTE:
    
    * v1.4 does not have the main problem fixed by suppressing the DTMF start
    frames.  The other three items fixed are relevant.
    
    * If you really must restore native bridging between analog ports, you
    need to disable CW/CID either by configuring chan_dahdi.conf
    callwaitingcallerid=no or dialing *70 before dialing the number to
    temporarily disable CW.
  ........
................


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@296167 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-11-24 22:49:48 +00:00
Richard Mudgett
a77913a22d One way audio before answering call waiting call on analog port.
* Analog call waiting Caller ID spills could get stuck resulting in one
way audio until the waiting call is answered.  This only happens on the
second (and later) call waiting call if the active call is not the first
call.

* The CLI/AMI "dahdi show channel" command could report the wrong channel
information.

Must keep the struct analog_pvt.owner and struct dahdi_pvt.owner pointer
in sync.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@295747 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-11-20 03:11:15 +00:00