1908 Commits

Author	SHA1	Message	Date
Joshua Colp	2c9ffadffb	Fix issue where it would be possible for the negotiated codecs to get set back to nothing. (issue #9992 reported by yehavi) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@69625 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-06-18 13:55:00 +00:00
Russell Bryant	93f3abb3e8	Move the logic for destroying a call when no response is received to a BYE ... outside of the block that checks for FLAG_FATAL to be set. This flag is only set when the packet is transmitted with the reliability set to XMIT_CRITICAL when the original packet is transmitted. A BYE is always sent with it set to XMIT_RELIABLE, meaning this code could never be encountered. This resulted in seeing some SIP channels that would never go away with the last packet sent being a BYE. (part of issue #9235, patch from jcmoore) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@69183 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-06-13 19:57:38 +00:00
Russell Bryant	f56c3be8ad	Clarify a bit of logic. This doesn't change behavior in any way, but it is ... helpful when following the logic to debug problems like 9235. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@69071 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-06-13 16:56:16 +00:00
Joshua Colp	b58a48d672	Merged revisions 67938 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r67938 | file | 2007-06-06 20:09:13 -0400 (Wed, 06 Jun 2007) | 2 lines Only notify the devicestate system of a peer state change when the peer is built from the config file. (issue #9900 reported by arkadia) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67941 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-06-07 00:10:48 +00:00
Russell Bryant	6595debbc5	Fix a crash when doing call pickups with SIP phones. The code unlocked the ... channel when it should not have. (issue #9652, reported by corruptor, fixed by me) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67862 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-06-06 21:14:46 +00:00
Joshua Colp	01456184f9	Better handle SIP devices that say they have SDP content... but really don't. (issue #9398 reported by mthomasslo) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67068 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-06-04 19:31:09 +00:00
Joshua Colp	c7112015ba	Merged revisions 66764 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r66764 | file | 2007-05-31 12:12:39 -0400 (Thu, 31 May 2007) | 2 lines It is now possible for this path of execution to have the frame pointer be NULL, therefore we need to check for it before trying to access it. (issue #9836 reported by barthpbx) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@66768 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-31 16:14:48 +00:00
Joshua Colp	612f61a9b2	Silly me for having out of date source! Oh well... I'm still leaving my comment. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@66639 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-30 17:28:12 +00:00
Joshua Colp	3d8d697e34	When calling some peer/host that may not exist/reply back... don't keep the dialog in memory for all of eternity. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@66637 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-30 17:21:06 +00:00
Olle Johansson	332eabcc07	Properly handle 408 request timeout - according to the RFC, the dialog dies if a request in a dialog gets this response. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@66503 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-29 19:32:57 +00:00
Olle Johansson	8d06f379fe	Don't issue hangup on hangup on hangup on hangup (for jcmoore) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@66474 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-29 19:02:04 +00:00
Olle Johansson	9f15005143	Don't reset hangupcause if we already have one ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@66414 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-29 16:07:44 +00:00
Olle Johansson	ff9e2751c6	Tracking down hanging channels, killing them one by one. Issue #9235 and related ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@66404 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-29 16:02:50 +00:00
Olle Johansson	bab6473879	Merged revisions 66349 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r66349 | oej | 2007-05-29 09:53:14 +0200 (Tue, 29 May 2007) | 2 lines Issue #9802 - Change inuse counter on CANCEL ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@66363 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-29 09:41:40 +00:00
Joshua Colp	0df2a42f96	Merged revisions 65837 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r65837 | file | 2007-05-24 10:40:38 -0400 (Thu, 24 May 2007) | 2 lines Allow RFC2833 to be negotiated when an INVITE comes in without SDP and is not matched to a user or peer. (issue #9546 reported by mcrawford) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@65839 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-24 14:42:12 +00:00
Olle Johansson	6cfe6a550e	Issue 8409 - phsultan - Fix "login" as component to jabber server. ... ...and, by accident, fix a bug in chan_sip for stopping a loop on retransmits of BYE requests. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@65836 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-24 14:38:30 +00:00
Kevin P. Fleming	ca6b421be4	Merged revisions 65682 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r65682 | kpfleming | 2007-05-23 16:46:22 -0400 (Wed, 23 May 2007) | 2 lines ensure that variables are set on a newly created channel before we start a PBX on it ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@65683 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-23 20:51:56 +00:00
Olle Johansson	4483fa12e8	Merged revisions 65122 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r65122 | oej | 2007-05-18 20:10:46 +0200 (Fri, 18 May 2007) | 2 lines Not getting an ACK to a 200 OK in the initial invite is critical to the call. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@65123 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-18 18:16:09 +00:00
Olle Johansson	7fe3608300	Merged revisions 65075 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r65075 | oej | 2007-05-18 17:12:09 +0200 (Fri, 18 May 2007) | 5 lines Issue 9235 - part of the problem, maybe not all. Please retry with this patch (and no other patch) if you have problems with hanging SIP channels. Thank you. A special Thank You to WeBRainstorm that gave me access to his system. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@65076 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-18 15:18:13 +00:00
Olle Johansson	50f79ba4b2	- Adding support for putting calls OFF hold with a re-invite with blank SDP. This was a bug found while doing tests at SIPit in Antwerp. ... - In order to not duplicate code, I restructured some of the code for putting calls on/off hold. Thanks DEA for reminding me. This fix has been asleep in the videocaps branch until now. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@65041 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-18 12:58:39 +00:00
Olle Johansson	73d0ba053b	Issue 9487 - stop media flows at hangup of call ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@64974 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-18 10:37:44 +00:00
Joshua Colp	7a8ca54257	Even more direct RTP setup fixes! Don't allow a codec that isn't supported to creep into the SDP of either side. (issue #9446 reported by marcelbarbulescu) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@64754 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-17 16:10:12 +00:00
Olle Johansson	4ae20ba8e4	Fix auth on BYE. (Different patch than for 1.2) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@64605 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-16 10:59:28 +00:00
Olle Johansson	5acc63d688	Issue #9681 - Handle www-auth on BYE ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@64602 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-16 10:38:18 +00:00
Olle Johansson	374b52f717	Final part of issue #9483 - fixing transfer() of sip calls in the dial plan (twilson) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@64578 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-16 10:05:47 +00:00
Olle Johansson	70ad556544	Issue #9439 - properly handle username parameters in SIP uri. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@64565 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-16 09:57:22 +00:00
Olle Johansson	bf1a15b9bf	Merged revisions 64535 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r64535 | oej | 2007-05-16 11:08:22 +0200 (Wed, 16 May 2007) | 2 lines Support SIP uri's starting with SIP: and sip: (reported by Tony Mountfield on the mailing list. Thanks!) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@64543 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-16 09:12:34 +00:00
Olle Johansson	56af259505	Merged following patch with a lot of changes for 1.4 ... ------ Merged revisions 64514 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r64514 | oej | 2007-05-16 10:25:56 +0200 (Wed, 16 May 2007) | 6 lines Issue #9726 - rlister - Better logging for ACL denials While at it, also added better logging and handling of peers that are not supposed to register. My patch, stole the issue report from Russell. My apologies, Russell :-) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@64516 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-16 08:46:18 +00:00
Olle Johansson	1f2afa0ff1	Change -2 to XMIT_ERROR to clarify a bit more ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@64324 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-14 19:26:50 +00:00
Olle Johansson	e041d57175	Handle network errors, like host or network unreachable, in a better way. This means that ... calls to hosts or qualify (OPTION) messages will fail quicker if the TCP/IP stack tells us that there is an issue. Since this is an unconnected UDP socket, we will not get error messages directly in most cases, but maybe on the second and third try. This is already implemented in trunk. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@64280 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-14 18:52:09 +00:00
Joshua Colp	9a73c07fb1	This concludes my final adventure with bitmasks and the onhold flag. Would anyone care for some peanuts? ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@64114 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-12 22:27:04 +00:00
Joshua Colp	699aa6ad74	Tweak hold flags some more. They can be of three states when active: active, inactive, one direction. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@64086 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-12 21:10:45 +00:00
Joshua Colp	026000bae8	Ensure the onhold flag is set no matter what when being put on hold. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@64044 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-12 16:32:15 +00:00
Olle Johansson	ca1ae5e81a	Merged revisions 63748 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r63748 | oej | 2007-05-10 22:38:54 +0200 (Thu, 10 May 2007) | 4 lines Do not allocate SIP pvt's for PEERs we can not reach. This was seen as a lot of dialogs being created then immediately destroyed at reload/restart of the SIP channel. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@63749 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-10 20:46:41 +00:00
Joshua Colp	67a0bbaa83	Do not prematurely go on hold if sendonly was not actually set. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@63656 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-09 17:43:30 +00:00
Joshua Colp	c83c0072bb	Merged revisions 63610 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r63610 | file | 2007-05-09 12:51:03 -0400 (Wed, 09 May 2007) | 2 lines Properly handle hints that point to multiple devices in chan_sip. Why chan_sip is even doing this I have no idea but I would rather not go into a rant. (issue #9536 reported by rlister) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@63611 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-09 16:54:56 +00:00
Olle Johansson	d30faa1dc2	Don't retransmit 200 OK's on ignore status. (Reported on asterisk-users) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@63532 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-09 13:04:14 +00:00
Joshua Colp	b50b92ab77	Minor backport of revision 59083 in trunk. Don't queue an unhold frame up if the call was never on hold to begin with. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@63283 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-07 21:26:58 +00:00
Joshua Colp	95de3fbf0c	Merged revisions 62987 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r62987 | file | 2007-05-03 13:42:19 -0300 (Thu, 03 May 2007) | 2 lines When a peer is seeded or built tell the devicestate core to update it's status. This is easier then having chan_sip load before pbx_config. (issue #9658 reported by dlynes) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@62989 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-03 16:44:00 +00:00
Olle Johansson	d5fda03428	Don't unlock a channel that we already know does not exist (propably isue 8228) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@62624 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-05-02 06:15:43 +00:00
Olle Johansson	34f9e0c4dd	Merged revisions 62126 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r62126 | oej | 2007-04-27 15:57:45 +0200 (Fri, 27 Apr 2007) | 4 lines Issue #7351 - SIP Cancel fails due to the wrong contact uri. Reported by PPYY, failed to fix by OEJ final fix by wojtekka - THANKS!!!! THis was a hard one to catch. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@62137 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-04-27 14:04:07 +00:00
Joshua Colp	b271179161	Merged revisions 61771 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r61771 | file | 2007-04-24 12:05:06 -0400 (Tue, 24 Apr 2007) | 2 lines Allow RFC2833 to be sent in the response SDP when an INVITE comes in without SDP. (issue #9546 reported by mcrawford) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@61772 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-04-24 16:07:02 +00:00
Olle Johansson	32be6621f6	Merged revisions 61685 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r61685 | oej | 2007-04-19 09:56:21 +0200 (Thu, 19 Apr 2007) | 3 lines Send NOTIFY to Contact: in SUBSCRIBE - as reported by Intertex and Citel. Fixed during SIPit 20 in Antwerp. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@61686 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-04-19 08:37:08 +00:00
Olle Johansson	dc6d309bdb	#9483, half of patch by twilson to solve 302 redirect issues ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@61666 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-04-16 14:47:05 +00:00
Joshua Colp	eb631c00a3	For those very verbose SIP implementations that attach tons of info to the Contact header... let's increase our variable sizes. (issue #9535 reported by jeffg) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@61648 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-04-13 17:19:53 +00:00
Joshua Colp	c06e063e1a	Don't assume the callid of a dialog will be set, as in some circumstances it may not. (issue #9534 reported by tecnoxarxa) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@61641 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-04-13 16:32:03 +00:00
Russell Bryant	5858778f40	Merged revisions 61476 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r61476 | russell | 2007-04-11 11:01:25 -0500 (Wed, 11 Apr 2007) | 5 lines If someone sets the "useragent" option in sip.conf to be empty, then don't add the User-Agent header at all. It is an optional header, anyway. Also, the bug report says that some of Japan's SIP providers don't allow it for some weird reason. (issue #9488, reported by makoto, fixed by me) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@61477 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-04-11 16:05:29 +00:00
Russell Bryant	a0d75effd5	Merged revisions 61426 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r61426 | russell | 2007-04-11 10:05:36 -0500 (Wed, 11 Apr 2007) | 6 lines Fix a bug with switching between host=dynamic and using specific hosts for peers. The code would only reset the peer's address when it is dynamic if it was a new peer structure. Now, it will also reset the address if it was already in the peer list, but before the reload, it was not dynamic. (issue #9515, reported by caio1982, fixed by me) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@61427 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-04-11 15:09:39 +00:00
Russell Bryant	9ce476a89c	Merged revisions 61376 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r61376 | russell | 2007-04-11 09:02:54 -0500 (Wed, 11 Apr 2007) | 5 lines Remove the attempt at reporting configuration errors in sip.conf. This can cause a bunch of improper messages when using realtime. I give up. As oej tried to convince me when I put this in, there is just no easy way to do it. (inspired by a message on the -dev list) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@61377 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-04-11 14:04:44 +00:00
Olle Johansson	3e5c59f235	Merged revisions 61038 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r61038 | oej | 2007-04-09 21:38:59 +0200 (Mon, 09 Apr 2007) | 3 lines - Don't send ActionID before Response: header. - Don't use a blank in an AMI header ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@61072 65c4cc65-6c06-0410-ace0-fbb531ad65f3	2007-04-09 19:58:17 +00:00