Commit Graph

1908 Commits

Author SHA1 Message Date
Joshua Colp
f373cad528 Compare technology using the pointers instead of a straight comparison based on name. (issue #8228 reported by dean bath)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47764 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-16 21:11:06 +00:00
Olle Johansson
e1e6a1b2a8 Make the HOLD notification optional, in order to avoid a lot of extra database lookups
for all those realtime users out there.



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47755 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-16 19:24:23 +00:00
Olle Johansson
d1ee29fc20 Don't fixup if there's nothing to fixup
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47744 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-16 16:51:59 +00:00
Olle Johansson
5bd53e3588 - CANCEL is never authenticated (according to the RFC)
- Update docs on canreinvite. "nonat" is the recommended setting for most users with
  phones behind a NAT.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47733 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-16 15:03:49 +00:00
Olle Johansson
c78840b900 - Improve SIP history
- Never send reply to ACK (again...)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47698 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-15 20:31:11 +00:00
Olle Johansson
63f87d112d Send error message when we can't allocate SIP dialog, possibly due to limitation of file descriptors.
(imported from 1.2)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47656 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-15 15:25:50 +00:00
Joshua Colp
25b5cf18b7 Only keep the video RTP structure around if 1. Video support is enabled and 2. A video codec is enabled on the dialog
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47628 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-14 22:05:03 +00:00
Olle Johansson
4ecb09f6e8 Update documentation to fit the implementation...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47613 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-14 16:22:35 +00:00
Olle Johansson
cb82979700 Issue #8272 - Don't destroy dialog in retransmission system if it's an OPTION packet from peerpoke
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47597 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-14 11:14:01 +00:00
Tilghman Lesher
e944561518 Merged revisions 47580 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r47580 | tilghman | 2006-11-13 14:18:30 -0600 (Mon, 13 Nov 2006) | 2 lines

Having more than 255 old messages caused corruption in the new/old count

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47581 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 20:20:01 +00:00
Tilghman Lesher
6e4d0e50c8 Re-enable old deprecated commands
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47573 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 19:11:15 +00:00
Olle Johansson
55c8a5ded8 - Don't reply to INVITE already replied to when we get BYE
- Declare errmsg as int. Oops.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47572 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 19:10:39 +00:00
Olle Johansson
0ca5dae550 Only produce error message about sip history once
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47540 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 16:00:57 +00:00
Olle Johansson
153cb1309f Issue 8314 - Restore auto-framing (Thanks DEA!!!)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47513 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-12 16:12:12 +00:00
Olle Johansson
fc5f9c78d1 Part of issue 8078 - parse even if udptl is UDPTL in sdp...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47511 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-12 15:35:19 +00:00
Olle Johansson
a471f0a87c - Don't destroy SIP dialog because of a failed T.38 re-invite. Wait for a bye.
Final response to a re-invite does not mean that the session dies, only that
  the re-invite fails.
- Keep RTP active during processing of T.38 re-invite. If the re-invite fails,
  RTP needs to remain as before the re-invite.

Issue 8338 - darren1713. Please test.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47509 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-12 15:27:00 +00:00
Olle Johansson
853958e863 -Remove blocking of ptime: parsing in sdp
-Add some comments to t.38 code



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47507 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-12 15:10:53 +00:00
Olle Johansson
2a321d80f5 ...and make sure that the dialog is destroyed, even if we don't get any answer on the bye...
This is the channel that remains dead after the SIP transfer


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47476 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-10 21:42:27 +00:00
Olle Johansson
ea257647a2 Add debug output while trying to trace bug in bug report
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47474 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-10 21:36:49 +00:00
Olle Johansson
ba58cf9ecd Make sure we destroy dialog...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47466 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-10 20:23:56 +00:00
Olle Johansson
1f2a4eb8c2 Small cleanup of handle_request_invite() - imported from 1.2 with changes
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47463 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-10 19:49:48 +00:00
Olle Johansson
d83a1f1356 Issue 8010 - Fix support for multipart SDP (alphaque)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47454 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-10 18:56:15 +00:00
Tilghman Lesher
f11ea0549d Discussion of these CLI changes resulted in more consistency (Bug 8236)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47436 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-10 16:51:55 +00:00
Olle Johansson
54994dfe04 Rip out half implementation of 491 response support, since it wasn't implemented
properly and caused memory leaks in the case of us getting 491's, which Asterisk
actually sends...

Since it is a bit too complicated to fix this, I'll rip it out of 1.4 and put
it on the to-do-list for future releases. Now, we handle this as congestion,
which it really is.

Issue #8331



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47418 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-10 13:04:42 +00:00
Olle Johansson
27e6ea10fb Fix bit definition for SIP_PAG2_CALL_ONHOLD. Thanks fenlander!
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47414 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-10 12:05:53 +00:00
Kevin P. Fleming
10978d0390 add simple fix for SDP to report proper sample rate for G.722 media sessions
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47333 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-08 18:07:16 +00:00
Olle Johansson
764ba93e05 Destroy dialog properly at unload (rizzo)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47309 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-08 07:40:53 +00:00
Steve Murphy
517978fd5f These mods are to solve the problem in bug 7506. It's a lot of rework to solve a fairly small problem... such is life.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47303 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-07 23:46:41 +00:00
Olle Johansson
647fb52e31 Issue 8303 (lrizzo) - break instead of continue.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47268 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-07 17:30:17 +00:00
Olle Johansson
eac4efcf22 Fixing the attack shield so it doesn't produce attacks... Issue 8265 - never reply to an ACK
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47250 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-07 13:13:51 +00:00
Olle Johansson
d5edfd432a Issue #8284: Fixes to Invite/replaces and transfer from "john"
Thank you!


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47199 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-04 18:32:02 +00:00
Steve Murphy
b6079499e4 This fix introduced via bug 8233
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47176 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-03 23:17:01 +00:00
Tilghman Lesher
e05a2752e8 Reverse change of "show" to "list" and make several other commands more consistent with "category verb arguments"
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47051 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-02 23:00:20 +00:00
Olle Johansson
ea69dd0cbc Move check for codec translation to sip_call() instead of in add_sdp. No one bothers
with the result of add_sdp anyway... Yet...


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47015 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-02 19:56:30 +00:00
Olle Johansson
bfb1d68414 Disable code for T38 over TCP and RTP since there's no trace of actual functionality for it :-)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46992 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-02 18:26:57 +00:00
Kevin P. Fleming
efdffc0cf8 don't send INVITE when we have determined that we can't offer any audio formats due to lack of trancoding support (or incorrect configuration)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46937 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-02 16:45:32 +00:00
Joshua Colp
eb25ec6ed5 Merged revisions 46920 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r46920 | file | 2006-11-02 11:02:27 -0500 (Thu, 02 Nov 2006) | 2 lines

Repeat after me oej: I will at least make sure my code compiles before I commit it.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46930 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-02 16:06:39 +00:00
Olle Johansson
5667c1c71d Dont overwrite pkt->flags (from 1.2)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46901 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-02 15:24:30 +00:00
Olle Johansson
9ab1cc22a4 Support ;rport when we're supposed to support ;rport. Issue #7473.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46628 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-31 10:26:16 +00:00
Olle Johansson
56f2cab81c If peer fails ACL check, fail peer at REGISTER
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46606 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-31 09:17:53 +00:00
Olle Johansson
cdb0c64271 Fix T38 too. Thanks, tgrman !
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46583 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-31 08:28:38 +00:00
Olle Johansson
86c973f71f Issue #8246 - Doxygen fixes from kshumard.
An extra big thankyou is given to everyone that contributes to doxygen!

		THANK YOU!



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46433 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-30 16:27:34 +00:00
Olle Johansson
9213317979 Issue #7869 - Stop retransmission of 302 redirects (imported from 1.2)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46407 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-29 19:31:58 +00:00
Olle Johansson
4456e58811 Issue #7608 - Notifications sent with wrong content-type (imported from 1.2, modified)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46403 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-29 19:12:18 +00:00
Olle Johansson
e8350b836b Backport of patch for #7828 that was reported for trunk, but obviously
exists in 1.4 too. 


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46401 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-29 17:16:38 +00:00
Olle Johansson
0ff30203f9 Restoring the old logic, since working around it and fixing it seemed too complicated.
- The SIP_OUTGOING flag indicates the direction of the last transaction in the dialog.
- The initreq stores the last request in the dialog, the request that opened the 
  latest transaction.

Please now retry all the 1.4 bug reports with mixed to/from headers, tags etc
in ACK, BYE, CANCEL. Thanks!


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46398 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-29 08:45:05 +00:00
Olle Johansson
b1b2177079 Accepting a message twice may be misinterpreted...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46389 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-28 20:25:18 +00:00
Olle Johansson
5c59f2f5f5 - 183 is not reliable message...
- Error should not have SDP


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46382 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-28 19:08:58 +00:00
Olle Johansson
77e12e971c Old todo note - Don't add Contact header on BYE and Cancel
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46276 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-25 20:14:57 +00:00
Olle Johansson
b36a4fad1b Somewhat ugly code to try to fix issue #7608.
Since the problem was not very well defined, the fix is a bit fuzzy too...
Thanks to Luigi for accidentally spotting the possible problem!


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46252 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-25 19:16:10 +00:00