Joshua Colp
67a0bbaa83
Do not prematurely go on hold if sendonly was not actually set.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@63656 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-09 17:43:30 +00:00
Joshua Colp
c83c0072bb
Merged revisions 63610 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r63610 | file | 2007-05-09 12:51:03 -0400 (Wed, 09 May 2007) | 2 lines
Properly handle hints that point to multiple devices in chan_sip. Why chan_sip is even doing this I have no idea but I would rather not go into a rant. (issue #9536 reported by rlister)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@63611 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-09 16:54:56 +00:00
Olle Johansson
d30faa1dc2
Don't retransmit 200 OK's on ignore status. (Reported on asterisk-users)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@63532 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-09 13:04:14 +00:00
Joshua Colp
b50b92ab77
Minor backport of revision 59083 in trunk. Don't queue an unhold frame up if the call was never on hold to begin with.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@63283 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-07 21:26:58 +00:00
Joshua Colp
95de3fbf0c
Merged revisions 62987 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r62987 | file | 2007-05-03 13:42:19 -0300 (Thu, 03 May 2007) | 2 lines
When a peer is seeded or built tell the devicestate core to update it's status. This is easier then having chan_sip load before pbx_config. (issue #9658 reported by dlynes)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@62989 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-03 16:44:00 +00:00
Olle Johansson
d5fda03428
Don't unlock a channel that we already know does not exist (propably isue 8228)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@62624 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-02 06:15:43 +00:00
Olle Johansson
34f9e0c4dd
Merged revisions 62126 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r62126 | oej | 2007-04-27 15:57:45 +0200 (Fri, 27 Apr 2007) | 4 lines
Issue #7351 - SIP Cancel fails due to the wrong contact uri. Reported by PPYY, failed to fix by OEJ
final fix by wojtekka - THANKS!!!! THis was a hard one to catch.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@62137 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-27 14:04:07 +00:00
Joshua Colp
b271179161
Merged revisions 61771 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r61771 | file | 2007-04-24 12:05:06 -0400 (Tue, 24 Apr 2007) | 2 lines
Allow RFC2833 to be sent in the response SDP when an INVITE comes in without SDP. (issue #9546 reported by mcrawford)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@61772 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-24 16:07:02 +00:00
Olle Johansson
32be6621f6
Merged revisions 61685 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r61685 | oej | 2007-04-19 09:56:21 +0200 (Thu, 19 Apr 2007) | 3 lines
Send NOTIFY to Contact: in SUBSCRIBE
- as reported by Intertex and Citel. Fixed during SIPit 20 in Antwerp.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@61686 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-19 08:37:08 +00:00
Olle Johansson
dc6d309bdb
#9483 , half of patch by twilson to solve 302 redirect issues
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@61666 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-16 14:47:05 +00:00
Joshua Colp
eb631c00a3
For those very verbose SIP implementations that attach tons of info to the Contact header... let's increase our variable sizes. (issue #9535 reported by jeffg)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@61648 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-13 17:19:53 +00:00
Joshua Colp
c06e063e1a
Don't assume the callid of a dialog will be set, as in some circumstances it may not. (issue #9534 reported by tecnoxarxa)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@61641 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-13 16:32:03 +00:00
Russell Bryant
5858778f40
Merged revisions 61476 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r61476 | russell | 2007-04-11 11:01:25 -0500 (Wed, 11 Apr 2007) | 5 lines
If someone sets the "useragent" option in sip.conf to be empty, then don't add
the User-Agent header at all. It is an optional header, anyway. Also, the bug
report says that some of Japan's SIP providers don't allow it for some weird
reason. (issue #9488 , reported by makoto, fixed by me)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@61477 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-11 16:05:29 +00:00
Russell Bryant
a0d75effd5
Merged revisions 61426 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r61426 | russell | 2007-04-11 10:05:36 -0500 (Wed, 11 Apr 2007) | 6 lines
Fix a bug with switching between host=dynamic and using specific hosts for
peers. The code would only reset the peer's address when it is dynamic if
it was a new peer structure. Now, it will also reset the address if it was
already in the peer list, but before the reload, it was not dynamic.
(issue #9515 , reported by caio1982, fixed by me)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@61427 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-11 15:09:39 +00:00
Russell Bryant
9ce476a89c
Merged revisions 61376 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r61376 | russell | 2007-04-11 09:02:54 -0500 (Wed, 11 Apr 2007) | 5 lines
Remove the attempt at reporting configuration errors in sip.conf. This can
cause a bunch of improper messages when using realtime. I give up. As oej
tried to convince me when I put this in, there is just no easy way to do it.
(inspired by a message on the -dev list)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@61377 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-11 14:04:44 +00:00
Olle Johansson
3e5c59f235
Merged revisions 61038 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r61038 | oej | 2007-04-09 21:38:59 +0200 (Mon, 09 Apr 2007) | 3 lines
- Don't send ActionID before Response: header.
- Don't use a blank in an AMI header
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@61072 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-09 19:58:17 +00:00
Steve Murphy
7d5a79a0b9
This is a big improvement over the current CDR fixes. It may still need refinement, but this won't have as many folks bothered.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@60989 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-09 18:32:07 +00:00
Joshua Colp
a85156a737
Merged revisions 60213 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r60213 | file | 2007-04-05 08:52:50 -0400 (Thu, 05 Apr 2007) | 2 lines
Only unlock our pvt and net locks if we are actually going to try to lock the owner again. (issue #9472 reported by zoa)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@60214 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-05 12:55:02 +00:00
Russell Bryant
0b94c7c27c
Add a Content-Length of 0 to the response built by transmit_response_with_unsupported().
...
(issue #9454 , reported by makoto, fixed by me)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@60112 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-04 16:49:45 +00:00
Russell Bryant
3e058dab84
Merged revisions 60083 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r60083 | russell | 2007-04-04 11:37:04 -0500 (Wed, 04 Apr 2007) | 4 lines
Fix the return value of handle_common_options() so that it always properly
indicates whether it handled the option or not.
(issue #9455 , reported by Netview, fixed by me)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@60088 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-04 16:39:04 +00:00
Russell Bryant
dff65e38f4
Merged revisions 59938 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r59938 | russell | 2007-04-03 14:15:04 -0500 (Tue, 03 Apr 2007) | 4 lines
Don't attempt to report configuration errors in build_user(). oej pointed out
that for a "friend" entry, this won't work, because all user options are valid
for peers, but not the other way around.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@59939 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-03 19:16:53 +00:00
Russell Bryant
f8773a1e80
Merged revisions 59916 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r59916 | russell | 2007-04-03 13:43:54 -0500 (Tue, 03 Apr 2007) | 3 lines
Make chan_sip report when it encounters an unknown option.
(issue #9440 , reported by nightcrawler)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@59936 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-03 18:55:57 +00:00
Russell Bryant
a2fc7b9e36
Fix the check that ensures that the CHANNEL function's first argument is "rtpqos".
...
Thanks, Corydon. :)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@59262 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-27 18:17:47 +00:00
Russell Bryant
c0aca26f30
Convert the RTPQOS function to just be additional parameter of the CHANNEL
...
function. This way, it will be possible for other RTP based channel drivers
to expose this information in the future.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@59256 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-27 16:20:53 +00:00
Tilghman Lesher
0220349ca4
Oops, this should be case insensitive
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@59230 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-26 21:45:44 +00:00
Tilghman Lesher
ec028bd1b2
Change this to a single dp function to make oej happy.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@59227 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-26 21:37:41 +00:00
Russell Bryant
cd3238d543
Rename the new dialplan functions to match the variable name
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@59209 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-26 17:53:07 +00:00
Russell Bryant
fa97f6c381
The AUDIORTPQOS and VIDEORTPQOS variables are not fully functional in some
...
because they get set in sip_hangup. So, there are common situations where
the variables will not be available in the dialplan at all. So, this patch
provides an alternate method for getting to this information by introducing
AUDIORTPQOS and VIDEORTPQOS dialplan functions.
(issue #9370 , patch by Corydon76, with some testing by blitzrage)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@59207 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-26 17:45:55 +00:00
Joshua Colp
3b6f376425
Merged revisions 59194 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r59194 | file | 2007-03-23 21:35:49 -0400 (Fri, 23 Mar 2007) | 2 lines
Only try to handle a response if it has a response code. (ASA-2007-011)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@59195 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-24 01:39:44 +00:00
Kevin P. Fleming
cf58b2ba46
don't allow string input to overrun the buffer to hold it (ASA-2007-010)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@59182 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-22 23:40:01 +00:00
Joshua Colp
067876afbc
Until we can do media level parsing for sendrecv/etc just use the first value found. This crept up when a phone was offered audio+video and returned an inactive video stream. chan_sip thought the phone said to put the person on hold but that was totally wrong. (issue #9319 reported by benbrown)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@59081 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-21 03:25:48 +00:00
Olle Johansson
156c178143
Issue #9313 , Asterisk crash on SIP return code 0 (reported by qwerty1979) (ASA-2007-011)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@59037 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-18 20:37:06 +00:00
Russell Bryant
4fc7d081d3
Some people like to put "limitonpeer" instead of "limitonpeers" in their
...
configuration. While we're at it, support "limitonpeerz" and
"limitonpeerssssss". (inspired by issue #9172 )
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@58906 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-14 19:18:08 +00:00
Olle Johansson
0eda92609d
Merged revisions 58847 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r58847 | oej | 2007-03-13 12:45:52 +0100 (Tue, 13 Mar 2007) | 2 lines
Issue #9229 - No port in request URI on register to non default SIP ports (neelakantan)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@58848 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-13 11:49:35 +00:00
Olle Johansson
f546453573
Don't hangup the call on OK or errors on MESSAGE and INFO
...
inside of a dialog (like video update requests).
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@58845 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-13 10:03:03 +00:00
Olle Johansson
83bb6718fc
Issue #9251 - Clear From URI from user attributes (tgrman)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@58843 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-13 09:12:16 +00:00
Joshua Colp
fa866efb5c
Add matchexterniplocally setting which only substitutes your externip/externhost setting if it matches the localnet setting. I know of at least two people who need opposite settings, so I made it an option! (issue #8821 reported by kokoskarokoska)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@58779 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-12 00:51:16 +00:00
Joshua Colp
b9124234e9
Merged revisions 58579 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r58579 | file | 2007-03-09 15:46:43 -0500 (Fri, 09 Mar 2007) | 2 lines
If we are unable to lookup the host in a c line we have to abort, otherwise the previous data is gone and we will (potentially) have no data when all is said and done.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@58584 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-09 20:49:47 +00:00
Joshua Colp
240355d78b
Ensure we have (or should have) at least one matching codec before attempting early bridge SDP seeding. (issue #9221 reported by marcelbarbulescu)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@58240 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-07 17:52:58 +00:00
Steve Murphy
81ef9a4f18
Merged revisions 58115 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r58115 | murf | 2007-03-06 15:52:52 -0700 (Tue, 06 Mar 2007) | 1 line
Fix for 9220: Eyebeam cannot renew subscriptions for presence info. Reason: re-SUBSCRIBE requests don't include Accept headers, which the rfc says are optional (to put it tersely), (it uses MAY), and luckily, the sip_pvt struct has the format info stored, so we simply leave it if the format is set, and the accept header null.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@58121 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-06 23:10:14 +00:00
Olle Johansson
275abf4e08
Merged revisions 58052 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r58052 | oej | 2007-03-06 21:33:21 +0100 (Tue, 06 Mar 2007) | 2 lines
Change error message to proper message
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@58053 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-06 20:37:07 +00:00
Joshua Colp
53b9bc89c0
Merged revisions 57475 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r57475 | file | 2007-03-02 12:02:46 -0500 (Fri, 02 Mar 2007) | 2 lines
If a SIP message comes in and goes to a method handler that requires additional values that may not be present then send back an error.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@57477 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-02 17:06:52 +00:00
Joshua Colp
4565c1483c
Merged revisions 56230 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r56230 | file | 2007-02-22 13:44:24 -0500 (Thu, 22 Feb 2007) | 2 lines
Only change the original or clone channel if it's the channel behind the proxy channel, not if it's just a regular bridged channel.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@56231 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-22 18:49:39 +00:00
Olle Johansson
d67ef52159
Move message from verbose to debug
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@56125 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-22 10:33:55 +00:00
Russell Bryant
9a7d1cc182
Restructure a little bit of code to reduce nesting. There is no functionality
...
change here.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@56055 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-22 01:24:10 +00:00
Russell Bryant
71921a8329
Merged revisions 56010 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r56010 | russell | 2007-02-21 18:53:25 -0600 (Wed, 21 Feb 2007) | 3 lines
If we receive a frame that is not in any of the negotiated formats, then drop
it. (potentially issue #8781 and SPD-12)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@56011 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-22 00:57:36 +00:00
Joshua Colp
3d95841eb3
Add a flag that indicates whether a SIP dialog is an outgoing call or not. SIP_OUTGOING originally did it but it was repurposed to the direction of the last transaction, which can cause update_call_counter to falsely decrease the wrong counters. (please don't hurt me oej) (issue #8943 reported by mdu113)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@55914 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-21 17:18:19 +00:00
Olle Johansson
c0f5102378
Issue #8848 - Turn off lamp more quickly after transfer (decrement inuse early on transferer's call leg)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@55834 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-21 08:32:34 +00:00
Joshua Colp
30d30fef76
Return behavior I removed. I did not remember that you could just add a localnet entry to make it work.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@55717 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-20 23:57:03 +00:00
Joshua Colp
49749e44a2
Don't test our own address against the localnet settings. At least one person has had issues as a result of this from #7051 so I'm reversing it. (issue #8821 reported by kokoskarokoska)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@55688 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-20 23:08:45 +00:00