Commit Graph

1661 Commits

Author SHA1 Message Date
Mark Michelson
a8d3745147 Fixed an issue where chanspy flags were uninitialized if no options were passed.
What triggered this investigation was an IRC chat where some people's quiet flags were
set while others' weren't even though none of them had specified the q option.



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@75066 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-13 20:10:39 +00:00
Jason Parker
01412290a2 Fix an issue where it was possible to have a service level of over 100%
Between the time recalc_holdtime and update_queue was called, it was possible that the call could have been hungup.
Move both additions to the same place, so this won't happen.

Issue 10158, initial patch by makoto, modified by me.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@74427 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-10 19:57:20 +00:00
Jason Parker
c908fb91d1 Fix a small typo in description in of Voicemail() application.
Issue 10170, patch by casper.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@74316 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-10 15:37:54 +00:00
Joshua Colp
e32e830419 Tweak spy locking. (issue #9951 reported by welles)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@73349 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-05 14:19:14 +00:00
Joshua Colp
bf7b174b08 Reset ServicelevelPerf variable back to 0 if we are unable to calculate it each time... otherwise we will get previous values. (issue #10117 reported by noriyuki)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@73315 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-05 13:19:17 +00:00
Tilghman Lesher
ff1c0bfa20 RetryDial should accept a 0 argument, but it does not, because atoi does not distinguish between 0 and error (closes issue #10106)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@73052 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-03 12:34:14 +00:00
Joshua Colp
aac9dd609c Update documentation to clarify variable usage with MixMonitor. (issue #9494 reported by netoguy)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@72378 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-27 23:24:01 +00:00
Joshua Colp
5c8b322f8d Fix issue where queue log events might be missing. (issue #7765 reported by mtryfoss)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@72327 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-27 22:43:11 +00:00
Jason Parker
4ce4fe74ae Fix another problem in voicemail with missing symbols.
Issue 10074, patch by kryptolus, extended to include #if 0'd blocks (just in case)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@72184 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-27 18:40:15 +00:00
Tilghman Lesher
8f2a415995 Issue 10062 - Trying to move a message without selecting one first results in memory corruption
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@71750 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-26 12:25:58 +00:00
Joshua Colp
e179ccaff2 Don't explode if the gain option is specified without a value. (issue #9274 reported by mfarver)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@70898 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-21 21:37:55 +00:00
Tilghman Lesher
a1cc9b4966 Issue 9997 - Timelimit times out the wrong channel
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@70444 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 19:25:54 +00:00
Joshua Colp
e21d079484 Perform an extra hangup check just in case. (issue #9589 reported by bcnit)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@69894 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-19 13:54:03 +00:00
Russell Bryant
086aba207e Don't automatically hang up after running Dictate so that callers can exit
cleanly using '#'
(closes issue #9577, patch from Thomas Andrews)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@68526 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-08 22:22:36 +00:00
Jason Parker
a3961d646a Don't try to save voicemail greetings unless the user presses '1' to accept/save.
Issue 9904, patch by me.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@68204 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 20:02:50 +00:00
Joshua Colp
9c0627eab0 Allow the 'g' option to work if used with the 'S' option. (issue #9888 reported by gasparz)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@68070 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 14:19:40 +00:00
Tilghman Lesher
c0ce087e43 Issue 9818 - Fix for issue 8329 breaks pbx_realtime. Issue 8329 will remain unfixed for pbx_realtime, but only because we lack core API to do it.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@66744 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-31 15:58:45 +00:00
Russell Bryant
03ad135134 Fix a memory leak that I just noticed in the device state handling in app_queue.
On most device state changes, it would leak roughly 8 to 64 bytes (the length of
the name of the device).


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@65389 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-22 13:07:03 +00:00
Steve Murphy
fd1fc0a9c1 This update will fix the situation that occurs as described by 9717, where when several targets are specified for a dial, if any one them reports FAIL, the whole call gets FAIL, even though others were ringing OK. I rearranged the priorities, so that a new disposition, NULL, is at the lowest level, and the disposition get init'd to NULL. Then, next up is FAIL, and next up is BUSY, then NOANSWER, then ANSWERED. All the related set routines will only do so if the disposition value to be set to is greater than what's already there. This gives the intended effect. So, if all the targets are busy, you'd get BUSY for the call disposition. If all get BUSY, but one, and that one rings is not answered, you get NOANSWER. If by some freak of nature, the NULL value doesn't get overridden, then the disp2str routine will report NOANSWER as before.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@65172 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-18 20:56:20 +00:00
Jason Parker
dfd24c33d2 If we have a negative current message, we shouldn't go back even further...
Issue 9727.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@64758 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-17 16:52:38 +00:00
Tilghman Lesher
47047d5004 Replicate fix from 51158 (app_voicemail) to app_directory (Issue 9224)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@63565 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-09 14:48:06 +00:00
Tilghman Lesher
25930c842f Issue 9602 - segfault in app_macro
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@63477 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-08 22:19:15 +00:00
Tilghman Lesher
616e3502e7 Issue 9527 - upon entering a folder, no message is selected (curmsg == -1), so deleting causes memory corruption (beyond bounds)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@63359 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-08 06:20:16 +00:00
Joshua Colp
6ab97a0292 Merge rewritten group counting support. No more storing data on the variable list of the channels. That was bad, mmmk? (issue #7497 reported by sabbathbh)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@61804 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-25 18:52:50 +00:00
Jason Parker
c28413ff94 If the '* to hangup' option is not enabled, we don't need to disable * as a valid exit key.
If it was enabled, this statement would've never been checked in the first place.

Issue #9552


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@61692 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-20 19:49:54 +00:00
Joshua Colp
4b17148846 Add OUTBOUND_GROUP_ONCE variable to app_dial. This behaves the same as OUTBOUND_GROUP except it will get unset after use so it won't get accidentally inherited. (issue #BE-140)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@61655 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-13 19:15:12 +00:00
Jason Parker
62de701abb Allow matching on names shorter than 3 chars.
This also fixes the case where somebody wants to match on less then 3 chars.

Issue 9071


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@60935 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-09 17:22:15 +00:00
Joshua Colp
f2680a35d4 When calling a device that then forwards us elsewhere... we have to make our channels compatible if it is the only channel being dialed. (issue #9445 reported by marcelbarbulescu)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@60797 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-09 00:59:29 +00:00
Tilghman Lesher
2e1fe209de Gosub called within a Macro resets the arguments improperly and causes general weirdness. (Issue 8329)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@60711 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-08 14:00:22 +00:00
Jason Parker
6374772250 Just because we can't find the voicemail configuration file, doesn't
mean that the module failed to load.  The user could be using realtime.

Issue #9473


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@60267 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-05 16:09:41 +00:00
Joshua Colp
5e01069962 Increase the maximum size for a string of mailboxes to 1024. (issue #9270 reported by rtucker)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@59723 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-02 18:55:25 +00:00
Joshua Colp
ec7458a460 Keep a global array of variables indicating whether certain conference rooms are in use. This ensures that two people going into a new dynamic conference when the 'e' option is set don't go into the same conference room. (issue #8835 reported by eliel)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@59360 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-29 17:33:58 +00:00
Tilghman Lesher
7ca5863965 Oops
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@59283 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-27 23:36:49 +00:00
Tilghman Lesher
43ac3f119b Fix a few remaining bad mmap(2) return values
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@59280 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-27 23:31:20 +00:00
Russell Bryant
653b6f22c5 Fix the check of the return value from mmap(). Thanks to Corydon for catching
this one.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@59277 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-27 23:19:41 +00:00
Steve Murphy
714e570302 Ugh. that was dumb. Fixed an error.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@59187 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-23 16:07:45 +00:00
Steve Murphy
fe9bbc5dfc Added a few words in the Macro doc strings about the behavior of macros with hangups (et al.), as per 9337
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@59186 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-23 15:57:26 +00:00
Joshua Colp
c17a4c7f53 Make create_dirpath use our standard for return values. -1 is failure, 0 is success. (issue #9205 reported by ballares)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@57869 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-05 17:49:18 +00:00
Tilghman Lesher
12a38f8e56 Memory leak of a list, if call recording was abandoned
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@57648 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-03 06:36:55 +00:00
Joshua Colp
aa54a5f91b Change naughty warning message to provide useful information. If a write now fails on a channel in meetme it will tell you the channel name instead of spitting out the wrong error message.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@55956 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-21 20:32:16 +00:00
Russell Bryant
602c5bb8c3 Fix random crashes when using the MeetMe application. This patch converts list
handling to use the linked list macros and most importantly, implements
reference counting on the ast_conference objects.  The reference counting was
first backported from 1.4.  However, that code has some problems that caused
the reference count to never hit zero.  Those problems are fixed in this patch
and will be resolved in 1.4 and trunk next, with a different patch.

(issues #7647, #9073, #9106, BE-115). 


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@55750 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-21 00:19:14 +00:00
Russell Bryant
82bc576ea4 Convert a tab to spaces so that the documentation is printed out properly
aligned.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@55588 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-20 19:49:50 +00:00
Tilghman Lesher
fababa3b74 forcename and forcegreetings options should check to see if the recording already exists
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@55434 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-19 18:09:09 +00:00
Olle Johansson
179c829291 Documentation update (#9053, jsmith)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@55277 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-18 12:32:13 +00:00
Joshua Colp
975f117300 Answer the channel before recording privacy information. (issue #8926 reported by lmamane)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@55153 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-17 03:53:45 +00:00
Russell Bryant
c9c943e8e2 Revert the change I did in revisions 54955, 54969, and 54970, in 1.2, 1.4,
and trunk.  I decided that once a conference is created from meetme.conf,
it is acceptable behavior that the pin can not be changed until the
conference goes away.  I also added a note in meetme.conf to describe this
behavior.

We still have another issue in 1.4 and trunk where some conferences with no
users don't go away.  That is the real bug that needs to be addressed here.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@55005 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-16 22:48:22 +00:00
Russell Bryant
2802ea3eeb For conferences that are configured in meetme.conf, check the configuration
file every time someone joins the conference instead of only when the
conference is first created.  This is to ensure that changes to the pin
numbers in the config file are always honored.  (issue #9073)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@54955 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-16 20:56:58 +00:00
Joshua Colp
041061ca36 Use a separate variable to indicate execution should continue instead of the return value. (issue #8842 reported by pluto70)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@54622 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-15 16:14:40 +00:00
Tilghman Lesher
f49ce518ba Issue 9003 - If fullname is empty, quote() passes back "\""
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@53529 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-08 13:36:10 +00:00
Tilghman Lesher
7d1af2b829 Issue 7440 - Macro called from Macro from the h extension exits prematurely
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@53354 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-07 15:30:02 +00:00