Commit Graph

2149 Commits

Author SHA1 Message Date
Olle Johansson
1dc6524449 Make some notes about a problem I found with the OPTIONs handler while working with
the bug tracker. Since we don't authenticate devices (peers/users) on OPTIONS we don't
have the proper context set for the user/peer. 

However, we might not want to process an authentication for every OPTIONS, so we could
have a config option for this, "optionsforceok" to always answer 200 OK on the request
and not check device or destination, nor add a SDP. If Asterisk sends the OPTIONs request,
it doesn't care about the reply. Some devices use OPTIONs to discover capabilities,
since we should answer like an INVITE from the device and we need to support that properly
too, which we don't today.

So much to do :-)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89404 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-19 08:34:26 +00:00
Luigi Rizzo
5663ff6518 fix breakage induced by previous mistake
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89382 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-17 14:45:46 +00:00
Luigi Rizzo
4afe3b5ba9 remove redundant #include "asterisk/compat.h",
but make sure that asterisk/compiler.h is included everywhere



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89336 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-16 21:08:28 +00:00
Luigi Rizzo
fdb7f7ba3d Start untangling header inclusion in a way that does not affect
build times - tested, there is no measureable difference before and
after this commit.

In this change:

use asterisk/compat.h to include a small set of system headers:
inttypes.h, unistd.h, stddef.h, stddint.h, sys/types.h, stdarg.h,
stdlib.h, alloca.h, stdio.h

Where available, the inclusion is conditional on HAVE_FOO_H as determined
by autoconf.

Normally, source files should not include any of the above system headers,
and instead use either "asterisk.h" or "asterisk/compat.h" which does it
better. 

For the time being I have left alone second-level directories
(main/db1-ast, etc.).



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89333 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-16 20:04:58 +00:00
Joshua Colp
e7e208009f And file said... let trunk build again! Accomplished by some more constification, and marking a function in chan_sip as purposely unused until it is fixed up.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89290 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-15 15:21:04 +00:00
Olle Johansson
8740176dc3 Always relying on the responses when crossing NAT's are not a good
solution, it breaks communication.
Rizzo - you need to implement a configuration option for this 
code. It's good, but maybe should be off by default.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89285 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-15 12:21:57 +00:00
Olle Johansson
a4ce44bda4 Merged revisions 89281 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89281 | oej | 2007-11-15 12:26:22 +0100 (Tor, 15 Nov 2007) | 6 lines

Don't send re-invites during pending INVITE transactions.

Patch by one47 - thanks!

Closes issue #9305

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89283 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-15 11:31:27 +00:00
Olle Johansson
c698e39245 Merged revisions 89280 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89280 | oej | 2007-11-15 12:15:09 +0100 (Tor, 15 Nov 2007) | 5 lines

Improve support for multipart messages. Code by gasparz, changes
by me (mostly formatting). Thanks, gasparz!

Closes issue #10947

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89282 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-15 11:27:19 +00:00
Olle Johansson
257b4fb41e Exit early instead of deciding to exit after processing the message.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89279 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-15 10:26:00 +00:00
Olle Johansson
eab6b00904 Add support for application/dtmf SIP INFO dtmf handling. Yep, another
way of handling DTMF in SIP. Totally undocumented, but implemented
in enough devices so we have to support it. 

Code by sergee, small changes by oej.

Closes issue #11049


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89278 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-15 10:21:41 +00:00
Luigi Rizzo
7f8ecd2cd3 make the 'name' and 'value' fields in ast_variable const char *
This prevents modifying the strings in the stored variables, 
and catched a few instances where this was actually done.

Given the differences between trunk and 1.4 (and the fact that this
is effectively an API change) it is better to fix 1.4 independently.
These are

chan_sip.c::sip_register()
chan_skinny.c:: near line 2847
config.c:: near line 1774
logger.c::make_components()
res_adsi.c:: near line 1049

I may have missed some instances for modules that do not build here.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89268 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-14 13:18:40 +00:00
Russell Bryant
50426062b7 - Convert initialization of a struct to C99 style instead of GNU style
- Fix a minor spelling error in a comment


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89251 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-13 20:53:49 +00:00
Tilghman Lesher
f821071748 Merged revisions 89246 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89246 | tilghman | 2007-11-13 11:34:11 -0600 (Tue, 13 Nov 2007) | 2 lines

If we set a value for qualify, we should actually pay attention to it, instead of overriding the value

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89247 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-13 17:41:02 +00:00
Tilghman Lesher
061e5a1674 Merged revisions 89184 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89184 | tilghman | 2007-11-12 11:29:17 -0600 (Mon, 12 Nov 2007) | 5 lines

Fix two cases of memory corruption caused by background threads.
Reported by: atis
Patch by: tilghman
Fixes issue #10923

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89185 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-12 17:44:04 +00:00
Mark Michelson
beef61b718 Merged revisions 89119 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89119 | mmichelson | 2007-11-08 15:00:08 -0600 (Thu, 08 Nov 2007) | 7 lines

Rework of the commit I made yesterday to use the already built-in
ast_uri_decode function as opposed to my home-rolled one. Also added
comments.

Thanks to oej for pointing me in the right direction


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89120 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-08 21:01:02 +00:00
Joshua Colp
6878c9962a Merged revisions 89101 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89101 | file | 2007-11-07 22:26:48 -0400 (Wed, 07 Nov 2007) | 4 lines

Do not add a sip: to the beginning of the To URI unless needed.
(closes issue #10756)
Reported by: goestelecom

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89102 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-08 02:28:15 +00:00
Joshua Colp
5a63438787 Merged revisions 89099 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89099 | file | 2007-11-07 21:28:56 -0400 (Wed, 07 Nov 2007) | 6 lines

Improve the devicestate logic for multiple devices. If any are available then the extension is considered available.
(closes issue #10164)
Reported by: nic_bellamy
Patches:
      sip-hinting-svn-branch-1.4.patch uploaded by nic (license 299)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89100 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-08 01:30:29 +00:00
Joshua Colp
f34bb18940 Merged revisions 89097 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89097 | file | 2007-11-07 21:11:25 -0400 (Wed, 07 Nov 2007) | 8 lines

Add support for allowing one outgoing transaction. This means if a response comes back out of order chan_sip will still handle it. I dream of a chan_sip with real transaction support.
(closes issue #10946)
Reported by: flefoll
(closes issue #10915)
Reported by: ramonpeek
(closes issue #9567)
Reported by: atca_pres

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89098 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-08 01:14:31 +00:00
Joshua Colp
7c6127ceef Merged revisions 89095 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89095 | file | 2007-11-07 19:53:25 -0400 (Wed, 07 Nov 2007) | 4 lines

If callerid is configured in sip.conf use that for checking the presence of an extension in the dialplan.
(closes issue #11185)
Reported by: spditner

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89096 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-07 23:55:08 +00:00
Mark Michelson
9aca31f0fc Merged revisions 89090 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89090 | mmichelson | 2007-11-07 16:40:35 -0600 (Wed, 07 Nov 2007) | 6 lines

This patch makes it possible for SIP phones to dial extensions defined with '#' characters
in extensions.conf AND maintain their escaped characters when forming URI's

(closes issue #10681, reported by cahen, patched by me, code review by file)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89091 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-07 22:42:24 +00:00
Tilghman Lesher
7c56918262 Commit some cleanups to the format type code.
- Remove the AST_FORMAT_MAX_* types, as these are consuming 3 out of our available 32 bits.
 - Add a native slin16 type, so that 16kHz codecs can translate without losing resolution.
   (This doesn't affect anything immediately, until another codec has wb support.)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89071 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-06 22:51:48 +00:00
Mark Michelson
5a4867543d "show application <foo>" changes for clarity.
(closes issue #11171, reported and patched by blitzrage)

Many thanks!



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89044 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-06 19:04:45 +00:00
Joshua Colp
b4031d6294 Merged revisions 89032 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89032 | file | 2007-11-06 13:08:05 -0400 (Tue, 06 Nov 2007) | 4 lines

Make it so that if a peer is determined to be unreachable using qualify their devicestate will report back unavailable.
(closes issue #11006)
Reported by: pj

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89034 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-06 17:10:03 +00:00
Russell Bryant
44bf973865 Merged revisions 88768 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r88768 | russell | 2007-11-05 15:33:56 -0600 (Mon, 05 Nov 2007) | 8 lines

When traversing the list of channel variables here in transmit_invite(), the 
asterisk channel must be locked, as this data may change at any time.

(I have seen numerous reports of crashes related to the handling of channel
variables.  There are a couple of issues on the bug tracker related to it,
but it has also been noted on IRC and mailing lists.  So, I am finding and
fixing some places where channel variables are handled improperly.) 

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@88769 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-05 21:35:51 +00:00
Russell Bryant
a33b10fe00 Merged revisions 88765 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r88765 | russell | 2007-11-05 15:21:39 -0600 (Mon, 05 Nov 2007) | 2 lines

Fix up some indentation.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@88766 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-05 21:23:32 +00:00
Joshua Colp
dbd26a0a19 Merged revisions 88671 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r88671 | file | 2007-11-05 14:47:13 -0400 (Mon, 05 Nov 2007) | 7 lines

If a SIP channel is put on hold multiple times do not keep incrementing the onHold value.
(closes issue #11085)
Reported by: francesco_r
Tested by: blitzrage
(closes issue #10474)
Reported by: acennami

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@88673 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-05 18:52:12 +00:00
Jason Parker
135810daf9 Merged revisions 88585 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

(closes issue #11163)
........
r88585 | qwell | 2007-11-05 11:19:41 -0600 (Mon, 05 Nov 2007) | 4 lines

Make sure we destroy the config structure on configuration failure.

Issue 11163, patch by eliel.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@88586 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-05 17:21:05 +00:00
Luigi Rizzo
08b10da53b Simplify the implementation and the API for stringfields;
details and examples are in include/asterisk/stringfields.h.

Not applicable to older branches except for 1.4 which will
receive a fix for the routines that free memory pools.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@88454 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-04 19:44:31 +00:00
Joshua Colp
17f0f4c3fa Merged revisions 88366 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r88366 | file | 2007-11-02 17:49:45 -0300 (Fri, 02 Nov 2007) | 4 lines

Make subscribecontext behave as advertised. It will now look for the presence of a hint in the given context (be it subscribecontext or context).
(closes issue #10702)
Reported by: slavon

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@88367 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-02 20:51:53 +00:00
Joshua Colp
a7c6c47e61 Merged revisions 88328 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r88328 | file | 2007-11-02 17:20:21 -0300 (Fri, 02 Nov 2007) | 6 lines

If an INFO request within a dialog is received with a content length of 0 simply send back a 200 OK. It is valid to do this and the remote side is probably using it to make sure the signalling is still alive.
(closes issue #5747)
Reported by: chandi
Patches:
      infofix-81430-1.patch uploaded by IgorG (license 20)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@88329 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-02 20:22:40 +00:00
Russell Bryant
1c7eb1d82b Change some uses of free() to ast_free(). (No functional differences.)
(closes issue #11138)
Reported by: eliel
Patches: 
      pbx_dundi.c.patch uploaded by eliel (license 64)
	  chan_sip.c.patch uploaded by eliel (license 64)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@88077 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-01 15:56:25 +00:00
Joshua Colp
230e7f0ee0 Merged revisions 87342 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r87342 | file | 2007-10-29 14:20:28 -0300 (Mon, 29 Oct 2007) | 6 lines

Fix issue where if both sides of the dialog cancelled the dialog at the same time chan_sip could kepe retransmitting a response for no reason.
(closes issue #9566)
Reported by: atca_pres
Patches:
      bug9566.patch uploaded by oej

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@87343 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-29 17:22:16 +00:00
Jason Parker
ebe4050128 Switch from AST_CLI (formerly NEW_CLI) to AST_CLI_DEFINE, since the former didn't make much sense
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@86820 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-22 20:05:18 +00:00
Joshua Colp
d167f88947 Merged revisions 86756 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r86756 | file | 2007-10-22 13:35:22 -0300 (Mon, 22 Oct 2007) | 4 lines

After reading online I have confirmed that Record-Route headers should be copied to 1xx responses as well.
(closes issue #10113)
Reported by: makoto

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@86757 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-22 16:36:56 +00:00
Jason Parker
b0f3e6097e Convert NEW_CLI to AST_CLI.
Closes issue #11039, as suggested by seanbright.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@86536 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-19 18:29:40 +00:00
Joshua Colp
eafb395b09 Merged revisions 86471 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r86471 | file | 2007-10-19 12:33:49 -0300 (Fri, 19 Oct 2007) | 6 lines

Fix two issues with domains and transfers. If a port was given in the hostname it was treated as part of the hostname. If domains were configured but external domains were not enabled all transfers would be considered remote.
(closes issue #11027)
Reported by: ramonpeek
Patches:
      11027-1.diff uploaded by ramonpeek (license 266)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@86472 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-19 15:36:27 +00:00
Joshua Colp
2d9034d87e Merged revisions 86469 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r86469 | file | 2007-10-19 12:08:12 -0300 (Fri, 19 Oct 2007) | 4 lines

Set port number in received as information for registrations as well.
(closes issue #11028)
Reported by: brad-x

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@86470 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-19 15:10:24 +00:00
Russell Bryant
ba2768f4df Merged revisions 86149 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r86149 | russell | 2007-10-17 12:57:45 -0500 (Wed, 17 Oct 2007) | 8 lines

If Asterisk is in the middle of shutting down, respond to OPTIONS
with 503 Unavailable.

(closes issue #10994)
Reported by: eserra
Patches:
      sip-options-503.patch uploaded by eserra (license 45)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@86150 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-17 18:01:38 +00:00
Joshua Colp
1a4171ae6b Merged revisions 86117 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r86117 | file | 2007-10-17 13:58:03 -0300 (Wed, 17 Oct 2007) | 4 lines

Whoops, forgot to remove the original sip_scheddestroy.
(closes issue #11010)
Reported by: vadim

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@86118 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-17 17:00:13 +00:00
Joshua Colp
e24eee1797 Merged revisions 86063 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r86063 | file | 2007-10-17 12:06:36 -0300 (Wed, 17 Oct 2007) | 4 lines

Don't schedule dialog destruction if a MESSAGE is received using an existing dialog.
(closes issue #11010)
Reported by: vadim

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@86064 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-17 15:09:36 +00:00
Russell Bryant
8fae310e81 This fixes SIP subscriptions in trunk.
Don't improperly memset() over an ast_str.  This was leftover from before it
got changed to use ast_str.

(closes issue #11003, reported by pj)
(closes issue #10770, reported by yehavi)
(patched by me)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@85944 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-16 20:32:16 +00:00
Jason Parker
ed690fc348 Switch dundi to new tos config format.
Remove old unused defines for old style.

Closes issue 10860, patch by IgorG.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@85764 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-15 23:20:40 +00:00
Russell Bryant
d79fe9b662 Merged revisions 85604 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r85604 | russell | 2007-10-15 11:54:57 -0500 (Mon, 15 Oct 2007) | 6 lines

Make the default for the srvlookup option to be yes.  It doesn't really make
sense for it to default to off.  The default configuration file has it on, and
proper RFC behavior, as indicated by a comment in the code, is for it to be on.
So, let's have it on by default to make lives easier.
(closes issue #10954, suggested by jtodd)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@85605 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-15 16:59:53 +00:00
Joshua Colp
15f3f5408c Merged revisions 85280 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r85280 | file | 2007-10-10 11:42:00 -0300 (Wed, 10 Oct 2007) | 4 lines

If devicestate is passed a port number strip it out.
(closes issue #10930)
Reported by: ibc

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@85281 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-10 14:43:37 +00:00
Joshua Colp
96f7f62acb Merged revisions 85277 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r85277 | file | 2007-10-10 11:28:18 -0300 (Wed, 10 Oct 2007) | 6 lines

Add support for handling a 182 Queued response.
(closes issue #10924)
Reported by: ramonpeek
Patches:
      queued-182.diff uploaded by ramonpeek (license 266)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@85278 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-10 14:30:05 +00:00
Joshua Colp
d9909a0151 Merged revisions 85093 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r85093 | file | 2007-10-09 11:30:16 -0300 (Tue, 09 Oct 2007) | 4 lines

Don't perform a reinvite if a transfer is in progress.
(issue #10915)
Reported by: ramonpeek

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@85094 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-09 14:31:27 +00:00
Russell Bryant
f58f7170d4 Merged revisions 84370 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r84370 | russell | 2007-10-02 09:12:35 -0500 (Tue, 02 Oct 2007) | 6 lines

Use snprintf instead of sprintf in one place.  There is no vulnerability here
due to various buffer sizes around the code, but I still didn't like seeing a
non length-limited copy of data coming off of the wire into a stack buffer, as
this would be a problem in the future if buffer sizes elsewhere got changed or
size limitations removed ...

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@84371 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-02 14:13:28 +00:00
Joshua Colp
5ae00a58b3 Check to make sure a structure pointer is non-NULL before touching it... crashing is bad, mmmk?
(closes issue #10831)
Reported by: eliel
Patches:
      chan_sip.c.patch uploaded by eliel (license 64)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@84176 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-01 15:57:04 +00:00
Russell Bryant
d78463be1e Corydon posted this janitor project to the bug tracker and mvanbaak provided
a patch for it.  It replaces a bunch of simple calls to snprintf with ast_copy_string

(closes issue #10843)
Reported by: Corydon76
Patches: 
      2007092900_10843.diff uploaded by mvanbaak (license 7)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@84173 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-01 15:23:19 +00:00
Joshua Colp
acb9d6bf2b Add MP4 to part of the SDP code.
(closes issue #10820)
Reported by: ruikubo
Patches:
      chan_sip.patch uploaded by ruikubo (license 250)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@84165 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-10-01 14:21:06 +00:00