Commit Graph

3370 Commits

Author SHA1 Message Date
Olle Johansson
318fd4186b KILL THE USER!
Actually, kill the in-memory structure for type=user and start using the sip_peer 
structure for every object. Have only one in-memory list and use them different
ways depending on type=user, type=peer and type=friend - like always.

The idea with this first patch is that configurations should work as before.

Some additional features for realtime peers. By adding a type= field, you
can now have multiple functions.

Let's test this for a while. Won't be integrated in 1.6.0, only in trunk,
for testing.

There's propably more to clean up and simplify here. Help is welcome
and encouraged!


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128242 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-05 20:59:49 +00:00
Olle Johansson
b04d101ee5 Stop cli command completion with tabs
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128201 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-05 20:04:50 +00:00
Olle Johansson
0a52297cf0 Add new SIP cli command "sip show channelstats" that displays some QoS data (if we have RTCP reports
and not use the p2p rtp bridge). I could not find a way to detect us using the p2p bridge, which
would be nice.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128197 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-05 19:27:42 +00:00
Tilghman Lesher
1d0637521a Fullcontact needs more than 20 characters, even for the simplest case
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@128082 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-04 16:41:03 +00:00
Olle Johansson
6f621e6205 - reorganize SIP extensions alphabetically, to make it easier to synch with the IANA list
- add a few new registered and well-known extension names


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127995 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-04 14:36:28 +00:00
Steve Murphy
bc2cfb3e81 Merged revisions 127663 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r127663 | murf | 2008-07-02 18:16:25 -0600 (Wed, 02 Jul 2008) | 30 lines

The CDRfix4/5/6 omnibus cdr fixes.

(closes issue #10927)
Reported by: murf
Tested by: murf, deeperror

(closes issue #12907)
Reported by: falves11
Tested by: murf, falves11


(closes issue #11849)
Reported by: greyvoip

As to 11849, I think these changes fix the core problems 
brought up in that bug, but perhaps not the more global
problems created by the limitations of CDR's themselves
not being oriented around transfers.

Reopen if necc, but bug reports are not the best
medium for enhancement discussions. We need to start
a second-generation CDR standardization effort to cover
transfers.

(closes issue #11093)
Reported by: rossbeer
Tested by: greyvoip, murf



........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127793 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-03 17:16:44 +00:00
Olle Johansson
f99a310219 Make sure we stop session timers as soon as we start hanging up an active call.
May fix issue 12919.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127791 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-03 16:48:23 +00:00
Olle Johansson
2491cc6e65 Revert some logic for session timers. We do send in-dialog requests that should not have session-timer
require headers, like MESSAGE and REFER. So in the future, only add them on requests and responses
that are related to INVITEs and re-INVITEs.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127779 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-03 16:25:59 +00:00
Olle Johansson
b423a939b0 Fix bad formatting in a very confusing function. Who added the sipdb sql output?
It's mixing peers and users in a strange way and should really not be a CLI command,
since it's not meant for human output. It should be done with an app connecting to
manager.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127685 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-03 09:59:12 +00:00
Brett Bryant
6aa9419cfe Update transport= in sip so that the option is not broken from a recent commit.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127621 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-02 22:16:29 +00:00
Tilghman Lesher
885d17506b Keep ast_app_inboxcount API compatible with 1.6.0.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127609 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-02 21:27:53 +00:00
Brett Bryant
b30ed551e0 Fix to sip_parse_host so that it passes the correct information to sip_registry.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127434 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-02 17:27:36 +00:00
Tilghman Lesher
cce1ec5463 Change the global timer B to be dependent on the value of the T1 timer, as
recommended in RFC 3261, instead of being hardcoded to 32 seconds.  This is
important for LANs, as it allows autocongestion to occur much more quickly, if
desired by the local PBX administrator.  It also corrects a bug: if the T1
timer was increased beyond 500ms, then timer B would have been set at a much
lower value than recommended.
(closes issue #12544)
 Reported by: kactus
 Patches: 
       20080616__bug12544.diff.txt uploaded by Corydon76 (license 14)
 Tested by: kactus


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127297 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-02 02:48:43 +00:00
Brett Bryant
1b07e87538 Add a configuration option so the global outboundproxy can use tcptls without it being defined by each sip user.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@127154 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 21:03:52 +00:00
Olle Johansson
b6b5525347 Merged revisions 126902 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r126902 | oej | 2008-07-01 16:59:31 +0200 (Tis, 01 Jul 2008) | 7 lines

Use domain part of SIP uri in register= configuration as fromdomain.

Reported by: one47
Patches: 
      sip-reg-fromdom2.dpatch uploaded by one47 (license 23)
(closes issue #12474)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126903 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 15:03:59 +00:00
Olle Johansson
f3170a4946 Merged revisions 126899 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r126899 | oej | 2008-07-01 16:27:33 +0200 (Tis, 01 Jul 2008) | 8 lines

Handle escaped URI's in call pickups. Patch by oej and IgorG.

Reported by: IgorG
Patches: 
      bug12299-11062-v2.patch uploaded by IgorG (license 20)
Tested by: IgorG, oej
(closes issue #12299)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126900 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 14:32:15 +00:00
Olle Johansson
42bed356d1 Merged revisions 126789 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r126789 | oej | 2008-07-01 13:51:38 +0200 (Tis, 01 Jul 2008) | 6 lines

Report 200 OK to all in-dialog OPTIONs requests (to confirm that the dialog
exist). Don't bother checking the request URI.

(closes issue #11264)
Reported by: ibc

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126790 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 11:58:17 +00:00
Olle Johansson
983b851e3b Merged revisions 126735 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r126735 | oej | 2008-07-01 09:49:15 +0200 (Tis, 01 Jul 2008) | 7 lines

Fix bad XML for hold notification.
Reported by: gowen72
Patches: 
      hold.patch uploaded by gowen72 (license 432)
(closes issue #12942)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126755 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-01 09:51:22 +00:00
Olle Johansson
33a54ee23b The following patch with some changes for trunk...
Merged revisions 126516 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r126516 | oej | 2008-06-30 14:50:55 +0200 (MÃ¥n, 30 Jun 2008) | 10 lines

Send all responses to an INVITE reliably, so that we retransmit if we don't get an ACK and
also fail if we don't get the very same precious ACK. Based on patch by tsearle, with
my own additions.

(closes issue #12951)

Reported by: tsearle
Patches: 
      busy_retransmit.patch uploaded by tsearle (license 373)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126517 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-30 13:03:53 +00:00
Tilghman Lesher
1503ea7128 Merged revisions 126056 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r126056 | tilghman | 2008-06-27 17:01:09 -0500 (Fri, 27 Jun 2008) | 4 lines

When we get a 408 Timeout, don't stop trying to re-register.
(closes issue #12863)
 Reported by: ricvil

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@126057 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-27 22:10:34 +00:00
Brett Bryant
4ebadd6d21 Small error in the function that converts peer transports to a string.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125947 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-27 17:35:41 +00:00
Brett Bryant
12d5cebea2 Change the way that the transport option works for sip users. transport will now take multiple arguments, the first one listed will be the one used
for new dialogs, and the rest listed will be acceptable ways for that peer to contact us. This fixes a minor bug where, because SIP TCP/UDP run on 
the same port, could cause a TCP peer to be saved in the ast_db. There will also be warnings when a transport is changed for an unexpected reason.

(issue #12799)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125891 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-27 16:28:06 +00:00
Olle Johansson
4f32bf72f9 Merged revisions 125384 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r125384 | oej | 2008-06-26 18:32:08 +0200 (Tor, 26 Jun 2008) | 3 lines

Add support for peer realm based auth (a few missing lines, the rest is well documented but never worked)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@125385 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-26 16:54:22 +00:00
Mark Michelson
0f62296eb6 Add a missing "ChannelType" header to one of the "PeerStatus" manager
events in chan_sip

(closes issue #12904)
Reported by: eliel
Patches:
      chan_sip.c.patch uploaded by eliel (license 64)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124243 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-20 15:20:11 +00:00
Michiel van Baak
8e8359465b Older versions of GNU gcc do not allow 'NULL' as sentinel.
They want (char *)NULL as sentinel.
An example is OpenBSD (confirmed on 4.3) that ships with gcc 3.3.4

This commit introduces a contstant SENTINEL which is declared as:
#define SENTINEL ((char *)NULL)

All places I could test compile on my openbsd system are converted.
Update CODING-GUIDELINES to tell about this constant.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124127 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-19 20:48:33 +00:00
Brett Bryant
249ac33ab0 Fix bug in sip registration that sets the default port to 5060 for tls.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@124024 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-19 18:57:04 +00:00
Brett Bryant
2aae0ba13d Updates all usages of ast_tcptls_session_instance to be managed by reference counts so that they only get destroyed when all threads are done using
them, and memory does not get free'd causing strange issues with SIP. 

This code was originally written by russellb in the team/group/issue_11972/ branch.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123546 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-17 21:46:57 +00:00
Mark Michelson
67ca33e267 Merged revisions 123485 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r123485 | mmichelson | 2008-06-17 15:26:38 -0500 (Tue, 17 Jun 2008) | 4 lines

Make chan_sip build under dev mode with compilers >= GCC 4.2
Thanks to jpeeler for alerting me of this


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123486 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-17 20:28:47 +00:00
Steve Murphy
bb20ef7017 Changes to list peers and users in alpha. order, as per a reasonable request in 12494. Due to changes in trunk to use the astobj2 i/f in the sip channel driver, the order of the entries in the config file was lost, thus the output was in a random order, but no longer.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123448 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-17 20:17:20 +00:00
Mark Michelson
8c6184f0da Merged revisions 123333 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r123333 | mmichelson | 2008-06-17 13:09:16 -0500 (Tue, 17 Jun 2008) | 11 lines

Cisco BTS sends SIP responses with a tab between the Cseq number and
SIP request method in the Cseq: header. Asterisk did not handle this
properly, but with this patch, all is well.

(closes issue #12834)
Reported by: tobias_e
Patches:
      12834.patch uploaded by putnopvut (license 60)
Tested by: tobias_e


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123334 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-17 18:09:54 +00:00
Tilghman Lesher
596f8b5186 Merged revisions 123113 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r123113 | tilghman | 2008-06-16 14:50:12 -0500 (Mon, 16 Jun 2008) | 2 lines

Port "hasvoicemail" change from SIP to other channel drivers

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123114 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-16 19:57:05 +00:00
Tilghman Lesher
ba07bd38b7 Merged revisions 123110 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r123110 | tilghman | 2008-06-16 14:21:58 -0500 (Mon, 16 Jun 2008) | 8 lines

People expect that if "hasvoicemail" is set in users.conf, even if "mailbox"
isn't set, that SIP will detect a mailbox.
(closes issue #12855)
 Reported by: PLL
 Patches: 
       20080614__bug12855__2.diff.txt uploaded by Corydon76 (license 14)
 Tested by: PLL

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@123111 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-16 19:23:51 +00:00
Joshua Colp
523532204a Merged revisions 122919 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r122919 | file | 2008-06-16 09:31:09 -0300 (Mon, 16 Jun 2008) | 6 lines

Only compare the first 15 characters so that even if the charset is specified we still accept it as SDP.
(closes issue #12803)
Reported by: lanzaandrea
Patches:
      chan_sip.c.diff uploaded by lanzaandrea (license 496)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@122920 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-16 12:32:02 +00:00
Joshua Colp
1c8f33b0d6 Merged revisions 122869 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r122869 | file | 2008-06-16 09:08:28 -0300 (Mon, 16 Jun 2008) | 6 lines

Don't send a BYE on a dialog that is already gone during a REFER.
(closes issue #12865)
Reported by: flefoll
Patches:
      chan_sip.c.br14.121495.patch-ALREADYGONE uploaded by flefoll (license 244)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@122870 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-16 12:09:54 +00:00
Tilghman Lesher
b2ef18dab4 Add some more IAX2-specific information about the channel to the CHANNEL()
function and begin the transition from SIPCHANINFO() to just using CHANNEL().
(closes issue #12856)
 Reported by: mostyn
 Patches: 
       iax_and_sip_channel_info.patch uploaded by mostyn (license 398)
       (with some additional cleanup by me)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@122802 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-15 15:21:16 +00:00
Joshua Colp
7025da48e5 Fix issue where session timer headers were present when they should not have been.
(closes issue #12706)
Reported by: falves11
Patches:
      chan_sip.c.diff uploaded by rjain (license 226)
Tested by: falves11


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@121503 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-10 14:11:16 +00:00
Joshua Colp
51602928e3 Merged revisions 121495 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r121495 | file | 2008-06-10 10:34:27 -0300 (Tue, 10 Jun 2008) | 4 lines

If we are destroying a dialog only set the MWI dialog pointer on the related peer to NULL if it is the dialog currently being destroyed.
(closes issue #12828)
Reported by: ramonpeek

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@121496 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-10 13:36:13 +00:00
Tilghman Lesher
53459f86b2 Expand RQ_INTEGER type out to multiple types, one for each precision
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@121367 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-09 22:51:59 +00:00
Tilghman Lesher
ba622c3431 Add storage of the useragent in the realtime database.
(Closes AST-38)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@121334 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-09 19:33:23 +00:00
Tilghman Lesher
07265a5033 Added a facility for sending arbitrary SIP notify commands from AMI.
(closes issue #12562)
 Reported by: michael-fig
 Patches: 
       20080515__bug12562.diff.txt uploaded by Corydon76 (license 14)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@121042 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-06 20:24:11 +00:00
Jeff Peeler
c7da6df5e1 Merged revisions 120959 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r120959 | jpeeler | 2008-06-06 13:29:14 -0500 (Fri, 06 Jun 2008) | 1 line

add another LOW_MEMORY define I forgot
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@120960 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-06 18:30:17 +00:00
Jeff Peeler
0bc65f7465 Merged revisions 120908 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r120908 | jpeeler | 2008-06-06 13:05:15 -0500 (Fri, 06 Jun 2008) | 1 line

only define thread storage variable if necessary for LOW_MEMORY
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@120909 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-06 18:06:06 +00:00
Jeff Peeler
5934801d84 Merged revisions 120863,120885 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r120863 | jpeeler | 2008-06-06 10:33:15 -0500 (Fri, 06 Jun 2008) | 3 lines

This fixes a crash when LOW_MEMORY is turned on. Two allocations of the ast_rtp struct that were previously allocated on the stack have been modified to use thread local storage instead.


........
r120885 | jpeeler | 2008-06-06 11:39:20 -0500 (Fri, 06 Jun 2008) | 2 lines

Correction to commmit 120863, make sure proper destructor function is called as well define two thread storage local variables.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@120906 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-06 17:50:05 +00:00
Tilghman Lesher
9471b87d27 Merge the adaptive realtime branch, which will make adding new required fields
to realtime less painful in the future.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@120789 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-05 19:07:27 +00:00
Brett Bryant
c1451b5537 This patch adds more detailed statistics for RTP channels, and provides an API call to access it, including maximums, minimums, standard deviatinos,
and normal deviations. Currently this is implemented for chan_sip, but could be added to the func_channel_read callbacks for the CHANNEL function 
for any channel that uses RTP.

(closes issue #10590)
Reported by: gasparz
Patches:
      chan_sip_c.diff uploaded by gasparz (license 219)
      rtp_c.diff uploaded by gasparz (license 219)
      rtp_h.diff uploaded by gasparz (license 219)
      audioqos-trunk.diff uploaded by snuffy (license 35)
      rtpqos-trunk-r119891.diff uploaded by sergee (license 138)
Tested by: jsmith, gasparz, snuffy, marsosa, chappell, sergee


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@120635 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-05 16:24:19 +00:00
Joshua Colp
16e401cc68 Merged revisions 119926 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r119926 | file | 2008-06-03 11:46:24 -0300 (Tue, 03 Jun 2008) | 2 lines

Treat ECONNREFUSED as an error that will stop further retransmissions. (issue #AST-58, patch from Switchvox)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@119927 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-06-03 14:47:54 +00:00
Joshua Colp
e4d1b39bd8 Merged revisions 118646 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r118646 | file | 2008-05-28 11:23:34 -0300 (Wed, 28 May 2008) | 4 lines

Add an option to use the source IP address of RTP as the destination IP address of UDPTL when a specific option is enabled. If the remote side is properly configured (ports forwarded) then UDPTL will flow.
(closes issue #10417)
Reported by: cstadlmann

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@118647 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-28 14:29:01 +00:00
Joshua Colp
cfb40367f4 Merged revisions 118558 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r118558 | file | 2008-05-27 16:32:38 -0300 (Tue, 27 May 2008) | 4 lines

Fix an issue where codec preferences were not set on dialogs that were not authenticated via a user or peer and allow framing to work without rtpmap in the SDP.
(closes issue #12501)
Reported by: slimey

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@118560 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-27 19:34:14 +00:00
Tilghman Lesher
f67e8ec980 Merged revisions 118251 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r118251 | tilghman | 2008-05-25 11:02:04 -0500 (Sun, 25 May 2008) | 12 lines

Realtime flag affects construction in multiple ways, so consulting whether
rtcachefriends was set was done too soon (needed to be done inside build_peer,
not just as a flag to build_peer).
Also, fullcontact needed to be reconstructed, because realtime separates the
embedded ';' into multiple fields.
(closes issue #12722)
 Reported by: barthpbx
 Patches: 
       20080525__bug12722.diff.txt uploaded by Corydon76 (license 14)
 Tested by: barthpbx
 (Much of the discussion happened on #asterisk-dev for diagnosing this issue)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@118252 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-25 16:17:05 +00:00
Michiel van Baak
f1e9371da8 - revert change to ast_queue_hangup and create ast_queue_hangup_with_cause
- make data member of the ast_frame struct a named union instead of a void

Recently the ast_queue_hangup function got a new parameter, the hangupcause
Feedback came in that this is no good and that instead a new function should be created.
This I did.

The hangupcause was stored in the seqno member of the ast_frame struct. This is not very
elegant, and since there's already a data member that one should be used.
Problem is, this member was a void *.
Now it's a named union so it can hold a pointer, an uint32 and there's a padding in case someone
wants to store another type in there in the future.

This commit is so massive, because all ast_frame.data uses have to be
altered to ast_frame.data.data

Thanks russellb and kpfleming for the feedback.

(closes issue #12674)
Reported by: mvanbaak


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117802 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-05-22 16:29:54 +00:00