Russell Bryant
7a5caf1a57
Fix a memory leak in func_curl. Every thread that used this function leaked
...
an allocation the size of a pointer.
(reported by jmls in #asterisk-dev)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@134540 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-30 19:52:53 +00:00
Tilghman Lesher
932ad2c19c
Only override sysconfdir and mandir when prefix=/usr
...
(closes issue #13093 )
Reported by: pabelanger
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@134536 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-30 19:47:16 +00:00
Tilghman Lesher
0dff9821d6
launch_netscript sometimes returns -1, which fails to set AGISTATUS. Map
...
failure to -1, so that AGISTATUS is always set.
(closes issue #13199 )
Reported by: smw1218
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@134480 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-30 19:03:44 +00:00
Mark Michelson
0257f5a967
Fix a spot where a function could return without bringing
...
a channel out of autoservice.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@134475 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-30 18:31:47 +00:00
Kevin P. Fleming
ced15f2814
use the proper method for building version.h
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@134352 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-30 15:29:17 +00:00
Kevin P. Fleming
7b61edde36
build against the now-typedef-free dahdi/user.h
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@134254 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-29 22:05:57 +00:00
Mark Michelson
b7aa2fb03c
Merging the imap_consistency branch.
...
The main aim of this branch was to make the IMAP
code function in the same manner as the ODBC code
does, eliminating the need for so many IMAP-specific
code chunks. The focal point of all of this work was
to make the various macros (e.g. RETRIEVE, DISPOSE)
functionally equivalent.
While doing the above work, I also fixed a few bugs
that I came across in my testing. Among these were
1. Fixed message forwarding. This was completely
broken when using IMAP.
2. Fixed the inability to save new messages as old
and vice versa.
3. Fixed the "delete" options in voicemail.conf when
using IMAP storage.
Even though a few bugs were fixed and the code is
a lot more consistent, the one thing that was *not*
improved in this branch was performance.
The merge of this to trunk may not come immediately
due to the amount of work it will probably involve.
(closes issue #12764 )
Reported by: balsamcn
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@134223 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-29 15:54:48 +00:00
Tilghman Lesher
0b2e233479
Detect when sox fails to raise the volume, because sox can't read the file.
...
(closes issue #12939 )
Reported by: rickbradley
Patches:
20080728__bug12939.diff.txt uploaded by Corydon76 (license 14)
Tested by: rickbradley
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@134161 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-28 21:50:50 +00:00
Russell Bryant
46b65b2cc0
Add the licensing section to the docs in 1.4, as well, so that we can work on
...
having an accurate list for each version of Asterisk that is supported
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@133980 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-26 15:31:21 +00:00
Tilghman Lesher
8e0165bb17
Remove unnecessary mmap flag
...
(Closes issue #13161 )
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@133709 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-25 18:00:33 +00:00
Tilghman Lesher
c5b4e1aec8
Fix some errant device states by making the devicestate API more strict in
...
terms of the device argument (only without the unique identifier appended).
(closes issue #12771 )
Reported by: davidw
Patches:
20080717__bug12771.diff.txt uploaded by Corydon76 (license 14)
Tested by: davidw, jvandal, murf
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@133649 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-25 17:19:39 +00:00
Russell Bryant
5ae8161b45
Merged revisions 133577 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r133577 | russell | 2008-07-25 10:00:13 -0500 (Fri, 25 Jul 2008) | 2 lines
Fix the IAX2 URI for calling Digium
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@133578 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-25 15:00:31 +00:00
Mark Michelson
a99f3d9365
We need to make sure to null-terminate the "name"
...
portion of SIP URI parameters so that there are no
bogus comparisons.
Thanks to bbryant for pointing this out.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@133572 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-25 14:40:10 +00:00
Tilghman Lesher
580ca7408c
Fix rtautoclear and rtcachefriends
...
(Closes issue #12707 )
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@133488 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-24 21:17:55 +00:00
Tilghman Lesher
bdf5dc4a4c
Blocked revisions 133360 via svnmerge
...
........
r133360 | tilghman | 2008-07-23 22:46:01 -0500 (Wed, 23 Jul 2008) | 2 lines
This part was not correctly patched for AST-2008-010.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@133361 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-24 03:48:07 +00:00
Jason Parker
82e28307c0
inbandrelease is gone - it's now inbanddisconnect
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@133295 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-23 21:49:03 +00:00
Kevin P. Fleming
888d269e8f
revert an optimization that broke ABI... thanks russell!
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@133237 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-23 21:05:22 +00:00
Kevin P. Fleming
cd12517eeb
make some more changes to the dahdi/zap channel name support stuff to ensure allthe globals are 'const', and clean up mmichelson's changes to app_chanspy to simplify the code
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@133226 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-23 20:42:30 +00:00
Mark Michelson
252c5728fc
As suggested by seanbright, the PSEUDO_CHAN_LEN in
...
app_chanspy should be set at load time, not at compile
time, since dahdi_chan_name is determined at load time.
Also changed the next_unique_id_to_use to have the
static qualifier.
Also added the dahdi_chan_name_len variable so that
strlen(dahdi_chan_name) isn't necessary. Thanks to
seanbright for the suggestion.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@133169 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-23 19:39:47 +00:00
Mark Michelson
9482af686b
Zap/pseudo is ten characters, but DAHDI/pseudo is
...
twelve. The strncmp call in next_channel should
account for this.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@133104 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-23 19:06:16 +00:00
Mark Michelson
ba642db1f4
Update the "last" channel in next_channel in app_chanspy so
...
that the same pseudo channel isn't constantly returned.
related to issue #13124
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@133101 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-23 18:57:17 +00:00
Mark Michelson
1fbde6a2f3
Small cleanup. Move the declaration of the DAHDI_SPANINFO
...
variable to the block where it is used. This allows one
less #ifdef HAVE_PRI to clutter things up.
Thanks to Tzafrir for pointing this out on #asterisk-dev
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@133038 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-23 17:50:01 +00:00
Mark Michelson
32bc585a57
Fix building of chan_dahdi when HAVE_PRI is not
...
defined.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@132974 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-23 17:05:04 +00:00
Kevin P. Fleming
b134688e7e
ensure that after a channel is created, if it happened to be in 'channel alarm' state, when that alarm clears we won't generate a spurious 'alarm cleared' message
...
(closes issue #12160 )
Reported by: tzafrir
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@132942 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-23 15:52:29 +00:00
Kevin P. Fleming
f6d7c63346
minor optimization for stringfields: when a field is being set to a larger value than it currently contains and it happens to be the most recent field allocated from the currentl pool, it is possible to 'grow' it without having to waste the space it is currently using (or potentially even allocate a new pool)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@132872 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-23 11:52:18 +00:00
Christian Richter
b6ca1a1b06
another Fix because of r119585, this commit has broken high frequented BRI Ports, there was a possibility that a channel, that was marked as in_use would be reused later, the corresponding port could got stuck then. So it is recommended to upgrade for chan_misdn users.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@132826 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-23 11:37:50 +00:00
Mark Michelson
d6aef7347a
Allow Spiraled INVITEs to work correctly within Asterisk.
...
Prior to this change, a spiraled INVITE would cause a 482
Loop Detected to be sent to the caller. With this change,
if a potential loop is detected, the Request-URI is inspected
to see if it has changed from what was originally received. If
pedantic mode is on, then this inspection is fully RFC 3261
compliant. If pedantic mode is not on, then a string comparison
is used to test the equality of the two R-URIs.
This has been tested by using OpenSER to rewrite the R-URI
and send the INVITE back to Asterisk.
(closes issue #7403 )
Reported by: stephen_dredge
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@132790 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-22 22:14:24 +00:00
Kevin P. Fleming
6a0bcc4754
fix up namespace pollution for dahdi_chan_mode enum
...
correct registration of AMI actions in chan_dahdi; in zap-only mode, only register the Zap flavors of the actions (and use Zap prefixes for headers and acks), but in dahdi+zap mode, register both Zap and DAHDI flavors of actions
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@132787 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-22 22:11:01 +00:00
Kevin P. Fleming
99d9727a84
add rules to create preprocessor output... useful for debugging macros
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@132784 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-22 22:09:37 +00:00
Tilghman Lesher
04614238c5
Merged revisions 132711 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r132711 | tilghman | 2008-07-22 16:14:10 -0500 (Tue, 22 Jul 2008) | 2 lines
Fixes for AST-2008-010 and AST-2008-011
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@132713 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-22 21:19:39 +00:00
Kevin P. Fleming
08a0f08234
ensure that if any alarms exist at channel creation time, they are handled identically to if they occurred later, so that later alarm clearing will work properly and 'make sense'
...
(closes issue #12160 )
Reported by: tzafrir
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@132712 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-22 21:17:23 +00:00
Kevin P. Fleming
5ef465d386
make AST_C_COMPILE_CHECK able to print a 'pretty' description of what it is doing
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@132704 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-22 20:49:41 +00:00
Olle Johansson
fe25fe728c
The most common question on the #asterisk iRC channel and on mailing lists
...
seems to be in regards to an error message when retransmit fails. This
is frequently misunderstood as a failure of Asterisk, not a failure of
the network to reach the other party.
This document tries to assist the Asterisk user in sorting out these
issues by explaining the logic and pointing at some possible
causes. Hopefully, we will get other questions now :-)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@132645 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-22 20:10:26 +00:00
Kevin P. Fleming
e2c41c9ee4
correct wording in comment
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@132642 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-22 19:57:43 +00:00
Kevin P. Fleming
0faccba9cb
use renamed libpri API call for controlling this feature (was improperly named before)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@132641 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-22 19:49:11 +00:00
Kevin P. Fleming
6ef40852de
teach chan_dahdi how to find the D-channel on BRI spans, and don't attempt to use channel 24 as a D-channel on spans of unexpected sizes
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@132571 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-21 22:45:16 +00:00
Brett Bryant
222f6d733a
Fix a bug where SENDTEXTSTATUS isn't set properly when it isn't
...
supported on a channel (yet _another_ useful patch by eliel).
(issue #13081 )
Reported by: eliel
Patches:
app_sendtext1.4.c uploaded by eliel (license 64)
Tested by: eliel
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@132507 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-21 20:51:45 +00:00
Brett Bryant
2172cc71b1
Fix a bug in 1.4 branch with iax2 channels not being removed when a call was rejected (from the calling box, not the box that denied the
...
registration). Related to revisions 132466 in trunk, and 132467 in 1.6.0. Earlier I had accidently tested 1.4 with a backport from those revisions,
so I didn't see this problem (oops).
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@132506 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-21 20:30:12 +00:00
Kevin P. Fleming
00228e42d0
grant a license exception to allow distribution of Asterisk binaries that use the UW IMAP Toolkit (which is licensed under a non-GPL-compatible license)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@132311 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-19 16:45:52 +00:00
Tilghman Lesher
31fec93dca
Fix for Taiwanese number syntax
...
(closes issue #12319 )
Reported by: CharlesWang
Patches:
saynumber-tw-1.4.18.1.patch uploaded by CharlesWang (license 444)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@132112 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-18 19:06:10 +00:00
Tilghman Lesher
678b90e2a0
Textual clarification
...
(closes issue #13106 )
Reported by: flefoll
Patches:
config.c.br14.120173.patch-unknown-directive uploaded by flefoll (license 244)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@132107 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-18 18:47:50 +00:00
Tilghman Lesher
79b6c3f9d6
Spinlock within the destroy, to allow a scheduled job to continue, if it's
...
waiting on the mutex which the destroy thread has.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@132042 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-18 17:33:42 +00:00
Tilghman Lesher
0f738146e8
Oops
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@131988 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-18 17:10:01 +00:00
Tilghman Lesher
89b6e63a8b
Preserve ABI compatibility with last change
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@131985 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-18 16:46:23 +00:00
Tilghman Lesher
64bbce9b9b
Make the ast_assert call within ast_sched_del report something useful.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@131970 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-18 16:30:31 +00:00
Kevin P. Fleming
ced50934cb
remove the dlfcn compatibility stuff, because no platforms that Asterisk currently runs on it use it, and it doesn't build anyway
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@131921 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-18 16:15:41 +00:00
Brett Bryant
5d4058b41a
Fix a bug in blind transfers where the BLINDTRANSFER variable isn't always set to the other end of the blind transfer.
...
(closes issue #12586 )
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@131915 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-18 15:34:42 +00:00
Tilghman Lesher
e0baf8a871
Revert part of issue #5620 (revision 6965) as it appears that it was in error.
...
This should fix talk call progress on analog lines.
(closes issue #12178 )
Reported by: michael-fig
Patches:
20080717__bug12178.diff.txt uploaded by Corydon76 (license 14)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@131790 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-17 20:35:44 +00:00
Brett Bryant
8a427aed77
Fix a bug in iax2 registration that allowed peers to register with
...
case-insensitive names (user_cmp_cb and peer_cmp_cb are now both
case-sensitive).
(closes issue #13091 )
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@131491 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-16 22:17:07 +00:00
Tilghman Lesher
b0586bd055
Apparently, in certain cases, a callno is already destroyed when iax2_destroy is called.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@131480 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-07-16 21:46:06 +00:00