Joshua Colp
f28947f7ef
Free localuser structure when we fail to dial (issue #8612 reported by rizzo)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@48584 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-19 21:10:26 +00:00
Matt O'Gorman
2cbdcb35b1
app_externalivr needs a real silence file, and additional
...
changes to add silence files into core instead of extra
patch provided by bug 8177 with minor additions.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@48394 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-11 21:55:43 +00:00
Tilghman Lesher
983d09bc21
When doing a fork() and exec(), two problems existed (Issue 8086):
...
1) Ignored signals stayed ignored after the exec().
2) Signals could possibly fire between the fork() and exec(), causing Asterisk
signal handlers within the child to execute, which caused nasty race conditions.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@48374 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-11 00:33:59 +00:00
Tilghman Lesher
31759faca8
If the recording in the database is too large, it will fail to retrieve with
...
an mmap error. Not too sure why this doesn't happen when we put it in the
database, also, but since that doesn't seem to be broken, I'm not going to fix
it (at least until someone reports it). Solution is to ask for the file in
smaller chunks. (Bug 8385)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@48251 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-05 01:26:08 +00:00
Jason Parker
9ce01ec196
Revert change from 8016 - this breaks other stuff... Needs further review.
...
Tip: When you've reported a bug about something and somebody has put up a
patch for it.. It's not a good idea to open a completely new bug and say that
something is broken because of the patch in the other bug - PLEASE mention
something in the bug where the patch was actually created.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@48246 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-04 21:20:34 +00:00
Jason Parker
8c413a42eb
Fix an issue where a message isn't saved correctly when using ODBC storage and reviewing a message.
...
Issue 8016 - patch by sokhapkin.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@48236 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-04 19:06:26 +00:00
Kevin P. Fleming
37d6a18db1
if Dial() is going to send music-on-hold to the calling party, it has to send PROGRESS first to ensure that the reverse audio path has been setup first (BE-106)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@48192 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-01 23:30:59 +00:00
Joshua Colp
0c18e0a5e1
Use the proper function to get the new message count instead of always using the filesystem. (issue #8421 reported by slimey)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@48053 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-27 18:03:57 +00:00
Tilghman Lesher
0e783db690
Failing to trap -1 error from mmap causes segfault (Issue 8385)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47862 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-20 19:59:07 +00:00
Jason Parker
b5d03cfa96
Fix a couple of typos in applications.. Initially spotted by mrobinson.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47780 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-16 23:16:35 +00:00
Kevin P. Fleming
c446ef9782
correct argument name typo that caused global variable to be used instead of the one for the specified voicemail user
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47696 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-15 20:30:29 +00:00
Kevin P. Fleming
bedd43d2f9
ensure that message duration is included in email notifications for forwarded messages (BE-96, fix by me after corydon used his clue-bat on me)
...
ensure that duration in the message metadata is updated if prepending is done during forwarding (related to BE-96)
remove prototype for API call that does not exist
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47677 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-15 17:56:42 +00:00
Joshua Colp
5cea7867b3
Update copyright information in the ADSI logo blob.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47631 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-14 22:15:10 +00:00
Joshua Colp
0d9602565f
When sending an SMS with a user data header properly set the UDH flag in the first byte. (issue #8347 reported by hoffmeis)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47549 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-13 17:05:32 +00:00
Tilghman Lesher
38ba4c204e
Move thread-unsafe initializer to the module loading code; add the
...
corresponding function to the module unload to fix a memory leak.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@46662 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-31 15:46:04 +00:00
Russell Bryant
bf20deeba1
We should always be using _exit() after a fork() or vfork() instead of exit().
...
This is because exit() does some extra cleanup which in some implementations
of vfork(), for example, can actually modify the state of the parent process,
causing very weird bugs or crashes. (issue #7971 , Nick Gavrikov)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@46361 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-27 17:36:07 +00:00
Joshua Colp
0d26753de2
Respect language selection when seeing if the file exists (issue #8178 reported by mnicholson)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@45691 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-19 17:16:37 +00:00
Joshua Colp
d0649af76d
Turn on volume adjustment if it needs to be on (issue #8136 reported by mnicholson)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@45060 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-13 17:01:22 +00:00
Steve Murphy
4f0d22fde1
For bug 7776, I have inserted a warning about Macro nesting vs. stack limitations
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@44343 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-04 16:02:22 +00:00
Kevin P. Fleming
9c405de30d
fix a logic error in my previous fix to the queue reload code
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@44296 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-03 20:14:13 +00:00
Joshua Colp
87803a8ac6
Put in missing \ns on the end of ast_logs (issue #7936 reported by wojtekka)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43924 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 18:00:30 +00:00
Kevin P. Fleming
7620e04612
fix buggy (and overly complex) loop used during reload of app_queue for static member list updating
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43916 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 17:31:57 +00:00
BJ Weschke
fb599cc53e
app_queue is comparing the device names incorrectly while checking their statuses. It's internal list of interfaces includes the dial string, while the argument passed to this function does not have the dial string (/n for a local channel). This causes it to ignore the device state changes because it thinks it belongs to none of its members. ( #8040 reported and patch by tim_ringenbach)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43897 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 16:37:15 +00:00
Joshua Colp
34adb7efe6
Stop the stream after waitstream returns so that our formats get restored. (issue #7370 reported by kryptolus)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43891 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 16:13:55 +00:00
BJ Weschke
f6ddf4e7d4
Fix race condion crash with get_member_status ( #7864 - tim_ringenbach reported and patched)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43871 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 15:18:05 +00:00
Tilghman Lesher
a2d98d6c7c
Avoid inability to lock directory log message by creating the directory ahead of time. (Issue 7631)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43815 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-27 20:20:35 +00:00
Jason Parker
e247b8ab33
Playback() wasn't setting PLAYBACKSTATUS under several circumstances.
...
Playback() returns -1 on missing args - so should Background()
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43800 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-27 19:35:09 +00:00
Russell Bryant
a0da756f2a
When parsing the sections of voicemail.conf that contain mailbox definitions,
...
don't introduce a length limit on the definition by using a 256 byte temporary
storage buffer. Instead, make the temporary buffer just as big as it needs
to be to hold the entire mailbox definition.
(fixes BE-68)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43699 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-26 20:23:15 +00:00
Tilghman Lesher
83b377451c
Two bugs when forwarding voicemail (Issue 7824):
...
1) delete=yes was ignored
2) maxmessages was ignored
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43634 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-25 21:14:41 +00:00
Joshua Colp
c6e25717b4
Yay another 'round of spy fixes! This fixes a small logic flaw with the cleanup function and a memory allocation issue. (issue #7960 reported by jojo & issue #7999 reported by aster1) Special thanks to csum77 for letting me into a box where this issue was happening.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43509 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-22 21:53:51 +00:00
Tilghman Lesher
e095711654
Whitespace change... really just an excuse to test repotools
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43420 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-21 17:01:48 +00:00
Matt O'Gorman
942768c022
fixes some verbose vs debug issues. patch from bug 2617
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43269 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-19 16:21:08 +00:00
Tilghman Lesher
6728ebb72c
cid is passed to a destructive function; thus a copy is needed (issue 7961)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43248 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-19 12:28:55 +00:00
Joshua Colp
b1708137da
Add deprecation notice about app_math (issue #7957 reported by k-egg)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43163 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-18 15:30:26 +00:00
Tilghman Lesher
88ccb83574
Directory used the wrong context for delivery of 0- and *- keypresses
...
(according to Directory's own documentation) - Issue 7965
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43072 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-17 13:54:34 +00:00
Tilghman Lesher
b2122691de
When the marked user enters the conference, we should no longer timeout
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43003 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-16 04:44:02 +00:00
Tilghman Lesher
ca79503d56
Backport bugfix patch from 7918 to 1.2 - msg_cfg destroyed before used
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42892 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-13 19:51:24 +00:00
Tilghman Lesher
9c8d9ce377
When paging, only wait 5 seconds for the marked user to enter the conference.
...
After that, assume the paging already completed by the time the channel entered
the conference and drop back out. (Issue 7275)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42783 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-11 21:47:23 +00:00
Tilghman Lesher
ec7535bba2
Jump logic was backwards: goto returns 0 if it succeeds, and we should jump if authentication fails. (Bug #7907 )
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42421 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-08 16:06:17 +00:00
Tilghman Lesher
0cfb462845
Format vulnerability fix - allowing the user to specify a format is not a good idea (Bug 7811)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42355 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-07 23:12:29 +00:00
Joshua Colp
68de3c0b29
Merge in last round of spy fixes. This should hopefully eliminate all the issues people have been seeing by distinctly separating what each component (core/spy) is responsible for. Core is responsible for adding a spy to a channel, feeding frames to the spy, removing the spy from a channel, and telling the spy to stop. Spy is responsible for reading frames in, and cleaning up after itself.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42054 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-05 20:02:48 +00:00
BJ Weschke
a05a361fc3
Make sure the forwarded channel inherits variables appropriately when we receive a call forward in the queue. ( #7867 - raarts reported and patched)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41882 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 17:38:22 +00:00
BJ Weschke
aaf0ad7b77
Don't keep trying the same member in certain strategies when members of the queue are unavailable ( #7278 - diLLec reported and patched) - This should have been patched here first and then merged into /trunk. My bad!
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41880 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 17:13:38 +00:00
BJ Weschke
919cb0b1a8
Let's NOT spy on Zap/psuedo channels, mmmmmmmmk?
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41830 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 14:50:59 +00:00
BJ Weschke
c3b61adc5b
Setting a retry of 0 is generally not a good idea and shouldn't be allowed. ( #7574 - reported by regin)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41827 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 14:16:08 +00:00
Steve Murphy
6daea8e8fb
According to a note added to 7731 by mneuhauser, this
...
will repair a break caused by the last fix (7731).
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41239 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-28 19:06:55 +00:00
Tilghman Lesher
e83bbab1ec
Text only - clarify the reason for entry into authentication mode when the skipuser option is ignored
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41065 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-25 15:07:16 +00:00
Tilghman Lesher
dad6bc4d32
Bug 7779 - Using initstate(3) means that we cannot unload this module once loaded.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@40821 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-22 02:59:37 +00:00
Jason Parker
d98055d875
Fix a bug with app_voicemail when trying to use app_directory to leave messages
...
to another user (options 3, 5, 2).
If the context/extension didn't exist in the dialplan (and why should it have to?),
it would fail, saying that it's an "invalid extension".
Fix was different in svn trunk.
(issue BE-71)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@40446 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-19 01:03:22 +00:00
Joshua Colp
afedbd97af
Make app_macro compile again
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@40223 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-17 16:18:08 +00:00