Commit Graph

205 Commits

Author SHA1 Message Date
BJ Weschke
64def5d791 We should lock the queue before we go making changes to member interface statuses.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@35669 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-23 11:30:17 +00:00
Kevin P. Fleming
d00c50cd14 don't use prefixed structure names for internal structures
don't use a plural structure name for a singular object


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@34274 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-15 13:30:22 +00:00
Kevin P. Fleming
55ba8ef5c4 coding style cleanups on queue interface handling code that was committed for the last release
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@34160 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-14 22:22:21 +00:00
Kevin P. Fleming
5684ba5966 return bridge exit logic to what it was before i broke it :-(
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@31921 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-04 03:43:35 +00:00
BJ Weschke
a6a17f1789 Fix infinite loop scenario and add some sanity checking to prevent segfault on a NULL parameter coming in (which probably shouldn't happen, but just to be safe...)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@30770 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-30 14:55:16 +00:00
BJ Weschke
a94248e7dc A new way to try and deal with deadlocks that occur in app_queue at present. Using this approach, we only manipulate the main queue mutexes when we get a dev state change on a device that is actually a member of a queue. Backported from /trunk for the "bug fix".
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@30546 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-26 17:09:51 +00:00
BJ Weschke
f1744d3e31 Oops.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@30424 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-25 21:22:16 +00:00
Kevin P. Fleming
f5765a22fc fix various bugs related to exiting from queue via keypress and moh handling (issue #6776, different fix)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@29971 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-24 16:52:08 +00:00
Kevin P. Fleming
e0989958cc don't allow queue member devices to ring longer than the total queue timeout (issue #6423, reported and patched by bcnit)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@28968 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-20 02:35:53 +00:00
Joshua Colp
14285e5b2b Treat paused queue members as unreachable (issue #7127 reported by peterh)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@28627 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-19 15:38:59 +00:00
BJ Weschke
249760b951 Make QueueStatusComplete event thread safe by wrapping it inside the queue lock clause already there. #7013 (bziherl reporting)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@25522 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-08 13:35:17 +00:00
BJ Weschke
d46fa7e825 Oops. :(
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@25520 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-08 13:15:30 +00:00
BJ Weschke
41210a37d6 Don't recheck valid_exit() after getting the result from say_position (which already checks it). Should prevent another loop if the caller hits digits during the position announcement. #6776 (tgj reporting)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@25518 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-08 13:11:32 +00:00
Tilghman Lesher
c7ee76b69f Bug 7023 - reload should not unpause members
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@24706 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-04 16:27:20 +00:00
Joshua Colp
d0aef28b0e Queue(somequeue,,,,) -> interpreted as Queue(somequeue,,,,0) (issue #7044 reported nathan fixed by jsmith - sort of)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@22954 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-27 19:11:47 +00:00
Olle Johansson
457bdd22bb Issue #6882 - move "res=-1" out of verbosity block, minor code cleanups (casper)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@17335 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-04 17:59:18 +00:00
Russell Bryant
14e8c4c5a3 fix a problem with not loading realtime queue members by always reloading a
realtime queue from the database even if it is found in the list (issue #6680)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@12925 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-03-14 18:28:39 +00:00
Kevin P. Fleming
ce008d40a1 don't double-increment abandon counter for calls that are hung up while dialing members (issue #6289)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@10018 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-02-14 20:20:15 +00:00
Russell Bryant
2f1d118537 fix memory leak from not freeing the queue member list when freeing an old queue
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@8445 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-22 19:03:53 +00:00
Tilghman Lesher
366c8a99ef Bug 5936 - AddQueueMember fails on realtime queue, if queue not yet loaded
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@8394 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-21 18:29:39 +00:00
Russell Bryant
30f2aff526 fix invalid value of prev_q (issue #6302)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@8347 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-20 18:34:42 +00:00
Russell Bryant
a434f8877a cast time_t to an int in printf/scanf (issue #5635)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@7634 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-12-26 18:19:12 +00:00
Russell Bryant
a49f954f6a don't delete dynamic queue members when reloading the static members from a realtime database (issue #5922)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@7337 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-12-05 00:09:12 +00:00
Russell Bryant
a32f75b800 fix queue weight feature - compare member interfaces instead of pointers to
the members, since each queue has its own list of members. (issue #5863)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@7249 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-12-01 01:19:04 +00:00
Kevin P. Fleming
a563eab49a remove extraneous svn:executable properties
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@7221 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-29 18:24:39 +00:00
Kevin P. Fleming
54dd7ac9fa issue #5707
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7053 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-10 23:22:37 +00:00
Russell Bryant
987b87662c make app_queue 1.2 jump compliant (issue #5580)
add missing includes of stdio.h
remove some unused and duplicate headers


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7026 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-08 04:48:00 +00:00
Kevin P. Fleming
a0a9769616 issue #5648
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7011 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-08 01:55:31 +00:00
Kevin P. Fleming
f09c6bc78e application doc update
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6992 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-07 22:01:22 +00:00
Russell Bryant
31a804b97c issue #5605
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6979 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-06 15:09:47 +00:00
Russell Bryant
3bd298f2dd alphabetize option lists
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6975 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-06 05:34:13 +00:00
Russell Bryant
5187de9ab6 remove unnecessary checks before calls to ast_strlen_zero
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6864 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-26 19:48:14 +00:00
Russell Bryant
3453e3efa5 Doxygen documentation update from oej (issue #5505)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6847 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-24 20:12:06 +00:00
Russell Bryant
4aa7912057 Massive cleanups to applications for LOCAL_USER handling and some other things.
In general, LOCAL_USER_ADD/REMOVE should be the first/last thing called in an
application.  An exception is if there is some *fast* setup code that might
halt the execution of the application, such as checking to see if an argument
exists.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6832 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-19 18:19:02 +00:00
Russell Bryant
29829640bf it's a good idea to unregister everything before calling STANDARD_HANGUP_LOCALUSERS
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6828 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-18 22:52:21 +00:00
Mark Spencer
dbdd193e12 Fix segfault in app queue when no cdr exists for the calling channel (bug #5462)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6824 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-18 20:58:16 +00:00
Mark Spencer
4e919f337c Fix queue, iax and sip formatting issues (bug #5449)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6811 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-17 22:26:33 +00:00
Kevin P. Fleming
7215e4179d add auto-monitor support (issue #5411)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6773 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-13 23:14:19 +00:00
Josh Roberson
485e3e0801 Log timeouts in queues when the call timeout is set from the dialplan (Bug #5422)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6761 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-13 20:16:50 +00:00
Kevin P. Fleming
e0680525e7 fix queues properly (issue #5300, take two)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6699 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-30 14:01:56 +00:00
Kevin P. Fleming
d45b683bdd ensure that app_queue won't crash if no members are defined via Realtime (issue #5300)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6693 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-29 04:12:08 +00:00
Russell Bryant
90aec0b0e3 fix logic error that breaks queue exit (issue #5312)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6677 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-28 19:33:00 +00:00
Kevin P. Fleming
d3f7c5fb74 don't drop the caller just because it's not time to play an announcement (issue #5279)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6655 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-26 00:41:28 +00:00
Kevin P. Fleming
b8f23573fa more license/copyright header updates (thanks Ian!)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6618 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-15 15:44:26 +00:00
Kevin P. Fleming
e0f02b46f1 convert a bunch of apps to use ast_goto_if_exists() (issue #5138)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6533 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-07 19:13:00 +00:00
Kevin P. Fleming
37a3c098bf fix stupid thinko (thanks velter!)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6497 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-09-01 22:32:29 +00:00
Kevin P. Fleming
3103fd6292 don't duplicate devicestate-to-string function (issue #5078)
use ast_build_string() for building output string


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6473 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-08-31 20:16:47 +00:00
Mark Spencer
129fd190a9 Make sure "now" is initialized (bug #4961)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6329 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-08-14 03:08:08 +00:00
Mark Spencer
e415ff3f87 Don't record all calls as abandoned (bug #4575) (fixes damage inadvertently added by bug #4644)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6299 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-08-07 14:11:48 +00:00
Mark Spencer
a9a91571a1 Remove queue/session co-locking until deadlocks are properly resolved
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6273 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-08-03 18:25:23 +00:00