Commit Graph

1203 Commits

Author SHA1 Message Date
Olle Johansson
910c44b1b6 Clean up handle_response_peerpoke
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21129 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-18 14:41:57 +00:00
Olle Johansson
60d91caa23 Change sip show channels to include refer status
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21128 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-18 14:37:54 +00:00
Olle Johansson
1fec0e47e7 - Deallocate refer structure at sip_destroy time
- Implement new sip_transfer() function


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21127 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-18 14:35:15 +00:00
Olle Johansson
177b8e9143 It's critical that we get an ACK on a 200 OK to an INVITE. If we do not get the ACK,
tear down the call. (Discovered at SIPit18)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21061 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-18 07:03:36 +00:00
Olle Johansson
2c73c08f5a use XMIT_RELIABLE ...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21043 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-18 07:00:27 +00:00
Olle Johansson
40161ae947 - Move subscribeuri away from refer-to, since refer-to is moving away from sip_pvt
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21039 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-18 06:40:01 +00:00
Olle Johansson
080298dad4 Set timeout timers to Timer A and F in rfc 3261, section 17
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20932 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-17 14:22:16 +00:00
Olle Johansson
ea7f924b30 Change transmit_invite(). SIP Transfers are now broken officially, while
waiting for the rest of the patches... This is the dev branch, after all.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20931 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-17 14:07:50 +00:00
Olle Johansson
5320c6b76a - Add supported header
- Send cause codes as well


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20908 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-17 14:00:44 +00:00
Olle Johansson
42918c225a Add more history on masqs
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20903 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-17 13:52:53 +00:00
Olle Johansson
b124cf4c80 - Implementing the new SIP transfer data structure
- Changing SIP call to support sending INVITEs as part of call transfers


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20902 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-17 13:47:30 +00:00
Olle Johansson
bdb2332621 - Documentation update
- Formatting change


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20901 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-17 13:22:31 +00:00
Olle Johansson
bedd0c2ed3 Documentation update
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20900 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-17 13:08:24 +00:00
Olle Johansson
382fd7260c Remove ignore from handle_respons_refer
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20872 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-17 09:21:56 +00:00
Olle Johansson
a5e5fb18e2 Clean up handle_response_invite
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20844 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-17 08:15:38 +00:00
Olle Johansson
92ac73fe3b - Drop too bad SIP requests in order to avoid some UDP misuse (hello Edwin)
- Clean up initialization of initatial request initialization


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20816 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-17 05:32:22 +00:00
Olle Johansson
4a312a044d - Fixes to ast_channel_lock functions
- New get_sip_pvt_byid function (not really used correctly yet...)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20424 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-16 12:57:15 +00:00
Olle Johansson
e75fa47099 More ast_channel_lock fixes
- Update lock.h with definitions of ast_channel_lock, ast_channel_unlock and ast_channel_trylock
- Convert some functions (but not all) in channel.c
- Fix some bugs in chan_sip.c
- Convert rest of chan_sip.c


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20295 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-15 15:07:39 +00:00
Olle Johansson
6b3367bf5c New functions for locking a channel - these simplify debugging
when you have channel locking issues.
(Part of the SIP transfer patch, where I had a *lot* of
channel locking problems)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20264 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-15 08:07:50 +00:00
Luigi Rizzo
e43bc6634d This rather large commit changes the way modules are loaded.
As partly documented in loader.c and include/asterisk/module.h,
modules are now expected to return all of their methods and flags
into a structure 'mod_data', and are normally loaded with RTLD_NOW
| RTLD_LOCAL, so symbols are resolved immediately and conflicts
should be less likely.  Only in a small number of cases (res_*,
typically) modules are loaded RTLD_GLOBAL, so they can export
symbols.
 
The core of the change is only the two files loader.c and
include/asterisk/module.h, all the rest is simply adaptation of the
existing modules to the new API, a rather mechanical (but believe
me, time and finger-consuming!) process whose detail you can figure
out by svn diff'ing any single module.

Expect some minor compilation issue after this change, please
report it on mantis http://bugs.digium.com/view.php?id=6968
so we collect all the feedback in one place.

I am just sorry that this change missed SVN version number 20000!



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20003 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-14 14:08:19 +00:00
Olle Johansson
5af687b83b Issue #6951 - Show last successful registration time in "sip show registry" (ivanfm) with mods for svn trunk
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19736 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-13 12:48:03 +00:00
Olle Johansson
d4b5393eeb - Adding some refer state definitions from the siptransfer branch
- A bit more URI conversions 
- Changes to sip_dual and the SIP invite structure
- Add Supported: headers to more requests


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19578 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-12 21:21:44 +00:00
Olle Johansson
9468e5cd06 Fix for Polycom bug...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19549 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-12 21:00:31 +00:00
Olle Johansson
ea4235c56c Implement a setting for denying/allowing transfer requests. At this stage,
we only have open/closed. Well, at least you can deny transfers from unknown
callers or at least incoming calls.
(Part of the SIPtransfer branch)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19546 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-12 20:57:07 +00:00
Olle Johansson
975ddb8552 Doxygen docs
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19542 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-12 20:32:40 +00:00
Luigi Rizzo
b24bc86fc2 reindent block properly
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19466 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-12 00:17:37 +00:00
Luigi Rizzo
86e8094c3c localize some variables, remove useless parentheses
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19465 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-12 00:15:57 +00:00
Luigi Rizzo
3579d11dc1 remove useless \0, and fix formatting.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19437 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-11 23:54:33 +00:00
Kevin P. Fleming
fb4d5fb6a6 fix logic error; don't test for rtcache flag unless asked to (issue #6923)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19393 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-11 22:07:52 +00:00
Olle Johansson
8318cddd8e - First stab at removing debug and ignore variables that
we pass along function calls, instead implementing them as
  flags on the incoming packet.
- Adding forward declarations of handle_request functions


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19128 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-11 06:09:01 +00:00
Olle Johansson
26198e8826 Fixup fixup - add some debugging and error handling
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18940 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-10 20:18:14 +00:00
Olle Johansson
8b1543974f Resolve conflicts, prepare for next batch of conflicts
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18909 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-10 19:55:39 +00:00
Olle Johansson
fed57c1eb2 Making sure that cancel destroy is only executed once...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18799 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-10 13:43:54 +00:00
Olle Johansson
f74538df11 Small fix
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18797 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-10 13:19:36 +00:00
Luigi Rizzo
c3b3feab76 - staticize gettag() complete_sip_peer() get_calleridname() arguments;
- use strsep() instead of strchr() where appropriate
- constify some args and add comments. 
- remove a conditional near line 1940 - we already know what to use.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18793 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-10 12:20:57 +00:00
Luigi Rizzo
8731b6386d - constification of some functions (args and return values):
transmit_response_reliable()
        hangup_cause2sip()
- remove useless braces;
- add comments on some slightly cryptic code segments
- mark XXX possible critical pieces of code.
- remove an unneeded string termination after ast_copy_string
- mark usage of some rarely used functions;
- use strsep() instead of emulating it inline;
- replace magic constants with sizeof(array)




git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18792 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-10 11:57:40 +00:00
Luigi Rizzo
7e5e2ffb5f - localize 'struct cfalias' into the only function using it;
- remove duplicate code to walk through sdp packets, replacing
  sdpLineNum_iterator_init(&foo); with  "foo = 0";
- remove duplicate code to test ast_test_flag(&p->flags[0], SIP_NAT_ROUTE);



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18791 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-10 11:36:02 +00:00
Luigi Rizzo
25e9168fea constify get_sdp*() and friends.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18790 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-10 11:19:14 +00:00
Luigi Rizzo
87890e75ba constify get_header(), which let me find out and fix one bug (overwriting
a string in the buffer) and finding out another one (not fixed yet,
just marked XXX).



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18789 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-10 11:04:04 +00:00
Luigi Rizzo
47df1e2020 - describe how sip packets are stored internally;
- remove useless braces or local variables;
- simplify some code sequences;
- mark with XXX a possible locking issue.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18788 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-10 10:40:13 +00:00
Luigi Rizzo
20d1876617 struct sip_request cleanup:
- remove a debug field that was read but never set, so it was basically
  unused as well as the code testing it (also removed);

- make scalar fields contiguous so any array overflow will be
  less harmful;



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18787 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-10 10:30:38 +00:00
Luigi Rizzo
104c2b0a3a more cleanup: remove useless braces, replace "if" with "?",
localize a couple of variables, remove trailing whitespace.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18786 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-10 10:22:42 +00:00
Olle Johansson
9b4e335439 Re-instate removed comment
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18785 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-10 10:01:14 +00:00
Luigi Rizzo
e081b42cd6 another batch of minor code simplifications
(moving repeated expressions into a function, const on
some arguments)



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18784 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-10 09:53:22 +00:00
Luigi Rizzo
e468d9011d a bunch of trivial code normalizations (removal of unnecessary
casts and parentheses, formatting fixes, pointing out replicated
code and so on). No functional changes.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18666 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-09 23:16:29 +00:00
Kevin P. Fleming
f10f427d49 since the module API is changing, it's a good time to const-ify the description() and key() return values
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18552 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-08 22:01:19 +00:00
Olle Johansson
8159124572 -Fixing some debugging messages in history and console
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18403 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-07 20:19:44 +00:00
Olle Johansson
aefba4ad7d Add history events for re-invites
(need to nail this issue...)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18373 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-07 19:46:50 +00:00
Olle Johansson
f235bbe5a5 make history easier to read
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18371 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-07 19:36:44 +00:00
Olle Johansson
8cd506cdfd Add some more information to SIP history
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18370 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-07 19:25:19 +00:00