Commit Graph

218 Commits

Author SHA1 Message Date
Russell Bryant
03ad135134 Fix a memory leak that I just noticed in the device state handling in app_queue.
On most device state changes, it would leak roughly 8 to 64 bytes (the length of
the name of the device).


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@65389 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-22 13:07:03 +00:00
Jason Parker
c28413ff94 If the '* to hangup' option is not enabled, we don't need to disable * as a valid exit key.
If it was enabled, this statement would've never been checked in the first place.

Issue #9552


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@61692 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-20 19:49:54 +00:00
Russell Bryant
f9db7779f0 Fix a bunch of places where pthread_attr_init() was called, but
pthread_attr_destroy() was not.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@53045 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-31 21:25:11 +00:00
Joshua Colp
e06d0f644b Make COMPLETECALLER and COMPLETEAGENT output to queue_log follow documentation. (issue #7677 reported by amilcar)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@52415 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-27 02:09:10 +00:00
Kevin P. Fleming
9c405de30d fix a logic error in my previous fix to the queue reload code
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@44296 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-10-03 20:14:13 +00:00
Kevin P. Fleming
7620e04612 fix buggy (and overly complex) loop used during reload of app_queue for static member list updating
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43916 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 17:31:57 +00:00
BJ Weschke
fb599cc53e app_queue is comparing the device names incorrectly while checking their statuses. It's internal list of interfaces includes the dial string, while the argument passed to this function does not have the dial string (/n for a local channel). This causes it to ignore the device state changes because it thinks it belongs to none of its members. (#8040 reported and patch by tim_ringenbach)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43897 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 16:37:15 +00:00
BJ Weschke
f6ddf4e7d4 Fix race condion crash with get_member_status (#7864 - tim_ringenbach reported and patched)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43871 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-28 15:18:05 +00:00
Matt O'Gorman
942768c022 fixes some verbose vs debug issues. patch from bug 2617
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43269 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-19 16:21:08 +00:00
BJ Weschke
a05a361fc3 Make sure the forwarded channel inherits variables appropriately when we receive a call forward in the queue. (#7867 - raarts reported and patched)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41882 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 17:38:22 +00:00
BJ Weschke
aaf0ad7b77 Don't keep trying the same member in certain strategies when members of the queue are unavailable (#7278 - diLLec reported and patched) - This should have been patched here first and then merged into /trunk. My bad!
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41880 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 17:13:38 +00:00
BJ Weschke
c3b61adc5b Setting a retry of 0 is generally not a good idea and shouldn't be allowed. (#7574 - reported by regin)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41827 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-03 14:16:08 +00:00
Russell Bryant
e81646d2dd remove duplicate queue log entry when the caller exits on a timeout
(issue #7616, ppyy)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@38972 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-05 08:08:48 +00:00
BJ Weschke
64def5d791 We should lock the queue before we go making changes to member interface statuses.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@35669 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-23 11:30:17 +00:00
Kevin P. Fleming
d00c50cd14 don't use prefixed structure names for internal structures
don't use a plural structure name for a singular object


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@34274 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-15 13:30:22 +00:00
Kevin P. Fleming
55ba8ef5c4 coding style cleanups on queue interface handling code that was committed for the last release
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@34160 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-14 22:22:21 +00:00
Kevin P. Fleming
5684ba5966 return bridge exit logic to what it was before i broke it :-(
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@31921 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-04 03:43:35 +00:00
BJ Weschke
a6a17f1789 Fix infinite loop scenario and add some sanity checking to prevent segfault on a NULL parameter coming in (which probably shouldn't happen, but just to be safe...)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@30770 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-30 14:55:16 +00:00
BJ Weschke
a94248e7dc A new way to try and deal with deadlocks that occur in app_queue at present. Using this approach, we only manipulate the main queue mutexes when we get a dev state change on a device that is actually a member of a queue. Backported from /trunk for the "bug fix".
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@30546 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-26 17:09:51 +00:00
BJ Weschke
f1744d3e31 Oops.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@30424 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-25 21:22:16 +00:00
Kevin P. Fleming
f5765a22fc fix various bugs related to exiting from queue via keypress and moh handling (issue #6776, different fix)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@29971 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-24 16:52:08 +00:00
Kevin P. Fleming
e0989958cc don't allow queue member devices to ring longer than the total queue timeout (issue #6423, reported and patched by bcnit)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@28968 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-20 02:35:53 +00:00
Joshua Colp
14285e5b2b Treat paused queue members as unreachable (issue #7127 reported by peterh)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@28627 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-19 15:38:59 +00:00
BJ Weschke
249760b951 Make QueueStatusComplete event thread safe by wrapping it inside the queue lock clause already there. #7013 (bziherl reporting)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@25522 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-08 13:35:17 +00:00
BJ Weschke
d46fa7e825 Oops. :(
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@25520 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-08 13:15:30 +00:00
BJ Weschke
41210a37d6 Don't recheck valid_exit() after getting the result from say_position (which already checks it). Should prevent another loop if the caller hits digits during the position announcement. #6776 (tgj reporting)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@25518 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-08 13:11:32 +00:00
Tilghman Lesher
c7ee76b69f Bug 7023 - reload should not unpause members
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@24706 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-04 16:27:20 +00:00
Joshua Colp
d0aef28b0e Queue(somequeue,,,,) -> interpreted as Queue(somequeue,,,,0) (issue #7044 reported nathan fixed by jsmith - sort of)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@22954 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-27 19:11:47 +00:00
Olle Johansson
457bdd22bb Issue #6882 - move "res=-1" out of verbosity block, minor code cleanups (casper)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@17335 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-04-04 17:59:18 +00:00
Russell Bryant
14e8c4c5a3 fix a problem with not loading realtime queue members by always reloading a
realtime queue from the database even if it is found in the list (issue #6680)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@12925 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-03-14 18:28:39 +00:00
Kevin P. Fleming
ce008d40a1 don't double-increment abandon counter for calls that are hung up while dialing members (issue #6289)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@10018 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-02-14 20:20:15 +00:00
Russell Bryant
2f1d118537 fix memory leak from not freeing the queue member list when freeing an old queue
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@8445 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-22 19:03:53 +00:00
Tilghman Lesher
366c8a99ef Bug 5936 - AddQueueMember fails on realtime queue, if queue not yet loaded
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@8394 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-21 18:29:39 +00:00
Russell Bryant
30f2aff526 fix invalid value of prev_q (issue #6302)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@8347 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-01-20 18:34:42 +00:00
Russell Bryant
a434f8877a cast time_t to an int in printf/scanf (issue #5635)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@7634 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-12-26 18:19:12 +00:00
Russell Bryant
a49f954f6a don't delete dynamic queue members when reloading the static members from a realtime database (issue #5922)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@7337 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-12-05 00:09:12 +00:00
Russell Bryant
a32f75b800 fix queue weight feature - compare member interfaces instead of pointers to
the members, since each queue has its own list of members. (issue #5863)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@7249 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-12-01 01:19:04 +00:00
Kevin P. Fleming
a563eab49a remove extraneous svn:executable properties
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@7221 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-29 18:24:39 +00:00
Kevin P. Fleming
54dd7ac9fa issue #5707
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7053 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-10 23:22:37 +00:00
Russell Bryant
987b87662c make app_queue 1.2 jump compliant (issue #5580)
add missing includes of stdio.h
remove some unused and duplicate headers


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7026 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-08 04:48:00 +00:00
Kevin P. Fleming
a0a9769616 issue #5648
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@7011 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-08 01:55:31 +00:00
Kevin P. Fleming
f09c6bc78e application doc update
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6992 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-07 22:01:22 +00:00
Russell Bryant
31a804b97c issue #5605
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6979 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-06 15:09:47 +00:00
Russell Bryant
3bd298f2dd alphabetize option lists
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6975 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-11-06 05:34:13 +00:00
Russell Bryant
5187de9ab6 remove unnecessary checks before calls to ast_strlen_zero
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6864 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-26 19:48:14 +00:00
Russell Bryant
3453e3efa5 Doxygen documentation update from oej (issue #5505)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6847 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-24 20:12:06 +00:00
Russell Bryant
4aa7912057 Massive cleanups to applications for LOCAL_USER handling and some other things.
In general, LOCAL_USER_ADD/REMOVE should be the first/last thing called in an
application.  An exception is if there is some *fast* setup code that might
halt the execution of the application, such as checking to see if an argument
exists.


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6832 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-19 18:19:02 +00:00
Russell Bryant
29829640bf it's a good idea to unregister everything before calling STANDARD_HANGUP_LOCALUSERS
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6828 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-18 22:52:21 +00:00
Mark Spencer
dbdd193e12 Fix segfault in app queue when no cdr exists for the calling channel (bug #5462)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6824 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-18 20:58:16 +00:00
Mark Spencer
4e919f337c Fix queue, iax and sip formatting issues (bug #5449)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6811 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2005-10-17 22:26:33 +00:00