Commit Graph

356 Commits

Author SHA1 Message Date
Jason Parker
c908fb91d1 Fix a small typo in description in of Voicemail() application.
Issue 10170, patch by casper.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@74316 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-10 15:37:54 +00:00
Jason Parker
4ce4fe74ae Fix another problem in voicemail with missing symbols.
Issue 10074, patch by kryptolus, extended to include #if 0'd blocks (just in case)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@72184 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-27 18:40:15 +00:00
Tilghman Lesher
8f2a415995 Issue 10062 - Trying to move a message without selecting one first results in memory corruption
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@71750 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-26 12:25:58 +00:00
Joshua Colp
e179ccaff2 Don't explode if the gain option is specified without a value. (issue #9274 reported by mfarver)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@70898 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-21 21:37:55 +00:00
Jason Parker
a3961d646a Don't try to save voicemail greetings unless the user presses '1' to accept/save.
Issue 9904, patch by me.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@68204 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 20:02:50 +00:00
Jason Parker
dfd24c33d2 If we have a negative current message, we shouldn't go back even further...
Issue 9727.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@64758 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-17 16:52:38 +00:00
Tilghman Lesher
616e3502e7 Issue 9527 - upon entering a folder, no message is selected (curmsg == -1), so deleting causes memory corruption (beyond bounds)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@63359 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-08 06:20:16 +00:00
Jason Parker
6374772250 Just because we can't find the voicemail configuration file, doesn't
mean that the module failed to load.  The user could be using realtime.

Issue #9473


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@60267 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-05 16:09:41 +00:00
Joshua Colp
5e01069962 Increase the maximum size for a string of mailboxes to 1024. (issue #9270 reported by rtucker)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@59723 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-04-02 18:55:25 +00:00
Tilghman Lesher
7ca5863965 Oops
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@59283 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-27 23:36:49 +00:00
Tilghman Lesher
43ac3f119b Fix a few remaining bad mmap(2) return values
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@59280 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-27 23:31:20 +00:00
Joshua Colp
c17a4c7f53 Make create_dirpath use our standard for return values. -1 is failure, 0 is success. (issue #9205 reported by ballares)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@57869 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-05 17:49:18 +00:00
Tilghman Lesher
12a38f8e56 Memory leak of a list, if call recording was abandoned
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@57648 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-03-03 06:36:55 +00:00
Tilghman Lesher
fababa3b74 forcename and forcegreetings options should check to see if the recording already exists
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@55434 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-19 18:09:09 +00:00
Tilghman Lesher
f49ce518ba Issue 9003 - If fullname is empty, quote() passes back "\""
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@53529 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-02-08 13:36:10 +00:00
Tilghman Lesher
c69d99c830 Postgres driver doesn't like a NULL pointer when retrieving the length (Bug 8513)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@51158 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-16 21:26:06 +00:00
Matt O'Gorman
741131aaa2 Solves issue with forwarding voicemails from folders other than inbox.
patch by anthonyl.



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@50946 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-15 20:44:53 +00:00
Tilghman Lesher
a0afc6c927 The advent of realtime has enabled people to use commas in the fullname field.
This could cause an issue with sending voicemails, when the field is unquoted.
(Issue 8595)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@50150 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-09 13:30:04 +00:00
Matt O'Gorman
99815228f2 converted a lot of 256 to PATH_MAX and some white space fixes.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@49447 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-04 17:45:16 +00:00
Matt O'Gorman
82016c83d2 good catch russell sorry i missed that.
fix magic number with proper sizeof


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@49412 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-04 16:48:43 +00:00
Matt O'Gorman
58f6fb69fb When using ODBC_STORAGE VoicemailMain doesn't create the
subdirectories for a mailbox such as the INBOX directory.

this patch solves that problem, was written by anthony
be-125


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@49354 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-01-03 23:22:47 +00:00
Tilghman Lesher
31759faca8 If the recording in the database is too large, it will fail to retrieve with
an mmap error.  Not too sure why this doesn't happen when we put it in the
database, also, but since that doesn't seem to be broken, I'm not going to fix
it (at least until someone reports it).  Solution is to ask for the file in
smaller chunks.  (Bug 8385)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@48251 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-05 01:26:08 +00:00
Jason Parker
9ce01ec196 Revert change from 8016 - this breaks other stuff... Needs further review.
Tip: When you've reported a bug about something and somebody has put up a
patch for it..  It's not a good idea to open a completely new bug and say that
something is broken because of the patch in the other bug - PLEASE mention
something in the bug where the patch was actually created.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@48246 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-04 21:20:34 +00:00
Jason Parker
8c413a42eb Fix an issue where a message isn't saved correctly when using ODBC storage and reviewing a message.
Issue 8016 - patch by sokhapkin.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@48236 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-12-04 19:06:26 +00:00
Joshua Colp
0c18e0a5e1 Use the proper function to get the new message count instead of always using the filesystem. (issue #8421 reported by slimey)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@48053 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-27 18:03:57 +00:00
Tilghman Lesher
0e783db690 Failing to trap -1 error from mmap causes segfault (Issue 8385)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47862 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-20 19:59:07 +00:00
Kevin P. Fleming
c446ef9782 correct argument name typo that caused global variable to be used instead of the one for the specified voicemail user
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47696 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-15 20:30:29 +00:00
Kevin P. Fleming
bedd43d2f9 ensure that message duration is included in email notifications for forwarded messages (BE-96, fix by me after corydon used his clue-bat on me)
ensure that duration in the message metadata is updated if prepending is done during forwarding (related to BE-96)
remove prototype for API call that does not exist


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47677 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-15 17:56:42 +00:00
Joshua Colp
5cea7867b3 Update copyright information in the ADSI logo blob.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@47631 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-11-14 22:15:10 +00:00
Tilghman Lesher
a2d98d6c7c Avoid inability to lock directory log message by creating the directory ahead of time. (Issue 7631)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43815 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-27 20:20:35 +00:00
Russell Bryant
a0da756f2a When parsing the sections of voicemail.conf that contain mailbox definitions,
don't introduce a length limit on the definition by using a 256 byte temporary
storage buffer.  Instead, make the temporary buffer just as big as it needs
to be to hold the entire mailbox definition.
(fixes BE-68)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43699 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-26 20:23:15 +00:00
Tilghman Lesher
83b377451c Two bugs when forwarding voicemail (Issue 7824):
1) delete=yes was ignored
2) maxmessages was ignored


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43634 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-25 21:14:41 +00:00
Tilghman Lesher
6728ebb72c cid is passed to a destructive function; thus a copy is needed (issue 7961)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@43248 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-19 12:28:55 +00:00
Tilghman Lesher
ca79503d56 Backport bugfix patch from 7918 to 1.2 - msg_cfg destroyed before used
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@42892 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-09-13 19:51:24 +00:00
Tilghman Lesher
e83bbab1ec Text only - clarify the reason for entry into authentication mode when the skipuser option is ignored
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@41065 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-25 15:07:16 +00:00
Jason Parker
d98055d875 Fix a bug with app_voicemail when trying to use app_directory to leave messages
to another user (options 3, 5, 2).

If the context/extension didn't exist in the dialplan (and why should it have to?),
it would fail, saying that it's an "invalid extension".

Fix was different in svn trunk.

(issue BE-71)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@40446 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-19 01:03:22 +00:00
Tilghman Lesher
84ad1fe0f3 Bug 7648 - Checking wrong count for plurality on new messages for Dutch language
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@38761 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-08-03 05:22:19 +00:00
Kevin P. Fleming
6ea65400a0 don't fail/abort if the message category sound file cannot be played, just generate a warning message and continue message playback
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@37571 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-13 21:22:11 +00:00
Kevin P. Fleming
ff3890a952 fix a weird case where a lock file could be left (but would happen almost never)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@37442 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-07-12 15:53:53 +00:00
Joshua Colp
43ad959914 Call reset_user_pw upon changing the password using externpass (issue #7395 reported by Ryan Cumming)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@34911 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-19 20:27:44 +00:00
Tilghman Lesher
4c688bb3b3 Issue 7357 - txt file left behind when going to operator. Also, fix a possible file descriptor leak.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@34875 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-19 18:07:26 +00:00
Tilghman Lesher
2159afd1ae VoicemailMain exits on any key, when the language is set to Italian, instead of
properly handling the key (issue 7353).


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@34242 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-15 12:40:10 +00:00
Russell Bryant
ec39ee2c34 fix various places where the code returns without unlocking vmlock or
destroying loaded configuration


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@33783 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-13 04:31:19 +00:00
Tilghman Lesher
95cd30dc01 Bug 7287 - A too short voicemail with ODBC_STORAGE will cause the first voicemail to be deleted erroneously
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@32605 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-06-06 16:55:23 +00:00
Joshua Colp
63c91a899e When forwarding messages use the context that the active voicemail user was found in. (issue #7010)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@28651 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-19 16:03:33 +00:00
Joshua Colp
3c8d8caca1 Return -1 on error in ODBC messagecount and 0 on success (issue #7133 reported by cfieldmtm)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@28212 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-18 16:31:16 +00:00
Joshua Colp
a6d8b31956 Fix endless looping message by checking value of res before doing retries stuff. (issue #7140 reported by tanischen)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@28169 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-18 14:27:21 +00:00
Joshua Colp
968d069242 Priority jumping not working on VoiceMail app with new syntax (issue #7164 reported and fixed by alvaro_palma_aste)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@27847 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-17 17:07:52 +00:00
Tilghman Lesher
728e1d9a31 Bug 7125 - Fix race condition between resequencing and leaving a message
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@27636 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-17 02:19:50 +00:00
Tilghman Lesher
ee46d2d92e Bug 7134 - File descriptor leak with ODBC storage of voicemail
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@27093 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2006-05-13 04:08:29 +00:00