Michael L. Young 3b731ff2d0 Properly indicate failure to open an audio stream in res_agi ...

If there is an error streaming an audio file, the current return status makes it
difficult for an AGI script to determine that there was an error with the audio
file.

This patches changes the result to return -1 and the function returns
RESULT_FAILURE instead of RESULT_SUCCESS.  From looking at other parts of
res_agi, this would appear to be the proper way to handle an error.

(closes issue ASTERISK-21903)
Reported by: Ariel Wainer
Tested by: Ariel Wainer
Patches:
	asterisk-21903-return-stream-res_1.8.diff
					by Michael L. Young (license 5026)

Review: https://reviewboard.asterisk.org/r/2625/
........

Merged revisions 394640 from http://svn.asterisk.org/svn/asterisk/branches/1.8


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@394641 65c4cc65-6c06-0410-ace0-fbb531ad65f3

2013-07-18 12:52:33 +00:00

..

ael

Clean up and ensure proper usage of alloca()

2012-07-31 20:21:43 +00:00

pjproject

Fix how we build pjproject.

2013-02-04 19:50:52 +00:00

snmp

Multiple revisions 369001-369002

2012-06-15 16:20:16 +00:00

Makefile

Fix how we build pjproject.

2013-02-04 19:50:52 +00:00

res_adsi.c

Multiple revisions 369323-369324

2012-06-25 15:55:25 +00:00

res_ael_share.c

Merged revisions 328247 via svnmerge from

2011-07-14 20:28:54 +00:00

res_ael_share.exports.in

…

res_agi.c

Properly indicate failure to open an audio stream in res_agi

2013-07-18 12:52:33 +00:00

res_agi.exports.in

…

res_calendar_caldav.c

Fix a variety of memory leaks

2012-05-18 14:43:44 +00:00

res_calendar_ews.c

Properly extract the Body information of an EWS calendar item

2012-10-31 14:49:33 +00:00

res_calendar_exchange.c

Fix a variety of memory leaks

2012-05-18 14:43:44 +00:00

res_calendar_icalendar.c

Fix memory leak in res_calendar_icalendar

2013-01-30 14:15:27 +00:00

res_calendar.c

Fix memory/ref counting leaks in a variety of locations

2013-06-25 01:07:29 +00:00

res_calendar.exports.in

…

res_clialiases.c

Fix crash that can occur if CLI registration fails for an aliased command.

2012-12-11 20:51:47 +00:00

res_clioriginate.c

Allow support for early media on AMI originates and call files.

2012-08-08 22:39:40 +00:00

res_config_curl.c

Properly delimit post data in res_config_curl.

2013-03-25 12:36:33 +00:00

res_config_ldap.c

Use LDAP memory management functions instead of Asterisk's

2013-04-10 14:25:44 +00:00

res_config_odbc.c

Fix coverity UNUSED_VALUE findings in core support level files

2012-06-11 15:23:30 +00:00

res_config_pgsql.c

Minor fixups to Doxygen comments.

2013-05-07 18:29:30 +00:00

res_config_sqlite3.c

Avoid cppcheck warnings; removing unused vars and a bit of cleanup.

2012-04-17 18:57:40 +00:00

res_config_sqlite.c

Fix misuses of asprintf throughout the code.

2012-08-21 20:54:19 +00:00

res_convert.c

Merged revisions 328247 via svnmerge from

2011-07-14 20:28:54 +00:00

res_corosync.c

Add a "corosync ping" CLI command.

2012-07-30 00:14:18 +00:00

res_crypto.c

Fix incorrect usage of sizeof() in res_crypto.

2012-03-14 00:39:23 +00:00

res_crypto.exports.in

Remove built-in AES code and use optional_api instead

2010-07-21 19:11:32 +00:00

res_curl.c

Update module support level on a variety of modules and compiler options

2012-08-18 01:08:03 +00:00

res_fax_spandsp.c

res_fax_spandsp: fix t38 transmission bug caused by not returning success

2013-01-22 22:05:14 +00:00

res_fax.c

Ensure ReceiveFax provides a CED tone via T.38

2012-12-10 16:55:05 +00:00

res_fax.exports.in

…

res_format_attr_celt.c

Add support for parsing SDP attributes, generating SDP attributes, and passing it through.

2012-07-13 16:49:40 +00:00

res_format_attr_h263.c

Reduce memory consumption and add the H.264 and H.263 modules I shamefully neglected to add.

2012-07-13 18:41:07 +00:00

res_format_attr_h264.c

AST-2013-001: Prevent buffer overflow through H.264 format negotiation

2013-03-27 14:26:44 +00:00

res_format_attr_silk.c

Add support for parsing SDP attributes, generating SDP attributes, and passing it through.

2012-07-13 16:49:40 +00:00

res_http_post.c

Avoid cppcheck warnings; removing unused vars and a bit of cleanup.

2012-04-17 18:57:40 +00:00

res_http_websocket.c

Fix segfault for certain invalid WebSocket input.

2013-06-12 21:00:38 +00:00

res_http_websocket.exports.in

Fix an issue with res_http_websocket where the chan_sip WebSocket handler could not be registered.

2012-10-31 18:00:32 +00:00

res_jabber.c

Distributed Device State broken at sites using res_xmpp or res_jabber where Secuity Advisory AST-2012-015 is inplace

2013-04-16 23:13:58 +00:00

res_jabber.exports.in

Fix chan_jingle/gtalk load regression introduced in r346087

2011-12-05 14:47:11 +00:00

res_limit.c

Merged revisions 328247 via svnmerge from

2011-07-14 20:28:54 +00:00

res_monitor.c

monitor: prevent attempts to move/remove recordings skipped with 'i' and 'o'.

2012-11-16 19:59:45 +00:00

res_monitor.exports.in

…

res_musiconhold.c

Refactor ast_timer_ack to return an error and handle the error in timer users

2012-11-05 23:09:30 +00:00

res_mutestream.c

Fix the svn:keywords property on several files.

2013-04-15 15:18:54 +00:00

res_odbc.c

Ensure that all ast_datastore_info structures are 'const'.

2012-07-18 17:18:20 +00:00

res_odbc.exports.in

…

res_phoneprov.c

Avoid cppcheck warnings; removing unused vars and a bit of cleanup.

2012-04-17 18:57:40 +00:00

res_pktccops.c

Multiple revisions 350788-350789

2012-01-14 15:51:43 +00:00

res_pktccops.exports.in

…

res_realtime.c

Cleanup references to sipusers and sipfriends dynamic realtime families

2011-11-01 19:53:26 +00:00

res_rtp_asterisk.c

Fix The Payload Being Set On CN Packets And Do Not Set Marker Bit

2013-05-09 04:10:27 +00:00

res_rtp_multicast.c

Calculate the timestamp for outbound RTP if we don't have timing information

2013-04-14 03:00:27 +00:00

res_security_log.c

Merged revisions 328247 via svnmerge from

2011-07-14 20:28:54 +00:00

res_smdi.c

Mark res_smdi/res_adsi as 'core' supported modules

2012-06-13 20:28:07 +00:00

res_smdi.exports.in

…

res_snmp.c

Merged revisions 328247 via svnmerge from

2011-07-14 20:28:54 +00:00

res_speech.c

Fix coverity UNUSED_VALUE findings in core support level files

2012-06-11 15:23:30 +00:00

res_speech.exports.in

…

res_srtp.c

Use srtp_shutdown when available

2013-05-15 12:39:55 +00:00

res_srtp.exports.in

…

res_stun_monitor.c

Add 'stun show status' command

2012-07-05 21:36:41 +00:00

res_timing_dahdi.c

Refactor ast_timer_ack to return an error and handle the error in timer users

2012-11-05 23:09:30 +00:00

res_timing_kqueue.c

Refactor ast_timer_ack to return an error and handle the error in timer users

2012-11-05 23:09:30 +00:00

res_timing_pthread.c

Prevent res_timing_pthread from blocking callers

2013-04-19 22:25:49 +00:00

res_timing_timerfd.c

Refactor ast_timer_ack to return an error and handle the error in timer users

2012-11-05 23:09:30 +00:00

res_xmpp.c

Distributed Device State broken at sites using res_xmpp or res_jabber where Secuity Advisory AST-2012-015 is inplace

2013-04-16 23:27:51 +00:00

res_xmpp.exports.in

Add a new unified Jingle, Google Jingle, and Google Talk channel driver written from scratch called chan_motif.

2012-07-07 17:06:51 +00:00