Richard Mudgett
1269dd06bc
res_fax: Fix latent bug exposed by ASTERISK-24841 changes.
...
Three fax related tests started failing as a result of changes made for
ASTERISK-24841:
tests/fax/pjsip/gateway_t38_g711
tests/fax/sip/gateway_mix1
tests/fax/sip/gateway_mix3
Historically, ast_channel_make_compatible() did nothing if the channels
were already "compatible" even if they had a sub-optimal translation path
already setup. With the changes from ASTERISK-24841 this is no longer
true in order to allow the best translation paths to always be picked. In
res_fax.c:fax_gateway_framehook() code manually setup the channels to go
through slin and then called ast_channel_make_compatible(). With the
previous version of ast_channel_make_compatible() this was always a
no-operation.
* Remove call to ast_channel_make_compatible() in fax_gateway_framehook()
that now undoes what was just setup when the framehook is attached.
* Fixed locking around saving the channel formats in
fax_gateway_framehook() to ensure that the formats that are saved are
consistent.
* Fix copy pasta errors in fax_gateway_framehook() that confuses read and
write when dealing with saved channel formats.
ASTERISK-24841
Reported by: Matt Jordan
Change-Id: I6fda0877104a370af586a5e8cf9e161a484da78d
2015-04-17 18:46:25 -05:00
..
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-17 15:33:29 -05:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-14 12:53:03 -04:00
2015-04-14 12:53:03 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-17 18:46:25 -05:00
2014-07-18 15:49:46 +00:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2014-03-28 18:32:50 +00:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2014-06-26 18:27:53 +00:00
2015-04-13 03:48:57 -04:00
2015-01-12 18:09:27 +00:00
2015-01-12 18:09:27 +00:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2014-01-06 17:45:25 +00:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2014-10-09 17:46:23 +00:00
2015-03-17 21:52:47 +00:00
2014-10-16 16:32:25 +00:00
2015-03-13 16:37:17 +00:00
2015-04-13 03:48:57 -04:00
2014-10-16 16:32:25 +00:00
2015-04-17 15:58:07 -05:00
2015-04-13 03:48:57 -04:00
2014-10-16 16:32:25 +00:00
2015-03-17 18:35:07 +00:00
2015-03-17 18:35:07 +00:00
2015-03-17 18:35:07 +00:00
2015-04-09 12:57:21 +00:00
2014-10-16 16:32:25 +00:00
2015-03-26 17:47:42 +00:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-07 15:34:53 +00:00
2015-02-12 20:34:37 +00:00
2014-10-16 16:32:25 +00:00
2015-01-23 15:21:56 +00:00
2015-03-20 19:54:48 +00:00
2015-03-26 17:47:42 +00:00
2014-10-16 16:32:25 +00:00
2014-10-16 16:32:25 +00:00
2015-01-30 17:41:02 +00:00
2014-08-07 14:35:09 +00:00
2015-01-28 04:29:23 +00:00
2014-10-16 16:32:25 +00:00
2015-04-09 23:12:13 +00:00
2014-10-16 16:32:25 +00:00
2014-10-16 16:32:25 +00:00
2014-10-16 16:32:25 +00:00
2015-02-20 17:53:33 +00:00
2015-04-16 13:52:10 -05:00
2014-08-07 14:37:26 +00:00
2015-03-10 16:08:40 +00:00
2015-03-27 21:06:22 +00:00
2015-03-27 20:46:55 +00:00
2014-10-16 16:32:25 +00:00
2015-04-13 03:48:57 -04:00
2015-02-17 15:34:10 +00:00
2015-04-10 17:56:47 +00:00
2015-03-10 16:08:40 +00:00
2015-01-29 21:02:23 +00:00
2015-04-13 03:48:57 -04:00
2015-02-12 20:34:37 +00:00
2014-10-16 16:32:25 +00:00
2015-04-17 15:33:29 -05:00
2013-11-23 17:26:57 +00:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-03-17 22:03:01 +00:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2013-11-23 17:48:28 +00:00
2015-04-13 03:48:57 -04:00
2014-01-14 23:44:57 +00:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2013-11-23 12:40:46 +00:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-04-13 03:48:57 -04:00
2015-03-27 14:41:46 +00:00
2015-04-13 03:48:57 -04:00
2014-07-25 16:47:17 +00:00
2015-04-13 03:48:57 -04:00