Richard Mudgett 2122c205e6 Audit ast_sockaddr_resolve() usage for memory leaks. ...

Valgrind found some memory leaks associated with ast_sockaddr_resolve().
Most of the leaks had already been fixed by earlier memory leak hunt
patches.  This patch performs an audit of ast_sockaddr_resolve() and found
one more.

* Fix ast_sockaddr_resolve() memory leak in
apps/app_externalivr.c:app_exec().

* Made main/netsock2.c:ast_sockaddr_resolve() always set the addrs
parameter for safety so the pointer will never be uninitialized on return.
The same goes for res/res_pjsip_acl.c:extract_contact_addr().

* Made functions that call ast_sockaddr_resolve() with RAII_VAR()
controlling the addrs variable use ast_free instead of ast_free_ptr to
provide better MALLOC_DEBUG information.

Review: https://reviewboard.asterisk.org/r/4509/
........

Merged revisions 433056 from http://svn.asterisk.org/svn/asterisk/branches/11


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/13@433057 65c4cc65-6c06-0410-ace0-fbb531ad65f3

2015-03-17 21:49:30 +00:00

..

editline

cli.c: Fix tab completion "module load" when MALLOC_DEBUG is enabled.

2014-09-22 17:41:45 +00:00

stdtime

localtime: Fix file descriptor leak on kqueue(2) systems

2015-03-10 17:47:04 +00:00

abstract_jb.c

func_jitterbuffer: fix frame leaks.

2014-11-02 07:39:36 +00:00

acl.c

Fix error with mixed address family ACLs.

2014-11-20 16:36:54 +00:00

adsi.c

Allow Asterisk to compile under GCC 4.10

2014-05-09 22:49:26 +00:00

alaw.c

Multiple revisions 369001-369002

2012-06-15 16:20:16 +00:00

aoc.c

ISDN AOC: Fix crash from an AOC-E message that doesn't have a channel association.

2015-02-19 18:25:36 +00:00

app.c

app: Add functions to swap voicemail function table for testing purposes

2015-03-06 21:11:11 +00:00

ast_expr2.c

Allow the REALTIME() function to report errors back to the caller.

2012-07-11 17:16:50 +00:00

ast_expr2.fl

Avoid cppcheck warnings; removing unused vars and a bit of cleanup.

2012-04-17 18:57:40 +00:00

ast_expr2.h

Allow the REALTIME() function to report errors back to the caller.

2012-07-11 17:16:50 +00:00

ast_expr2.y

Multiple revisions 360356-360357

2012-03-24 02:42:42 +00:00

ast_expr2f.c

Doxygen Updates - janitor work

2012-09-21 17:14:59 +00:00

asterisk.c

HTTP: Stop accepting requests on final system shutdown.

2015-02-11 17:28:13 +00:00

asterisk.dynamics

Fix error loading res_monitor.

2014-04-23 15:02:39 +00:00

asterisk.exports.in

Add _IO_stdin_used in version-script to fix SIGBUSes on Sparc.

2013-08-22 08:26:55 +00:00

astfd.c

Unregister CLI commands on exit

2013-08-20 15:36:10 +00:00

astmm.c

MALLOC_DEBUG: Change fence magic number to be completely different from the freed magic number.

2013-09-09 23:29:44 +00:00

astobj2_container_private.h

astobj2: Additional refactoring to push impl specific code down into the impls.

2014-06-20 15:27:43 +00:00

astobj2_container.c

ao2_container node object ignores REF_DEBUG in all places except one

2014-06-25 18:57:04 +00:00

astobj2_hash.c

astobj2: Additional refactoring to push impl specific code down into the impls.

2014-06-20 15:27:43 +00:00

astobj2_private.h

astobj2: Additional refactoring to push impl specific code down into the impls.

2014-06-20 15:27:43 +00:00

astobj2_rbtree.c

astobj2: Additional refactoring to push impl specific code down into the impls.

2014-06-20 15:27:43 +00:00

astobj2.c

astobj2.c/refcounter.py: Fix to deal with invalid object refs.

2014-09-18 16:47:59 +00:00

audiohook.c

main/audiohook: Update internal sample rate on reads

2015-03-12 12:58:11 +00:00

autochan.c

Multiple revisions 369001-369002

2012-06-15 16:20:16 +00:00

autoservice.c

autoservice: stop thread on graceful shutdown

2014-06-09 03:50:45 +00:00

backtrace.c

Fix memory corruption when trying to get "core show locks".

2013-08-23 18:07:40 +00:00

bridge_after.c

Fix some memory leaks.

2015-01-30 16:47:50 +00:00

bridge_basic.c

bridge: avoid leaking channel during blond transfer pt2

2015-01-05 22:49:40 +00:00

bridge_channel.c

bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

2015-01-27 17:32:36 +00:00

bridge_roles.c

ARI: bridges/{bridgeID}/addChannel: add roles parameter

2013-08-05 16:59:13 +00:00

bridge.c

HTTP: Stop accepting requests on final system shutdown.

2015-02-11 17:28:13 +00:00

bucket.c

Allow shutdown to unload modules that register bucket scheme's or codec's.

2015-02-21 02:56:59 +00:00

buildinfo.c

fix a few small things found by using sparse

2008-10-30 16:49:02 +00:00

callerid.c

CallerID: Fix parsing regression

2014-10-10 13:01:41 +00:00

ccss.c

Stasis: Allow message types to be blocked

2014-08-06 12:55:28 +00:00

cdr.c

Documentation: Revise explanation of cdr.conf option 'Unanswered'

2014-11-14 17:45:53 +00:00

cel.c

Fix race condition that could result in ARI transfer messages not being sent.

2014-11-14 15:24:48 +00:00

channel_internal_api.c

Stasis: Fix StasisStart/End order and missing events

2014-12-08 15:43:14 +00:00

channel.c

app_chanspy, channel: fix frame leaks

2015-02-26 17:07:50 +00:00

chanvars.c

res_phoneprov: Refactor phoneprov to allow pluggable config providers

2014-10-09 17:45:23 +00:00

cli.c

core: Fix tab completion of "core set debug channel" CLI command.

2015-03-14 01:36:56 +00:00

codec_builtin.c

media formats: re-architect handling of media for performance improvements

2014-07-20 22:06:33 +00:00

codec.c

Allow shutdown to unload modules that register bucket scheme's or codec's.

2015-02-21 02:56:59 +00:00

config_options.c

AMI: Allow for command response documentation

2014-07-24 13:00:59 +00:00

config.c

various: cleanup issues found during leak hunt

2015-02-06 21:26:12 +00:00

core_local.c

Stasis: Allow message types to be blocked

2014-08-06 12:55:28 +00:00

core_unreal.c

AMI: Add missing VarSet events when a channel inherits variables.

2014-10-17 02:41:34 +00:00

crypt.c

Fix utils directory breakage.

2013-07-04 13:06:15 +00:00

cygload.c

Kill off red blobs in most of main/*

2012-03-22 19:51:16 +00:00

data.c

data: Properly access formats in capabilities structure when adding codecs.

2014-10-07 18:33:45 +00:00

datastore.c

This is no longer needed.

2013-06-29 00:18:57 +00:00

db.c

AMI: Make AMI actions that generate event lists consistent.

2015-01-09 17:54:49 +00:00

devicestate.c

devicestate.c: Minor tweaks

2014-09-05 17:36:35 +00:00

dial.c

Dial API: add self destruct option when complete

2015-02-26 18:52:56 +00:00

dns.c

Clean up files that do not end with newlines

2014-08-21 14:52:06 +00:00

dnsmgr.c

Migrate a large number of AMI events over to Stasis-Core

2013-05-24 20:44:07 +00:00

dsp.c

media formats: re-architect handling of media for performance improvements

2014-07-20 22:06:33 +00:00

ecdisa.h

Kill off red blobs in most of main/*

2012-03-22 19:51:16 +00:00

endpoints.c

core: Don't create snapshots with locks.

2015-03-10 23:09:17 +00:00

enum.c

Allow Asterisk to compile under GCC 4.10

2014-05-09 22:49:26 +00:00

event.c

event.c: Fix type mismatch errors in ie_maps[].

2014-06-27 23:21:44 +00:00

features_config.c

Allow for transferer to retry when dialing an invalid extension.

2014-11-17 16:51:16 +00:00

features.c

app_bridge: return to the next dialplan priority

2015-01-09 21:44:31 +00:00

file.c

main/file.c: fix possible extra ast_module_unref to format modules.

2014-11-06 12:13:56 +00:00

fixedjitterbuf.c

Multiple revisions 369001-369002

2012-06-15 16:20:16 +00:00

fixedjitterbuf.h

Kill off red blobs in most of main/*

2012-03-22 19:51:16 +00:00

format_cache.c

Clean up files that do not end with newlines

2014-08-21 14:52:06 +00:00

format_cap.c

main/frame: Don't report empty disallow values as an error

2015-03-14 02:28:56 +00:00

format_compatibility.c

chan_iax2: Several media format fixes.

2014-08-07 18:51:16 +00:00

format.c

media: Fix crash when determining sample count of a frame during shutdown.

2014-12-12 16:57:26 +00:00

frame.c

media formats: re-architect handling of media for performance improvements

2014-07-20 22:06:33 +00:00

framehook.c

audiohooks: Reevaluate the bridge technology when an audiohook is added or removed.

2014-10-03 19:39:49 +00:00

fskmodem_float.c

Multiple revisions 369001-369002

2012-06-15 16:20:16 +00:00

fskmodem_int.c

Multiple revisions 369001-369002

2012-06-15 16:20:16 +00:00

fskmodem.c

Multiple revisions 369001-369002

2012-06-15 16:20:16 +00:00

global_datastores.c

Multiple revisions 369001-369002

2012-06-15 16:20:16 +00:00

hashtab.c

Fix utilities compilation/linking.

2013-08-16 16:26:11 +00:00

heap.c

Fix incorrect usages of ast_realloc().

2013-09-10 18:05:47 +00:00

http.c

http: Add missing html tag to 'httpstatus' functionality.

2015-02-21 14:05:45 +00:00

image.c

media formats: re-architect handling of media for performance improvements

2014-07-20 22:06:33 +00:00

indications.c

media formats: re-architect handling of media for performance improvements

2014-07-20 22:06:33 +00:00

io.c

Allow Asterisk to compile under GCC 4.10

2014-05-09 22:49:26 +00:00

jitterbuf.c

jitterbuf: Fix memory leak on jitter buffer reset

2013-10-24 19:42:21 +00:00

json.c

ARI: Fix crash if integer values used in JSON payload 'variables' object.

2015-02-27 18:23:22 +00:00

libasteriskssl.c

Resolve memory leaks in TLS initialization and TLS client connections

2012-09-14 19:53:43 +00:00

libasteriskssl.exports.in

Address OpenSSL initialization issues when using third-party libraries.

2012-01-30 21:21:16 +00:00

loader.c

Allow shutdown to unload modules that register bucket scheme's or codec's.

2015-02-21 02:56:59 +00:00

lock.c

DEBUG_THREADS: Fix regression and lock tracking initialization problems.

2014-12-12 23:40:50 +00:00

logger.c

queue_log: Post QUEUESTART entry when Asterisk fully boots.

2014-12-22 19:44:03 +00:00

Makefile

Add support for the clang compiler; update RAII_VAR to use BlocksRuntime

2015-03-12 12:39:26 +00:00

manager_bridges.c

Fix typo's (retrieve, specified, address).

2015-01-23 15:03:05 +00:00

manager_channels.c

ARI/AMI: Include language in standard channel snapshot output

2014-12-09 20:19:40 +00:00

manager_endpoints.c

Multiple revisions 399887,400138,400178,400180-400181

2013-09-30 18:55:27 +00:00

manager_mwi.c

Multiple revisions 399887,400138,400178,400180-400181

2013-09-30 18:55:27 +00:00

manager_system.c

Multiple revisions 399887,400138,400178,400180-400181

2013-09-30 18:55:27 +00:00

manager.c

Fix some memory leaks.

2015-01-30 16:47:50 +00:00

md5.c

md5: supress some compiler warnings.

2012-04-28 01:33:49 +00:00

media_index.c

media formats: re-architect handling of media for performance improvements

2014-07-20 22:06:33 +00:00

message.c

message: Don't close an AMI connection on SendMessage action error

2014-10-06 18:38:25 +00:00

mixmonitor.c

Removed quotes from svn:keywords props on a few files.

2013-07-29 17:51:25 +00:00

named_acl.c

acl: Fix reloading of configuration if configuration file does not exist at startup.

2014-12-20 20:57:19 +00:00

netsock2.c

Audit ast_sockaddr_resolve() usage for memory leaks.

2015-03-17 21:49:30 +00:00

netsock.c

Move eid functions to utils.c, mark netsock.h deprecated

2014-06-24 02:50:15 +00:00

optional_api.c

Logger/CLI/etc.: Fix some aesthetic issues; reduce chatty verbose messages

2014-05-28 22:54:12 +00:00

parking.c

res_pjsip_refer: Fix bugs involving Parking/PJSIP/transfers

2014-05-22 15:52:30 +00:00

pbx.c

Fix some memory leaks.

2015-01-30 16:47:50 +00:00

pickup.c

Stasis: Allow message types to be blocked

2014-08-06 12:55:28 +00:00

plc.c

Multiple revisions 369001-369002

2012-06-15 16:20:16 +00:00

poll.c

Merged revisions 285268 via svnmerge from

2010-09-07 19:09:08 +00:00

presencestate.c

Stasis: Allow message types to be blocked

2014-08-06 12:55:28 +00:00

privacy.c

Multiple revisions 369001-369002

2012-06-15 16:20:16 +00:00

rtp_engine.c

Various fixes for OS X

2015-01-26 14:49:32 +00:00

say.c

app_voicemail, say: Add support for Japanese Language

2014-06-30 04:00:19 +00:00

sched.c

Create work around for scheduler leaks during shutdown.

2015-02-19 02:01:34 +00:00

sdp_srtp.c

channels/sip/sdp_crypto: Handle SRTP keys negotiated with key lifetime/MKI

2015-02-25 21:42:04 +00:00

security_events.c

Stasis: Allow message types to be blocked

2014-08-06 12:55:28 +00:00

sem.c

Various fixes for OS X

2015-01-26 14:49:32 +00:00

sha1.c

Doxygen Updates - janitor work

2012-09-21 17:14:59 +00:00

sip_api.c

Don't make chan_sip export global symbols.

2012-10-11 15:49:02 +00:00

slinfactory.c

media formats: re-architect handling of media for performance improvements

2014-07-20 22:06:33 +00:00

smoother.c

media formats: re-architect handling of media for performance improvements

2014-07-20 22:06:33 +00:00

sorcery.c

sorcery: Output an error message if a wizard is specified for an object type and it isn't found.

2015-02-14 19:45:40 +00:00

sounds_index.c

Indexer: Format message types may not exist

2014-10-08 14:54:29 +00:00

srv.c

Removed #if checks for crazy old versions of OS X.

2013-05-08 20:25:28 +00:00

stasis_bridges.c

core: Don't create snapshots with locks.

2015-03-10 23:09:17 +00:00

stasis_cache_pattern.c

stasis: use ao2_t_alloc for certain object allocators

2014-07-18 19:55:24 +00:00

stasis_cache.c

main/stasis: Allow subscriptions to use a threadpool for message delivery

2014-12-01 17:57:12 +00:00

stasis_channels.c

core: Don't create snapshots with locks.

2015-03-10 23:09:17 +00:00

stasis_endpoints.c

Stasis: Allow message types to be blocked

2014-08-06 12:55:28 +00:00

stasis_message_router.c

res_pjsip: make it unloadable (take 2)

2015-01-27 19:08:44 +00:00

stasis_message.c

Stasis: Allow message types to be blocked

2014-08-06 12:55:28 +00:00

stasis_system.c

Stasis: Allow message types to be blocked

2014-08-06 12:55:28 +00:00

stasis.c

main/stasis: Allow subscriptions to use a threadpool for message delivery

2014-12-01 17:57:12 +00:00

strcompat.c

Add builtin roundf() for systems lacking it.

2013-01-19 20:54:07 +00:00

strings.c

Add support for RFC 4662 resource list subscriptions.

2014-08-07 19:26:32 +00:00

stun.c

stun: correct attribute string padding to match rfc

2014-11-14 15:51:17 +00:00

syslog.c

main/syslog: Allow dynamic logs, such as security events, to log to the syslog

2015-01-12 18:01:24 +00:00

taskprocessor.c

chan_pjsip: Fix deadlock when masquerading PJSIP channels.

2014-10-03 17:39:50 +00:00

tcptls.c

tcptls: Handle new OpenSSL compile time option to disable SSLv3

2015-02-19 15:28:10 +00:00

tdd.c

Doxygen Updates - janitor work

2012-09-21 17:14:59 +00:00

term.c

Revamp of terminal color codes

2013-02-14 18:47:56 +00:00

test.c

main/test: Fix compilation issue on 32-bit systems

2014-12-04 17:13:34 +00:00

threadpool.c

threadpool.c: Minor cleanup fixes.

2014-09-29 20:26:50 +00:00

threadstorage.c

Unregister CLI commands on exit

2013-08-20 15:36:10 +00:00

timing.c

timing: Improve performance for most timing implementations.

2014-02-07 20:01:45 +00:00

translate.c

translate: Prevent invalid memory accesses on fast shutdown

2015-03-04 18:52:10 +00:00

udptl.c

Fix printf problems with high ascii characters after r413586 (1.8).

2014-12-17 09:54:00 +00:00

ulaw.c

Multiple revisions 369001-369002

2012-06-15 16:20:16 +00:00

uri.c

uri: Quiet warning about type qualifiers ignored on function return type

2014-08-21 14:39:27 +00:00

utils.c

various: cleanup issues found during leak hunt

2015-02-06 21:26:12 +00:00

uuid.c

Fix printf problems with high ascii characters after r413586 (1.8).

2014-12-17 09:54:00 +00:00

xml.c

Detect and use xsltCleanupGlobals when available

2013-10-03 18:00:15 +00:00

xmldoc.c

Fix some memory leaks.

2015-01-30 16:47:50 +00:00