kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-10-31 02:37:10 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
329e11194712b3effe92c8bdfc47acb565be371a
asterisk/main
History
Walter Doekes 329e111947 res/res_pjsip: Standardize/fix localnet checks across pjsip. 
In 2dee95cc (ASTERISK-27024) and 776ffd77 (ASTERISK-26879) there was
confusion about whether the transport_state->localnet ACL has ALLOW or
DENY semantics.

For the record: the localnet has DENY semantics, meaning that "not in
the list" means ALLOW, and the local nets are in the list.

Therefore, checks like this look wrong, but are right:

    /* See if where we are sending this request is local or not, and if
       not that we can get a Contact URI to modify */
    if (ast_apply_ha(transport_state->localnet, &addr) != AST_SENSE_ALLOW) {
        ast_debug(5, "Request is being sent to local address, "
                     "skipping NAT manipulation\n");

(In the list == localnet == DENY == skip NAT manipulation.)

And conversely, other checks that looked right, were wrong.

This change adds two macro's to reduce the confusion and uses those
instead:

    ast_sip_transport_is_nonlocal(transport_state, addr)
    ast_sip_transport_is_local(transport_state, addr)

ASTERISK-27248 #close

Change-Id: Ie7767519eb5a822c4848e531a53c0fd054fae934
2017-09-05 09:17:24 -05:00
..
editline
BuildSystem: Avoid 'ar cru' and use 'ar cr' instead.
2016-06-07 09:32:11 +02:00
stdtime
Fix compiler warnings on Fedora 26 / GCC 7.
2017-08-01 15:39:25 -06:00
.gitignore
build-system: Allow building with static pjproject
2016-03-01 09:30:43 -07:00
abstract_jb.c
abstract/fixed/adpative jitter buffer: disallow frame re-inserts
2017-01-17 17:08:53 -06:00
acl.c
res/res_pjsip: Standardize/fix localnet checks across pjsip.
2017-09-05 09:17:24 -05:00
adsi.c
…
alaw.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
alertpipe.c
core: Use eventfd for alert pipes on Linux when possible
2017-04-24 11:50:09 -05:00
aoc.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
app.c
core: Add PARSE_TIMELEN support to ast_parse_arg and ACO.
2017-07-13 11:44:14 -04:00
ast_expr2.c
Fix compiler warnings on Fedora 26 / GCC 7.
2017-08-01 15:39:25 -06:00
ast_expr2.fl
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
ast_expr2.h
…
ast_expr2.y
Fix compiler warnings on Fedora 26 / GCC 7.
2017-08-01 15:39:25 -06:00
ast_expr2f.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
asterisk.c
AST-2017-006: Fix app_minivm application MinivmNotify command injection
2017-08-30 18:42:58 +00:00
asterisk.dynamics
…
asterisk.exports.in
pjproject_bundled: Various fixes discovered during testing of OSes
2016-05-03 07:56:18 -05:00
astfd.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
astmm.c
cli: Fix various CLI documentation and completion issues
2017-02-13 11:33:15 -05:00
astobj2_container_private.h
Astobj2: Allow reference debugging to be enabled/disabled by config.
2015-04-27 18:37:26 -04:00
astobj2_container.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
astobj2_hash.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
astobj2_private.h
Astobj2: Allow reference debugging to be enabled/disabled by config.
2015-04-27 18:37:26 -04:00
astobj2_rbtree.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
astobj2.c
astobj2: Prevent potential deadlocks with ao2_global_obj_release
2017-03-30 13:59:11 -04:00
audiohook.c
frame: Better handle interpolated frames.
2017-04-26 11:34:59 -05:00
autochan.c
autochan/mixmonitor/chanspy: Fix unsafe channel locking and references.
2017-03-15 17:18:55 -06:00
autoservice.c
core: Reduce video update queueing.
2017-08-28 13:09:25 -03:00
backtrace.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
bridge_after.c
asterisk: Audit locking of channel when manipulating flags.
2017-05-16 14:25:23 +00:00
bridge_basic.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
bridge_channel.c
bridge_channel.c: Fix FRACK when mapping frames to the bridge.
2017-08-22 11:57:21 -05:00
bridge_roles.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
bridge.c
bridge: Fix stream topology/participant locking and video misrouting.
2017-08-06 11:17:42 -05:00
bucket.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
buildinfo.c
…
callerid.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
ccss.c
Fix compiler warnings on Fedora 26 / GCC 7.
2017-08-01 15:39:25 -06:00
cdr.c
core: Remove 'Data Retrieval API'
2017-07-05 11:25:58 -05:00
cel.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
channel_internal_api.c
core: Remove 'Data Retrieval API'
2017-07-05 11:25:58 -05:00
channel.c
channel: Fix topology API locking.
2017-08-22 11:57:21 -05:00
chanvars.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
cli.c
Fix compiler warnings on Fedora 26 / GCC 7.
2017-08-01 15:39:25 -06:00
codec_builtin.c
core: Add VP9 passthrough support.
2017-07-24 13:51:12 -05:00
codec.c
SDP: Ensure SDPs "merge" properly.
2017-04-25 13:03:33 -05:00
config_options.c
core: Add PARSE_TIMELEN support to ast_parse_arg and ACO.
2017-07-13 11:44:14 -04:00
config.c
core: Add PARSE_TIMELEN support to ast_parse_arg and ACO.
2017-07-13 11:44:14 -04:00
conversions.c
core/conversions: Added string to unsigned integer and long conversions
2017-05-17 17:41:11 -05:00
core_local.c
core_local: local channel data not being properly unref'ed and unlocked
2017-06-21 16:18:13 -05:00
core_unreal.c
core: Reduce video update queueing.
2017-08-28 13:09:25 -03:00
crypt.c
BuildSystem: Fix build on FreeBSD due to missing crypt.h
2017-06-08 10:42:54 -05:00
cygload.c
…
datastore.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
db.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
devicestate.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
dial.c
channel: Remove old epoll support and fixed max number of file descriptors.
2017-03-27 19:54:44 +00:00
dns_core.c
Add support for older name resolving version libraries like openBSD
2016-11-20 09:19:18 +11:00
dns_naptr.c
Add support for older name resolving version libraries like openBSD
2016-11-20 09:19:18 +11:00
dns_query_set.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
dns_recurring.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
dns_srv.c
Add support for older name resolving version libraries like openBSD
2016-11-20 09:19:18 +11:00
dns_system_resolver.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
dns_test.c
dns: Fix build when TEST_FRAMEWORK is not defined.
2015-04-10 13:32:24 +00:00
dns_tlsa.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
dns.c
Add support for older name resolving version libraries like openBSD
2016-11-20 09:19:18 +11:00
dnsmgr.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
dsp.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
ecdisa.h
…
endpoints.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
enum.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
event.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
features_config.c
Fix issue with CLI not returning to prompt after running "features show"
2016-10-20 09:53:24 +11:00
features.c
bridge: Fix returning to dialplan when executing Bridge() from AMI.
2017-05-04 16:40:04 -05:00
file.c
asterisk: Audit locking of channel when manipulating flags.
2017-05-16 14:25:23 +00:00
fixedjitterbuf.c
abstract/fixed/adpative jitter buffer: disallow frame re-inserts
2017-01-17 17:08:53 -06:00
fixedjitterbuf.h
abstract/fixed/adpative jitter buffer: disallow frame re-inserts
2017-01-17 17:08:53 -06:00
format_cache.c
core: Add VP9 passthrough support.
2017-07-24 13:51:12 -05:00
format_cap.c
stream: Add media stream topology definition and API
2017-02-13 07:49:25 -07:00
format_compatibility.c
T.140: Fix format ref and memory leaks.
2017-01-25 13:46:41 -06:00
format.c
format: Reintroduce smoother flags
2017-05-30 15:10:20 -05:00
frame.c
channel: Add ast_read_stream function for reading frames from all streams.
2017-02-24 10:20:33 -06:00
framehook.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
fskmodem_float.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
fskmodem_int.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
fskmodem.c
…
global_datastores.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
hashtab.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
heap.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
http.c
http.c: Reduce log spam
2017-07-11 09:29:51 -05:00
image.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
indications.c
core: Remove 'Data Retrieval API'
2017-07-05 11:25:58 -05:00
io.c
Core: Add support for systemd socket activation.
2017-07-21 14:04:33 -05:00
iostream.c
BuildSystem: Add patches to allow building with recent LibreSSL
2017-06-09 15:34:34 +02:00
jitterbuf.c
abstract/fixed/adpative jitter buffer: disallow frame re-inserts
2017-01-17 17:08:53 -06:00
json.c
json.c: Add backtrace log to find 'Invalid UTF-8 string' errors
2017-07-07 18:26:25 -05:00
libasteriskpj.c
PJPROJECT logging: Fix detection of max supported log level.
2017-01-24 11:25:19 -06:00
libasteriskssl.c
Fix compiler warnings on Fedora 26 / GCC 7.
2017-08-01 15:39:25 -06:00
libasteriskssl.exports.in
…
loader.c
modules: change module LOAD_FAILUREs to LOAD_DECLINES
2017-04-12 15:57:21 -06:00
lock.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
logger.c
logger: Added logger_queue_limit to the configuration options.
2017-05-08 16:49:13 -05:00
Makefile
Fix compile error for old versions of GCC.
2017-08-03 11:31:58 -05:00
manager_bridges.c
res/ari/resource_bridges: Add the ability to manipulate the video source
2016-11-14 17:03:09 -05:00
manager_channels.c
manager: Add documentation for NewConnectedLine event.
2016-10-31 14:46:54 -04:00
manager_endpoints.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
manager_mwi.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
manager_system.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
manager.c
manager: hook event is not being raised
2017-08-16 09:41:42 -05:00
max_forwards.c
Detect potential forwarding loops based on count.
2015-04-17 15:58:07 -05:00
md5.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
media_cache.c
media_cache: Prefer ast_file_is_readable() over access()
2017-03-08 17:26:41 -06:00
media_index.c
…
message.c
res_pjsip_messaging: Check URI type before dereferencing
2017-03-21 08:45:37 -06:00
mixmonitor.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
named_acl.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
named_locks.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
netsock2.c
STUN/netsock2: Fix some valgrind uninitialized memory findings.
2017-08-10 14:38:01 -05:00
netsock.c
netsock.c: fix includes for HURD
2016-11-01 11:48:06 +02:00
optional_api.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
parking.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
pbx_app.c
Core/PBX: Deadlock between dialplan execution and application unregistration.
2017-06-16 13:26:22 -05:00
pbx_builtins.c
core: Add digit filtering to ast_waitfordigit_full
2017-07-12 19:08:23 -04:00
pbx_functions.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
pbx_hangup_handler.c
cli: Fix various CLI documentation and completion issues
2017-02-13 11:33:15 -05:00
pbx_ignorepat.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
pbx_include.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
pbx_private.h
pbx: Create pbx_sw.c for management of 'struct ast_sw'.
2016-07-21 13:58:26 -04:00
pbx_sw.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
pbx_switch.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
pbx_timing.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
pbx_variables.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
pbx.c
core: Remove 'Data Retrieval API'
2017-07-05 11:25:58 -05:00
pickup.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
plc.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
poll.c
…
presencestate.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
privacy.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
rtp_engine.c
rtp_engine: Prevent possible double free with DTLS config
2017-09-01 17:59:58 -05:00
say.c
say.c: Fix file locations for second, seconds, minute, minutes files
2017-07-21 16:05:20 -05:00
sched.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
sdp_options.c
SDP: Add get/set option calls for RTP sched context per type.
2017-06-15 09:42:15 -05:00
sdp_private.h
SDP: Add get/set option calls for RTP sched context per type.
2017-06-15 09:42:15 -05:00
sdp_srtp.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
sdp_state.c
SDP: Add get/set option calls for RTP sched context per type.
2017-06-15 09:42:15 -05:00
sdp_translator.c
SDP: Make SDP translation to/from internal representation more const.
2017-04-27 19:08:05 -05:00
sdp.c
SDP: Make process possible multiple fmtp attributes per rtpmap.
2017-05-09 12:57:57 -05:00
security_events.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
sem.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
sha1.c
…
sip_api.c
…
slinfactory.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
smoother.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
sorcery.c
sorcery.c: Speed up ast_sorcery_retrieve_by_id()
2017-04-11 12:58:35 -05:00
sounds_index.c
Replace most uses of ast_register_atexit with ast_register_cleanup.
2015-03-26 22:24:26 +00:00
srv.c
srv: Fix crash when ast_srv_lookup is used and 0 records are returned.
2017-02-07 12:13:23 -06:00
stasis_bridges.c
res/ari/resource_bridges: Add the ability to manipulate the video source
2016-11-14 17:03:09 -05:00
stasis_cache_pattern.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
stasis_cache.c
main/stasis_cache: Demote the ERROR message when removing a nonexistent item
2017-03-14 08:40:54 -06:00
stasis_channels.c
res_ari: fix memory leak for channelvars
2017-02-03 16:42:52 -05:00
stasis_endpoints.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
stasis_message_router.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
stasis_message.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
stasis_system.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
stasis.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
strcompat.c
…
stream.c
chan_pjsip: Add support for multiple streams of the same type.
2017-06-28 18:36:29 +00:00
stringfields.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
strings.c
ari: Implement 'debug all' and request/response logging
2017-01-23 10:25:58 -07:00
stun.c
STUN/netsock2: Fix some valgrind uninitialized memory findings.
2017-08-10 14:38:01 -05:00
syslog.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
taskprocessor.c
taskprocessor.c: Change when high water warning logged.
2017-01-13 21:36:54 -06:00
tcptls.c
Core: Add support for systemd socket activation.
2017-07-21 14:04:33 -05:00
tdd.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
term.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
test.c
unittests: Add a unit test that causes a SEGV and...
2017-05-24 15:58:18 -05:00
threadpool.c
threadpool: Fix leak in ast_threadpool_serializer_group error path.
2016-07-13 11:47:56 -05:00
threadstorage.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
timing.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
translate.c
frame: Better handle interpolated frames.
2017-04-26 11:34:59 -05:00
udptl.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
ulaw.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
uri.c
…
utils.c
Fix compiler warnings on Fedora 26 / GCC 7.
2017-08-01 15:39:25 -06:00
uuid.c
Fix printf problems with high ascii characters after r413586 (1.8).
2014-12-17 10:23:32 +00:00
xml.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00
xmldoc.c
Remove ASTERISK_REGISTER_FILE.
2016-10-27 09:53:55 -04:00