Mark Michelson 3e2a2ac24f Fix some potential misuses of ast_str in the code. ...

Passing an ast_str pointer by value that then calls
ast_str_set(), ast_str_set_va(), ast_str_append(), or
ast_str_append_va() can result in the pointer originally
passed by value being invalidated if the ast_str had
to be reallocated.

This fixes places in the code that do this. Only the
example in ccss.c could result in pointer invalidation
though since the other cases use a stack-allocated ast_str
and cannot be reallocated.

I've also updated the doxygen in strings.h to include
notes about potential misuse of the functions mentioned
previously.

Review: https://reviewboard.asterisk.org/r/2161
........

Merged revisions 375025 from http://svn.asterisk.org/svn/asterisk/branches/1.8


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10@375026 65c4cc65-6c06-0410-ace0-fbb531ad65f3

2012-10-15 21:06:42 +00:00

..

editline

Fix a variety of memory leaks

2012-05-18 14:01:56 +00:00

stdtime

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

abstract_jb.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

acl.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

adsi.c

Fix crash in unloading of res_adsi module

2012-06-26 13:22:42 +00:00

alaw.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

aoc.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

app.c

Clean up and ensure proper usage of alloca()

2012-07-31 19:57:09 +00:00

ast_expr2.c

Multiple revisions 360356-360357

2012-03-24 02:38:59 +00:00

ast_expr2.fl

Merged revisions 309808 via svnmerge from

2011-03-07 01:01:08 +00:00

ast_expr2.h

Multiple revisions 360356-360357

2012-03-24 02:38:59 +00:00

ast_expr2.y

Multiple revisions 360356-360357

2012-03-24 02:38:59 +00:00

ast_expr2f.c

Multiple revisions 360356-360357

2012-03-24 02:38:59 +00:00

asterisk.c

Ensure Shutdown AMI event is still fired during Asterisk shutdown

2012-10-02 21:12:30 +00:00

asterisk.dynamics

Remove the old stub files, preferring the optional_api method.

2010-07-14 20:48:59 +00:00

asterisk.exports.in

Merged revisions 288640 via svnmerge from

2010-09-24 03:43:14 +00:00

astfd.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

astmm.c

Fix MALLOC_DEBUG version of ast_strndup().

2012-09-07 23:06:38 +00:00

astobj2.c

Constify __ao2_ref_debug in astobj2

2012-09-14 18:28:40 +00:00

audiohook.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

autochan.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

autoservice.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

bridging.c

Fix bridging thread leak.

2012-07-06 15:23:28 +00:00

buildinfo.c

fix a few small things found by using sparse

2008-10-30 16:49:02 +00:00

callerid.c

Clean up and ensure proper usage of alloca()

2012-07-31 19:57:09 +00:00

ccss.c

Fix some potential misuses of ast_str in the code.

2012-10-15 21:06:42 +00:00

cdr.c

Fix incorrect billing duration reported when batch mode is enabled

2012-10-11 15:43:19 +00:00

cel.c

Fix a variety of ref counting issues

2012-10-02 01:09:39 +00:00

channel.c

Fix a variety of ref counting issues

2012-10-02 01:09:39 +00:00

chanvars.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

cli.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

config.c

Handle integer over/under-flow in ast_parse_args

2012-08-16 22:50:12 +00:00

cygload.c

…

data.c

Fix a variety of ref counting issues

2012-10-02 01:09:39 +00:00

datastore.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

db.c

Fix DBDelTree error codes for AMI, CLI and AGI

2012-10-04 15:37:11 +00:00

devicestate.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

dial.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

dns.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

dnsmgr.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

dsp.c

dsp.c User Configurable DTMF_HITS_TO_BEGIN and DTMF_MISSES_TO_END

2012-10-04 20:17:16 +00:00

ecdisa.h

…

enum.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

event.c

Clean up and ensure proper usage of alloca()

2012-07-31 19:57:09 +00:00

features.c

Fix a variety of ref counting issues

2012-10-02 01:09:39 +00:00

file.c

Fix misuses of asprintf throughout the code.

2012-08-21 20:40:18 +00:00

fixedjitterbuf.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

fixedjitterbuf.h

…

format_cap.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

format_pref.c

Fix a variety of ref counting issues

2012-10-02 01:09:39 +00:00

format.c

Fix a variety of ref counting issues

2012-10-02 01:09:39 +00:00

frame.c

Rewrite a comment that didn't adequately explain the code it was documenting.

2012-07-24 16:54:01 +00:00

framehook.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

fskmodem_float.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

fskmodem_int.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

fskmodem.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

global_datastores.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

hashtab.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

heap.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

http.c

Remove old debug code from http configuration loading

2012-08-18 02:34:10 +00:00

image.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

indications.c

Fix a variety of ref counting issues

2012-10-02 01:09:39 +00:00

io.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

jitterbuf.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

loader.c

loader: Ensure dependent modules are properly initialized.

2012-09-27 16:50:46 +00:00

lock.c

Fixes ast_rwlock_timed[rd|wr]lock for BSD and variants.

2012-08-27 16:43:09 +00:00

logger.c

Clean up and ensure proper usage of alloca()

2012-07-31 19:57:09 +00:00

Makefile

Add OPENSSL_INCLUDE to the CFLAGS for ssl.c and tcptls.c.

2012-09-08 05:21:41 +00:00

manager.c

Multiple revisions 374570,374581

2012-10-05 20:23:14 +00:00

md5.c

Fix compilation in dev-mode

2012-06-11 14:11:14 +00:00

message.c

Fix findings from check-in on r374177

2012-10-02 17:10:04 +00:00

netsock2.c

Fix NULL pointer segfault in ast_sockaddr_parse()

2012-06-20 02:04:58 +00:00

netsock.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

pbx.c

Fix execution of 'i' extension due to uninitialized variable.

2012-10-09 22:19:26 +00:00

plc.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

poll.c

Merged revisions 285268 via svnmerge from

2010-09-07 19:09:08 +00:00

privacy.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

rtp_engine.c

Fix apparent copy and paste error where incorrect "glue" is used.

2012-06-29 20:28:10 +00:00

say.c

Fix saying of date in Dutch.

2012-09-25 23:08:46 +00:00

sched.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

security_events.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

sha1.c

Update SHA1 code to RFC 6234

2011-10-11 18:41:05 +00:00

slinfactory.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

srv.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

ssl.c

Resolve memory leaks in TLS initialization and TLS client connections

2012-09-14 19:12:48 +00:00

strcompat.c

Clean up and ensure proper usage of alloca()

2012-07-31 19:57:09 +00:00

strings.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

stun.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

syslog.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

taskprocessor.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

tcptls.c

Do not use a FILE handle when doing SIP TCP reads.

2012-10-12 16:11:30 +00:00

tdd.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

term.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

test.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

threadstorage.c

Clean up and ensure proper usage of alloca()

2012-07-31 19:57:09 +00:00

timing.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

translate.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

udptl.c

Ignore recovered zero-length secondary UDPTL packets

2012-08-20 15:27:15 +00:00

ulaw.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

utils.c

Implement workaround for BETTER_BACKTRACES crash

2012-08-27 13:57:10 +00:00

xml.c

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

xmldoc.c

Fix misuses of asprintf throughout the code.

2012-08-21 20:40:18 +00:00