Terry Wilson c068460b12 Don't leak a ref if out of memory and can't link the linkedid ...

If the ao2_link fails, we are most likely out of memory and bad things
are going to happen. Before those bad things happen, make sure to clean
up the linkedid references.

This patch also adds a comment explaining why linkedid can't be passed
to both local channel allocations and combines two ao2_ref calls into 1.

Review: https://reviewboard.asterisk.org/r/1895/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@365068 65c4cc65-6c06-0410-ace0-fbb531ad65f3

2012-05-02 17:02:39 +00:00

..

db1-ast

…

editline

Revert r280019 for now - This was poorly executed.

2010-07-27 22:30:38 +00:00

stdtime

Fix a variety of potential buffer overflows

2012-04-19 02:08:44 +00:00

abstract_jb.c

Merged revisions 297311 via svnmerge from

2010-12-02 18:13:49 +00:00

acl.c

Prevent outbound SIP NOTIFY packets from displaying a port of 0

2012-03-01 14:18:01 +00:00

alaw.c

…

aoc.c

Typos: recieved => received

2010-12-20 09:14:29 +00:00

app.c

Fix bad check in voicemail functions for ast_inboxcount2_func

2012-05-01 18:16:27 +00:00

ast_expr2.c

Rebuild parsers.

2012-03-24 02:34:39 +00:00

ast_expr2.fl

Merged revisions 309251 via svnmerge from

2011-03-07 00:54:42 +00:00

ast_expr2.h

Rebuild parsers.

2012-03-24 02:34:39 +00:00

ast_expr2.y

expression parser: Fix (theoretical) memory leak.

2012-03-24 02:33:36 +00:00

ast_expr2f.c

Rebuild parsers.

2012-03-24 02:34:39 +00:00

asterisk.c

Add more constness to the end_buf pointer in the netconsole

2012-04-26 19:24:35 +00:00

asterisk.dynamics

Remove the old stub files, preferring the optional_api method.

2010-07-14 20:48:59 +00:00

asterisk.exports.in

Export timersub for platforms which do not have it

2010-09-24 03:42:37 +00:00

astfd.c

On some platforms, O_RDONLY is not a flag to be checked, but merely the absence of O_RDWR and O_WRONLY.

2012-04-23 16:02:28 +00:00

astmm.c

…

astobj2.c

Fixed __ao2_ref() validating user_data twice.

2012-05-01 23:11:53 +00:00

audiohook.c

Revert a change to audio_audiohook_write_list that had no affect.

2012-02-16 20:01:15 +00:00

autochan.c

…

autoservice.c

Merged revisions 278167 via svnmerge from

2010-07-20 22:26:23 +00:00

bridging.c

Revert part of a change to the bridging API code

2011-05-19 23:28:13 +00:00

buildinfo.c

…

callerid.c

Merged revisions 310635 via svnmerge from

2011-03-14 16:50:59 +00:00

ccss.c

Fix case-sensitivity for device-specific event subscriptions and CCSS

2012-03-02 21:02:21 +00:00

cdr.c

Add missing newlines to CLI logging

2012-04-06 18:09:19 +00:00

cel.c

Don't leak a ref if out of memory and can't link the linkedid

2012-05-02 17:02:39 +00:00

channel.c

Replace GNU old-style field designator extensions to fix clang warnings

2012-04-04 16:29:18 +00:00

chanvars.c

…

cli.c

Make CLI "core show channel" not hold the channel lock during console output.

2011-11-11 17:56:51 +00:00

config.c

Fix ast_parse_arg numeric type range checking and add tests

2012-04-27 21:45:15 +00:00

cygload.c

…

data.c

Kill some startup warnings and errors and make some messages more helpful in tracking down the source.

2010-07-09 17:00:22 +00:00

datastore.c

Merged revisions 273565 via svnmerge from

2010-07-01 22:16:23 +00:00

db.c

Update the documentation to better clarify how the existing commands work.

2011-11-19 15:08:03 +00:00

devicestate.c

Make hints for invalid SIP devices return Unavail, not idle

2012-03-13 19:51:23 +00:00

dial.c

Updated SIP 484 handling; added Incomplete control frame

2011-09-09 16:09:09 +00:00

dns.c

…

dnsmgr.c

Increase verbosity level for ast_verb messages

2012-03-26 18:25:45 +00:00

dsp.c

Fix an issue where dsp.c would interpret multiple dtmf events from a single key press.

2012-01-05 21:46:55 +00:00

ecdisa.h

…

enum.c

Decrease verbose messages to debug, to help clean up CLI.

2011-07-25 19:49:40 +00:00

event.c

Fix case-sensitivity for device-specific event subscriptions and CCSS

2012-03-02 21:02:21 +00:00

features.c

Fix DTMF atxfer running h exten after the wrong bridge ends.

2012-04-26 20:23:09 +00:00

file.c

Allow playback of formats that don't support seeking

2012-01-05 22:06:46 +00:00

fixedjitterbuf.c

Fix various typos reported by Lintian

2010-07-02 15:57:02 +00:00

fixedjitterbuf.h

…

frame.c

Fix a variety of potential buffer overflows

2012-04-19 02:08:44 +00:00

framehook.c

Addition of the FrameHook API (AKA AwesomeHooks)

2010-09-20 22:09:16 +00:00

fskmodem_float.c

Fix a bunch of compiler warnings generated by gcc 4.6.0.

2011-05-03 19:55:49 +00:00

fskmodem_int.c

…

fskmodem.c

…

global_datastores.c

Add SRTP support for Asterisk

2010-06-08 05:29:08 +00:00

hashtab.c

…

heap.c

Change mutex tracking so that it only consumes memory in the core mutex object when it's actually being used.

2011-01-31 06:41:36 +00:00

http.c

Fix crash caused by unloading or reloading of res_http_post

2012-04-10 19:57:06 +00:00

image.c

…

indications.c

Audit of ao2_iterator_init() usage for v1.8.

2012-01-27 18:22:39 +00:00

io.c

…

jitterbuf.c

Fix a variety of potential buffer overflows

2012-04-19 02:08:44 +00:00

loader.c

Track module use count for res_calendar

2012-02-22 21:08:50 +00:00

lock.c

Initialize track pointer

2011-04-20 05:25:15 +00:00

logger.c

Sanatize result from bfd_find_nearest_line (BETTER_BACKTRACES)

2012-04-30 15:51:12 +00:00

Makefile

Various changes to allow 1.8 to compile on Mac OS X Lion (10.7)

2011-09-19 20:27:03 +00:00

manager.c

Prevent a potential crash when using manager hooks.

2012-05-01 21:37:17 +00:00

md5.c

Fix incorrect sizeof() on a pointer in MD5Final().

2012-03-14 00:08:54 +00:00

netsock2.c

Fix possible error on stringification of IPv4-mapped addrs

2011-08-18 21:26:01 +00:00

netsock.c

Find even more network interfaces.

2012-01-29 02:42:59 +00:00

pbx.c

Add missing newlines to CLI logging

2012-04-06 18:09:19 +00:00

plc.c

Fix a bunch of compiler warnings generated by gcc 4.6.0.

2011-05-03 19:55:49 +00:00

poll.c

Merged revisions 285267 via svnmerge from

2010-09-07 19:08:09 +00:00

privacy.c

…

rtp_engine.c

Allow SRTP policies to be reloaded

2012-02-24 15:07:09 +00:00

say.c

Removes improper use of sound 'and' in German language mode from application saynumber

2011-10-04 19:33:12 +00:00

sched.c

Fix inaccurate sizeof() in sched.c.

2012-03-14 01:32:28 +00:00

security_events.c

…

sha1.c

Update SHA1 code to RFC 6234

2011-10-11 00:43:14 +00:00

slinfactory.c

…

srv.c

Crash when using hagi and no servers are available.

2011-05-27 23:45:41 +00:00

ssl.c

…

strcompat.c

Little endian machines were not converted properly.

2011-01-10 22:39:31 +00:00

strings.c

fixes segfault on logging

2010-05-18 22:48:51 +00:00

stun.c

Re-resolve the STUN address if a STUN poll fails for res_stun_monitor.

2011-12-01 21:11:39 +00:00

syslog.c

…

taskprocessor.c

Audit of ao2_iterator_init() usage for v1.8.

2012-01-27 18:22:39 +00:00

tcptls.c

Add missing newlines to CLI logging

2012-04-06 18:09:19 +00:00

tdd.c

Fix a variety of potential buffer overflows

2012-04-19 02:08:44 +00:00

term.c

Make console colors work for TERM=xterm-256color

2011-07-28 21:42:41 +00:00

test.c

Avoid unnecessary rebuilds of main/test.c.

2012-01-25 21:16:54 +00:00

threadstorage.c

…

timing.c

Merged revisions 294277 via svnmerge from

2010-11-08 21:59:45 +00:00

translate.c

Fix places in main where a negative return value could impact execution

2012-04-17 21:00:10 +00:00

udptl.c

udptl: Ensure fec[] in udptl_build_packet() is initialized.

2012-03-14 23:00:19 +00:00

ulaw.c

…

utils.c

Make use of va_args more appropriate to form in various res_config modules plus utils.

2012-04-17 20:43:22 +00:00

xml.c

Asterisk data retrieval API.

2010-04-22 18:07:02 +00:00

xmldoc.c

Add missing newlines to CLI logging

2012-04-06 18:09:19 +00:00