mirror of
https://github.com/asterisk/asterisk.git
synced 2025-10-05 12:42:49 +00:00
40d9e9e238
It's possible for the transferer channel to get hung up early during the attended transfer process. For instance, a phone may send a "bye" immediately upon receiving a sip notify that contains a sip frag 100 (I'm looking at you Jitsi). When this occurs a race begins between the transferer being hung up and completion of the transfer code. If the channel hangs up too early during a transfer involving stasis bridging for instance, then when the created local channel goes to look up its swap channel (and associated datastore) it can't find it (since it is no longer in the bridge) thus it fails to enter the stasis application. Consequently, the created local channel(s) hang up as well. If the timing is just right then the bridging code attempts to add the message link with missing local channel(s). Hence the crash. Unfortunately, there is no great way to solve the problem of the unexpected "bye". While we can't guarantee we won't receive an early hangup, and in this case still fail to enter the stasis application, we can make it so asterisk does not crash. This patch does just that by locking the local channel structure, checking that the local channel's peer has not been lost, and then continuing. This keeps the local channel's peer from being ripped out from underneath it by the local/unreal hangup code while attempting to set the stasis message link. ASTERISK-25771 Change-Id: Ie6d6061e34c7c95f07116fffac9a09e5d225c880
170 lines
5.2 KiB
C
170 lines
5.2 KiB
C
/*
|
|
* Asterisk -- An open source telephony toolkit.
|
|
*
|
|
* Copyright (C) 2013 Digium, Inc.
|
|
*
|
|
* Richard Mudgett <rmudgett@digium.com>
|
|
*
|
|
* See http://www.asterisk.org for more information about
|
|
* the Asterisk project. Please do not directly contact
|
|
* any of the maintainers of this project for assistance;
|
|
* the project provides a web site, mailing lists and IRC
|
|
* channels for your use.
|
|
*
|
|
* This program is free software, distributed under the terms of
|
|
* the GNU General Public License Version 2. See the LICENSE file
|
|
* at the top of the source tree.
|
|
*/
|
|
|
|
/*!
|
|
* \file
|
|
* \brief Local proxy channel special access.
|
|
*
|
|
* \author Richard Mudgett <rmudgett@digium.com>
|
|
*
|
|
* See Also:
|
|
* \arg \ref AstCREDITS
|
|
*/
|
|
|
|
#ifndef _ASTERISK_CORE_LOCAL_H
|
|
#define _ASTERISK_CORE_LOCAL_H
|
|
|
|
#if defined(__cplusplus) || defined(c_plusplus)
|
|
extern "C" {
|
|
#endif
|
|
|
|
/* Forward declare some struct names */
|
|
struct ast_channel;
|
|
struct ast_bridge;
|
|
struct ast_bridge_features;
|
|
struct stasis_message_type;
|
|
|
|
/* ------------------------------------------------------------------- */
|
|
|
|
/*!
|
|
* \brief Lock the "chan" and "owner" channels (and return them) on the base
|
|
* private structure as well as the base private structure itself.
|
|
*
|
|
* \note This also adds references to each of the above mentioned elements and
|
|
* also the underlying private local structure.
|
|
* \note None of these locks should be held prior to calling this function.
|
|
* \note To undo this process call ast_local_unlock_all.
|
|
*
|
|
* \since 13.8.0
|
|
*
|
|
* \param chan Must be a local channel
|
|
* \param outchan The local channel's "chan" channel
|
|
* \param outowner The local channel's "owner" channel
|
|
*/
|
|
void ast_local_lock_all(struct ast_channel *chan, struct ast_channel **outchan,
|
|
struct ast_channel **outowner);
|
|
|
|
/*!
|
|
* \brief Unlock the "chan" and "owner" channels on the base private structure
|
|
* as well as the base private structure itself.
|
|
*
|
|
* \note This also removes references to each of the above mentioned elements and
|
|
* also the underlying private local structure.
|
|
* \note This function should be used in conjunction with ast_local_lock_all.
|
|
*
|
|
* \since 13.8.0
|
|
*
|
|
* \param chan Must be a local channel
|
|
*/
|
|
void ast_local_unlock_all(struct ast_channel *chan);
|
|
|
|
/*!
|
|
* \brief Get the other local channel in the pair.
|
|
* \since 12.0.0
|
|
*
|
|
* \param ast Local channel to get peer.
|
|
*
|
|
* \note On entry, ast must be locked.
|
|
*
|
|
* \retval peer reffed on success.
|
|
* \retval NULL if no peer or error.
|
|
*/
|
|
struct ast_channel *ast_local_get_peer(struct ast_channel *ast);
|
|
|
|
/*!
|
|
* \brief Setup the outgoing local channel to join a bridge on ast_call().
|
|
* \since 12.0.0
|
|
*
|
|
* \param ast Either channel of a local channel pair.
|
|
* \param bridge Bridge to join.
|
|
* \param swap Channel to swap with when joining.
|
|
* \param features Bridge features structure.
|
|
*
|
|
* \note The features parameter must be NULL or obtained by
|
|
* ast_bridge_features_new(). You must not dereference features
|
|
* after calling even if the call fails.
|
|
*
|
|
* \note Intended to be called after ast_request() and before
|
|
* ast_call() on a local channel.
|
|
*
|
|
* \retval 0 on success.
|
|
* \retval -1 on error.
|
|
*/
|
|
int ast_local_setup_bridge(struct ast_channel *ast, struct ast_bridge *bridge, struct ast_channel *swap, struct ast_bridge_features *features);
|
|
|
|
/*!
|
|
* \brief Setup the outgoing local channel to masquerade into a channel on ast_call().
|
|
* \since 12.0.0
|
|
*
|
|
* \param ast Either channel of a local channel pair.
|
|
* \param masq Channel to masquerade into.
|
|
*
|
|
* \note Intended to be called after ast_request() and before
|
|
* ast_call() on a local channel.
|
|
*
|
|
* \retval 0 on success.
|
|
* \retval -1 on error.
|
|
*/
|
|
int ast_local_setup_masquerade(struct ast_channel *ast, struct ast_channel *masq);
|
|
|
|
/* ------------------------------------------------------------------- */
|
|
|
|
/*!
|
|
* \brief Message type for when two local channel halves are bridged together
|
|
* \since 12.0.0
|
|
*
|
|
* \note Payloads for the \ref ast_local_bridge_type are a \ref ast_multi_channel_blob.
|
|
* Roles for the channels in the \ref ast_multi_channel_blob are "1" and "2", reflecting
|
|
* the two halves. Unlike most other bridges, the 'bridge' between two local channels is
|
|
* not part of the bridge framework; as such, the message simply references the two local
|
|
* channel halves that are now bridged.
|
|
*
|
|
* \retval A \ref stasis message type
|
|
*/
|
|
struct stasis_message_type *ast_local_bridge_type(void);
|
|
|
|
/*!
|
|
* \brief Message type for when a local channel optimization begins
|
|
* \since 12.0.0
|
|
*
|
|
* \note Payloads for the \ref ast_local_optimization_begin_type are a
|
|
* \ref ast_multi_channel_blob. Roles for the channels in the \ref ast_multi_channel_blob
|
|
* are "1" and "2", reflecting the two halves.
|
|
*
|
|
* \retval A \ref stasis message type
|
|
*/
|
|
struct stasis_message_type *ast_local_optimization_begin_type(void);
|
|
|
|
/*!
|
|
* \brief Message type for when a local channel optimization completes
|
|
* \since 12.0.0
|
|
*
|
|
* \note Payloads for the \ref ast_local_optimization_end_type are a
|
|
* \ref ast_multi_channel_blob. Roles for the channels in the \ref ast_multi_channel_blob
|
|
* are "1" and "2", reflecting the two halves.
|
|
*
|
|
* \retval A \ref stasis message type
|
|
*/
|
|
struct stasis_message_type *ast_local_optimization_end_type(void);
|
|
|
|
#if defined(__cplusplus) || defined(c_plusplus)
|
|
}
|
|
#endif
|
|
|
|
#endif /* _ASTERISK_CORE_LOCAL_H */
|