Richard Mudgett
602c4b74b5
res_pjsip_outbound_registration.c: Fix handle_client_state_destruction() refs
...
* handle_client_state_destruction() must always be passed a ref to
client_state because it will always unref client_state.
handle_registration_response() was not passing a client_state ref.
* Made the final un-REGISTER message get sent normally using the pjproject
register control structure in handle_client_state_destruction(). The
previous code attempted to short circuit the response handling for the
module to unload. That doesn't work for a couple reasons. One,
pjsip_regc_send() may call the registered callback before it returns and
unbalance the client_state ref count. Two, the registered callback
handles any authentication for the un-REGISTER message.
* Made the distinction between internal registration state and external
registration status with sip_outbound_registration_status_str(). This is
necessary to avoid altering documented AMI messages with internal
changes.
* Removed references to client_state->client outside of the serializer
thread. When handle_client_state_destruction() destroys the pjproject
register control structure that memory is freed and cannot be referenced
anymore. These accesses were to provide information for debug and
off-nominal warning messages.
* In sip_outbound_registration_timer_cb() you should not access entry->id
after unrefing client_state because the passed in entry is normally
pointing to the timer entry in the client_state object.
ASTERISK-24907
Reported by: Kevin Harwell
Change-Id: Ia7b446d8644b6b4550ef5bea49527671de65183f
2015-06-25 14:37:08 -05:00
..
2015-04-12 13:48:10 -05:00
2015-05-22 11:12:03 -05:00
2015-06-16 11:21:51 -05:00
2015-06-23 10:12:38 -03:00
2015-01-20 16:46:16 +00:00
2015-06-18 16:19:08 -05:00
2015-04-07 02:03:20 +00:00
2015-04-29 07:39:22 -04:00
2015-03-28 12:40:49 +00:00
2014-07-25 16:47:17 +00:00
2014-07-25 16:47:17 +00:00
2010-04-02 18:57:58 +00:00
2014-12-12 22:53:05 +00:00
2010-04-02 18:57:58 +00:00
2015-04-29 07:39:22 -04:00
2015-04-29 07:39:22 -04:00
2015-04-29 07:39:22 -04:00
2015-04-29 07:39:22 -04:00
2015-04-29 07:39:22 -04:00
2015-04-29 07:39:22 -04:00
2015-05-22 11:12:03 -05:00
2015-04-29 07:39:22 -04:00
2014-07-25 16:47:17 +00:00
2013-07-27 23:11:02 +00:00
2015-04-29 07:39:22 -04:00
2015-04-29 07:39:22 -04:00
2015-04-29 07:39:22 -04:00
2014-07-25 16:47:17 +00:00
2013-07-27 23:11:02 +00:00
2014-07-25 16:47:17 +00:00
2014-10-12 07:44:32 +00:00
2014-07-25 16:47:17 +00:00
2014-07-25 16:47:17 +00:00
2015-03-30 02:44:57 +00:00
2010-04-02 18:57:58 +00:00
2014-07-25 16:47:17 +00:00
2014-07-25 16:47:17 +00:00
2014-07-20 22:06:33 +00:00
2014-07-25 16:47:17 +00:00
2014-07-25 16:47:17 +00:00
2015-03-10 21:33:40 +00:00
2014-07-25 16:47:17 +00:00
2014-07-25 16:47:17 +00:00
2014-07-25 16:47:17 +00:00
2011-07-14 20:28:54 +00:00
2015-04-23 06:30:11 -05:00
2014-12-17 09:54:00 +00:00
2010-07-21 19:11:32 +00:00
2014-07-25 16:47:17 +00:00
2015-04-29 15:37:12 -05:00
2015-04-29 15:37:12 -05:00
2014-07-18 15:49:46 +00:00
2014-07-25 16:47:17 +00:00
2014-07-25 16:47:17 +00:00
2015-01-31 16:27:41 +00:00
2015-01-28 12:18:14 +00:00
2015-01-28 12:18:14 +00:00
2014-10-16 14:35:00 +00:00
2015-05-22 22:58:32 -04:00
2014-11-06 09:23:32 +00:00
2014-03-28 18:32:50 +00:00
2014-07-25 16:47:17 +00:00
2015-05-19 19:59:45 -05:00
2014-06-26 18:27:53 +00:00
2011-12-05 14:47:11 +00:00
2012-10-14 21:44:27 +00:00
2015-01-09 17:54:49 +00:00
2015-01-09 17:54:49 +00:00
2015-04-13 07:27:40 -04:00
2010-04-02 18:57:58 +00:00
2014-08-25 16:44:37 +00:00
2014-03-27 19:21:44 +00:00
2015-05-21 18:18:16 -05:00
2014-07-25 16:47:17 +00:00
2014-01-06 17:45:25 +00:00
2015-05-04 06:47:26 -05:00
2010-04-02 18:57:58 +00:00
2014-07-25 16:47:17 +00:00
2015-04-09 22:35:11 +00:00
2014-10-09 17:45:23 +00:00
2015-03-17 21:49:30 +00:00
2014-10-16 14:35:00 +00:00
2015-03-13 16:26:38 +00:00
2015-05-15 16:18:11 -06:00
2014-10-16 14:35:00 +00:00
2015-04-17 15:57:10 -05:00
2015-05-02 03:15:15 -04:00
2015-06-03 17:43:33 -05:00
2015-03-17 18:34:12 +00:00
2015-03-17 18:34:12 +00:00
2015-03-17 18:34:12 +00:00
2015-05-22 12:18:31 -05:00
2013-07-30 18:14:50 +00:00
2014-10-16 14:35:00 +00:00
2015-03-26 17:46:46 +00:00
2014-07-25 16:47:17 +00:00
2014-10-16 14:35:00 +00:00
2015-04-07 15:33:33 +00:00
2015-02-12 20:32:48 +00:00
2014-10-16 14:35:00 +00:00
2015-06-23 10:12:38 -03:00
2015-03-20 19:52:30 +00:00
2015-03-26 17:46:46 +00:00
2014-10-16 14:35:00 +00:00
2015-04-30 14:13:42 -05:00
2015-01-30 17:38:10 +00:00
2014-08-07 14:35:09 +00:00
2015-06-25 14:37:08 -05:00
2014-10-16 14:35:00 +00:00
2015-04-09 22:35:11 +00:00
2014-10-16 14:35:00 +00:00
2014-10-16 14:35:00 +00:00
2014-10-16 14:35:00 +00:00
2015-02-20 17:46:17 +00:00
2015-05-22 12:22:39 -05:00
2015-05-07 09:32:58 -03:00
2015-03-10 16:04:32 +00:00
2015-03-27 21:04:14 +00:00
2015-06-23 10:12:38 -03:00
2014-10-16 14:35:00 +00:00
2015-06-15 12:35:53 -05:00
2015-02-17 15:31:46 +00:00
2015-06-03 17:43:33 -05:00
2015-03-10 16:04:32 +00:00
2015-01-29 20:58:12 +00:00
2015-04-23 13:08:54 -05:00
2015-06-10 09:38:37 -05:00
2014-10-16 14:35:00 +00:00
2015-06-15 12:35:53 -05:00
2013-11-23 17:26:57 +00:00
2014-12-17 09:54:00 +00:00
2010-04-02 18:57:58 +00:00
2011-11-01 19:53:26 +00:00
2015-05-13 04:52:52 -05:00
2014-07-25 16:47:17 +00:00
2015-05-22 22:58:32 -04:00
2015-04-08 11:44:32 +00:00
2010-04-02 18:57:58 +00:00
2014-07-25 16:47:17 +00:00
2014-07-25 16:47:17 +00:00
2015-04-29 12:46:21 -03:00
2014-07-25 16:47:17 +00:00
2015-03-25 18:37:04 +00:00
2014-07-25 16:47:17 +00:00
2013-09-16 18:00:32 +00:00
2014-10-27 01:47:26 +00:00
2015-04-07 19:38:27 +00:00
2014-08-22 16:44:21 +00:00
2013-05-20 14:21:39 +00:00
2015-05-22 22:58:32 -04:00
2013-11-23 17:48:28 +00:00
2014-07-25 16:47:17 +00:00
2014-01-14 23:44:57 +00:00
2015-04-23 18:26:55 +02:00
2013-05-23 20:11:35 +00:00
2015-04-23 18:26:55 +02:00
2013-07-03 17:58:45 +00:00
2015-05-06 16:09:33 -05:00
2013-11-23 12:40:46 +00:00
2014-08-06 12:55:28 +00:00
2013-05-08 13:39:08 +00:00
2015-06-18 16:19:08 -05:00
2013-04-15 16:43:47 +00:00
2014-07-25 16:47:17 +00:00
2013-04-26 20:05:15 +00:00
2014-08-06 12:55:28 +00:00
2014-07-25 16:47:17 +00:00
2015-03-27 14:41:05 +00:00
2015-02-15 12:39:09 +00:00
2014-07-25 16:47:17 +00:00
2015-05-22 22:58:32 -04:00
2012-07-07 17:06:51 +00:00