Matthew Jordan 6129593e95 Fix memory leaks in app_voicemail when using IMAP storage or realtime config ...

This patch fixes two memory leaks:

1. When find_user is called with NULL as its first parameter, the voicemail
   user returned is allocated on the heap.  The inboxcount2 function uses
   find_user in such a fashion when counting new messages, and fails to free
   the resulting voicemail user object.

2. When populate_defaults is called on a voicemail user, it wipes whatever
   flags have been set on the object by copying over the global flags object.
   If the VM_ALLOCED flag was ste on the voicemail user prior to doing so,
   that flag is removed.  This leaks the voicemail user when free_user is later
   called.

(closes issue ASTERISK-19155)
Reported by: Filip Jenicek
patches:
  asterisk.patch2 uploaded by Filip Jenicek (license 6277)

Patch slightly modified for this commit.

Review: https://reviewboard.asterisk.org/r/2096
........

Merged revisions 372268 from http://svn.asterisk.org/svn/asterisk/branches/1.8


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10@372288 65c4cc65-6c06-0410-ace0-fbb531ad65f3

2012-09-05 13:42:54 +00:00

..

confbridge

Multiple revisions 369001-369002

2012-06-15 16:07:08 +00:00

app_adsiprog.c

…

app_alarmreceiver.c

…

app_amd.c

…

app_authenticate.c

Fix crash during CDR update.

2011-12-16 21:04:01 +00:00

app_cdr.c

…

app_celgenuserevent.c

Fixes some support level info so that it can be read by menuselect.

2011-10-14 16:18:08 +00:00

app_chanisavail.c

app_chanisavail: Fix use of uninitialized variable.

2012-03-14 23:28:32 +00:00

app_channelredirect.c

…

app_chanspy.c

Fix Not Unreferencing A Spied Channel

2012-08-08 22:42:05 +00:00

app_confbridge.c

Fix crash in ConfBridge when user announcement is played for more than 2 users

2012-05-24 13:32:33 +00:00

app_controlplayback.c

…

app_dahdibarge.c

…

app_dahdiras.c

…

app_db.c

…

app_dial.c

Fix hangup cause passthrough regression.

2012-08-29 18:24:54 +00:00

app_dictate.c

Clean up and ensure proper usage of alloca()

2012-07-31 19:57:09 +00:00

app_directed_pickup.c

Clean up and ensure proper usage of alloca()

2012-07-31 19:57:09 +00:00

app_directory.c

Fix coverity UNUSED_VALUE findings in core support level files

2012-06-11 15:15:07 +00:00

app_disa.c

Coverity Report: Fix issues for error type UNINIT in Core supported modules

2012-05-10 15:43:06 +00:00

app_dumpchan.c

…

app_echo.c

Prevent Echo() from relaying control, null, and modem frames

2012-03-20 20:37:46 +00:00

app_exec.c

…

app_externalivr.c

Prevent a crash in ExternalIVR when the 'S' command is sent first.

2012-04-19 16:04:21 +00:00

app_fax.c

Merged revisions 340108 via svnmerge from

2011-10-10 14:15:41 +00:00

app_festival.c

Clean up and ensure proper usage of alloca()

2012-07-31 19:57:09 +00:00

app_flash.c

…

app_followme.c

* Fix FollowMe memory leak on error paths in app_exec().

2012-05-08 20:25:08 +00:00

app_forkcdr.c

Make ForkCDR e option not set end time of the newly forked CDR log

2012-04-13 16:04:22 +00:00

app_getcpeid.c

Clean up and ensure proper usage of alloca()

2012-07-31 19:57:09 +00:00

app_ices.c

Add missing newlines to CLI logging

2012-04-06 18:13:04 +00:00

app_image.c

…

app_ivrdemo.c

…

app_jack.c

app_jack: fix datastore memory leak in error handling path.

2012-03-24 03:02:15 +00:00

app_macro.c

Clean up and ensure proper usage of alloca()

2012-07-31 19:57:09 +00:00

app_meetme.c

app_meetme: Adding test events for following activity in MeetMe.

2012-08-29 20:58:21 +00:00

app_milliwatt.c

Replace GNU old-style field designator extensions to fix clang warnings

2012-04-04 16:38:12 +00:00

app_minivm.c

Clean up and ensure proper usage of alloca()

2012-07-31 19:57:09 +00:00

app_mixmonitor.c

Clean up and ensure proper usage of alloca()

2012-07-31 19:57:09 +00:00

app_morsecode.c

…

app_mp3.c

…

app_nbscat.c

…

app_originate.c

Added support for all slin formats to app_originate

2011-12-14 22:34:51 +00:00

app_osplookup.c

Clean up and ensure proper usage of alloca()

2012-07-31 19:57:09 +00:00

app_page.c

Fix a variety of memory leaks

2012-05-18 14:01:56 +00:00

app_parkandannounce.c

Fix crash in ParkAndAnnounce.

2012-02-09 02:54:14 +00:00

app_playback.c

…

app_playtones.c

…

app_privacy.c

…

app_queue.c

Prevent crash on shutdown due to refcount error on queues container.

2012-08-30 20:53:09 +00:00

app_read.c

…

app_readexten.c

…

app_readfile.c

…

app_record.c

Fix a variety of memory leaks

2012-05-18 14:01:56 +00:00

app_saycounted.c

…

app_sayunixtime.c

…

app_senddtmf.c

…

app_sendtext.c

…

app_setcallerid.c

…

app_skel.c

…

app_sms.c

Clean up and ensure proper usage of alloca()

2012-07-31 19:57:09 +00:00

app_softhangup.c

…

app_speech_utils.c

Document Speech* apps hangup on failure and suggest TryExec

2012-04-20 14:49:42 +00:00

app_stack.c

Fix misuses of asprintf throughout the code.

2012-08-21 20:40:18 +00:00

app_system.c

Fixes some support level info so that it can be read by menuselect.

2011-10-14 16:18:08 +00:00

app_talkdetect.c

…

app_test.c

…

app_transfer.c

Fix the display of documentation for Transfer

2012-04-03 20:08:47 +00:00

app_url.c

…

app_userevent.c

…

app_verbose.c

…

app_voicemail.c

Fix memory leaks in app_voicemail when using IMAP storage or realtime config

2012-09-05 13:42:54 +00:00

app_voicemail.exports.in

…

app_waitforring.c

…

app_waitforsilence.c

…

app_waituntil.c

…

app_while.c

Clean up and ensure proper usage of alloca()

2012-07-31 19:57:09 +00:00

app_zapateller.c

…

enter.h

…

leave.h

…

Makefile

…