Walter Doekes f30c13bbed app_voicemail: Fix unchecked bounds of myArray in IMAP_STORAGE. ...

In update_messages_by_imapuser(), messages were appended to a finite
array which resulted in a crash when an IMAP mailbox contained more
than 256 entries. This memory is now dynamically increased as needed.

Observe that this patch adds a bunch of XXX's to questionable code. See
the review (url below) for more information.

ASTERISK-24190 #close
Reported by: Nick Adams
Tested by: Nick Adams

Review: https://reviewboard.asterisk.org/r/4126/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@426691 65c4cc65-6c06-0410-ace0-fbb531ad65f3

2014-10-30 09:11:39 +00:00

..

app_adsiprog.c

Allow Asterisk to compile under GCC 4.10

2014-05-09 22:18:59 +00:00

app_alarmreceiver.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

app_amd.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

app_authenticate.c

Fix crash during CDR update.

2011-12-16 20:55:17 +00:00

app_cdr.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

app_celgenuserevent.c

Remove unnecessary channel module references.

2012-11-27 20:32:31 +00:00

app_chanisavail.c

app_chanisavail: Fix use of uninitialized variable.

2012-03-14 23:26:59 +00:00

app_channelredirect.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

app_chanspy.c

app_chanspy: Documentation Update To Clarify "x" Option

2014-02-21 00:46:35 +00:00

app_confbridge.c

app_confbridge: Correct verification of conference name length

2014-06-04 07:18:05 +00:00

app_controlplayback.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

app_dahdibarge.c

Revert changes to defaultenabled state for modules in Asterisk 1.8

2011-07-15 20:41:12 +00:00

app_dahdiras.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

app_db.c

Don't throw a spurious error when using DBdeltree

2013-02-14 03:42:06 +00:00

app_dial.c

apps/app_dial: Fix Dial 'z' option

2014-08-17 23:06:29 +00:00

app_dictate.c

Clean up and ensure proper usage of alloca()

2012-07-31 19:31:42 +00:00

app_directed_pickup.c

Clean up and ensure proper usage of alloca()

2012-07-31 19:31:42 +00:00

app_directory.c

Fix coverity UNUSED_VALUE findings in core support level files

2012-06-11 15:13:22 +00:00

app_disa.c

Coverity Report: Fix issues for error type UNINIT in Core supported modules

2012-05-10 15:35:33 +00:00

app_dumpchan.c

Allow Asterisk to compile under GCC 4.10

2014-05-09 22:18:59 +00:00

app_echo.c

Prevent Echo() from relaying control, null, and modem frames

2012-03-20 20:32:55 +00:00

app_exec.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

app_externalivr.c

Prevent a crash in ExternalIVR when the 'S' command is sent first.

2012-04-19 15:53:56 +00:00

app_fax.c

Load the proper XML documentation when multiple modules document the same application.

2011-10-10 14:14:48 +00:00

app_festival.c

Allow Asterisk to compile under GCC 4.10

2014-05-09 22:18:59 +00:00

app_flash.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

app_followme.c

Allow configured numbers for FollowMe to be greater than 90 characters

2012-09-06 00:54:30 +00:00

app_forkcdr.c

app_forkcdr: ForkCDR v option does not keep CDR variables for subsequent records

2014-02-21 20:18:45 +00:00

app_getcpeid.c

Allow Asterisk to compile under GCC 4.10

2014-05-09 22:18:59 +00:00

app_ices.c

Add missing newlines to CLI logging

2012-04-06 18:09:19 +00:00

app_image.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

app_ivrdemo.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

app_jack.c

Fix dialplan function NULL channel safety issues

2014-03-27 19:06:13 +00:00

app_macro.c

Clean up and ensure proper usage of alloca()

2012-07-31 19:31:42 +00:00

app_meetme.c

Fix more dev-mode build issues

2014-07-22 13:17:45 +00:00

app_milliwatt.c

Replace GNU old-style field designator extensions to fix clang warnings

2012-04-04 16:29:18 +00:00

app_minivm.c

Allow Asterisk to compile under GCC 4.10

2014-05-09 22:18:59 +00:00

app_mixmonitor.c

Several components: fixing Typos in comments and code, "avaliable" instead of "available"

2013-12-17 23:32:35 +00:00

app_morsecode.c

Document applications that play audio and do not answer unanswered calls.

2011-09-19 20:07:36 +00:00

app_mp3.c

Document applications that play audio and do not answer unanswered calls.

2011-09-19 20:07:36 +00:00

app_nbscat.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

app_originate.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

app_osplookup.c

Clean up and ensure proper usage of alloca()

2012-07-31 19:31:42 +00:00

app_page.c

Correct app_page documentation

2013-03-06 18:22:06 +00:00

app_parkandannounce.c

Make ParkAndAnnounce return to priority + 1 when return context is not defined

2013-02-24 15:33:32 +00:00

app_playback.c

Check result of ast_var_assign() calls for memory allocation failure.

2013-08-06 08:14:59 +00:00

app_playtones.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

app_privacy.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

app_queue.c

datastores: Audit ast_channel_datastore_remove usage.

2014-07-28 18:27:56 +00:00

app_read.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

app_readexten.c

Fix dialplan function NULL channel safety issues

2014-03-27 19:06:13 +00:00

app_readfile.c

Revert changes to defaultenabled state for modules in Asterisk 1.8

2011-07-15 20:41:12 +00:00

app_record.c

Fix misuses of timeouts throughout the code.

2012-11-07 17:01:13 +00:00

app_saycounted.c

Document applications that play audio and do not answer unanswered calls.

2011-09-19 20:07:36 +00:00

app_sayunixtime.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

app_senddtmf.c

Fix SendDTMF crash and channel reference leak using channel name parameter.

2012-09-27 22:08:24 +00:00

app_sendtext.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

app_setcallerid.c

Revert changes to defaultenabled state for modules in Asterisk 1.8

2011-07-15 20:41:12 +00:00

app_skel.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

app_sms.c

Allow Asterisk to compile under GCC 4.10

2014-05-09 22:18:59 +00:00

app_softhangup.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

app_speech_utils.c

datastores: Audit ast_channel_datastore_remove usage.

2014-07-28 18:27:56 +00:00

app_stack.c

features.c: Allow appliationmap to use Gosub.

2014-07-25 23:04:09 +00:00

app_system.c

Fixes some support level info so that it can be read by menuselect.

2011-10-14 15:58:44 +00:00

app_talkdetect.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

app_test.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

app_transfer.c

Documentation: doc fixes across various parts of the code for ASTERISK issues 23061,23028,23046,23027

2014-01-17 15:39:23 +00:00

app_url.c

Initialize option flags for SendURL application.

2011-10-07 19:34:55 +00:00

app_userevent.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

app_verbose.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

app_voicemail.c

app_voicemail: Fix unchecked bounds of myArray in IMAP_STORAGE.

2014-10-30 09:11:39 +00:00

app_voicemail.exports.in

Allow symbol export filtering to work properly on platforms that have symbol prefixes.

2010-04-02 18:57:58 +00:00

app_waitforring.c

Fix misuses of timeouts throughout the code.

2012-11-07 17:01:13 +00:00

app_waitforsilence.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

app_waituntil.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

app_while.c

Clean up and ensure proper usage of alloca()

2012-07-31 19:31:42 +00:00

app_zapateller.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

enter.h

…

leave.h

…

Makefile

One of the changes in 1.6.1 was to allow app_directory to use functionality

2009-06-18 20:52:36 +00:00