Richard Mudgett 7e3bf4936e Crash when using directed pickup applications. ...

The directed pickup applications can cause a crash if the pickup was
successful because the dialplan keeps executing.

This patch does the following:

* Completes the channel masquerade on a successful pickup before the
application returns.  The channel is now guaranteed a zombie and must not
continue executing the dialplan.

* Changes the return value of the directed pickup applications to return
zero if the pickup failed and nonzero(-1) if the pickup succeeded.

* Made some code optimizations that no longer require re-checking the
pickup channel to see if it is still available to pickup.

(closes issue #19310)
Reported by: remiq
Patches:
      issue19310_v1.8_v2.patch uploaded by rmudgett (license 664)
Tested by: alecdavis, remiq, rmudgett

Review: https://reviewboard.asterisk.org/r/1221/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@319997 65c4cc65-6c06-0410-ace0-fbb531ad65f3

2011-05-20 15:48:25 +00:00

..

app_adsiprog.c

When optional_api is non-optional, force dependent modules to be loaded.

2010-09-02 05:20:59 +00:00

app_alarmreceiver.c

ast_callerid restructuring

2010-07-14 15:48:36 +00:00

app_amd.c

Fix a bunch of compiler warnings generated by gcc 4.6.0.

2011-05-03 19:55:49 +00:00

app_authenticate.c

Global var cleanup - constification and removing unused vars.

2009-06-07 14:55:51 +00:00

app_cdr.c

Const-ify the world (or at least a good part of it)

2009-05-21 21:13:09 +00:00

app_celgenuserevent.c

Add an argument missing from the CELGenUserEvent documentation.

2010-08-20 11:52:37 +00:00

app_chanisavail.c

Store the cause code that is returned when trying to create a channel in ChanIsAvail in the

2009-11-13 17:22:47 +00:00

app_channelredirect.c

Global var cleanup - constification and removing unused vars.

2009-06-07 14:55:51 +00:00

app_chanspy.c

Merged revisions 316644 via svnmerge from

2011-05-04 14:25:03 +00:00

app_confbridge.c

Add load priority order, such that preload becomes unnecessary in most cases

2010-07-20 19:35:02 +00:00

app_controlplayback.c

Change warning message to debug message.

2009-11-03 19:48:53 +00:00

app_dahdibarge.c

Expand codec bitfield from 32 bits to 64 bits.

2009-11-04 14:05:12 +00:00

app_dahdiras.c

Global var cleanup - constification and removing unused vars.

2009-06-07 14:55:51 +00:00

app_db.c

Global var cleanup - constification and removing unused vars.

2009-06-07 14:55:51 +00:00

app_dial.c

Merged revisions 319528 via svnmerge from

2011-05-18 20:05:34 +00:00

app_dictate.c

Expand codec bitfield from 32 bits to 64 bits.

2009-11-04 14:05:12 +00:00

app_directed_pickup.c

Crash when using directed pickup applications.

2011-05-20 15:48:25 +00:00

app_directory.c

Merged revisions 263769 via svnmerge from

2010-05-18 19:27:34 +00:00

app_disa.c

ast_callerid restructuring

2010-07-14 15:48:36 +00:00

app_dumpchan.c

Bring the dumpchan application inline with "core show channel".

2011-04-12 22:35:53 +00:00

app_echo.c

revert ability to exit echo app

2010-03-02 19:39:58 +00:00

app_exec.c

Because ExecIf needs to reprocess arguments, it's best if we don't remove quotes during parsing.

2010-03-11 21:07:07 +00:00

app_externalivr.c

Merged revisions 309356 via svnmerge from

2011-03-04 01:50:44 +00:00

app_fax.c

ast_callerid restructuring

2010-07-14 15:48:36 +00:00

app_festival.c

Fix a bunch of compiler warnings generated by gcc 4.6.0.

2011-05-03 19:55:49 +00:00

app_flash.c

Const-ify the world (or at least a good part of it)

2009-05-21 21:13:09 +00:00

app_followme.c

Fix a bunch of compiler warnings generated by gcc 4.6.0.

2011-05-03 19:55:49 +00:00

app_forkcdr.c

This patch adds a sequence field to CDRs that can be combined with the linkedid or uniqueid field to uniquely identify a CDR.

2009-11-03 21:21:09 +00:00

app_getcpeid.c

When optional_api is non-optional, force dependent modules to be loaded.

2010-09-02 05:20:59 +00:00

app_ices.c

Fix a bunch of compiler warnings generated by gcc 4.6.0.

2011-05-03 19:55:49 +00:00

app_image.c

Const-ify the world (or at least a good part of it)

2009-05-21 21:13:09 +00:00

app_ivrdemo.c

Const-ify the world (or at least a good part of it)

2009-05-21 21:13:09 +00:00

app_jack.c

Convert a few places to use ast_calloc_with_stringfields where applicable.

2010-01-15 18:21:50 +00:00

app_macro.c

Merged revisions 295843 via svnmerge from

2010-11-22 19:36:10 +00:00

app_meetme.c

Use the right variable to print the time in a debug message.

2011-05-06 21:49:01 +00:00

app_milliwatt.c

Expand codec bitfield from 32 bits to 64 bits.

2009-11-04 14:05:12 +00:00

app_minivm.c

Resolve another warning.

2011-05-03 21:41:11 +00:00

app_mixmonitor.c

Merged revisions 309857 via svnmerge from

2011-03-07 22:07:25 +00:00

app_morsecode.c

AST-2009-005

2009-08-10 19:20:57 +00:00

app_mp3.c

Merged revisions 238009 via svnmerge from

2010-01-06 15:19:10 +00:00

app_nbscat.c

Expand codec bitfield from 32 bits to 64 bits.

2009-11-04 14:05:12 +00:00

app_originate.c

Fix a bunch of compiler warnings generated by gcc 4.6.0.

2011-05-03 19:55:49 +00:00

app_osplookup.c

Fixed the issue caused by EXTEN including user parameters.

2010-08-10 07:26:17 +00:00

app_page.c

Add audio announcement option to app_page

2009-12-10 17:31:23 +00:00

app_parkandannounce.c

ast_callerid restructuring

2010-07-14 15:48:36 +00:00

app_playback.c

Merged revisions 220288 via svnmerge from

2009-09-24 19:41:02 +00:00

app_playtones.c

Const-ify the world (or at least a good part of it)

2009-05-21 21:13:09 +00:00

app_privacy.c

Merged revisions 302920 via svnmerge from

2011-01-20 16:12:15 +00:00

app_queue.c

Merged revisions 317575 via svnmerge from

2011-05-06 08:18:53 +00:00

app_read.c

Last batch of 'static' qualifiers for module-level global variables.

2009-06-15 19:10:10 +00:00

app_readexten.c

Merged revisions 281722 via svnmerge from

2010-08-11 15:18:40 +00:00

app_readfile.c

AST-2009-005

2009-08-10 19:20:57 +00:00

app_record.c

Be less ambiguous in Record() app docs.

2010-03-10 20:53:43 +00:00

app_rpt.c

Fix potential memory leak, and use of uninitialized memory.

2011-05-05 21:58:45 +00:00

app_saycounted.c

Add new application for declining counting words in multiple languages.

2010-06-21 05:10:06 +00:00

app_sayunixtime.c

Const-ify the world (or at least a good part of it)

2009-05-21 21:13:09 +00:00

app_senddtmf.c

Allow SendDTMF to play digits to a specified channel.

2010-05-24 22:16:29 +00:00

app_sendtext.c

Merged revisions 305889 via svnmerge from

2011-02-03 00:24:40 +00:00

app_setcallerid.c

ast_callerid restructuring

2010-07-14 15:48:36 +00:00

app_skel.c

Last batch of 'static' qualifiers for module-level global variables.

2009-06-15 19:10:10 +00:00

app_sms.c

Merged revisions 289425 via svnmerge from

2010-09-30 15:39:45 +00:00

app_softhangup.c

Flags not initialized in app_softhangup.c, causing undefined behavior

2009-11-11 18:13:56 +00:00

app_speech_utils.c

When optional_api is non-optional, force dependent modules to be loaded.

2010-09-02 05:20:59 +00:00

app_stack.c

When optional_api is non-optional, force dependent modules to be loaded.

2010-09-02 05:20:59 +00:00

app_system.c

If the argument to the system application is quoted, ensure we remove the quotes before trying to execute.

2010-03-11 20:25:02 +00:00

app_talkdetect.c

ast_callerid restructuring

2010-07-14 15:48:36 +00:00

app_test.c

Expand codec bitfield from 32 bits to 64 bits.

2009-11-04 14:05:12 +00:00

app_transfer.c

Const-ify the world (or at least a good part of it)

2009-05-21 21:13:09 +00:00

app_url.c

Expand codec bitfield from 32 bits to 64 bits.

2009-11-04 14:05:12 +00:00

app_userevent.c

Change usage of pipe to comma in UserEvent docs.

2010-03-18 17:52:35 +00:00

app_verbose.c

Merged revisions 301176 via svnmerge from

2011-01-08 22:00:12 +00:00

app_voicemail.c

Don't create [general] voicemail context when using users.conf

2011-05-17 12:53:50 +00:00

app_voicemail.exports.in

Allow symbol export filtering to work properly on platforms that have symbol prefixes.

2010-04-02 18:57:58 +00:00

app_waitforring.c

add silence gen to wait apps

2010-01-13 16:31:14 +00:00

app_waitforsilence.c

add silence gen to wait apps

2010-01-13 16:31:14 +00:00

app_waituntil.c

AST-2009-005

2009-08-10 19:20:57 +00:00

app_while.c

ast_callerid restructuring

2010-07-14 15:48:36 +00:00

app_zapateller.c

ast_callerid restructuring

2010-07-14 15:48:36 +00:00

enter.h

…

leave.h

…

Makefile

One of the changes in 1.6.1 was to allow app_directory to use functionality

2009-06-18 20:52:36 +00:00

rpt_flow.pdf

…