Richard Mudgett 7e3bf4936e Crash when using directed pickup applications. ...

The directed pickup applications can cause a crash if the pickup was
successful because the dialplan keeps executing.

This patch does the following:

* Completes the channel masquerade on a successful pickup before the
application returns.  The channel is now guaranteed a zombie and must not
continue executing the dialplan.

* Changes the return value of the directed pickup applications to return
zero if the pickup failed and nonzero(-1) if the pickup succeeded.

* Made some code optimizations that no longer require re-checking the
pickup channel to see if it is still available to pickup.

(closes issue #19310)
Reported by: remiq
Patches:
      issue19310_v1.8_v2.patch uploaded by rmudgett (license 664)
Tested by: alecdavis, remiq, rmudgett

Review: https://reviewboard.asterisk.org/r/1221/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@319997 65c4cc65-6c06-0410-ace0-fbb531ad65f3

2011-05-20 15:48:25 +00:00

..

db1-ast

Merged revisions 209879 via svnmerge from

2009-08-01 11:29:25 +00:00

editline

Revert r280019 for now - This was poorly executed.

2010-07-27 22:30:38 +00:00

stdtime

Add missing ifdefs for test framework and new locale code.

2010-10-14 18:45:02 +00:00

abstract_jb.c

Merged revisions 297311 via svnmerge from

2010-12-02 18:13:49 +00:00

acl.c

Restore some conditionals that we lost in r277814.

2011-01-28 20:19:08 +00:00

alaw.c

Fix compile when certain G711 menuselect options are enabled.

2009-08-19 22:38:46 +00:00

aoc.c

Typos: recieved => received

2010-12-20 09:14:29 +00:00

app.c

Merged revisions 302599 via svnmerge from

2011-01-19 20:24:57 +00:00

ast_expr2.c

Merged revisions 293195-293196 via svnmerge from

2010-10-28 20:00:06 +00:00

ast_expr2.fl

Merged revisions 309251 via svnmerge from

2011-03-07 00:54:42 +00:00

ast_expr2.h

Merged revisions 293195-293196 via svnmerge from

2010-10-28 20:00:06 +00:00

ast_expr2.y

Merged revisions 293195-293196 via svnmerge from

2010-10-28 20:00:06 +00:00

ast_expr2f.c

Merged revisions 309251 via svnmerge from

2011-03-07 00:54:42 +00:00

asterisk.c

Fix a bunch of compiler warnings generated by gcc 4.6.0.

2011-05-03 19:55:49 +00:00

asterisk.dynamics

Remove the old stub files, preferring the optional_api method.

2010-07-14 20:48:59 +00:00

asterisk.exports.in

Export timersub for platforms which do not have it

2010-09-24 03:42:37 +00:00

astfd.c

Merged revisions 228338 via svnmerge from

2009-11-06 15:42:46 +00:00

astmm.c

Two more minor fixes due to constification

2009-05-22 16:53:41 +00:00

astobj2.c

Add missing debug info for ao2_link for use with REF_DEBUG in ao2 callback.

2011-02-09 21:06:33 +00:00

audiohook.c

Fix a bunch of compiler warnings generated by gcc 4.6.0.

2011-05-03 19:55:49 +00:00

autochan.c

Convert the ast_channel data structure over to the astobj2 framework.

2009-04-24 14:04:26 +00:00

autoservice.c

Merged revisions 278167 via svnmerge from

2010-07-20 22:26:23 +00:00

bridging.c

Revert part of a change to the bridging API code

2011-05-19 23:28:13 +00:00

buildinfo.c

fix a few small things found by using sparse

2008-10-30 16:49:02 +00:00

callerid.c

Merged revisions 310635 via svnmerge from

2011-03-14 16:50:59 +00:00

ccss.c

CCSS generic agent with POTS and ISDN phones fail caller busy call-back test.

2011-05-19 16:50:48 +00:00

cdr.c

Fix a bunch of compiler warnings generated by gcc 4.6.0.

2011-05-03 19:55:49 +00:00

cel.c

Make the AST_CEL_AMA enum match up with the AST_CDR_ ama flag values.

2010-08-23 13:23:12 +00:00

channel.c

Fixes a segmentation fault in dynamic hints when a channel technology isn't

2011-05-13 18:09:34 +00:00

chanvars.c

Add additional memory debugging to several core APIs, and fix several memory

2008-10-14 22:38:06 +00:00

cli.c

Merged revisions 313859 via svnmerge from

2011-04-15 15:08:05 +00:00

config.c

Fix a bunch of compiler warnings generated by gcc 4.6.0.

2011-05-03 19:55:49 +00:00

cygload.c

Doxygen updates, formatting.

2007-12-11 22:20:22 +00:00

data.c

Kill some startup warnings and errors and make some messages more helpful in tracking down the source.

2010-07-09 17:00:22 +00:00

datastore.c

Merged revisions 273565 via svnmerge from

2010-07-01 22:16:23 +00:00

db.c

Rate limit calls to fsync() to 1 per second after astdb updates.

2010-09-10 20:31:58 +00:00

devicestate.c

Merged revisions 294500 via svnmerge from

2010-11-10 12:46:27 +00:00

dial.c

ast_callerid restructuring

2010-07-14 15:48:36 +00:00

dns.c

Fix a few compilation problems found when building Asterisk against uClibc.

2009-07-08 16:43:12 +00:00

dnsmgr.c

Don't use ast_strdupa() from within the arguments to a function.

2010-09-21 15:43:33 +00:00

dsp.c

Makes busy detection in dsp.c always allow for at least one frame (20ms) of error so that 200ms tone lengths don't get ignored by single frame error lengths.

2011-05-16 21:00:55 +00:00

ecdisa.h

…

enum.c

Extend max call limit duration from 24.8 days to 292+ million years.

2010-01-18 22:31:25 +00:00

event.c

Merged revisions 295710 via svnmerge from

2010-11-20 00:50:00 +00:00

features.c

Crash when using directed pickup applications.

2011-05-20 15:48:25 +00:00

file.c

Merged revisions 304096 via svnmerge from

2011-01-26 01:26:26 +00:00

fixedjitterbuf.c

Fix various typos reported by Lintian

2010-07-02 15:57:02 +00:00

fixedjitterbuf.h

Merged revisions 135841,135847,135850 via svnmerge from

2008-08-06 00:30:53 +00:00

frame.c

adds speex 16khz audio support

2010-06-17 17:23:43 +00:00

framehook.c

Addition of the FrameHook API (AKA AwesomeHooks)

2010-09-20 22:09:16 +00:00

fskmodem_float.c

Fix a bunch of compiler warnings generated by gcc 4.6.0.

2011-05-03 19:55:49 +00:00

fskmodem_int.c

Optionally build integer-based routines for FSK tone decoding (but default

2008-07-21 20:59:03 +00:00

fskmodem.c

(Step 2 of 2)

2008-07-21 21:00:47 +00:00

global_datastores.c

Add SRTP support for Asterisk

2010-06-08 05:29:08 +00:00

hashtab.c

Add MALLOC_DEBUG to various utility APIs, so that memory leaks can be tracked back to their source.

2009-03-11 00:29:59 +00:00

heap.c

Change mutex tracking so that it only consumes memory in the core mutex object when it's actually being used.

2011-01-31 06:41:36 +00:00

http.c

Use the correct HTTP method when generating our digest, otherwise we always fail.

2011-05-05 02:30:45 +00:00

image.c

More 'static' qualifiers on module global variables.

2009-06-15 17:34:30 +00:00

indications.c

Implement AstData API data providers as part of the GSOC 2010 project,

2010-07-08 14:48:42 +00:00

io.c

Merged revisions 182810 via svnmerge from

2009-03-18 02:28:55 +00:00

jitterbuf.c

Merged revisions 174583 via svnmerge from

2009-02-10 18:16:31 +00:00

loader.c

When optional_api is non-optional, force dependent modules to be loaded.

2010-09-02 05:20:59 +00:00

lock.c

Initialize track pointer

2011-04-20 05:25:15 +00:00

logger.c

Fix issue with verbose messages not showing on remote console.

2011-02-08 21:24:01 +00:00

Makefile

Merged revisions 298957 via svnmerge from

2010-12-17 23:52:04 +00:00

manager.c

Filter out blacklisted manager events when using eventfilter.

2011-05-10 18:46:25 +00:00

md5.c

Start untangling header inclusion in a way that does not affect

2007-11-16 20:04:58 +00:00

netsock2.c

Resolve some compiler errors in ast_sockaddr_is_any().

2010-10-18 19:50:04 +00:00

netsock.c

Merged revisions 298050 via svnmerge from

2010-12-10 16:26:46 +00:00

pbx.c

Fix calculation of free RAM to make minmemfree option work.

2011-05-06 21:06:33 +00:00

plc.c

Fix a bunch of compiler warnings generated by gcc 4.6.0.

2011-05-03 19:55:49 +00:00

poll.c

Merged revisions 285267 via svnmerge from

2010-09-07 19:08:09 +00:00

privacy.c

remove a bunch of useless #include "options.h"

2007-11-21 23:09:02 +00:00

rtp_engine.c

Fix a bunch of compiler warnings generated by gcc 4.6.0.

2011-05-03 19:55:49 +00:00

say.c

Merged revisions 298962 via svnmerge from

2010-12-18 00:09:49 +00:00

sched.c

Merged revisions 281574 via svnmerge from

2010-08-10 18:05:07 +00:00

security_events.c

Add an API for reporting security events, and a security event logging module.

2009-07-11 19:15:03 +00:00

sha1.c

more header removal/normalization

2007-11-21 00:23:49 +00:00

slinfactory.c

Expand codec bitfield from 32 bits to 64 bits.

2009-11-04 14:05:12 +00:00

srv.c

Formatting changes

2010-07-16 13:32:22 +00:00

ssl.c

pthread_self returns a pthread_t which is not an unsigned int on all

2009-07-09 08:31:24 +00:00

strcompat.c

Little endian machines were not converted properly.

2011-01-10 22:39:31 +00:00

strings.c

fixes segfault on logging

2010-05-18 22:48:51 +00:00

stun.c

Merged revisions 284593,284595 via svnmerge from

2010-09-02 05:00:34 +00:00

syslog.c

Add functions to map syslog facilities and priorities constants to strings.

2009-06-26 13:00:35 +00:00

taskprocessor.c

Minor tweaks to comment blocks and includes.

2010-02-22 06:45:52 +00:00

tcptls.c

Use SSLv23_client_method instead of old SSLv2 only.

2011-04-19 15:42:10 +00:00

tdd.c

Merge changes from str_substitution that are unrelated to that branch.

2009-04-01 20:13:28 +00:00

term.c

Revert r280019 for now - This was poorly executed.

2010-07-27 22:30:38 +00:00

test.c

Kill some startup warnings and errors and make some messages more helpful in tracking down the source.

2010-07-09 17:00:22 +00:00

threadstorage.c

Fixed an issue in the threadstorage cli functions resulting from the constification of struct ast_cli_args in r196072.

2009-06-01 15:23:21 +00:00

timing.c

Merged revisions 294277 via svnmerge from

2010-11-08 21:59:45 +00:00

translate.c

improved translation paths for wideband codecs

2010-08-12 20:15:41 +00:00

udptl.c

Fix a bunch of compiler warnings generated by gcc 4.6.0.

2011-05-03 19:55:49 +00:00

ulaw.c

Fix compile when certain G711 menuselect options are enabled.

2009-08-19 22:38:46 +00:00

utils.c

Look at the correct buffer for our digest info instead of an empty one.

2011-05-05 02:25:20 +00:00

xml.c

Asterisk data retrieval API.

2010-04-22 18:07:02 +00:00

xmldoc.c

Merged revisions 300520 via svnmerge from

2011-01-04 21:53:27 +00:00