Matthew Jordan 7eb528fbf1 Fix checking bounds of array index after using it; improper sizeof ...

This patch fixes two problems pointed out by a static analysis tool.

* In chan_dahdi, when an event is handled the index of the sub channel is first
  obtained.  In very off nominal cases, the method that determines the index
  can return a negative value.  In the event handling code, whether or not
  the index returned is valid was being checked after that value was used to
  index into an array.  This patch makes it so the value is checked before
  any indexing is done.

* In res_calendar_ews, sizeof was being passed a pointer instead of the struct to
  determine the amount of memory to allocate.

(issue ASTERISK-19651)
Reported by: Matt Jordan

(closes issue ASTERISK-19671)
Reported by: Matt Jordan




git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@366740 65c4cc65-6c06-0410-ace0-fbb531ad65f3

2012-05-17 12:51:36 +00:00

..

ael

Resolve FORWARD_NULL static analysis warnings

2012-05-10 20:50:47 +00:00

ais

Dump cache of published events when a node joins the cluster.

2012-03-13 23:45:23 +00:00

snmp

Audit of ao2_iterator_init() usage for v1.8.

2012-01-27 18:22:39 +00:00

Makefile

Remove references to res_features and its export file.

2011-05-09 23:15:32 +00:00

res_adsi.c

Fix broken usage of sizeof() in res_adsi.

2012-03-14 00:27:31 +00:00

res_adsi.exports.in

Remove the old stub files, preferring the optional_api method.

2010-07-14 20:48:59 +00:00

res_ael_share.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

res_ael_share.exports.in

Allow symbol export filtering to work properly on platforms that have symbol prefixes.

2010-04-02 18:57:58 +00:00

res_agi.c

Fix findings 0-3, 5, and 8 for Coverity MISSING_BREAK errors.

2012-05-07 16:01:28 +00:00

res_agi.exports.in

Allow symbol export filtering to work properly on platforms that have symbol prefixes.

2010-04-02 18:57:58 +00:00

res_ais.c

Dump cache of published events when a node joins the cluster.

2012-03-13 23:45:23 +00:00

res_calendar_caldav.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

res_calendar_ews.c

Fix checking bounds of array index after using it; improper sizeof

2012-05-17 12:51:36 +00:00

res_calendar_exchange.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

res_calendar_icalendar.c

Resolve FORWARD_NULL static analysis warnings

2012-05-10 20:50:47 +00:00

res_calendar.c

Track module use count for res_calendar

2012-02-22 21:08:50 +00:00

res_calendar.exports.in

Allow symbol export filtering to work properly on platforms that have symbol prefixes.

2010-04-02 18:57:58 +00:00

res_clialiases.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

res_clioriginate.c

Add missing newlines to CLI logging

2012-04-06 18:09:19 +00:00

res_config_curl.c

Make use of va_args more appropriate to form in various res_config modules plus utils.

2012-04-17 20:43:22 +00:00

res_config_ldap.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

res_config_odbc.c

Make use of va_args more appropriate to form in various res_config modules plus utils.

2012-04-17 20:43:22 +00:00

res_config_pgsql.c

Make use of va_args more appropriate to form in various res_config modules plus utils.

2012-04-17 20:43:22 +00:00

res_config_sqlite.c

Add missing newlines to CLI logging

2012-04-06 18:09:19 +00:00

res_convert.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

res_crypto.c

Fix incorrect usage of sizeof() in res_crypto.

2012-03-14 00:37:17 +00:00

res_crypto.exports.in

Remove built-in AES code and use optional_api instead

2010-07-21 19:11:32 +00:00

res_curl.c

Fixes some support level info so that it can be read by menuselect.

2011-10-14 15:58:44 +00:00

res_fax_spandsp.c

Correctly apply FAXOPT settings (V17, V27, V29) before starting spandsp layer

2012-01-23 19:12:14 +00:00

res_fax.c

Add missing newlines to CLI logging

2012-04-06 18:09:19 +00:00

res_fax.exports.in

Log spandsp's fax debug output to the FAX logger level.

2010-05-21 15:15:58 +00:00

res_http_post.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

res_jabber.c

Fix res_jabber resource leaks

2011-11-23 17:12:46 +00:00

res_jabber.exports.in

Fix chan_jingle/gtalk load regression introduced in r346087

2011-12-05 14:45:18 +00:00

res_limit.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

res_monitor.c

Resolve FORWARD_NULL static analysis warnings

2012-05-10 20:50:47 +00:00

res_monitor.exports.in

Allow symbol export filtering to work properly on platforms that have symbol prefixes.

2010-04-02 18:57:58 +00:00

res_musiconhold.c

Fix places in resources where a negative return value could impact execution

2012-04-17 21:10:25 +00:00

res_mutestream.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

res_odbc.c

Resolve FORWARD_NULL static analysis warnings

2012-05-10 20:50:47 +00:00

res_odbc.exports.in

Allow symbol export filtering to work properly on platforms that have symbol prefixes.

2010-04-02 18:57:58 +00:00

res_phoneprov.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

res_pktccops.c

Fix -Werror=unused-but-set-variable compiler error (gcc 4.6.2)

2012-02-18 03:59:26 +00:00

res_pktccops.exports.in

Allow symbol export filtering to work properly on platforms that have symbol prefixes.

2010-04-02 18:57:58 +00:00

res_realtime.c

Cleanup references to sipusers and sipfriends dynamic realtime families

2011-11-01 19:37:47 +00:00

res_rtp_asterisk.c

Fix core FINDING 2, FINDING 3, and FINDING 4 from Coverity's CONSTANT_EXPRESSION_RESULT report.

2012-05-04 15:48:44 +00:00

res_rtp_multicast.c

Fix sequence number overflow over 16 bits causing codec change in RTP packets.

2011-10-27 19:34:29 +00:00

res_security_log.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

res_smdi.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

res_smdi.exports.in

Allow symbol export filtering to work properly on platforms that have symbol prefixes.

2010-04-02 18:57:58 +00:00

res_snmp.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

res_speech.c

Fix findings 0-3, 5, and 8 for Coverity MISSING_BREAK errors.

2012-05-07 16:01:28 +00:00

res_speech.exports.in

Allow symbol export filtering to work properly on platforms that have symbol prefixes.

2010-04-02 18:57:58 +00:00

res_srtp.c

Add missing newlines to CLI logging

2012-04-06 18:09:19 +00:00

res_srtp.exports.in

Add SRTP support for Asterisk

2010-06-08 05:29:08 +00:00

res_stun_monitor.c

Re-resolve the STUN address if a STUN poll fails for res_stun_monitor.

2011-12-01 21:11:39 +00:00

res_timing_dahdi.c

Fix timing source dependency issues with MOH

2011-12-27 20:48:11 +00:00

res_timing_kqueue.c

Introduce <support_level> tags in MODULEINFO.

2011-07-14 20:13:06 +00:00

res_timing_pthread.c

Fix timing source dependency issues with MOH

2011-12-27 20:48:11 +00:00

res_timing_timerfd.c

Fix timing source dependency issues with MOH

2011-12-27 20:48:11 +00:00