mirror of
https://github.com/asterisk/asterisk.git
synced 2025-10-04 03:20:33 +00:00
Downgrade had a few issues. First there was an errant 'update' statement in add_auto_dtmf_mode that looks like it was a copy/paste error. Second, we weren't cleaning up the ENUMs so subsequent upgrades on postgres failed because the types already existed. For sqlite... sqlite doesn't support ALTER or DROP COLUMN directly. Fortunately alembic batch_operations takes care of this for us if we use it so the alter and drops were converted to use batch operations. Here's an example downgrade: with op.batch_alter_table('ps_endpoints') as batch_op: batch_op.drop_column('tos_audio') batch_op.drop_column('tos_video') batch_op.add_column(sa.Column('tos_audio', yesno_values)) batch_op.add_column(sa.Column('tos_video', yesno_values)) batch_op.drop_column('cos_audio') batch_op.drop_column('cos_video') batch_op.add_column(sa.Column('cos_audio', yesno_values)) batch_op.add_column(sa.Column('cos_video', yesno_values)) with op.batch_alter_table('ps_transports') as batch_op: batch_op.drop_column('tos') batch_op.add_column(sa.Column('tos', yesno_values)) # Can't cast integers to YESNO_VALUES, so dropping and adding is required batch_op.drop_column('cos') batch_op.add_column(sa.Column('cos', yesno_values)) Upgrades from base to head and downgrades from head to base were tested repeatedly for postgresql, mysql/mariadb, and sqlite3. Change-Id: I862b0739eb3fd45ec3412dcc13c2340e1b7baef8
50 lines
1.4 KiB
Python
Executable File
50 lines
1.4 KiB
Python
Executable File
#
|
|
# Asterisk -- An open source telephony toolkit.
|
|
#
|
|
# Copyright (C) 2015, Richard Mudgett
|
|
#
|
|
# Richard Mudgett <rmudgett@digium.com>
|
|
#
|
|
# See http://www.asterisk.org for more information about
|
|
# the Asterisk project. Please do not directly contact
|
|
# any of the maintainers of this project for assistance;
|
|
# the project provides a web site, mailing lists and IRC
|
|
# channels for your use.
|
|
#
|
|
# This program is free software, distributed under the terms of
|
|
# the GNU General Public License Version 2. See the LICENSE file
|
|
# at the top of the source tree.
|
|
#
|
|
|
|
"""add rpid_immediate
|
|
|
|
Revision ID: 23530d604b96
|
|
Revises: 45e3f47c6c44
|
|
Create Date: 2015-03-18 17:41:58.055412
|
|
|
|
"""
|
|
|
|
# revision identifiers, used by Alembic.
|
|
revision = '23530d604b96'
|
|
down_revision = '45e3f47c6c44'
|
|
|
|
from alembic import op
|
|
import sqlalchemy as sa
|
|
from sqlalchemy.dialects.postgresql import ENUM
|
|
|
|
YESNO_NAME = 'yesno_values'
|
|
YESNO_VALUES = ['yes', 'no']
|
|
|
|
def upgrade():
|
|
############################# Enums ##############################
|
|
|
|
# yesno_values have already been created, so use postgres enum object
|
|
# type to get around "already created" issue - works okay with mysql
|
|
yesno_values = ENUM(*YESNO_VALUES, name=YESNO_NAME, create_type=False)
|
|
|
|
op.add_column('ps_endpoints', sa.Column('rpid_immediate', yesno_values))
|
|
|
|
def downgrade():
|
|
with op.batch_alter_table('ps_endpoints') as batch_op:
|
|
batch_op.drop_column('rpid_immediate')
|