Matthew Jordan 85456f605e Fix a file descriptor leak in off nominal path ...

While looking at the security vulnerability in ASTERISK-20967, Walter noticed
a file descriptor leak and some other issues in off nominal code paths. This
patch corrects them.

Note that this patch is not related to the vulnerability in ASTERISK-20967,
but the patch was placed on that issue.

(closes issue ASTERISK-20967)
Reported by: wdoekes
patches:
  issueA20967_file_leak_and_unused_wkspace.patch uploaded by wdoekes (License 5674)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@384118 65c4cc65-6c06-0410-ace0-fbb531ad65f3

2013-03-27 18:49:17 +00:00

..

db1-ast

Coverity Report: Fix issues for error type REVERSE_INULL (core modules)

2012-05-31 18:00:59 +00:00

editline

Fix a variety of memory leaks

2012-05-18 13:58:23 +00:00

stdtime

Cleanup core main on exit.

2012-12-03 20:26:37 +00:00

abstract_jb.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

acl.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

adsi.c

Fix crash in unloading of res_adsi module

2012-06-26 13:21:13 +00:00

alaw.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

aoc.c

Cleanup CLI commands on exit for several files.

2012-12-11 21:54:22 +00:00

app.c

core: Fix a memory leak in app.c from an early return

2012-10-22 19:47:47 +00:00

ast_expr2.c

Rebuild parsers.

2012-03-24 02:34:39 +00:00

ast_expr2.fl

Merged revisions 309251 via svnmerge from

2011-03-07 00:54:42 +00:00

ast_expr2.h

Rebuild parsers.

2012-03-24 02:34:39 +00:00

ast_expr2.y

expression parser: Fix (theoretical) memory leak.

2012-03-24 02:33:36 +00:00

ast_expr2f.c

Rebuild parsers.

2012-03-24 02:34:39 +00:00

asterisk.c

Update init.d scripts to handle stderr; readd splash screen for remote consoles

2013-01-21 20:19:54 +00:00

asterisk.dynamics

Remove the old stub files, preferring the optional_api method.

2010-07-14 20:48:59 +00:00

asterisk.exports.in

Export timersub for platforms which do not have it

2010-09-24 03:42:37 +00:00

astfd.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

astmm.c

MALLOC_DEBUG: Only wait if we want atexit allocation dumps.

2012-12-07 23:40:19 +00:00

astobj2.c

Attempt to be more helpful when using a bad ao2 object pointer.

2013-01-23 00:19:40 +00:00

audiohook.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

autochan.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

autoservice.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

bridging.c

Fix bridging thread leak.

2012-07-06 15:20:11 +00:00

buildinfo.c

fix a few small things found by using sparse

2008-10-30 16:49:02 +00:00

callerid.c

Clean up and ensure proper usage of alloca()

2012-07-31 19:31:42 +00:00

ccss.c

Fix CCSS CLI commands and logger level not unregistered.

2012-12-03 17:05:40 +00:00

cdr.c

Resolve deadlock between pending CDR and batch CDR locks

2013-03-26 01:50:28 +00:00

cel.c

Cleanup CLI commands on exit for several files.

2012-12-11 21:54:22 +00:00

channel.c

Add missing test event

2013-01-03 18:35:38 +00:00

chanvars.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

cli.c

Cleanup CLI resources on exit and CLI command registration errors.

2012-12-03 19:13:01 +00:00

config.c

Prevent crashes from occurring when reading from data sources with large values

2013-01-02 21:48:57 +00:00

cygload.c

Doxygen updates, formatting.

2007-12-11 22:20:22 +00:00

data.c

Cleanup CLI commands on exit for several files.

2012-12-11 21:54:22 +00:00

datastore.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

db.c

Cleanup astdb on exit.

2012-12-10 23:13:48 +00:00

devicestate.c

Prevent exhaustion of system resources through exploitation of event cache

2013-01-02 16:54:20 +00:00

dial.c

Separate option_types[] from the struct definition.

2013-02-05 18:09:05 +00:00

dns.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

dnsmgr.c

Cleanup dnsmgr on exit.

2012-12-11 00:30:15 +00:00

dsp.c

dsp.c User Configurable DTMF_HITS_TO_BEGIN and DTMF_MISSES_TO_END

2012-10-04 20:15:35 +00:00

ecdisa.h

…

enum.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

event.c

Prevent exhaustion of system resources through exploitation of event cache

2013-01-02 16:54:20 +00:00

features.c

Write the correct callid to the data1 field in queue_log for transfer events.

2013-02-19 19:16:44 +00:00

file.c

Change cleanup ordering in filestream destructor.

2013-01-28 01:52:39 +00:00

fixedjitterbuf.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

fixedjitterbuf.h

Merged revisions 135841,135847,135850 via svnmerge from

2008-08-06 00:30:53 +00:00

frame.c

Cleanup frame on exit.

2012-12-11 01:11:05 +00:00

framehook.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

fskmodem_float.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

fskmodem_int.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

fskmodem.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

global_datastores.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

hashtab.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

heap.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

http.c

Fix a file descriptor leak in off nominal path

2013-03-27 18:49:17 +00:00

image.c

Cleanup CLI commands on exit for several files.

2012-12-11 21:54:22 +00:00

indications.c

Cleanup indications on exit.

2012-12-11 02:09:33 +00:00

io.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

jitterbuf.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

loader.c

Fix potential double free when unloading a module.

2012-12-17 23:07:24 +00:00

lock.c

Re-initialize logmsgs mutex upon logger initialization to prevent lock errors

2012-11-22 23:51:02 +00:00

logger.c

Cleanup logger on exit.

2012-12-11 02:41:01 +00:00

Makefile

Remove unneeded linux-gnueabi*

2013-02-26 19:06:51 +00:00

manager.c

tcptls: Prevent unsupported options from being set

2013-03-15 12:49:59 +00:00

md5.c

Fix compilation in dev-mode

2012-06-11 14:10:13 +00:00

netsock2.c

Fix NULL pointer segfault in ast_sockaddr_parse()

2012-06-20 02:03:22 +00:00

netsock.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

pbx.c

Cleanup pbx on exit.

2012-12-11 19:46:56 +00:00

plc.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

poll.c

Merged revisions 285267 via svnmerge from

2010-09-07 19:08:09 +00:00

privacy.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

rtp_engine.c

Do not allow native RTP bridging if packetization of media streams differs.

2013-02-12 20:16:24 +00:00

say.c

Fix saying of date in Dutch.

2012-09-25 23:07:59 +00:00

sched.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

security_events.c

Fix most leftover non-opaque ast_str uses.

2012-11-19 19:30:58 +00:00

sha1.c

Update SHA1 code to RFC 6234

2011-10-11 00:43:14 +00:00

slinfactory.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

srv.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

ssl.c

Resolve memory leaks in TLS initialization and TLS client connections

2012-09-14 19:07:20 +00:00

strcompat.c

Add builtin roundf() for systems lacking it.

2013-01-19 20:41:35 +00:00

strings.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

stun.c

Cleanup CLI commands on exit for several files.

2012-12-11 21:54:22 +00:00

syslog.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

taskprocessor.c

Cleanup taskprocessor on exit.

2012-12-11 20:37:36 +00:00

tcptls.c

tcptls: Prevent unsupported options from being set

2013-03-15 12:49:59 +00:00

tdd.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

term.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

test.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

threadstorage.c

Clean up and ensure proper usage of alloca()

2012-07-31 19:31:42 +00:00

timing.c

Cleanup CLI commands on exit for several files.

2012-12-11 21:54:22 +00:00

translate.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

udptl.c

Cleanup udptl on exit.

2012-12-11 21:05:07 +00:00

ulaw.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

utils.c

Fix XML encoding of 'identity display' in NOTIFY messages.

2013-01-12 06:26:34 +00:00

xml.c

Add support-level indications to many more source files.

2012-06-15 15:56:08 +00:00

xmldoc.c

Improve documentation by making all of the colors used readable,

2012-12-10 01:38:52 +00:00