Jonathan Rose 47244a11d6 Eliminate double close of file descriptor in manager.c ...

The process_output function in manager.c attempted to call fclose and close immediately
afterwards. Since fclose implies close, this resulted in a potential double free on file
descriptors. This patch changes that behavior and also adds error checking to fclose and
close depending on which was deemed necessary. Also error messages. Thanks to Rosen
Iliev for pointing out the location of the problem.

(closes issue ASTERISK-18453)
Reported By: Jaco Kroon
Review: https://reviewboard.asterisk.org/r/1793/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@358214 65c4cc65-6c06-0410-ace0-fbb531ad65f3

2012-03-05 18:49:58 +00:00

..

db1-ast

…

editline

Revert r280019 for now - This was poorly executed.

2010-07-27 22:30:38 +00:00

stdtime

Add missing ifdefs for test framework and new locale code.

2010-10-14 18:45:02 +00:00

abstract_jb.c

Merged revisions 297311 via svnmerge from

2010-12-02 18:13:49 +00:00

acl.c

Prevent outbound SIP NOTIFY packets from displaying a port of 0

2012-03-01 14:18:01 +00:00

alaw.c

…

aoc.c

Typos: recieved => received

2010-12-20 09:14:29 +00:00

app.c

Fix ast_app_dtget() time unit inconsistency.

2012-01-21 00:20:07 +00:00

ast_expr2.c

Merged revisions 293195-293196 via svnmerge from

2010-10-28 20:00:06 +00:00

ast_expr2.fl

Merged revisions 309251 via svnmerge from

2011-03-07 00:54:42 +00:00

ast_expr2.h

Merged revisions 293195-293196 via svnmerge from

2010-10-28 20:00:06 +00:00

ast_expr2.y

Merged revisions 293195-293196 via svnmerge from

2010-10-28 20:00:06 +00:00

ast_expr2f.c

Merged revisions 309251 via svnmerge from

2011-03-07 00:54:42 +00:00

asterisk.c

Allow only one thread at a time to do asterisk cleanup/shutdown.

2012-01-15 20:07:13 +00:00

asterisk.dynamics

Remove the old stub files, preferring the optional_api method.

2010-07-14 20:48:59 +00:00

asterisk.exports.in

Export timersub for platforms which do not have it

2010-09-24 03:42:37 +00:00

astfd.c

…

astmm.c

…

astobj2.c

Check fopen return value for ao2 reference debug output.

2011-10-25 22:04:59 +00:00

audiohook.c

Revert a change to audio_audiohook_write_list that had no affect.

2012-02-16 20:01:15 +00:00

autochan.c

…

autoservice.c

Merged revisions 278167 via svnmerge from

2010-07-20 22:26:23 +00:00

bridging.c

Revert part of a change to the bridging API code

2011-05-19 23:28:13 +00:00

buildinfo.c

…

callerid.c

Merged revisions 310635 via svnmerge from

2011-03-14 16:50:59 +00:00

ccss.c

Fix case-sensitivity for device-specific event subscriptions and CCSS

2012-03-02 21:02:21 +00:00

cdr.c

CDR comment tweaks.

2011-06-01 23:11:55 +00:00

cel.c

Add missing CEL logging fields to various CEL backends.

2012-01-13 17:12:51 +00:00

channel.c

Remove ISDN hold restriction for non-bridged calls.

2012-03-02 18:34:29 +00:00

chanvars.c

…

cli.c

Make CLI "core show channel" not hold the channel lock during console output.

2011-11-11 17:56:51 +00:00

config.c

Make the config parser remove escaping backslashes

2012-02-09 19:52:25 +00:00

cygload.c

…

data.c

Kill some startup warnings and errors and make some messages more helpful in tracking down the source.

2010-07-09 17:00:22 +00:00

datastore.c

Merged revisions 273565 via svnmerge from

2010-07-01 22:16:23 +00:00

db.c

Update the documentation to better clarify how the existing commands work.

2011-11-19 15:08:03 +00:00

devicestate.c

Merged revisions 294500 via svnmerge from

2010-11-10 12:46:27 +00:00

dial.c

Updated SIP 484 handling; added Incomplete control frame

2011-09-09 16:09:09 +00:00

dns.c

…

dnsmgr.c

Re-link peers by IP when dnsmgr changes the IP

2012-01-30 23:17:16 +00:00

dsp.c

Fix an issue where dsp.c would interpret multiple dtmf events from a single key press.

2012-01-05 21:46:55 +00:00

ecdisa.h

…

enum.c

Decrease verbose messages to debug, to help clean up CLI.

2011-07-25 19:49:40 +00:00

event.c

Fix case-sensitivity for device-specific event subscriptions and CCSS

2012-03-02 21:02:21 +00:00

features.c

Copy CDR variables when set during a bridge

2012-02-27 16:03:04 +00:00

file.c

Allow playback of formats that don't support seeking

2012-01-05 22:06:46 +00:00

fixedjitterbuf.c

Fix various typos reported by Lintian

2010-07-02 15:57:02 +00:00

fixedjitterbuf.h

…

frame.c

adds speex 16khz audio support

2010-06-17 17:23:43 +00:00

framehook.c

Addition of the FrameHook API (AKA AwesomeHooks)

2010-09-20 22:09:16 +00:00

fskmodem_float.c

Fix a bunch of compiler warnings generated by gcc 4.6.0.

2011-05-03 19:55:49 +00:00

fskmodem_int.c

…

fskmodem.c

…

global_datastores.c

Add SRTP support for Asterisk

2010-06-08 05:29:08 +00:00

hashtab.c

…

heap.c

Change mutex tracking so that it only consumes memory in the core mutex object when it's actually being used.

2011-01-31 06:41:36 +00:00

http.c

Fix TLS port binding behavior as well as reload behavior:

2012-02-02 16:58:44 +00:00

image.c

…

indications.c

Audit of ao2_iterator_init() usage for v1.8.

2012-01-27 18:22:39 +00:00

io.c

…

jitterbuf.c

…

loader.c

Track module use count for res_calendar

2012-02-22 21:08:50 +00:00

lock.c

Initialize track pointer

2011-04-20 05:25:15 +00:00

logger.c

Fix deadlock when using dummy channels.

2011-09-26 19:30:39 +00:00

Makefile

Various changes to allow 1.8 to compile on Mac OS X Lion (10.7)

2011-09-19 20:27:03 +00:00

manager.c

Eliminate double close of file descriptor in manager.c

2012-03-05 18:49:58 +00:00

md5.c

…

netsock2.c

Fix possible error on stringification of IPv4-mapped addrs

2011-08-18 21:26:01 +00:00

netsock.c

Find even more network interfaces.

2012-01-29 02:42:59 +00:00

pbx.c

Audit of ao2_iterator_init() usage for v1.8.

2012-01-27 18:22:39 +00:00

plc.c

Fix a bunch of compiler warnings generated by gcc 4.6.0.

2011-05-03 19:55:49 +00:00

poll.c

Merged revisions 285267 via svnmerge from

2010-09-07 19:08:09 +00:00

privacy.c

…

rtp_engine.c

Allow SRTP policies to be reloaded

2012-02-24 15:07:09 +00:00

say.c

Removes improper use of sound 'and' in German language mode from application saynumber

2011-10-04 19:33:12 +00:00

sched.c

Merged revisions 281574 via svnmerge from

2010-08-10 18:05:07 +00:00

security_events.c

…

sha1.c

Update SHA1 code to RFC 6234

2011-10-11 00:43:14 +00:00

slinfactory.c

…

srv.c

Crash when using hagi and no servers are available.

2011-05-27 23:45:41 +00:00

ssl.c

…

strcompat.c

Little endian machines were not converted properly.

2011-01-10 22:39:31 +00:00

strings.c

fixes segfault on logging

2010-05-18 22:48:51 +00:00

stun.c

Re-resolve the STUN address if a STUN poll fails for res_stun_monitor.

2011-12-01 21:11:39 +00:00

syslog.c

…

taskprocessor.c

Audit of ao2_iterator_init() usage for v1.8.

2012-01-27 18:22:39 +00:00

tcptls.c

r346525 | jrose | 2011-11-30 15:10:38 -0600 (Wed, 30 Nov 2011) | 18 lines

2011-11-30 21:41:31 +00:00

tdd.c

…

term.c

Make console colors work for TERM=xterm-256color

2011-07-28 21:42:41 +00:00

test.c

Avoid unnecessary rebuilds of main/test.c.

2012-01-25 21:16:54 +00:00

threadstorage.c

…

timing.c

Merged revisions 294277 via svnmerge from

2010-11-08 21:59:45 +00:00

translate.c

Second attempt to get optimal translation paths when codec_resample is used.

2012-03-02 00:20:04 +00:00

udptl.c

Fix debugging messages generated by 'udptl debug'.

2011-10-06 17:49:38 +00:00

ulaw.c

…

utils.c

Use __alignof__ instead of sizeof for stringfield length storage.

2011-11-11 21:54:47 +00:00

xml.c

Asterisk data retrieval API.

2010-04-22 18:07:02 +00:00

xmldoc.c

Load the proper XML documentation when multiple modules document the same application.

2011-10-10 14:14:48 +00:00